RFR: 6946: There should be an option to build the agent in the build script [v21]
Alex Macdonald
aptmac at openjdk.java.net
Wed Jan 13 20:11:03 UTC 2021
On Wed, 13 Jan 2021 17:16:17 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JMC-6946
>> added:
>> - build.sh --packageAgent
>> - build.sh --runAgentExample
>
> Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:
>
> - 6946: missing letter
> - 6946: text improvements
I found a nifty dictionary vscode extension that pointed out a couple last ones, should be good after this.
build.sh line 226:
> 224: printf "%s\n" "try to execute an agent example"
> 225: else
> 226: err_log "unknown OS type: \"${OSTYPE}\". Please coheck package ${JMC_DIR}/agent README.MD"
Almost there, on re-reading I found this one: "coheck" should probably be "check"
build.sh line 153:
> 151: printf "%s\n" "See agent/README.md for more information"
> 152: else
> 153: err_log "unknown OS type: \"${OSTYPE}\". Please coheck package in \"${JMC_DIR}/agent/target\""
"coheck" here as well should be "check"
-------------
PR: https://git.openjdk.java.net/jmc/pull/183
More information about the jmc-dev
mailing list