RFR: 6946: There should be an option to build the agent in the build script [v22]

Miroslav Wengner mwengner at openjdk.java.net
Wed Jan 13 21:27:18 UTC 2021


On Wed, 13 Jan 2021 21:11:59 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: update
>
> build.sh line 102:
> 
>> 100:     local timestamp=$1
>> 101:     startJetty $timestamp
>> 102:     echo "$${timestamp} running tests"
> 
> Ok, I think this should be the last thing (it wasn't a spelling typo so my dictionary didn't help me out here..), sorry for making you go back and forth here.
> 
> There's an extra `$` before the timestamp. This results in something like:
> 
> 16:00:37 jetty server up and running on pid 595959
> 595716{timestamp} running tests
> instead of something like:
> 16:01:20 jetty server up and running on pid 596437
> 20210113160105 running tests

very nice!, I've not noticed it, corrected

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list