RFR: 6988: Initial implementation of JFR binary format writer [v6]

[Marcus Hirt]

On Thu, 14 Jan 2021 16:48:38 GMT, Alexander Kuznetsov <github.com+13893590+AlexVanGogen at openjdk.org> wrote:

>> All affected files should have the copyright updated now
>
> Hi! We at JetBrains tried to use this writer to make tests for our JMC fork support. It works fine, however, it seems that almost every type is assumed to have constant pool (`org.openjdk.jmc.flightrecorder.writer.ConstantPool#writeValueType`). But that’s not always true; for example, async-profiler and JFR write `jdk.types.StackFrame` as-is, not referring to constant pool. It may lead to false-positive/negative outcomes when generated recordings are parsed well while the real ones make parser fail, or vice versa.
> Is it worth to extend API to control which types must have constant pool and which must not? What do you think?

Hi @AlexVanGogen! I think that is a great idea - that said, we're very close to the next source release. I was just about to approve this. How would you like the API to look/work?

-------------

PR: https://git.openjdk.java.net/jmc/pull/84