RFR: JMC-7090: [JFR Writer] Make constant pool optional when registering a new type [v4]

[Alexander Kuznetsov]

On Tue, 19 Jan 2021 11:54:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test failing on windows
>
> Changes requested by hirt (Lead).

OK, thanks for the explanation! 
One more thing: looks like this assumption can be violated now, since types may not fall to constant pool:
https://github.com/openjdk/jmc/blob/d4cfbd2486cce3bb56b45a9d6993df2d4b4d6a9c/core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/ConstantPool.java#L107-L120
Shouldn't `true` as argument to `writeValueType` here be replaced? Let's say, by something like `TypedValueImpl#getType#hasConstantPool`?

-------------

PR: https://git.openjdk.java.net/jmc/pull/200