RFR: 6588: Move JMC core to JDK 8 [v3]

Marcus Hirt hirt at openjdk.java.net
Tue Jan 19 12:25:44 UTC 2021


On Mon, 18 Jan 2021 19:57:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> WIP. Now that core requires JDK 8, we can make it a little bit more easygoing when using streams. I'm thinking it would be nice to remove the need for the StreamModel altogether as well.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'master' into 6588-core-jdk8-cleanup
>  - Formatting
>  - Adding values()
>  - Supporting streaming in IItemIterable
>  - Additional cleanup
>  - Inlining stream
>  - First move
>  - 6588: Initial cleanup

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AggregationGrid.java line 222:

> 220: 			// It seems Eclipse 4.5 has trouble inferring the correct type of this function ...
> 221: 			Function<IItem, T> getMemberFunc = accessor::getMember;
> 222: 			return is.stream().collect(KeyedStream.collector(getMemberFunc));

Just noticed that this should be parallelStream. Will fix.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/BucketBuilder.java line 102:

> 100: 
> 101: 	private List<C> collectItems(IItemIterable is) {
> 102: 		return is.stream().collect(collector(is.getType()));

And here.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/PairBucketBuilder.java line 108:

> 106: 
> 107: 	private List<Pair<C, CC>> collectItems(IItemIterable is) {
> 108: 		return is.stream().collect(collector(is.getType()));

And here.

-------------

PR: https://git.openjdk.java.net/jmc/pull/194


More information about the jmc-dev mailing list