RFR: 6588: Move JMC core to JDK 8 [v4]

Marcus Hirt hirt at openjdk.java.net
Tue Jan 19 19:17:00 UTC 2021


On Tue, 19 Jan 2021 15:34:05 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing omitted parallel streams
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/messages/internal/Messages.java line 58:
> 
>> 56: 	public static final String ItemAggregate_VARIANCE = "ItemAggregate_VARIANCE"; //$NON-NLS-1$
>> 57: 	public static final String ItemAggregate_VARIANCEP = "ItemAggregate_VARIANCEP"; //$NON-NLS-1$
>> 58: 	public static final String ITEM_COLLECTION_DESC = "ITEM_COLLECTION_DESC";
> 
> Is this still relevant? I think the key in the properties file was removed?

Good catch, forgot moving the properties file entry.

> core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/item/StreamTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> Year?

Yup.

-------------

PR: https://git.openjdk.java.net/jmc/pull/194


More information about the jmc-dev mailing list