RFR: 6588: Move JMC core to JDK 8 [v5]

Marcus Hirt hirt at openjdk.java.net
Wed Jan 20 13:37:49 UTC 2021


On Wed, 20 Jan 2021 12:03:14 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing message and updating copyright
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItemCollection.java line 95:
> 
>> 93: //	 * @return an item collection matching the range and filter.
>> 94: //	 */
>> 95: //	IItemCollection getItems(IRange<IQuantity> range, IItemFilter filter);
> 
> Should this be removed?

Yep, saving that for later. :)

> core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/item/StreamTest.java line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>> 3:  * 
> 
> Should this also include DataDog copyright?

Indeed! Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/194


More information about the jmc-dev mailing list