RFR: 6588: Move JMC core to JDK 8

Mario Torre neugens at redhat.com
Wed Jan 20 14:31:05 UTC 2021


On Wed, Jan 20, 2021 at 3:21 PM Marcus Hirt <hirt at openjdk.java.net> wrote:
>
> On Tue, 19 Jan 2021 21:37:06 GMT, Jie Kang <jkang at openjdk.org> wrote:
>
> >> Compromise that might be enough to make JMC 8 more enjoyable for people streaming. The grand end goal will be to get rid of StreamModel, but there is no time left for JMC 8. Might want to mark the toolkits as deprecated, and kill them off in a later release.
> >
> > @thegreystone Hi Marcus! The changes I've seen so far are to make use of JDK 8 language features where the overall functionality/result is the same. Are there any parts of the code where functionality is changed that might need a closer look?
>
> @jiekang - this is mostly a first step to make IItemCollection and friends more streaming friendly for consumers of core. There is also an API name change getTimeRanges -> getAvailableTimeRanges (for API introduced in 8, so should be OK). I'm thinking we might be able to perhaps find a better name there. It's all of the available time ranges in the recording, not necessarily only for the filtered collection. getOriginalTimeRanges?

getRecordingTimeRanges?

Do you think that "Available" really adds meaning here?

I would also remove "Ranges" since it's already returning a set of
ranges (Set<IRange<IQuantity>>) so that's implicit for me (however,
that would bring us close to getRecordingTimes which is probably
ambiguous in this context, so we would need a better name, but this
may be getAvailableTimes at this point).

Cheers,
Mario

-- 
Mario Torre
Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898



More information about the jmc-dev mailing list