RFR: 7116: Updating to 8.1.0

Jie Kang jkang at openjdk.java.net
Fri Jan 22 20:45:40 UTC 2021


On Fri, 22 Jan 2021 17:04:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Funnily enough, the revision pattern doesn't work on core, since the pom in the .m2 repo for the core components will contain the unexpanded revision variable. Didn't have time to figure out why or a workaround. This PR at least improves matters a little bit.

Hello! Changes look good; I have two requests below:

Can `application/uitests/pom.xml` use `project.version` instead of defining its own `jmc.version` for its dependencies?

Regarding the deployed/installed jmc-core, the maven guide [1] states that the `flatten-maven-plugin` must be used to deal with this (with example). I would like to request this actually be done for jmc too as there is a project that uses jmc maven dependencies from the m2 repo. Without it, the project would break similar to the jmc & jmc-core relationship.

[1]
https://maven.apache.org/maven-ci-friendly.html#install-deploy

-------------

PR: https://git.openjdk.java.net/jmc/pull/206


More information about the jmc-dev mailing list