From hirt at openjdk.java.net Thu Jul 1 11:02:02 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 1 Jul 2021 11:02:02 GMT Subject: RFR: 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors [v2] In-Reply-To: References: Message-ID: On Wed, 30 Jun 2021 20:30:22 GMT, Alex Macdonald wrote: >> This PR addresses JMC-5904 [[0]](https://bugs.openjdk.java.net/browse/JMC-5904), in which it is noted that org.openjdk.jmc.ui.celleditors could be merged with org.openjdk.jmc.rjmx.ui.celleditors instead of separating the code. >> >> For the most part this is a fairly straightforward migration of code. There are three classes in jmc.ui.celleditors that needed to be moved into rjmx.ui.celleditors: >> 1. ClearableTextCellEditor >> 2. CommonCellEditors >> 3. NullableTextCellEditor >> >> Once these files are moved there is a slight problem: org.openjdk.jmc.ui.misc.FilterEditor uses CommonCellEditors, and org.openjdk.jmc.rjmx.ui requires org.openjdk.jmc.ui. In this case, adding a dependency from org.openjdk.jmc.rjmx.ui.celleditors.CommonCellEditors to org.openjdk.jmc.ui.misc.FilterEditors would introduce a circular dependency. >> >> The solution I've gone with here is to move FilterEditor to org.openjdk.jmc.flightrecorder.ui, which IMO makes sense anyways because it's closer to the code it gets consumed by. FilterEditor is used in: >> - _org.openjdk.jmc.flightrecorder.ui_.common.DataPageToolkit >> - _org.openjdk.jmc.flightrecorder.ui_.common.FilterComponent >> - _org.openjdk.jmc.flightrecorder.ui_.common.LaneEditor >> - _org.openjdk.jmc.flightrecorder.ui_.pages.ItemHandlerPage >> >> **Note:** this issue was originally targeted for 8.1.0, but isn't really critical (it's a P4 task), so if desired we can hold off on integrating it now and keep this around for integration into 8.2.0 as discussed in the jmc bi-weekly calls >> >> [0] https://bugs.openjdk.java.net/browse/JMC-5904 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors I think it looks fairly straight forward, but at this point we're ramping down 8.1.0. Let's wait with integrating this until after we're done with 8.1.0. ------------- PR: https://git.openjdk.java.net/jmc/pull/271 From hirt at openjdk.java.net Fri Jul 2 22:09:51 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 2 Jul 2021 22:09:51 GMT Subject: RFR: 7042: Bring back summary screen for Statistics on Object Allocation outside TLAB. [v3] In-Reply-To: <8s4J8Po2cqKoGIuM_GMrq9e43YVfHGgMQjsJDVoS94g=.f02fcd30-cab7-4dce-99ea-1f55b0a151d7@github.com> References: <8s4J8Po2cqKoGIuM_GMrq9e43YVfHGgMQjsJDVoS94g=.f02fcd30-cab7-4dce-99ea-1f55b0a151d7@github.com> Message-ID: On Wed, 23 Jun 2021 21:53:00 GMT, Suchita Chaturvedi wrote: >> This PR addresses the enhancement of adding General screen (providing summary) and By Class (table and graph) for allocations inside and outside TLAB. >> >> The changes include the enhancement "7043: Bring back summary screen for Statistics on Object Allocation inside TLAB" as well. >> >> Note: This is bring back feature i.e. which was present in JMC 5.5 but was missing in recent releases. >> >> Please review the change and provide your valuable comments. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Implemented Review Comments Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/269 From schaturvedi at openjdk.java.net Mon Jul 5 04:03:52 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Mon, 5 Jul 2021 04:03:52 GMT Subject: Integrated: 7042: Bring back summary screen for Statistics on Object Allocation outside TLAB. In-Reply-To: References: Message-ID: On Fri, 18 Jun 2021 11:11:58 GMT, Suchita Chaturvedi wrote: > This PR addresses the enhancement of adding General screen (providing summary) and By Class (table and graph) for allocations inside and outside TLAB. > > The changes include the enhancement "7043: Bring back summary screen for Statistics on Object Allocation inside TLAB" as well. > > Note: This is bring back feature i.e. which was present in JMC 5.5 but was missing in recent releases. > > Please review the change and provide your valuable comments. This pull request has now been integrated. Changeset: 81344ce7 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/81344ce7f78a67ca9d23be1a9a3e10566a33a5a9 Stats: 124 lines in 8 files changed: 119 ins; 0 del; 5 mod 7042: Bring back summary screen for Statistics on Object Allocation outside TLAB. Reviewed-by: aptmac, hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/269 From jpbempel at openjdk.java.net Mon Jul 5 10:02:03 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 5 Jul 2021 10:02:03 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace Message-ID: replaced by java.util.logging logging ------------- Commit messages: - 4792: Stop using System.out/err.println and e.printStackTrace Changes: https://git.openjdk.java.net/jmc/pull/272/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-4792 Stats: 219 lines in 41 files changed: 97 ins; 13 del; 109 mod Patch: https://git.openjdk.java.net/jmc/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/272/head:pull/272 PR: https://git.openjdk.java.net/jmc/pull/272 From jpbempel at openjdk.java.net Mon Jul 5 10:23:13 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 5 Jul 2021 10:23:13 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v2] In-Reply-To: References: Message-ID: > replaced by java.util.logging logging Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: spotless ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/272/files - new: https://git.openjdk.java.net/jmc/pull/272/files/9cfba8ce..55892654 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/272/head:pull/272 PR: https://git.openjdk.java.net/jmc/pull/272 From hirt at openjdk.java.net Mon Jul 5 10:39:52 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 5 Jul 2021 10:39:52 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v2] In-Reply-To: References: Message-ID: <6ocsI6qYzXwNmcK2pN3Adn7qiLY75pI0TvDSSAAqFIs=.2715900f-7082-4b42-816d-c09cb65d0c8a@github.com> On Mon, 5 Jul 2021 10:23:13 GMT, Jean-Philippe Bempel wrote: >> replaced by java.util.logging logging > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > spotless agent/src/main/java/org/openjdk/jmc/agent/jfrlegacy/impl/JFRUtils.java line 79: > 77: } catch (NoSuchMethodException | SecurityException e) { > 78: // This should never happen > 79: Agent.getLogger().severe("Failed to find the addEvent method of the producer."); Let's just roll them up into one logger call with stacktrace. ------------- PR: https://git.openjdk.java.net/jmc/pull/272 From hirt at openjdk.java.net Mon Jul 5 10:47:53 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 5 Jul 2021 10:47:53 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v2] In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 10:23:13 GMT, Jean-Philippe Bempel wrote: >> replaced by java.util.logging logging > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > spotless application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java line 113: > 111: } catch (IOException e) { > 112: // FIXME: Better exception handling > 113: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); "Failed to load local template from file"? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java line 116: > 114: } catch (ParseException e) { > 115: // FIXME: Better exception handling > 116: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); "Failed to parse local template from file " + file... application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 240: > 238: VolatileStorageDelegate.getOnServerDelegate())); > 239: } catch (ParseException e) { > 240: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 242: > 240: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); > 241: } catch (IOException e) { > 242: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 246: > 244: } > 245: } catch (FlightRecorderException e) { > 246: ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java line 383: > 381: getSite().getPage().showView(CONTENT_OUTLINE_VIEW_ID, null, IWorkbenchPage.VIEW_VISIBLE); > 382: } catch (PartInitException e) { > 383: FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java line 1106: > 1104: setPageComplete(isPageComplete()); > 1105: } catch (Exception e) { > 1106: LOGGER.log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java line 165: > 163: buildHistogram(); > 164: } catch (Exception e) { > 165: LOGGER.log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java line 182: > 180: buildHistogram(); > 181: } catch (Exception e) { > 182: LOGGER.log(Level.SEVERE, "", e); Add helpful message? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/preferences/RulesPage.java line 211: > 209: getPreferenceStore().setValue(IGNORED_RULES, ignoredState.toString()); > 210: } catch (IOException e) { > 211: FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e); Add helpful message? core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/util/ChunkReader.java line 122: > 120: } catch (IOException e) { > 121: // Shouldn't happen. > 122: LOGGER.log(Level.SEVERE, "", e); Add helpful message? ------------- PR: https://git.openjdk.java.net/jmc/pull/272 From jpbempel at openjdk.java.net Mon Jul 5 16:54:15 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 5 Jul 2021 16:54:15 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v3] In-Reply-To: References: Message-ID: > replaced by java.util.logging logging Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: add helpful messages ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/272/files - new: https://git.openjdk.java.net/jmc/pull/272/files/55892654..d948fa39 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=01-02 Stats: 41 lines in 23 files changed: 2 ins; 5 del; 34 mod Patch: https://git.openjdk.java.net/jmc/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/272/head:pull/272 PR: https://git.openjdk.java.net/jmc/pull/272 From jpbempel at openjdk.java.net Mon Jul 5 17:30:14 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 5 Jul 2021 17:30:14 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v4] In-Reply-To: References: Message-ID: > replaced by java.util.logging logging Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: spotless ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/272/files - new: https://git.openjdk.java.net/jmc/pull/272/files/d948fa39..980aa8fa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=272&range=02-03 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/272/head:pull/272 PR: https://git.openjdk.java.net/jmc/pull/272 From mwengner at openjdk.java.net Tue Jul 6 13:05:52 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Tue, 6 Jul 2021 13:05:52 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v5] In-Reply-To: References: Message-ID: <-h-zydXfdQ6sisJUai6P1TrcEH__W2lCDLwUaf7l4rA=.2efd7f05-668c-438a-8729-b41fe50a1b17@github.com> On Mon, 28 Jun 2021 15:07:44 GMT, Alex Macdonald wrote: >> It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like: >> >> ![2021-06-25-115040_1173x738_scrot](https://user-images.githubusercontent.com/10425301/123451350-945a4580-d5ab-11eb-8b15-0d349926fccc.png) >> >> Steps: >> 1. Run as JMC-Eclipse IDE >> 2. Import a project >> 3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder" >> 4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.." >> 5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top >> >> At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice. >> >> However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222 >> >> Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this line looks to fix it. >> >> Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working: >> ![ezgif-2-1ce1066b3b31](https://user-images.githubusercontent.com/10425301/123454466-983b9700-d5ae-11eb-91d0-a66f5d0d8a9b.gif) > >> @aptmac it also doesn't allow you to select a template, even when you have created one in previous recording. This is bug and should be IMHO solved in another ticket, what do you think ? > > To be honest I thought from reading the bug description on [JMC-6204](https://bugs.openjdk.java.net/browse/JMC-6204) that this was the actual issue needing to be solved. It reads: > >> Usually the template combo box will contain the templates available in the template manager. However, it seems to bug out, especially for JDK 11 templates. Perhaps if the previously used template is no longer available too? Or if trying to select a template using the Template Manager button? > > So I see this PR as addressing a separate issue where the addition of commercial features flags was preventing the launcher tab from opening, but JMC-6204 is concerned with the template manager within the launcher. @thegreystone could you confirm? > > If you still wanted to go the separate bug route then a new bug could be opened for tracking this PR, and leave 6204 for the template manager work. > > For Linux there still needs to be a resolution for this line: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222. I'm not sure if that issue reported for Oracle JDK 7.1 is still valid, but to be safe there could also just be a quick check on `getShell()` to make sure it's not null. As it stands now it's crashing from a NPE and not providing any helpful diagnostic information in the dialog, here's what the error looks like: > > ![2021-06-28-110728_1152x733_scrot](https://user-images.githubusercontent.com/10425301/123659781-0b3c4c00-d801-11eb-8259-ce02e4f0701f.png) @aptmac I've fixed the commercial flag issue, but seems your are right. I'll take a look at the templates that should be available in template manager, this should be part of this bugfix ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From mwengner at openjdk.java.net Wed Jul 7 13:09:19 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 13:09:19 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v7] In-Reply-To: References: Message-ID: > Adding check box to the launcher tab to select Oracle JDK < 11. Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6204: adding default JDK_11 ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/265/files - new: https://git.openjdk.java.net/jmc/pull/265/files/b4ee87cf..e576aa74 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=06 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/265/head:pull/265 PR: https://git.openjdk.java.net/jmc/pull/265 From mwengner at openjdk.java.net Wed Jul 7 15:34:20 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 15:34:20 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v5] In-Reply-To: References: Message-ID: On Fri, 25 Jun 2021 16:12:48 GMT, Alex Macdonald wrote: > It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like: > > ![2021-06-25-115040_1173x738_scrot](https://user-images.githubusercontent.com/10425301/123451350-945a4580-d5ab-11eb-8b15-0d349926fccc.png) > > Steps: > > 1. Run as JMC-Eclipse IDE > 2. Import a project > 3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder" > 4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.." > 5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top > > At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice. > > However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222 > > Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this line looks to fix it. > > Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working: > ![ezgif-2-1ce1066b3b31](https://user-images.githubusercontent.com/10425301/123454466-983b9700-d5ae-11eb-91d0-a66f5d0d8a9b.gif) this behavior is caused by wrong schema version (1.0) which comes from JfrLaunchModel, I've changed it now to JDK_11. which should allows at least more JDKs. issue is again Oracle JDK. Trying to figure out how to update properly the configuration. I need to find a way how to override the schema configuration when the RecordingWizard is open. Currently all works when you just configure JFR and push Apply for Oracle JDK 1.8 ![image](https://user-images.githubusercontent.com/1956942/124787062-8364e900-df48-11eb-8efc-e22073b7bd1c.png) ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From mwengner at openjdk.java.net Wed Jul 7 15:34:20 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 15:34:20 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v8] In-Reply-To: References: Message-ID: > Adding check box to the launcher tab to select Oracle JDK < 11. Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6204: update schema version in configuration wizard ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/265/files - new: https://git.openjdk.java.net/jmc/pull/265/files/e576aa74..c3624160 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=06-07 Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/265/head:pull/265 PR: https://git.openjdk.java.net/jmc/pull/265 From hirt at openjdk.java.net Wed Jul 7 17:10:56 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Jul 2021 17:10:56 GMT Subject: RFR: 7167: Agent Plugin [v11] In-Reply-To: References: Message-ID: On Tue, 22 Jun 2021 22:10:08 GMT, Joshua Matsuoka wrote: >> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. >> >> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) > > Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: > > Decorating outputstreamWriter with a bufferedWriter Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From mwengner at openjdk.java.net Wed Jul 7 17:48:12 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 17:48:12 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v9] In-Reply-To: References: Message-ID: > Adding check box to the launcher tab to select Oracle JDK < 11. Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision: - 6204: spot check - 6204: update shell ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/265/files - new: https://git.openjdk.java.net/jmc/pull/265/files/c3624160..9be40714 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=08 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=265&range=07-08 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/265.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/265/head:pull/265 PR: https://git.openjdk.java.net/jmc/pull/265 From mwengner at openjdk.java.net Wed Jul 7 17:56:51 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 17:56:51 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v5] In-Reply-To: References: Message-ID: <5sCqLDGbSptPMvGbeOyKaEjd6o153C8di5h8NOJEJq0=.021ff0fa-a388-4693-84e3-0f82ea915a97@github.com> On Mon, 28 Jun 2021 15:07:44 GMT, Alex Macdonald wrote: >> It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like: >> >> ![2021-06-25-115040_1173x738_scrot](https://user-images.githubusercontent.com/10425301/123451350-945a4580-d5ab-11eb-8b15-0d349926fccc.png) >> >> Steps: >> 1. Run as JMC-Eclipse IDE >> 2. Import a project >> 3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder" >> 4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.." >> 5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top >> >> At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice. >> >> However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222 >> >> Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this line looks to fix it. >> >> Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working: >> ![ezgif-2-1ce1066b3b31](https://user-images.githubusercontent.com/10425301/123454466-983b9700-d5ae-11eb-91d0-a66f5d0d8a9b.gif) > >> @aptmac it also doesn't allow you to select a template, even when you have created one in previous recording. This is bug and should be IMHO solved in another ticket, what do you think ? > > To be honest I thought from reading the bug description on [JMC-6204](https://bugs.openjdk.java.net/browse/JMC-6204) that this was the actual issue needing to be solved. It reads: > >> Usually the template combo box will contain the templates available in the template manager. However, it seems to bug out, especially for JDK 11 templates. Perhaps if the previously used template is no longer available too? Or if trying to select a template using the Template Manager button? > > So I see this PR as addressing a separate issue where the addition of commercial features flags was preventing the launcher tab from opening, but JMC-6204 is concerned with the template manager within the launcher. @thegreystone could you confirm? > > If you still wanted to go the separate bug route then a new bug could be opened for tracking this PR, and leave 6204 for the template manager work. > > For Linux there still needs to be a resolution for this line: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222. I'm not sure if that issue reported for Oracle JDK 7.1 is still valid, but to be safe there could also just be a quick check on `getShell()` to make sure it's not null. As it stands now it's crashing from a NPE and not providing any helpful diagnostic information in the dialog, here's what the error looks like: > > ![2021-06-28-110728_1152x733_scrot](https://user-images.githubusercontent.com/10425301/123659781-0b3c4c00-d801-11eb-8259-ce02e4f0701f.png) I'll open a bug according to the issue with Oracle JDK 1.8 and Template Manager. @aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From mwengner at openjdk.java.net Wed Jul 7 17:56:52 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 17:56:52 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v9] In-Reply-To: References: Message-ID: On Wed, 7 Jul 2021 17:48:12 GMT, Miroslav Wengner wrote: >> Adding check box to the launcher tab to select Oracle JDK < 11. > > Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision: > > - 6204: spot check > - 6204: update shell Seem this bug is fixed for most of use-cases ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From aptmac at openjdk.java.net Wed Jul 7 18:07:53 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 7 Jul 2021 18:07:53 GMT Subject: RFR: 6204: Flight recorder launcher tab bugs out [v9] In-Reply-To: References: Message-ID: On Wed, 7 Jul 2021 17:48:12 GMT, Miroslav Wengner wrote: >> Adding check box to the launcher tab to select Oracle JDK < 11. > > Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision: > > - 6204: spot check > - 6204: update shell Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From aptmac at openjdk.java.net Wed Jul 7 18:13:58 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 7 Jul 2021 18:13:58 GMT Subject: RFR: 7167: Agent Plugin [v11] In-Reply-To: References: Message-ID: On Wed, 7 Jul 2021 18:09:05 GMT, Alex Macdonald wrote: >> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: >> >> Decorating outputstreamWriter with a bufferedWriter > > Thanks for all the reviews everyone, I'll integrate this shortly on behalf of Josh > @aptmac Only the author (@Josh-Matsuoka) is allowed to issue the `integrate` command. Jokes on me, I'll send him a ping to do so ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From aptmac at openjdk.java.net Wed Jul 7 18:13:58 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 7 Jul 2021 18:13:58 GMT Subject: RFR: 7167: Agent Plugin [v11] In-Reply-To: References: Message-ID: On Tue, 22 Jun 2021 22:10:08 GMT, Joshua Matsuoka wrote: >> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. >> >> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) > > Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: > > Decorating outputstreamWriter with a bufferedWriter Thanks for all the reviews everyone, I'll integrate this shortly on behalf of Josh ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From mwengner at openjdk.java.net Wed Jul 7 18:15:52 2021 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 7 Jul 2021 18:15:52 GMT Subject: Integrated: 6204: Flight recorder launcher tab bugs out In-Reply-To: References: Message-ID: <0EzV8Gen5gdCd97vITxTXAEQI-OiuNrAAzWweo9toJU=.bf9d960d-7d7b-4395-924c-2f4127bf3cbf@github.com> On Fri, 11 Jun 2021 22:04:39 GMT, Miroslav Wengner wrote: > Adding check box to the launcher tab to select Oracle JDK < 11. This pull request has now been integrated. Changeset: 1d7397ef Author: Miroslav Wengner URL: https://git.openjdk.java.net/jmc/commit/1d7397ef3d555d90ab1535ba1b8ea0079ccd6bd2 Stats: 91 lines in 10 files changed: 75 ins; 2 del; 14 mod 6204: Flight recorder launcher tab bugs out Reviewed-by: aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/265 From jmatsuoka at openjdk.java.net Wed Jul 7 18:18:57 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Wed, 7 Jul 2021 18:18:57 GMT Subject: Integrated: 7167: Agent Plugin In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 22:58:07 GMT, Joshua Matsuoka wrote: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) This pull request has now been integrated. Changeset: 2e8a2513 Author: Joshua Matsuoka URL: https://git.openjdk.java.net/jmc/commit/2e8a2513ec842b1baa59b5285960a14357793df8 Stats: 9122 lines in 73 files changed: 9120 ins; 0 del; 2 mod 7167: Agent Plugin Co-authored-by: Alex Macdonald Co-authored-by: Jessye Coleman-Shapiro Co-authored-by: Kangcheng Xu Reviewed-by: hirt, jkang ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From jpbempel at openjdk.java.net Thu Jul 8 16:39:16 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Thu, 8 Jul 2021 16:39:16 GMT Subject: RFR: 7327: Constant Pool optimizations Message-ID: Fix topic name for Constant pools page. This avoid to have the same results than the recording ones ------------- Commit messages: - 7327: Constant Pool optimizations Changes: https://git.openjdk.java.net/jmc/pull/273/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=273&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7327 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/273.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/273/head:pull/273 PR: https://git.openjdk.java.net/jmc/pull/273 From hirt at openjdk.java.net Thu Jul 8 18:15:51 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 8 Jul 2021 18:15:51 GMT Subject: RFR: 7327: Constant Pool optimizations In-Reply-To: References: Message-ID: On Thu, 8 Jul 2021 16:33:47 GMT, Jean-Philippe Bempel wrote: > Fix topic name for Constant pools page. This avoid to have the same > results than the recording ones Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/273 From jpbempel at openjdk.java.net Thu Jul 8 20:06:56 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Thu, 8 Jul 2021 20:06:56 GMT Subject: Integrated: 7327: Constant Pool optimizations In-Reply-To: References: Message-ID: <7nawRWN_fAVcadV5TH9CzMrrLn4NmhRInCZ2vfyXH_8=.48b49256-3083-47b0-8d5f-bc35685bcbeb@github.com> On Thu, 8 Jul 2021 16:33:47 GMT, Jean-Philippe Bempel wrote: > Fix topic name for Constant pools page. This avoid to have the same > results than the recording ones This pull request has now been integrated. Changeset: f5a9cf32 Author: Jean-Philippe Bempel URL: https://git.openjdk.java.net/jmc/commit/f5a9cf32a17f2c74685eb4682beea76a420f0d44 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod 7327: Constant Pool optimizations Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/273 From jbachorik at openjdk.java.net Fri Jul 9 09:56:06 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Fri, 9 Jul 2021 09:56:06 GMT Subject: RFR: JMC-7338: Add parser support for frame types generated by async-profiler Message-ID: Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel). It is adding three new frame types for this reason: - Native (C) - C++ - Kernel Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type. ------------- Commit messages: - JMC-7338: Add parser support for frame types generated by async-profiler Changes: https://git.openjdk.java.net/jmc/pull/274/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=274&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7338 Stats: 25 lines in 2 files changed: 23 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/274/head:pull/274 PR: https://git.openjdk.java.net/jmc/pull/274 From schaturvedi at openjdk.java.net Fri Jul 9 10:23:07 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Fri, 9 Jul 2021 10:23:07 GMT Subject: RFR: 6922: Reintroduce GC summary screen Message-ID: <5gwD6wpjW51kcI8wzk3CLG2fDOluZMugzc6fLsMQRHk=.063da7d6-0c54-48f4-b764-313377fefc5a@github.com> This PR addresses the enhancement of adding a new screen "GC Summary" which will cover missing information from "GC Times" screen present in JMC 5.5. Here is the preview of the new screen added for the reference: ![image](https://user-images.githubusercontent.com/11155712/125062925-8a1c6900-e0cc-11eb-992e-a40a72a21ffe.png) Here is the preview of the reference screen from JMC 5.5 ![image](https://user-images.githubusercontent.com/11155712/125063237-dc5d8a00-e0cc-11eb-86d8-37a883511d45.png) I have opened same JFR in both the versions, so that values can be compared while review. Please review the changes and let me know your valuable comments. ------------- Commit messages: - 6922: Reintroduce GC summary screen Changes: https://git.openjdk.java.net/jmc/pull/275/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=275&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6922 Stats: 278 lines in 10 files changed: 277 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/275.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/275/head:pull/275 PR: https://git.openjdk.java.net/jmc/pull/275 From jpbempel at openjdk.java.net Fri Jul 9 13:25:53 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Fri, 9 Jul 2021 13:25:53 GMT Subject: RFR: JMC-7338: Add parser support for frame types generated by async-profiler In-Reply-To: References: Message-ID: On Fri, 9 Jul 2021 09:50:52 GMT, Jaroslav Bachorik wrote: > Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel). > It is adding three new frame types for this reason: > > - Native (C) > - C++ > - Kernel > > > Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java line 3: > 1: /* > 2: * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved. > 3: * Copyright (c) 2021, Datadog, Inc. All rights reserved. I think the Datadog copyright can only added for entire new file. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/ParserToolkit.java line 3: > 1: /* > 2: * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved. > 3: * Copyright (c) 2021, Datadog, Inc. All rights reserved. same as above ------------- PR: https://git.openjdk.java.net/jmc/pull/274 From hirt at openjdk.java.net Fri Jul 9 13:41:55 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Jul 2021 13:41:55 GMT Subject: RFR: JMC-7338: Add parser support for frame types generated by async-profiler In-Reply-To: References: Message-ID: On Fri, 9 Jul 2021 09:50:52 GMT, Jaroslav Bachorik wrote: > Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel). > It is adding three new frame types for this reason: > > - Native (C) > - C++ > - Kernel > > > Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type. Also, just a reminder that no reviewer should approve this PR until the master branch is updated to 8.2.0. ------------- PR: https://git.openjdk.java.net/jmc/pull/274 From jbachorik at openjdk.java.net Fri Jul 9 13:57:51 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Fri, 9 Jul 2021 13:57:51 GMT Subject: RFR: JMC-7338: Add parser support for frame types generated by async-profiler In-Reply-To: References: Message-ID: On Fri, 9 Jul 2021 13:20:46 GMT, Jean-Philippe Bempel wrote: >> Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel). >> It is adding three new frame types for this reason: >> >> - Native (C) >> - C++ >> - Kernel >> >> >> Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type. > > core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java line 3: > >> 1: /* >> 2: * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved. >> 3: * Copyright (c) 2021, Datadog, Inc. All rights reserved. > > I think the Datadog copyright can only added for entire new file. I am not sure. From what I understand from the licenses even the changes should be covered by copyright. But IANAL - I am fine either way. @thegreystone - what is the 'right' way here? ------------- PR: https://git.openjdk.java.net/jmc/pull/274 From hirt at openjdk.java.net Fri Jul 9 15:14:58 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Jul 2021 15:14:58 GMT Subject: RFR: 7338: Add parser support for frame types generated by async-profiler In-Reply-To: References: Message-ID: <1kBGfmEhPCR_W-iYM08OO6FM9nBO4QP_GsDeDcGFNuE=.70b91f60-2b25-40d6-aa72-ba8dc2504aad@github.com> On Fri, 9 Jul 2021 13:54:35 GMT, Jaroslav Bachorik wrote: >> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java line 3: >> >>> 1: /* >>> 2: * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved. >>> 3: * Copyright (c) 2021, Datadog, Inc. All rights reserved. >> >> I think the Datadog copyright can only added for entire new file. > > I am not sure. From what I understand from the licenses even the changes should be covered by copyright. > But IANAL - I am fine either way. > > @thegreystone - what is the 'right' way here? The right way is to only update the year for pre-existing files with only the Oracle copyright. For new files, the copyright of the company contributing the code can be added _after_ the Oracle copyright. ------------- PR: https://git.openjdk.java.net/jmc/pull/274 From jbachorik at openjdk.java.net Fri Jul 9 16:22:18 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Fri, 9 Jul 2021 16:22:18 GMT Subject: RFR: 7338: Add parser support for frame types generated by async-profiler [v2] In-Reply-To: References: Message-ID: > Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel). > It is adding three new frame types for this reason: > > - Native (C) > - C++ > - Kernel > > > Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type. Jaroslav Bachorik has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7338: Add parser support for frame types generated by async-profiler ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/274/files - new: https://git.openjdk.java.net/jmc/pull/274/files/cd04fb80..6b8a5f32 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=274&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=274&range=00-01 Stats: 5 lines in 2 files changed: 0 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/274.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/274/head:pull/274 PR: https://git.openjdk.java.net/jmc/pull/274 From jbachorik at openjdk.java.net Fri Jul 9 16:47:52 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Fri, 9 Jul 2021 16:47:52 GMT Subject: RFR: 7338: Add parser support for frame types generated by async-profiler [v2] In-Reply-To: <1kBGfmEhPCR_W-iYM08OO6FM9nBO4QP_GsDeDcGFNuE=.70b91f60-2b25-40d6-aa72-ba8dc2504aad@github.com> References: <1kBGfmEhPCR_W-iYM08OO6FM9nBO4QP_GsDeDcGFNuE=.70b91f60-2b25-40d6-aa72-ba8dc2504aad@github.com> Message-ID: On Fri, 9 Jul 2021 15:12:14 GMT, Marcus Hirt wrote: >> I am not sure. From what I understand from the licenses even the changes should be covered by copyright. >> But IANAL - I am fine either way. >> >> @thegreystone - what is the 'right' way here? > > The right way is to only update the year for pre-existing files with only the Oracle copyright. For new files, the copyright of the company contributing the code can be added _after_ the Oracle copyright. Removed ------------- PR: https://git.openjdk.java.net/jmc/pull/274 From hirt at openjdk.java.net Sat Jul 10 12:25:01 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 10 Jul 2021 12:25:01 GMT Subject: RFR: 7328: Incorrect sort order in method profiling page Message-ID: Also fixing some import warnings. ------------- Commit messages: - 7328: Incorrect sort order in method profiling page Changes: https://git.openjdk.java.net/jmc/pull/276/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=276&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7328 Stats: 29 lines in 7 files changed: 19 ins; 7 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/276.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/276/head:pull/276 PR: https://git.openjdk.java.net/jmc/pull/276 From jpbempel at openjdk.java.net Sat Jul 10 13:16:47 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Sat, 10 Jul 2021 13:16:47 GMT Subject: RFR: 7328: Incorrect sort order in method profiling page In-Reply-To: References: Message-ID: On Sat, 10 Jul 2021 12:20:43 GMT, Marcus Hirt wrote: > Also fixing some import warnings. Marked as reviewed by jpbempel (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/276 From aptmac at openjdk.java.net Mon Jul 12 14:38:59 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 12 Jul 2021 14:38:59 GMT Subject: RFR: 7328: Incorrect sort order in method profiling page In-Reply-To: References: Message-ID: On Sat, 10 Jul 2021 12:20:43 GMT, Marcus Hirt wrote: > Also fixing some import warnings. Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/276 From hirt at openjdk.java.net Mon Jul 12 16:29:50 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 12 Jul 2021 16:29:50 GMT Subject: Integrated: 7328: Incorrect sort order in method profiling page In-Reply-To: References: Message-ID: <68GwBUQn-XD_glc5ETuMc7t6vAHdqRlKiTst8gPeeZU=.f9094f5a-54d3-4d4b-90e4-112325b82ce2@github.com> On Sat, 10 Jul 2021 12:20:43 GMT, Marcus Hirt wrote: > Also fixing some import warnings. This pull request has now been integrated. Changeset: 11e547a0 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/11e547a0fc127973eeeacc6ee30b22ea21ef2daa Stats: 29 lines in 7 files changed: 19 ins; 7 del; 3 mod 7328: Incorrect sort order in method profiling page Reviewed-by: jpbempel, aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/276 From schaturvedi at openjdk.java.net Wed Jul 14 19:11:22 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Wed, 14 Jul 2021 19:11:22 GMT Subject: RFR: 7329: Exception while opening Method Profile page. Message-ID: This PR addresses the null pointer exception issue. ------------- Commit messages: - 7329: Exception while opening Method Profile page. Changes: https://git.openjdk.java.net/jmc/pull/277/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=277&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7329 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/277/head:pull/277 PR: https://git.openjdk.java.net/jmc/pull/277 From aptmac at openjdk.java.net Wed Jul 14 21:39:11 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 14 Jul 2021 21:39:11 GMT Subject: RFR: 7329: Exception while opening Method Profile page. In-Reply-To: References: Message-ID: On Wed, 14 Jul 2021 19:06:33 GMT, Suchita Chaturvedi wrote: > This PR addresses the null pointer exception issue. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/internal/MethodWithFrameTypeLabelProvider.java line 109: > 107: method = ((IMCFrame) key).getMethod(); > 108: } > 109: if ((method != null) & (method.getModifier() != null)) { Spotbugs: Error: High: Questionable use of non-short-circuit logic in org.openjdk.jmc.flightrecorder.ui.pages.internal.MethodWithFrameTypeLabelProvider.getImage(Object) [org.openjdk.jmc.flightrecorder.ui.pages.internal.MethodWithFrameTypeLabelProvider] At MethodWithFrameTypeLabelProvider.java:[line 109] NS_NON_SHORT_CIRCUIT NS: Questionable use of non-short-circuit logic (NS_NON_SHORT_CIRCUIT) This code seems to be using non-short-circuit logic (e.g., & or |) rather than short-circuit logic (&& or ||). Non-short-circuit logic causes both sides of the expression to be evaluated even when the result can be inferred from knowing the left-hand side. This can be less efficient and can result in errors if the left-hand side guards cases when evaluating the right-hand side can generate an error. ------------- PR: https://git.openjdk.java.net/jmc/pull/277 From schaturvedi at openjdk.java.net Thu Jul 15 05:29:34 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Thu, 15 Jul 2021 05:29:34 GMT Subject: RFR: 7329: Exception while opening Method Profile page. [v2] In-Reply-To: References: Message-ID: > This PR addresses the null pointer exception issue. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Fix spotbugs failures ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/277/files - new: https://git.openjdk.java.net/jmc/pull/277/files/b0942554..3570af41 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=277&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=277&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/277.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/277/head:pull/277 PR: https://git.openjdk.java.net/jmc/pull/277 From hirt at openjdk.java.net Thu Jul 15 11:34:13 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 15 Jul 2021 11:34:13 GMT Subject: RFR: 7329: Exception while opening Method Profile page. [v2] In-Reply-To: References: Message-ID: <95fIOe8IUgS8eCT6RmHLElFhL8FOPwBcGmTF6_8Qgso=.715a31fe-d3e0-4483-9934-dc5e3ad22e87@github.com> On Thu, 15 Jul 2021 05:29:34 GMT, Suchita Chaturvedi wrote: >> This PR addresses the null pointer exception issue. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Fix spotbugs failures Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/277 From schaturvedi at openjdk.java.net Thu Jul 15 11:41:13 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Thu, 15 Jul 2021 11:41:13 GMT Subject: Integrated: 7329: Exception while opening Method Profile page. In-Reply-To: References: Message-ID: On Wed, 14 Jul 2021 19:06:33 GMT, Suchita Chaturvedi wrote: > This PR addresses the null pointer exception issue. This pull request has now been integrated. Changeset: 362414b5 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/362414b51b3306dacb4869a3022ce3d566508eb4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7329: Exception while opening Method Profile page. Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/277 From ghb at openjdk.java.net Thu Jul 15 15:07:25 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Thu, 15 Jul 2021 15:07:25 GMT Subject: RFR: 7324: Update eclipse version and Min JDK required in Update Site landing sites Message-ID: With Eclipse 4.19 JMC can't be used with Boot JDK 8. Currently the Update sites landing page and README.txt had instruction on how JMC can be used with JDK8 (Which is not valid any more). Updated instruction to use JMC with JDK 11 and above. ------------- Commit messages: - 7324: Update eclipse version and Min JDK required in Update Site landing pages Changes: https://git.openjdk.java.net/jmc/pull/278/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=278&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7324 Stats: 18 lines in 7 files changed: 1 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/jmc/pull/278.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/278/head:pull/278 PR: https://git.openjdk.java.net/jmc/pull/278 From hirt at openjdk.java.net Thu Jul 15 18:03:13 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 15 Jul 2021 18:03:13 GMT Subject: RFR: 7324: Update eclipse version and Min JDK required in Update Site landing pages In-Reply-To: References: Message-ID: <-es7iwSDtwMV6vwSQ3fnqGX95fhSSgiFWs2ACTS8a2U=.0089b698-a77f-48aa-af57-7a9b337d70fb@github.com> On Thu, 15 Jul 2021 15:03:07 GMT, Guru Hb wrote: > With Eclipse 4.19 JMC can't be used with Boot JDK 8. Currently the Update sites landing page and README.txt had instruction on how JMC can be used with JDK8 (Which is not valid any more). > > Updated instruction to use JMC with JDK 11 and above. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/278 From ghb at openjdk.java.net Fri Jul 16 05:57:13 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 16 Jul 2021 05:57:13 GMT Subject: Integrated: 7324: Update eclipse version and Min JDK required in Update Site landing pages In-Reply-To: References: Message-ID: <8g3jyAQmvfpTk0dvbHgBpeBMrnqjVuKjQnEKTR16TOY=.4e45e58c-210e-4c09-8762-f0145ef6e560@github.com> On Thu, 15 Jul 2021 15:03:07 GMT, Guru Hb wrote: > With Eclipse 4.19 JMC can't be used with Boot JDK 8. Currently the Update sites landing page and README.txt had instruction on how JMC can be used with JDK8 (Which is not valid any more). > > Updated instruction to use JMC with JDK 11 and above. This pull request has now been integrated. Changeset: 5a3e3033 Author: Guru Hb URL: https://git.openjdk.java.net/jmc/commit/5a3e30334a303903fcdca7c77f321dc19b0a888b Stats: 18 lines in 7 files changed: 1 ins; 0 del; 17 mod 7324: Update eclipse version and Min JDK required in Update Site landing pages Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/278 From hirt at openjdk.java.net Thu Jul 22 10:50:48 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 22 Jul 2021 10:50:48 GMT Subject: RFR: 7344: Unhandled exception in rule evaluation In-Reply-To: References: Message-ID: On Wed, 21 Jul 2021 16:50:04 GMT, Guru Hb wrote: > With JFR generated from JDK17-ea "usedSize" event was missing (i.e not generated) due to this the used aggregator was null. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/280 From ghb at openjdk.java.net Thu Jul 22 11:50:52 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Thu, 22 Jul 2021 11:50:52 GMT Subject: Integrated: 7344: Unhandled exception in rule evaluation In-Reply-To: References: Message-ID: On Wed, 21 Jul 2021 16:50:04 GMT, Guru Hb wrote: > With JFR generated from JDK17-ea "usedSize" event was missing (i.e not generated) due to this the used aggregator was null. This pull request has now been integrated. Changeset: b0b037aa Author: Guru Hb URL: https://git.openjdk.java.net/jmc/commit/b0b037aa001eed8e9ac004ffed302672a4e95472 Stats: 312 lines in 4 files changed: 297 ins; 0 del; 15 mod 7344: Unhandled exception in rule evaluation Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/280 From hirt at openjdk.java.net Thu Jul 22 12:13:52 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 22 Jul 2021 12:13:52 GMT Subject: RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v4] In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 17:30:14 GMT, Jean-Philippe Bempel wrote: >> replaced by java.util.logging logging > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > spotless Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/272 From jpbempel at openjdk.java.net Thu Jul 22 12:34:48 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Thu, 22 Jul 2021 12:34:48 GMT Subject: Integrated: 4792: Stop using System.out/err.println and e.printStackTrace In-Reply-To: References: Message-ID: On Mon, 5 Jul 2021 09:56:33 GMT, Jean-Philippe Bempel wrote: > replaced by java.util.logging logging This pull request has now been integrated. Changeset: c6e0606d Author: Jean-Philippe Bempel URL: https://git.openjdk.java.net/jmc/commit/c6e0606d25a7cc89e3b85a958a49567cabfb3013 Stats: 225 lines in 41 files changed: 99 ins; 14 del; 112 mod 4792: Stop using System.out/err.println and e.printStackTrace Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/272 From schaturvedi at openjdk.java.net Thu Jul 22 13:50:50 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Thu, 22 Jul 2021 13:50:50 GMT Subject: Integrated: 6922: Reintroduce GC summary screen In-Reply-To: <5gwD6wpjW51kcI8wzk3CLG2fDOluZMugzc6fLsMQRHk=.063da7d6-0c54-48f4-b764-313377fefc5a@github.com> References: <5gwD6wpjW51kcI8wzk3CLG2fDOluZMugzc6fLsMQRHk=.063da7d6-0c54-48f4-b764-313377fefc5a@github.com> Message-ID: On Fri, 9 Jul 2021 10:19:11 GMT, Suchita Chaturvedi wrote: > This PR addresses the enhancement of adding a new screen "GC Summary" which will cover missing information from "GC Times" screen present in JMC 5.5. > > Here is the preview of the new screen added for the reference: > > ![image](https://user-images.githubusercontent.com/11155712/125062925-8a1c6900-e0cc-11eb-992e-a40a72a21ffe.png) > > Here is the preview of the reference screen from JMC 5.5 > > ![image](https://user-images.githubusercontent.com/11155712/125063237-dc5d8a00-e0cc-11eb-86d8-37a883511d45.png) > > I have opened same JFR in both the versions, so that values can be compared while review. > > Please review the changes and let me know your valuable comments. This pull request has now been integrated. Changeset: c54c00b4 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/c54c00b4b466a6c64d2dd53a7c98811341db8780 Stats: 278 lines in 10 files changed: 277 ins; 0 del; 1 mod 6922: Reintroduce GC summary screen Reviewed-by: ghb, aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/275 From aptmac at openjdk.java.net Fri Jul 23 14:57:15 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 23 Jul 2021 14:57:15 GMT Subject: RFR: 7353: JMC fails to build because it can't download babel dependency Message-ID: This PR addresses JMC-7353 [[0]](https://bugs.openjdk.java.net/browse/JMC-7353) (and JMC-7356 [[1]](https://bugs.openjdk.java.net/browse/JMC-7356)), in which JMC cannot build because the babel dependency is unable to be downloaded: [ERROR] All attempts to read artifact osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 failed: [ERROR] An error occurred while transferring artifact canonical: osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 from repository https://archive.eclipse.org/technology/babel/update-site/R0.18.3/2021-03 This is due to a recent update to babel for platforms 2020-12 and 2021-03 (and 2021-06, but that doesn't affect us yet ..) [[2]](https://www.eclipse.org/babel/downloads.php), which resulted in a new url being required to fetch the current supported version of babel for 2021-03. This PR updates the url and version of babel for the 2021-03 target platform. Note that there is also an updated link for the 2020-12 babel, but the older babel isn't causing any problems downloading at the moment, so I've decided to only update the 2021-03 target platform here. To verify this you can blow-up your ~/.m2 folder and try a clean install with 2021-03 as the active platform. [0] https://bugs.openjdk.java.net/browse/JMC-7353 [1] https://bugs.openjdk.java.net/browse/JMC-7356 [2] https://www.eclipse.org/babel/downloads.php ------------- Commit messages: - 7353: JMC fails to build because it can't download babel dependency Changes: https://git.openjdk.java.net/jmc/pull/281/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=281&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7353 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/281.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/281/head:pull/281 PR: https://git.openjdk.java.net/jmc/pull/281 From hirt at openjdk.java.net Fri Jul 23 15:54:05 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 23 Jul 2021 15:54:05 GMT Subject: RFR: 7353: JMC fails to build because it can't download babel dependency In-Reply-To: References: Message-ID: On Fri, 23 Jul 2021 14:52:29 GMT, Alex Macdonald wrote: > This PR addresses JMC-7353 [[0]](https://bugs.openjdk.java.net/browse/JMC-7353) (and JMC-7356 [[1]](https://bugs.openjdk.java.net/browse/JMC-7356)), in which JMC cannot build because the babel dependency is unable to be downloaded: > > [ERROR] All attempts to read artifact osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 failed: > [ERROR] An error occurred while transferring artifact canonical: osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 from repository > https://archive.eclipse.org/technology/babel/update-site/R0.18.3/2021-03 > > > This is due to a recent update to babel for platforms 2020-12 and 2021-03 (and 2021-06, but that doesn't affect us yet ..) [[2]](https://www.eclipse.org/babel/downloads.php), which resulted in a new url being required to fetch the current supported version of babel for 2021-03. This PR updates the url and version of babel for the 2021-03 target platform. > > Note that there is also an updated link for the 2020-12 babel, but the older babel isn't causing any problems downloading at the moment, so I've decided to only update the 2021-03 target platform here. > > To verify this you can blow-up your ~/.m2 folder and try a clean install with 2021-03 as the active platform. > > [0] https://bugs.openjdk.java.net/browse/JMC-7353 > [1] https://bugs.openjdk.java.net/browse/JMC-7356 > [2] https://www.eclipse.org/babel/downloads.php Marked as reviewed by hirt (Lead). Thanks for looking into this Alex! ------------- PR: https://git.openjdk.java.net/jmc/pull/281 From aptmac at openjdk.java.net Fri Jul 23 18:41:01 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 23 Jul 2021 18:41:01 GMT Subject: Integrated: 7353: JMC fails to build because it can't download babel dependency In-Reply-To: References: Message-ID: <9M_L0296dubJrA8PwzigpdBl03C9YfEaPhkAaRYYD1w=.5a5ce941-59ac-4877-985f-e870e5fc25b3@github.com> On Fri, 23 Jul 2021 14:52:29 GMT, Alex Macdonald wrote: > This PR addresses JMC-7353 [[0]](https://bugs.openjdk.java.net/browse/JMC-7353) (and JMC-7356 [[1]](https://bugs.openjdk.java.net/browse/JMC-7356)), in which JMC cannot build because the babel dependency is unable to be downloaded: > > [ERROR] All attempts to read artifact osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 failed: > [ERROR] An error occurred while transferring artifact canonical: osgi.bundle,org.eclipse.compare.core.nl_ja,4.19.0.v20210327020002 from repository > https://archive.eclipse.org/technology/babel/update-site/R0.18.3/2021-03 > > > This is due to a recent update to babel for platforms 2020-12 and 2021-03 (and 2021-06, but that doesn't affect us yet ..) [[2]](https://www.eclipse.org/babel/downloads.php), which resulted in a new url being required to fetch the current supported version of babel for 2021-03. This PR updates the url and version of babel for the 2021-03 target platform. > > Note that there is also an updated link for the 2020-12 babel, but the older babel isn't causing any problems downloading at the moment, so I've decided to only update the 2021-03 target platform here. > > To verify this you can blow-up your ~/.m2 folder and try a clean install with 2021-03 as the active platform. > > [0] https://bugs.openjdk.java.net/browse/JMC-7353 > [1] https://bugs.openjdk.java.net/browse/JMC-7356 > [2] https://www.eclipse.org/babel/downloads.php This pull request has now been integrated. Changeset: 0113da9c Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/0113da9ca69601c58244361e4322b4ea210809f6 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 7353: JMC fails to build because it can't download babel dependency Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/281 From ghb at openjdk.java.net Mon Jul 26 06:40:20 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 06:40:20 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code Message-ID: Trivial Fortify warning fix ------------- Commit messages: - 7357: Double-Checked Locking in Agent Plugin code Changes: https://git.openjdk.java.net/jmc/pull/282/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=282&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7357 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/282/head:pull/282 PR: https://git.openjdk.java.net/jmc/pull/282 From ghb at openjdk.java.net Mon Jul 26 07:00:27 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 07:00:27 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v2] In-Reply-To: References: Message-ID: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> > Trivial Fortify warning fix Guru Hb has updated the pull request incrementally with one additional commit since the last revision: Fixing formatting error ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/282/files - new: https://git.openjdk.java.net/jmc/pull/282/files/e48a53ae..c9488a1d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=282&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=282&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/282/head:pull/282 PR: https://git.openjdk.java.net/jmc/pull/282 From hirt at openjdk.java.net Mon Jul 26 10:04:28 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 10:04:28 GMT Subject: RFR: 7362: Reference wrong in agent plug-in.xml Message-ID: Also cleaning up and making it possible to use the project from within Eclipse. ------------- Commit messages: - 7362: Reference wrong in agent plug-in.xml Changes: https://git.openjdk.java.net/jmc/pull/283/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=283&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7362 Stats: 100 lines in 13 files changed: 49 ins; 47 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/283/head:pull/283 PR: https://git.openjdk.java.net/jmc/pull/283 From hirt at openjdk.java.net Mon Jul 26 10:16:54 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 10:16:54 GMT Subject: RFR: 7362: Reference wrong in agent plug-in.xml [v2] In-Reply-To: References: Message-ID: > Also cleaning up and making it possible to use the project from within Eclipse. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Getting rid of warnings ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/283/files - new: https://git.openjdk.java.net/jmc/pull/283/files/961bc83c..ba9aedda Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=283&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=283&range=00-01 Stats: 9 lines in 2 files changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/283/head:pull/283 PR: https://git.openjdk.java.net/jmc/pull/283 From jpbempel at openjdk.java.net Mon Jul 26 10:24:09 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 26 Jul 2021 10:24:09 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v2] In-Reply-To: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> References: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> Message-ID: <1_8XOTa-J8tvjHjRJbMxToBNhpj3g0P5M7CzeKBlJLI=.cd3437a5-99d6-403c-940c-100b5bd3ca93@github.com> On Mon, 26 Jul 2021 07:00:27 GMT, Guru Hb wrote: >> Trivial Fortify warning fix > > Guru Hb has updated the pull request incrementally with one additional commit since the last revision: > > Fixing formatting error application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 53: > 51: if (singleton == null) { > 52: synchronized (PresetRepositoryFactory.class) { > 53: singleton = create(); Actually, singleton field need also to be `volatile`. see https://shipilev.net/blog/2014/safe-public-construction/ for more info ------------- PR: https://git.openjdk.java.net/jmc/pull/282 From ghb at openjdk.java.net Mon Jul 26 12:16:07 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 12:16:07 GMT Subject: RFR: 7362: Reference wrong in agent plug-in.xml [v2] In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 10:16:54 GMT, Marcus Hirt wrote: >> Also cleaning up and making it possible to use the project from within Eclipse. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Getting rid of warnings Looks good to me . ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/283 From hirt at openjdk.java.net Mon Jul 26 13:51:07 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 13:51:07 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v2] In-Reply-To: <1_8XOTa-J8tvjHjRJbMxToBNhpj3g0P5M7CzeKBlJLI=.cd3437a5-99d6-403c-940c-100b5bd3ca93@github.com> References: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> <1_8XOTa-J8tvjHjRJbMxToBNhpj3g0P5M7CzeKBlJLI=.cd3437a5-99d6-403c-940c-100b5bd3ca93@github.com> Message-ID: On Mon, 26 Jul 2021 10:21:33 GMT, Jean-Philippe Bempel wrote: >> Guru Hb has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixing formatting error > > application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 53: > >> 51: if (singleton == null) { >> 52: synchronized (PresetRepositoryFactory.class) { >> 53: singleton = create(); > > Actually, singleton field need also to be `volatile`. > see https://shipilev.net/blog/2014/safe-public-construction/ for more info Indeed. I haven't checked, but couldn't all this be avoided by simply creating the singleton at the field declaration - does it really have to be lazily created? ------------- PR: https://git.openjdk.java.net/jmc/pull/282 From hirt at openjdk.java.net Mon Jul 26 13:53:10 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 13:53:10 GMT Subject: RFR: 7362: Reference wrong in agent plug-in.xml [v2] In-Reply-To: References: Message-ID: <8S06y62XOMURM-88m2tBFI5oTxWcVQzg6O43W_AVffk=.05f91cce-25ba-463a-9881-89e10c076e83@github.com> On Mon, 26 Jul 2021 10:16:54 GMT, Marcus Hirt wrote: >> Also cleaning up and making it possible to use the project from within Eclipse. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Getting rid of warnings Adding a second reviewer since we're in ramp down 2. ------------- PR: https://git.openjdk.java.net/jmc/pull/283 From ghb at openjdk.java.net Mon Jul 26 14:03:30 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 14:03:30 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v3] In-Reply-To: References: Message-ID: > Trivial Fortify warning fix Guru Hb has updated the pull request incrementally with one additional commit since the last revision: fixing LI_LAZY_INIT_STATIC with volatile ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/282/files - new: https://git.openjdk.java.net/jmc/pull/282/files/c9488a1d..2620d3c7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=282&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=282&range=01-02 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/282.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/282/head:pull/282 PR: https://git.openjdk.java.net/jmc/pull/282 From aptmac at openjdk.java.net Mon Jul 26 14:17:08 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 26 Jul 2021 14:17:08 GMT Subject: RFR: 7362: Reference wrong in agent plug-in.xml [v2] In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 10:16:54 GMT, Marcus Hirt wrote: >> Also cleaning up and making it possible to use the project from within Eclipse. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Getting rid of warnings Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/283 From ghb at openjdk.java.net Mon Jul 26 14:22:12 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 14:22:12 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v2] In-Reply-To: References: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> <1_8XOTa-J8tvjHjRJbMxToBNhpj3g0P5M7CzeKBlJLI=.cd3437a5-99d6-403c-940c-100b5bd3ca93@github.com> Message-ID: On Mon, 26 Jul 2021 13:48:12 GMT, Marcus Hirt wrote: >> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 53: >> >>> 51: if (singleton == null) { >>> 52: synchronized (PresetRepositoryFactory.class) { >>> 53: singleton = create(); >> >> Actually, singleton field need also to be `volatile`. >> see https://shipilev.net/blog/2014/safe-public-construction/ for more info > > Indeed. I haven't checked, but couldn't all this be avoided by simply creating the singleton at the field declaration - does it really have to be lazily created? We could have created a Singleton in field declaration if below points were true : 1. If we had only "PresetRepository" as a main class with Singleton (Currently this is a factory). 2. Likelihood of "PresetRepository" object required all the time of JMC's lifecycle . + "- does it really have to be lazily created?" 3. Singleton Object + init (PresetRepository.addLocalPresetTo(...) ) is doing a File Operation. ------------- PR: https://git.openjdk.java.net/jmc/pull/282 From ghb at openjdk.java.net Mon Jul 26 14:22:12 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 14:22:12 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v2] In-Reply-To: References: <9l7ZoxEN8ywYx14UGKMeqAX6e7ecpx_-WxiGbNhfHT4=.8b4ce6cd-603e-4e2f-90e7-0b73b3d2ed53@github.com> <1_8XOTa-J8tvjHjRJbMxToBNhpj3g0P5M7CzeKBlJLI=.cd3437a5-99d6-403c-940c-100b5bd3ca93@github.com> Message-ID: On Mon, 26 Jul 2021 14:16:39 GMT, Guru Hb wrote: >> Indeed. I haven't checked, but couldn't all this be avoided by simply creating the singleton at the field declaration - does it really have to be lazily created? > > We could have created a Singleton in field declaration if below points were true : > 1. If we had only "PresetRepository" as a main class with Singleton (Currently this is a factory). > 2. Likelihood of "PresetRepository" object required all the time of JMC's lifecycle . > + "- does it really have to be lazily created?" > 3. Singleton Object + init (PresetRepository.addLocalPresetTo(...) ) is doing a File Operation. > Actually, singleton field need also to be `volatile`. > see https://shipilev.net/blog/2014/safe-public-construction/ for more info Thanks @jpbempel that was an informative article and added `volatile` to the field declaration, with this neither Fortify nor apptest complained. ------------- PR: https://git.openjdk.java.net/jmc/pull/282 From hirt at openjdk.java.net Mon Jul 26 14:23:06 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 14:23:06 GMT Subject: Integrated: 7362: Reference wrong in agent plug-in.xml In-Reply-To: References: Message-ID: <8EKl1VM7llaisrg1UjXpjF5jX31DMdNDC3K_goTGUb4=.bb7a2b46-f411-49a6-b407-4986d1c2f2c2@github.com> On Mon, 26 Jul 2021 10:00:01 GMT, Marcus Hirt wrote: > Also cleaning up and making it possible to use the project from within Eclipse. This pull request has now been integrated. Changeset: 4b492a42 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/4b492a429393642bc87a0865d46a14093bf47aca Stats: 109 lines in 15 files changed: 58 ins; 47 del; 4 mod 7362: Reference wrong in agent plug-in.xml Reviewed-by: ghb, aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/283 From jpbempel at openjdk.java.net Mon Jul 26 14:29:06 2021 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Mon, 26 Jul 2021 14:29:06 GMT Subject: RFR: 7357: Double-Checked Locking in Agent Plugin code [v3] In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 14:03:30 GMT, Guru Hb wrote: >> Trivial Fortify warning fix > > Guru Hb has updated the pull request incrementally with one additional commit since the last revision: > > fixing LI_LAZY_INIT_STATIC with volatile Marked as reviewed by jpbempel (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/282 From hirt at openjdk.java.net Mon Jul 26 14:52:26 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 14:52:26 GMT Subject: RFR: 7358: Rename Agent Plug-in in the JVM Browser Message-ID: See the issue for more information. ------------- Commit messages: - 7358: Rename Agent Plug-in in the JVM Browser Changes: https://git.openjdk.java.net/jmc/pull/284/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=284&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7358 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/284.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/284/head:pull/284 PR: https://git.openjdk.java.net/jmc/pull/284 From ghb at openjdk.java.net Mon Jul 26 15:13:02 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 15:13:02 GMT Subject: RFR: 7358: Rename Agent Plug-in in the JVM Browser In-Reply-To: References: Message-ID: <-DLkosO-4A7S-w5Y2nNBYtE6LdjLsrQm3fh3fJcd2LY=.32245111-47ca-4ff0-b237-87ffc2957712@github.com> On Mon, 26 Jul 2021 14:48:06 GMT, Marcus Hirt wrote: > See the issue for more information. Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/284 From aptmac at openjdk.java.net Mon Jul 26 15:23:06 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 26 Jul 2021 15:23:06 GMT Subject: RFR: 7358: Rename Agent Plug-in in the JVM Browser In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 14:48:06 GMT, Marcus Hirt wrote: > See the issue for more information. Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/284 From hirt at openjdk.java.net Mon Jul 26 15:26:07 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 15:26:07 GMT Subject: Integrated: 7358: Rename Agent Plug-in in the JVM Browser In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 14:48:06 GMT, Marcus Hirt wrote: > See the issue for more information. This pull request has now been integrated. Changeset: ef886f3a Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/ef886f3a84e212d28543354ca1bfa2c8b7c5467f Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod 7358: Rename Agent Plug-in in the JVM Browser Reviewed-by: ghb, aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/284 From hirt at openjdk.java.net Mon Jul 26 18:58:52 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 18:58:52 GMT Subject: RFR: 6817: AutoBoxing rule can crash due to null dereference Message-ID: Hypothetical solution to hypothetical problem. ------------- Commit messages: - 6817: AutoBoxing rule can crash due to null dereference Changes: https://git.openjdk.java.net/jmc/pull/286/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=286&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6817 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/286.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/286/head:pull/286 PR: https://git.openjdk.java.net/jmc/pull/286 From ghb at openjdk.java.net Mon Jul 26 19:05:32 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Mon, 26 Jul 2021 19:05:32 GMT Subject: RFR: 6817: AutoBoxing rule can crash due to null dereference In-Reply-To: References: Message-ID: <4zqGSlQ8AhzjzIL-EDJUbEHXBDfdikgwI-kMABhInVU=.c850ac11-977d-4932-92ee-8dad173ddb09@github.com> On Mon, 26 Jul 2021 18:54:30 GMT, Marcus Hirt wrote: > Hypothetical solution to hypothetical problem. Looks good to me ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/286 From hirt at openjdk.java.net Mon Jul 26 19:43:38 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 26 Jul 2021 19:43:38 GMT Subject: Integrated: 6817: AutoBoxing rule can crash due to null dereference In-Reply-To: References: Message-ID: On Mon, 26 Jul 2021 18:54:30 GMT, Marcus Hirt wrote: > Hypothetical solution to hypothetical problem. This pull request has now been integrated. Changeset: fb71a220 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/fb71a220f82ec79c1dc9c9d3f53e233a0396363a Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 6817: AutoBoxing rule can crash due to null dereference Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/286 From schaturvedi at openjdk.java.net Tue Jul 27 14:37:52 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Tue, 27 Jul 2021 14:37:52 GMT Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to produce results for Class Leak Rule. [v2] In-Reply-To: References: Message-ID: <8MN9KvyumUkhdcxel1wQHcDioJF3WNyuPqWHxjLgkeA=.f38fc47e-2e64-45cd-adfd-22bcadef6b71@github.com> > This PR addresses the optimization of Class Leak Rule. > > Please refer the JBS for the sample JFR which was taking ~90 minutes to generate results for Class Leak Rule. After the optimization time is reduced to ~10-15 minutes. > > Please review the change and let me the know if there are any comments / suggestions. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Calculation maximum timeout is set via preference and hardcoding removed. ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/248/files - new: https://git.openjdk.java.net/jmc/pull/248/files/2a6aba8a..899e9a8b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=248&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=248&range=00-01 Stats: 21 lines in 4 files changed: 13 ins; 1 del; 7 mod Patch: https://git.openjdk.java.net/jmc/pull/248.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/248/head:pull/248 PR: https://git.openjdk.java.net/jmc/pull/248 From schaturvedi at openjdk.java.net Tue Jul 27 14:37:52 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Tue, 27 Jul 2021 14:37:52 GMT Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to produce results for Class Leak Rule. [v2] In-Reply-To: <7zGD3A_Ulqn6GYA3bWhAFt3t7SPlXvAdTBbw2HOgtA0=.94e1faec-7dda-456e-8ed5-af8ea2fe7164@github.com> References: <7zGD3A_Ulqn6GYA3bWhAFt3t7SPlXvAdTBbw2HOgtA0=.94e1faec-7dda-456e-8ed5-af8ea2fe7164@github.com> Message-ID: On Wed, 21 Jul 2021 17:26:55 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 134: >> >>> 132: } >>> 133: // Higher timeout value added for worst case >>> 134: exec.awaitTermination(1, TimeUnit.HOURS); >> >> It may be worth to make this value configurable. IE let hte use know that how long it will allow for the background job to run. >> >> Also, it may be worthy to actually enforce the shutdown once this delay is over. IE soemthing like that >> >> >> try { >> // allow for budget (default 1h) to process the aggregates >> if(!exec.awaitTermination(delay, delayUnit)) { >> exec.shutdownNow(); >> // last grace period >> if (!pool.awaitTermination(1, TimeUnit.MINUTES)) { >> // report an issue with the pool >> } >> } >> } catch (InterruptedException e) { >> Thread.currentThread().interrupt(); >> } >> >> >> Also I think this code could moved in the same scope as the shutdown call. > > Agreed, let's add a preference. Also, the comment is not aligned with the implementation, seems it's set to 1 minute, not 1 hour. @thegreystone Removed the hard-coding and added it as part of preferences. Please approve the changes if you feel its good to go now. ------------- PR: https://git.openjdk.java.net/jmc/pull/248 From jmatsuoka at openjdk.java.net Tue Jul 27 14:41:54 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Tue, 27 Jul 2021 14:41:54 GMT Subject: RFR: 7366: Object contributions Message-ID: <87aKBhMbnWSB-AwSSjhR1WzbkbTJ37mrq_XadOd0-xg=.821c52a4-82b7-4133-bc91-eb30c66e0244@github.com> This PR addresses JMC-7366, adding Object Contributions for method types in JMC. This allows users to right click on a method in the UI and create an agent plugin probe template for that method, simplifying the user experience a bit. ------------- Commit messages: - Cleanup - Removing old comment - 7366: Object Contribution to Methods Changes: https://git.openjdk.java.net/jmc/pull/288/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=288&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7366 Stats: 308 lines in 6 files changed: 308 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/288.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/288/head:pull/288 PR: https://git.openjdk.java.net/jmc/pull/288 From hirt at openjdk.java.net Tue Jul 27 20:33:44 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 27 Jul 2021 20:33:44 GMT Subject: RFR: 7349: JFR Parser struct types hashcode is not stable In-Reply-To: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> References: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> Message-ID: On Tue, 27 Jul 2021 11:45:53 GMT, Jaroslav Bachorik wrote: > 7349: JFR Parser struct types hashcode is not stable Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/287 From jbachorik at openjdk.java.net Tue Jul 27 20:33:44 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 27 Jul 2021 20:33:44 GMT Subject: RFR: 7349: JFR Parser struct types hashcode is not stable Message-ID: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> 7349: JFR Parser struct types hashcode is not stable ------------- Commit messages: - JMC-7349: JFR Parser struct types hashcode is not stable Changes: https://git.openjdk.java.net/jmc/pull/287/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=287&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7349 Stats: 26 lines in 1 file changed: 25 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/287.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/287/head:pull/287 PR: https://git.openjdk.java.net/jmc/pull/287 From ghb at openjdk.java.net Tue Jul 27 20:33:44 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Tue, 27 Jul 2021 20:33:44 GMT Subject: RFR: 7349: JFR Parser struct types hashcode is not stable In-Reply-To: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> References: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> Message-ID: <99oU0CpvySwH2GN1DfwLozida22JF4eseKM6dWUW1f8=.c06f8636-8cc9-4d11-9423-2449a8c2899d@github.com> On Tue, 27 Jul 2021 11:45:53 GMT, Jaroslav Bachorik wrote: > 7349: JFR Parser struct types hashcode is not stable @jbachorik remove first 4 character of the title msg "7349: JFR Parser struct types hashcode is not stable" to resolve jcheck failure ------------- PR: https://git.openjdk.java.net/jmc/pull/287 From hirt at openjdk.java.net Tue Jul 27 20:36:32 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 27 Jul 2021 20:36:32 GMT Subject: RFR: 7366: Object contributions In-Reply-To: <87aKBhMbnWSB-AwSSjhR1WzbkbTJ37mrq_XadOd0-xg=.821c52a4-82b7-4133-bc91-eb30c66e0244@github.com> References: <87aKBhMbnWSB-AwSSjhR1WzbkbTJ37mrq_XadOd0-xg=.821c52a4-82b7-4133-bc91-eb30c66e0244@github.com> Message-ID: On Tue, 27 Jul 2021 14:37:03 GMT, Joshua Matsuoka wrote: > This PR addresses JMC-7366, adding Object Contributions for method types in JMC. This allows users to right click on a method in the UI and create an agent plugin probe template for that method, simplifying the user experience a bit. application/org.openjdk.jmc.console.agent/plugin.xml line 99: > 97: > 98: > 99: 1: /* > 2: * Copyright (c) 2021 Oracle and/or its affiliates. All rights reserved. Comma after year. application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/contribution/CreateMethodProbePage.java line 2: > 1: /* > 2: * Copyright (c) 2021 Oracle and/or its affiliates. All rights reserved. Comma. ------------- PR: https://git.openjdk.java.net/jmc/pull/288 From jbachorik at openjdk.java.net Wed Jul 28 09:52:32 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Wed, 28 Jul 2021 09:52:32 GMT Subject: Integrated: 7349: JFR Parser struct types hashcode is not stable In-Reply-To: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> References: <2F6iiobzpR8pPIb7X7GVdOaD37oXQyfi32rgZMQmGEY=.c43c8375-8553-4741-975a-20339be35884@github.com> Message-ID: <9jOjh1hf3RzaAZ0xt16cl-f1xqERri7KgceY1udHHoo=.3a150108-d443-4d83-a8c7-5f9a308fa819@github.com> On Tue, 27 Jul 2021 11:45:53 GMT, Jaroslav Bachorik wrote: > 7349: JFR Parser struct types hashcode is not stable This pull request has now been integrated. Changeset: bba7e411 Author: Jaroslav Bachorik Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/bba7e411c8e65f94d2e4e74a056372a9a98554c6 Stats: 26 lines in 1 file changed: 25 ins; 0 del; 1 mod 7349: JFR Parser struct types hashcode is not stable Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/287 From ghb at openjdk.java.net Wed Jul 28 10:31:40 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Wed, 28 Jul 2021 10:31:40 GMT Subject: RFR: 7348: JMC preference options are duplicated Message-ID: "General" , "Appearance" and "Keys" had duplicate entry . This was due to some in consistence "org.eclipse.ui.*" Components were used (one with older + latest version which is causing duplicate entry). Solution : Restricted the Eclipse UI components to v3.2.0 and less than equal to 4.0.0. ------------- Commit messages: - Updated Copyright header - 7348: JMC preference options are duplicated Changes: https://git.openjdk.java.net/jmc/pull/289/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=289&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7348 Stats: 46 lines in 2 files changed: 40 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/289.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/289/head:pull/289 PR: https://git.openjdk.java.net/jmc/pull/289 From ghb at openjdk.java.net Wed Jul 28 10:52:53 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Wed, 28 Jul 2021 10:52:53 GMT Subject: RFR: 7348: JMC preference options are duplicated [v2] In-Reply-To: References: Message-ID: > "General" , "Appearance" and "Keys" had duplicate entry . This was due to some in consistence "org.eclipse.ui.*" Components were used (one with older + latest version which is causing duplicate entry). > > Solution : adding "resolution:=optional" resolves the duplicate entry. ~~Restricted the Eclipse UI components to v3.2.0 and less than equal to 4.0.0.~~ Guru Hb has updated the pull request incrementally with one additional commit since the last revision: Removing required-bundle which is redundent ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/289/files - new: https://git.openjdk.java.net/jmc/pull/289/files/44bfb25e..ffb3ebc1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=289&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=289&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/289.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/289/head:pull/289 PR: https://git.openjdk.java.net/jmc/pull/289 From hirt at openjdk.java.net Wed Jul 28 10:57:36 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 28 Jul 2021 10:57:36 GMT Subject: RFR: 7348: JMC preference options are duplicated [v2] In-Reply-To: References: Message-ID: On Wed, 28 Jul 2021 10:52:53 GMT, Guru Hb wrote: >> "General" , "Appearance" and "Keys" had duplicate entry . This was due to some in consistence "org.eclipse.ui.*" Components were used (one with older + latest version which is causing duplicate entry). >> >> Solution : adding "resolution:=optional" resolves the duplicate entry. ~~Restricted the Eclipse UI components to v3.2.0 and less than equal to 4.0.0.~~ > > Guru Hb has updated the pull request incrementally with one additional commit since the last revision: > > Removing required-bundle which is redundent application/org.openjdk.jmc.feature.console.agent/feature.xml line 3: > 1: > 2: