RFR: 4792: Stop using System.out/err.println and e.printStackTrace [v2]

[Marcus Hirt]

On Mon, 5 Jul 2021 10:23:13 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> replaced by java.util.logging logging
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spotless

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java line 113:

> 111: 				} catch (IOException e) {
> 112: 					// FIXME: Better exception handling
> 113: 					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);

"Failed to load local template from file"?

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java line 116:

> 114: 				} catch (ParseException e) {
> 115: 					// FIXME: Better exception handling
> 116: 					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);

"Failed to parse local template from file " + file...

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 240:

> 238: 							VolatileStorageDelegate.getOnServerDelegate()));
> 239: 				} catch (ParseException e) {
> 240: 					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 242:

> 240: 					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);
> 241: 				} catch (IOException e) {
> 242: 					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java line 246:

> 244: 			}
> 245: 		} catch (FlightRecorderException e) {
> 246: 			ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java line 383:

> 381: 				getSite().getPage().showView(CONTENT_OUTLINE_VIEW_ID, null, IWorkbenchPage.VIEW_VISIBLE);
> 382: 			} catch (PartInitException e) {
> 383: 				FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java line 1106:

> 1104: 						setPageComplete(isPageComplete());
> 1105: 					} catch (Exception e) {
> 1106: 						LOGGER.log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java line 165:

> 163: 					buildHistogram();
> 164: 				} catch (Exception e) {
> 165: 					LOGGER.log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java line 182:

> 180: 				buildHistogram();
> 181: 			} catch (Exception e) {
> 182: 				LOGGER.log(Level.SEVERE, "", e);

Add helpful message?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/preferences/RulesPage.java line 211:

> 209: 			getPreferenceStore().setValue(IGNORED_RULES, ignoredState.toString());
> 210: 		} catch (IOException e) {
> 211: 			FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e);

Add helpful message?

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/util/ChunkReader.java line 122:

> 120: 				} catch (IOException e) {
> 121: 					// Shouldn't happen.
> 122: 					LOGGER.log(Level.SEVERE, "", e);

Add helpful message?

-------------

PR: https://git.openjdk.java.net/jmc/pull/272