RFR: 6204: Flight recorder launcher tab bugs out [v5]

[Miroslav Wengner]

On Fri, 25 Jun 2021 16:12:48 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like:
> 
> ![2021-06-25-115040_1173x738_scrot](https://user-images.githubusercontent.com/10425301/123451350-945a4580-d5ab-11eb-8b15-0d349926fccc.png)
> 
> Steps:
> 
> 1. Run as JMC-Eclipse IDE
> 2. Import a project
> 3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder"
> 4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.."
> 5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top
> 
> At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice.
> 
> However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222
> 
> Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this line looks to fix it.
> 
> Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working:
> ![ezgif-2-1ce1066b3b31](https://user-images.githubusercontent.com/10425301/123454466-983b9700-d5ae-11eb-91d0-a66f5d0d8a9b.gif)

this behavior is caused by wrong schema version (1.0) which comes from JfrLaunchModel, I've changed it now to JDK_11. which should allows at least more JDKs. issue is again Oracle JDK. Trying to figure out how to update properly the configuration. I need to find a way how to override the schema configuration when the RecordingWizard is open. Currently all works when you just configure JFR and push Apply for Oracle JDK 1.8

![image](https://user-images.githubusercontent.com/1956942/124787062-8364e900-df48-11eb-8efc-e22073b7bd1c.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/265