RFR: JMC-7338: Add parser support for frame types generated by async-profiler

Jean-Philippe Bempel jpbempel at openjdk.java.net
Fri Jul 9 13:25:53 UTC 2021


On Fri, 9 Jul 2021 09:50:52 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

> Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel).
> It is adding three new frame types for this reason:
> 
> - Native (C)
> - C++
> - Kernel
>  
> 
> Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java line 3:

> 1: /*
> 2:  * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2021, Datadog, Inc. All rights reserved.

I think the Datadog copyright can only added for entire new file.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/ParserToolkit.java line 3:

> 1: /*
> 2:  * Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2021, Datadog, Inc. All rights reserved.

same as above

-------------

PR: https://git.openjdk.java.net/jmc/pull/274


More information about the jmc-dev mailing list