RFR: 7122: Rules evaluation never complete

Marcus Hirt hirt at openjdk.java.net
Thu Jul 29 17:49:30 UTC 2021


On Thu, 29 Jul 2021 16:22:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Looks good to me. What’s the thread sleep doing there though?
>
>> Looks good to me. What’s the thread sleep doing there though?
> 
> I'm thinking it was there to reduce the frequency of looping to see if the result had resolved by then. FWIW the sleep has been there since JMC was open sourced: https://github.com/openjdk/jmc/blame/65187e9448cf9b8ed9b629295965fd8db63262f6/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/RuleManager.java#L121

@aptmac - gogogo. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/291


More information about the jmc-dev mailing list