RFR: 7262: Add rule for when the JVM version is < OpenJDK 8u302

[Brice Dutheil]

On Tue, 1 Jun 2021 11:49:06 GMT, Oskar Jung <github.com+1101441+ojung at openjdk.org> wrote:

> Still known issues:
> * OpenJDK and Oracle JDK are treated equally
> 
> This PR contains a rule for notifying users of JVM < OpenJDK8u302 to upgrade to avoid performance issues caused by https://bugs.openjdk.java.net/browse/JDK-8266723.
> 
> JFR recorded on OpenJDK 8u302 EA:
> ![Screen Shot 2021-06-02 at 14 45 46](https://user-images.githubusercontent.com/1101441/120482697-a9c7bf80-c3b1-11eb-83e0-7d17b23cfd99.png)

Some nitpicks, but it seems good!

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersion.java line 168:

> 166: 				return thisNumber > otherNumber;
> 167: 			}
> 168: 		}

It would be nice to avoid code duplication with the above method `isGreaterOrEqualThan`

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 292:

> 290: JfrPeriodicEventsFixRule_NO_JVM_VERSION_EVENTS_TEXT=There were no VM information events with JVM version information recorded. Please turn on JVM information events to use this rule.
> 291: JfrPeriodicEventsFixRule_UNSUPPORTED_TEXT_WARN_SHORT=The version of OpenJDK 8 you are running is lacking an important performance fix.
> 292: JfrPeriodicEventsFixRule_UNSUPPORTED_TEXT_WARN_LONG=The version of OpenJDK 8 you are running is lacking an important performance fix. Upgrading to version 8u302 or later can, in some cases, improve your performance quite radically. See JDK-8266723 for more information. An alternative can be to disable any periodic events not needed, such as the NativeExecutionSample event.

Is it possible to embed http link ?

It would be nice to be able to click directly on the bug id [JDK-8266723](https://bugs.openjdk.java.net/browse/JDK-8266723) to get more details.

-------------

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jmc/pull/256