RFR: 7260: Create a new serializers bundle
Henrik Dafgård
hdafgard at openjdk.java.net
Wed Jun 2 16:12:31 UTC 2021
On Fri, 28 May 2021 00:22:06 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> This creates a new core bundle that can be used to serialize data from JFR into various popular formats, such as DOT and JSON.
Minor nits.
core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 3:
> 1: /*
> 2: * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
> 3: * Copyright (c) 2020, 2021, sDatadog, Inc. All rights reserved.
Suggestion:
* Copyright (c) 2020, 2021, Datadog, Inc. All rights reserved.
core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 195:
> 193: }
> 194: if (eventCountsByType.size() > MAX_TYPES_IN_ROOT_TITLE) {
> 195: title.append(Messages.getFormattedMessage(FLAMEGRAPH_SELECT_HTML_MORE)); // $NON-NLS-1$
Suggestion:
title.append(Messages.getFormattedMessage(FLAMEGRAPH_SELECT_HTML_MORE));
-------------
Marked as reviewed by hdafgard (Reviewer).
PR: https://git.openjdk.java.net/jmc/pull/254
More information about the jmc-dev
mailing list