RFR: 7262: Add rule for when the JVM version is < OpenJDK 8u302 [v5]

[Henrik Dafgård]

On Wed, 2 Jun 2021 16:23:08 GMT, Oskar Jung <github.com+1101441+ojung at openjdk.org> wrote:

>> This PR contains a rule for notifying users of JVM < OpenJDK8u302 to upgrade to avoid performance issues caused by https://bugs.openjdk.java.net/browse/JDK-8266723.
>> 
>> **JFR recorded on OpenJDK 8u302 EA:**
>> ![Screen Shot 2021-06-02 at 14 45 46](https://user-images.githubusercontent.com/1101441/120482697-a9c7bf80-c3b1-11eb-83e0-7d17b23cfd99.png)
>> 
>> **JFR recorded on OpenJDK 8u292:**
>> ![Screen Shot 2021-06-02 at 15 49 14](https://user-images.githubusercontent.com/1101441/120492943-ce746500-c3ba-11eb-999c-e75bf3fba245.png)
>
> Oskar Jung has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - fixup! 7262: Add rule for when the JVM version is < OpenJDK 8u302
>  - fixup! 7262: Add rule for when the JVM version is < OpenJDK 8u302
>  - 7262: Add rule for when the JVM version is < OpenJDK 8u302
>    
>    Since the test flight recording was created with 8u302 EA, a method
>    `JavaVersion.isGreaterOrEqualThanDisregardEa` had to be added to compare
>    java versions disregarding early access status.

Changes requested by hdafgard (Reviewer).

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java line 124:

> 122: 	 * @param vmName
> 123: 	 *            the JVM name to check.
> 124: 	 * @return <code>true</code> if it is a OpenJDK JVM, <code>false</code> if it isn't or if was

Use {@code true} etc instead.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java line 131:

> 129: 			return false;
> 130: 		}
> 131: 		return vmName.startsWith("OpenJDK"); //$NON-NLS-1$ //$NON-NLS-2$;

Only the first non-nls comment is needed here.

-------------

PR: https://git.openjdk.java.net/jmc/pull/256