RFR: 7262: Add rule for when the JVM version is < OpenJDK 8u302 [v5]
Marcus Hirt
hirt at openjdk.java.net
Wed Jun 2 16:25:48 UTC 2021
On Wed, 2 Jun 2021 13:53:18 GMT, Oskar Jung <github.com+1101441+ojung at openjdk.org> wrote:
>> Some nitpicks, but it seems good!
>
> Hey @bric3, thanks for your comments! Unfortunately I didn't notice you already started reviewing. I force-pushed a rewritten commit. The difference is, that I now check if it is an `OpenJDK`. See https://github.com/openjdk/jmc/pull/256/files#diff-d03e56fffa9483fb8054f457e45a52a76c057012d19c9d68ec88926db8a0624fR83-R85
@ojung - there is no need to force push new editions of the branch. You can have one gazillion commits in the PR; In the end Skara will squish them into one commit when integrating anyways. :)
-------------
PR: https://git.openjdk.java.net/jmc/pull/256
More information about the jmc-dev
mailing list