RFR: 7260: Create a new serializers bundle [v3]

[Marcus Hirt]

On Wed, 2 Jun 2021 16:20:00 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding dependency on jfr
>
> core/org.openjdk.jmc.flightrecorder.serializers/META-INF/MANIFEST.MF line 12:
> 
>> 10:  org.openjdk.jmc.flightrecorder.serializers.dot
>> 11: Automatic-Module-Name: org.openjdk.jmc.flightrecorder.serializers
>> 12: Require-Bundle: org.lz4.lz4-java
> 
> Looks like it could use `org.openjdk.jmc.flightrecorder` in the require-bundle list? Otherwise when trying to use the Flamegraph or Graphview I end up with lots of exceptions such as:
> 
> 
> Exception in thread "FlameGraphModelCalculation-0" java.lang.NoClassDefFoundError: org/openjdk/jmc/flightrecorder/stacktrace/tree/StacktraceTreeModel
> 	at org.openjdk.jmc.flightrecorder.serializers.json.FlameGraphJsonSerializer.toJson(FlameGraphJsonSerializer.java:89)
> 	at org.openjdk.jmc.flightrecorder.flameview.views.FlameGraphView$ModelRebuildRunnable.run(FlameGraphView.java:305)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> 	at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: java.lang.ClassNotFoundException: org.openjdk.jmc.flightrecorder.stacktrace.tree.StacktraceTreeModel cannot be found by org.openjdk.jmc.flightrecorder.serializers_8.1.0.qualifier
> 	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:519)
> 	at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:171)
> 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
> 	... 5 more

Nice catch! Thanks @aptmac. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/254