RFR: 7167: Agent Plugin [v6]

[Joshua Matsuoka]

On Thu, 27 May 2021 09:20:27 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix rcp feature to use new agent plugin name
>
> application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlPartitionScanner.java line 44:
> 
>> 42: public class XmlPartitionScanner extends RuleBasedPartitionScanner {
>> 43: 	public final static String XML_COMMENT = "__xml_comment";
>> 44: 	public final static String XML_TAG = "__xml_tag";
> 
> SHouldn't those be commented by `//$NON-NLS-1$`

Fixed, thanks

> configuration/spotbugs/spotbugs-exclude.xml line 85:
> 
>> 83: 		<Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
>> 84: 	</Match>
>> 85: 	
> 
> Tabulation instead of spaces in this file

Fixed, thanks

-------------

PR: https://git.openjdk.java.net/jmc/pull/226