RFR: 7272: Method profiling page should show the frame type

[Marcus Hirt]

On Thu, 17 Jun 2021 20:55:14 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Bot feels I am not talking enough (⚠️ The pull request body must not be empty). This line of text fixes Sad Bot.
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/internal/MethodWithFrameTypeLabelProvider.java line 144:
> 
>> 142: 			return ((IDisplayable) key).displayUsing(IDisplayable.VERBOSE);
>> 143: 		}
>> 144: 		return key.toString();
> 
> When giving this a try I'm finding that the key object is a `MethodWithFrameType`, and as such it doesn't get formatted into any human readable way.
> 
> ![2021-06-17-151839_1916x1036_scrot](https://user-images.githubusercontent.com/10425301/122470248-d40da580-cf8b-11eb-8286-a3855edf00d7.png)

> Is the design of these icons standardized, and is there a place to find out in jmc what they mean? Should this information be added to the tooltip perhaps? Otherwise I added a couple of comments inline, other than those I think it looks good.

Yeah, it's the same geometric figures as Eclipse is using. ;)

> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java line 139:
> 
>> 137: 				}
>> 138: 			});
>> 139: 
> 
> Mainly out of curiosity, but I noticed that there are still extra lines scattered through this file, but I couldn't figure out a pattern. Is there a purpose behind the lines removed here and the ones that still remain?

Well, some of them seemed to _maybe_ indicate some sort of grouping so I left them. I should probably just remove them all. ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/267