RFR: 6204: Flight recorder launcher tab bugs out [v2]

[Alex Macdonald]

On Fri, 11 Jun 2021 22:43:09 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> Adding check box to the launcher tab to select Oracle JDK < 11.
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6204: added tests

There were a few grammatical errors, and I made a comment wondering if `ConnectionToolkit.isOarcle()` could be of any help in automating the process as I see you've added a `//TODO` to JfrLaunchModel to get information dynamically. If you're adding a TODO here maybe open a JMC bug that can be used to track progress on fixing it.

Is there an easy and reproduce-able way to verify the bug and this fix?

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 54:

> 52: 	private Button enabledCheckbox;
> 53: 	private Button autoOpenCheckbox;
> 54: 	private Button lessThenOracleJDK11Checkbox;

lessThen -> lessThan

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 125:

> 123: 
> 124: 	private void createLessThenOracleJdk11(Composite parent, int cols) {
> 125: 		lessThenOracleJDK11Checkbox = new Button(parent, SWT.CHECK);

Here we're letting the user explicitly toggle this if it's a particular Oracle JDK, could `ConnectionToolkit.isOracle()` help here to automate this?

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/model/JfrArgsBuilder.java line 101:

> 99: 	private final String name;
> 100: 	private final boolean continuous;
> 101: 	private final boolean lessThenOracleJdk11;

lessThen -> lessThan

application/tests/org.openjdk.jmc.ide.launch.test/src/test/java/org/openjdk/jmc/ide/launch/model/JfrArgsBuilderJfrArgsTest.java line 125:

> 123: 
> 124: 	@Test
> 125: 	public void testJfrArgsIfQuotedSpacePathsDefaultSettingsJdkHigherThen11() throws Exception {

HigherThen -> HigherThan

-------------

PR: https://git.openjdk.java.net/jmc/pull/265