RFR: 6204: Flight recorder launcher tab bugs out [v5]

[Alex Macdonald]

On Mon, 21 Jun 2021 20:38:54 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> Adding check box to the launcher tab to select Oracle JDK < 11.
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6204: code clean up

It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like:

![2021-06-25-115040_1173x738_scrot](https://user-images.githubusercontent.com/10425301/123451350-945a4580-d5ab-11eb-8b15-0d349926fccc.png)

Steps:
1. Run as JMC-Eclipse IDE
2. 2.Import a project
3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder"
4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.."
5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top

At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice.

However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222

Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this layout looks to fix it.

Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working:
![ezgif-2-1ce1066b3b31](https://user-images.githubusercontent.com/10425301/123454466-983b9700-d5ae-11eb-91d0-a66f5d0d8a9b.gif)

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 74:

> 72: 		createEnabled(comp, cols);
> 73: 		createOpenAutomatically(comp, cols);
> 74: 		createLessThenOracleJdk11(comp, cols);

"lessThen" -> "lessThan"

application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java line 122:

> 120: 	}
> 121: 
> 122: 	private void createLessThenOracleJdk11(Composite parent, int cols) {

"lessThen" -> "lessThan"

-------------

PR: https://git.openjdk.java.net/jmc/pull/265