RFR: 7167: Agent Plugin [v11]

[Brice Dutheil]

On Tue, 22 Jun 2021 22:10:08 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Decorating outputstreamWriter with a bufferedWriter

Yes it looks good to me.

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/editor/AgentEditorUi.java line 191:

> 189: 				DialogToolkit.showWarning(window.getShell(), Messages.AgentEditorUI_MESSAGE_EMPTY_PRESET_TITLE,
> 190: 						Messages.AgentEditorUI_MESSAGE_EMPTY_PRESET);
> 191: 			}

��

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/wizards/StartAgentWizard.java line 66:

> 64: 		startAgentWizardPage = new StartAgentWizardPage(helper);
> 65: 		this.setHelpAvailable(false);
> 66: 		WizardDialog.setDialogHelpAvailable(false);

��

-------------

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jmc/pull/226