RFR: 6204: Flight recorder launcher tab bugs out [v5]
Miroslav Wengner
mwengner at openjdk.java.net
Sat Jun 26 20:43:00 UTC 2021
On Fri, 25 Jun 2021 16:12:48 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 6204: code clean up
>
> It took me longer to figure out how to get to this page than I had originally thought. For anyone else curious, here's what it looks like:
>
> 
>
> Steps:
> 1. Run as JMC-Eclipse IDE
> 2. Import a project
> 3. Highlight project in the package explorer and select "Run as" -> "Run as Java Application with Flight Recorder"
> 4. Go back to the context menu under the package explorer, but this time go "Run as" -> "Run Configurations.."
> 5. Find the Launcher under "Java Application", then use the "Flight Recorder" tab at the top
>
> At first observation, compared to master these changes allow for the "Run as Java Application with Flight Recorder" to be used, otherwise I was experiencing and error trying to enable flight recorder features, so that's nice.
>
> However using this changeset I'm hitting a NPE at RecordingWizardPage line 222: https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java#L222
>
> Running through with the debugger I found that the shell is actually `null`, so this blows up trying to `layout()`. Simply removing this line looks to fix it.
>
> Is this what the bug is? I'm trying to select a template in the template manager but nothing seems to be working:
> 
@aptmac it also doesn't allow you to select a template, even when you have created one in previous recording. This is bug and should be IMHO solved in another ticket, what do you think ?
-------------
PR: https://git.openjdk.java.net/jmc/pull/265
More information about the jmc-dev
mailing list