From jbachorik at openjdk.java.net Mon Mar 1 10:37:51 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 1 Mar 2021 10:37:51 GMT Subject: RFR: JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block Message-ID: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block ------------- Commit messages: - Merge branch 'master' into jb/lazy_type_registration - JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block Changes: https://git.openjdk.java.net/jmc/pull/221/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=221&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7154 Stats: 26 lines in 1 file changed: 24 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/221/head:pull/221 PR: https://git.openjdk.java.net/jmc/pull/221 From jbachorik at openjdk.java.net Mon Mar 1 11:52:49 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 1 Mar 2021 11:52:49 GMT Subject: RFR: JMC-7158: [JFR Writer] Improve single-value types handling Message-ID: JMC-7158: [JFR Writer] Improve single-value types handling ------------- Commit messages: - JMC-7158: [JFR Writer] Improve single-value types handling Changes: https://git.openjdk.java.net/jmc/pull/224/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=224&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7158 Stats: 80 lines in 7 files changed: 44 ins; 13 del; 23 mod Patch: https://git.openjdk.java.net/jmc/pull/224.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/224/head:pull/224 PR: https://git.openjdk.java.net/jmc/pull/224 From jbachorik at openjdk.java.net Mon Mar 1 11:52:55 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 1 Mar 2021 11:52:55 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code Message-ID: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> JMC-7155: [JFR Writer] Complete the annotation handling code ------------- Commit messages: - JMC-7155: [JFR Writer] Complete the annotation handling code Changes: https://git.openjdk.java.net/jmc/pull/222/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=222&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7155 Stats: 534 lines in 19 files changed: 425 ins; 74 del; 35 mod Patch: https://git.openjdk.java.net/jmc/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/222/head:pull/222 PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Mon Mar 1 12:26:45 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 1 Mar 2021 12:26:45 GMT Subject: RFR: JMC-7156: [JFR Writer] Allow providing extra recording settings Message-ID: JMC-7156: [JFR Writer] Allow providing extra recording settings ------------- Commit messages: - JMC-7156: [JFR Writer] Allow providing extra recording settings Changes: https://git.openjdk.java.net/jmc/pull/223/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=223&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7156 Stats: 251 lines in 7 files changed: 238 ins; 1 del; 12 mod Patch: https://git.openjdk.java.net/jmc/pull/223.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/223/head:pull/223 PR: https://git.openjdk.java.net/jmc/pull/223 From hirt at openjdk.java.net Mon Mar 1 14:38:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 1 Mar 2021 14:38:40 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v4] In-Reply-To: References: Message-ID: On Fri, 26 Feb 2021 16:35:00 GMT, Jean-Philippe Bempel wrote: >> Add new `IParserStats` interface implemented by `EventCollection`. >> That way, `IItemCollection` is not touched, but you need to cast the >> instance to `IParserStats`. >> Support of old (v0.x) JFR format. >> During parsing, we collect number of events per type, the size, number >> of chunks and version of the file. >> We also track for version 1.x/2.x the number of skipped events. >> `RecordingPrinter` tool class is modified to support a summary verbosity mode >> and `-summary` option to print statistics per event type. > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > Rename JdkTypeIDsPreJdk11 Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Tue Mar 2 10:46:43 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 2 Mar 2021 10:46:43 GMT Subject: Integrated: 6936: Parser should track statistics during parsing In-Reply-To: References: Message-ID: On Tue, 23 Feb 2021 09:24:55 GMT, Jean-Philippe Bempel wrote: > Add new `IParserStats` interface implemented by `EventCollection`. > That way, `IItemCollection` is not touched, but you need to cast the > instance to `IParserStats`. > Support of old (v0.x) JFR format. > During parsing, we collect number of events per type, the size, number > of chunks and version of the file. > We also track for version 1.x/2.x the number of skipped events. > `RecordingPrinter` tool class is modified to support a summary verbosity mode > and `-summary` option to print statistics per event type. This pull request has now been integrated. Changeset: 0c7ae2a0 Author: Jean-Philippe Bempel Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/0c7ae2a0 Stats: 562 lines in 24 files changed: 499 ins; 0 del; 63 mod 6936: Parser should track statistics during parsing Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From jbachorik at openjdk.java.net Tue Mar 2 10:52:37 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 2 Mar 2021 10:52:37 GMT Subject: RFR: JMC-7156: [JFR Writer] Allow providing extra recording settings In-Reply-To: References: Message-ID: On Mon, 1 Mar 2021 11:30:40 GMT, Jaroslav Bachorik wrote: > JMC-7156: [JFR Writer] Allow providing extra recording settings @AlexVanGogen can you, as an active user of this API, take a look at this, plz? ------------- PR: https://git.openjdk.java.net/jmc/pull/223 From jbachorik at openjdk.java.net Tue Mar 2 10:52:39 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 2 Mar 2021 10:52:39 GMT Subject: RFR: JMC-7158: [JFR Writer] Improve single-value types handling In-Reply-To: References: Message-ID: On Mon, 1 Mar 2021 11:49:39 GMT, Jaroslav Bachorik wrote: > JMC-7158: [JFR Writer] Improve single-value types handling @AlexVanGogen can you, as an active user of this API, take a look at this, plz? ------------- PR: https://git.openjdk.java.net/jmc/pull/224 From jbachorik at openjdk.java.net Tue Mar 2 11:04:40 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 2 Mar 2021 11:04:40 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 1 Mar 2021 11:17:39 GMT, Jaroslav Bachorik wrote: > JMC-7155: [JFR Writer] Complete the annotation handling code @AlexVanGogen can you, as an active user of this API, take a look at this, plz? ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Thu Mar 11 10:10:25 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Thu, 11 Mar 2021 10:10:25 GMT Subject: RFR: JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block [v2] In-Reply-To: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> References: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> Message-ID: > JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision: Fix the lazy type registration call for the default 'with-constantpool' case ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/221/files - new: https://git.openjdk.java.net/jmc/pull/221/files/ce67a64f..946214f5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=221&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=221&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/221/head:pull/221 PR: https://git.openjdk.java.net/jmc/pull/221 From jbachorik at openjdk.java.net Thu Mar 11 10:42:26 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Thu, 11 Mar 2021 10:42:26 GMT Subject: RFR: JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block [v3] In-Reply-To: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> References: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> Message-ID: > JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block Jaroslav Bachorik has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Fix the lazy type registration call for the default 'with-constantpool' case ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/221/files - new: https://git.openjdk.java.net/jmc/pull/221/files/946214f5..eaef3b03 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=221&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=221&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/221.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/221/head:pull/221 PR: https://git.openjdk.java.net/jmc/pull/221 From jmatsuoka at openjdk.java.net Thu Mar 11 21:12:15 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Thu, 11 Mar 2021 21:12:15 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions Message-ID: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. [1] https://bugs.openjdk.java.net/browse/JMC-6890 ------------- Commit messages: - 6890: defineEventProbes should throw exception on malformed probe definitions Changes: https://git.openjdk.java.net/jmc/pull/227/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=227&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6890 Stats: 38 lines in 5 files changed: 26 ins; 1 del; 11 mod Patch: https://git.openjdk.java.net/jmc/pull/227.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/227/head:pull/227 PR: https://git.openjdk.java.net/jmc/pull/227 From hirt at openjdk.java.net Fri Mar 12 12:05:04 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 12 Mar 2021 12:05:04 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions In-Reply-To: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> Message-ID: On Thu, 11 Mar 2021 21:06:50 GMT, Joshua Matsuoka wrote: > This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. > > [1] https://bugs.openjdk.java.net/browse/JMC-6890 Don't forget to update the copyright years. ------------- PR: https://git.openjdk.java.net/jmc/pull/227 From hirt at openjdk.java.net Fri Mar 12 12:26:06 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 12 Mar 2021 12:26:06 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions In-Reply-To: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> Message-ID: <4h0s7ExAeGEoUSnWvoH3J2qX4XmXsGO2EfEAOEO_0qs=.2145ea11-e5cf-4f5c-99b9-6affca84bee0@github.com> On Thu, 11 Mar 2021 21:06:50 GMT, Joshua Matsuoka wrote: > This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. > > [1] https://bugs.openjdk.java.net/browse/JMC-6890 agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java line 91: > 89: * if the supplied XML fails to validate. > 90: */ > 91: Set modify(String xmlDescription) throws XMLStreamException; Perhaps have our own exception class (e.g. XmlValidationException)? It shouldn't depend on whatever XML parser methology we're using (StAX vs DOM etc). ------------- PR: https://git.openjdk.java.net/jmc/pull/227 From ghb at openjdk.java.net Fri Mar 12 12:58:07 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 12 Mar 2021 12:58:07 GMT Subject: RFR: 7139: Prepare new and noteworthy for JMC 8.0.0 In-Reply-To: References: Message-ID: On Fri, 26 Feb 2021 22:38:01 GMT, Marcus Hirt wrote: > There is a launcher included to build from within Eclipse. Import the project into Eclipse and run the launcher. Open the generated html page in a browser. Looks good to me Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/220 From hirt at openjdk.java.net Fri Mar 12 14:07:11 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 12 Mar 2021 14:07:11 GMT Subject: Integrated: 7139: Prepare new and noteworthy for JMC 8.0.0 In-Reply-To: References: Message-ID: <1t2TsUduAHaFIR9PqCn1HaLWDAtIOMfBX8yzU7a2A80=.20d74a18-8680-4466-b66a-9fe61d326de2@github.com> On Fri, 26 Feb 2021 22:38:01 GMT, Marcus Hirt wrote: > There is a launcher included to build from within Eclipse. Import the project into Eclipse and run the launcher. Open the generated html page in a browser. This pull request has now been integrated. Changeset: c1937f14 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/c1937f14 Stats: 391 lines in 30 files changed: 391 ins; 0 del; 0 mod 7139: Prepare new and noteworthy for JMC 8.0.0 Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/220 From jmatsuoka at openjdk.java.net Fri Mar 12 16:22:16 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Fri, 12 Mar 2021 16:22:16 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions [v2] In-Reply-To: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> Message-ID: <1-G9dfcckHmeOFBqERmuxBnK3mgXfUDqZYihoWKdvvY=.bdfa87c9-16eb-4557-8939-a30396c1bd4a@github.com> > This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. > > [1] https://bugs.openjdk.java.net/browse/JMC-6890 Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: Update Copyright headers, have XML validation throw its' own exception ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/227/files - new: https://git.openjdk.java.net/jmc/pull/227/files/b563856e..5c6c695a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=227&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=227&range=00-01 Stats: 120 lines in 10 files changed: 70 ins; 3 del; 47 mod Patch: https://git.openjdk.java.net/jmc/pull/227.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/227/head:pull/227 PR: https://git.openjdk.java.net/jmc/pull/227 From jmatsuoka at openjdk.java.net Fri Mar 12 16:22:17 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Fri, 12 Mar 2021 16:22:17 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions [v2] In-Reply-To: <4h0s7ExAeGEoUSnWvoH3J2qX4XmXsGO2EfEAOEO_0qs=.2145ea11-e5cf-4f5c-99b9-6affca84bee0@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> <4h0s7ExAeGEoUSnWvoH3J2qX4XmXsGO2EfEAOEO_0qs=.2145ea11-e5cf-4f5c-99b9-6affca84bee0@github.com> Message-ID: On Fri, 12 Mar 2021 12:22:51 GMT, Marcus Hirt wrote: >> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: >> >> Update Copyright headers, have XML validation throw its' own exception > > agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java line 91: > >> 89: * if the supplied XML fails to validate. >> 90: */ >> 91: Set modify(String xmlDescription) throws XMLStreamException; > > Perhaps have our own exception class (e.g. XmlValidationException)? It shouldn't depend on whatever XML parser methology we're using (StAX vs DOM etc). Makes sense, I've added an XMLValidationException in the most recent commit and have it thrown from validateProbeDefinition ------------- PR: https://git.openjdk.java.net/jmc/pull/227 From github.com+13893590+alexvangogen at openjdk.java.net Mon Mar 15 13:52:05 2021 From: github.com+13893590+alexvangogen at openjdk.java.net (Alexander Kuznetsov) Date: Mon, 15 Mar 2021 13:52:05 GMT Subject: RFR: JMC-7158: [JFR Writer] Improve single-value types handling In-Reply-To: References: Message-ID: On Tue, 2 Mar 2021 10:50:20 GMT, Jaroslav Bachorik wrote: >> JMC-7158: [JFR Writer] Improve single-value types handling > > @AlexVanGogen can you, as an active user of this API, take a look at this, plz? I have no objections ------------- PR: https://git.openjdk.java.net/jmc/pull/224 From github.com+13893590+alexvangogen at openjdk.java.net Mon Mar 15 14:00:09 2021 From: github.com+13893590+alexvangogen at openjdk.java.net (Alexander Kuznetsov) Date: Mon, 15 Mar 2021 14:00:09 GMT Subject: RFR: JMC-7156: [JFR Writer] Allow providing extra recording settings In-Reply-To: References: Message-ID: <2phOgK2U5MoSZadIJJydKncDjxXYhX-QJn9YaHWL7nU=.8b9ccab8-4dbd-4eae-a6f1-dab17f7fa3a3@github.com> On Tue, 2 Mar 2021 10:50:27 GMT, Jaroslav Bachorik wrote: >> JMC-7156: [JFR Writer] Allow providing extra recording settings > > @AlexVanGogen can you, as an active user of this API, take a look at this, plz? Looks good to me! ------------- PR: https://git.openjdk.java.net/jmc/pull/223 From hirt at openjdk.java.net Mon Mar 15 14:14:06 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 14:14:06 GMT Subject: RFR: JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block [v3] In-Reply-To: References: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> Message-ID: On Thu, 11 Mar 2021 10:42:26 GMT, Jaroslav Bachorik wrote: >> JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block > > Jaroslav Bachorik has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/221 From hirt at openjdk.java.net Mon Mar 15 14:16:06 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 14:16:06 GMT Subject: RFR: JMC-7156: [JFR Writer] Allow providing extra recording settings In-Reply-To: References: Message-ID: <_3SIzTlp-5jQqraKSb4-FYs5sWZO6Nj00YY2y9vgD1k=.dc9aef55-1e42-4eb4-ad33-9ab6947b1ef0@github.com> On Mon, 1 Mar 2021 11:30:40 GMT, Jaroslav Bachorik wrote: > JMC-7156: [JFR Writer] Allow providing extra recording settings Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/223 From hirt at openjdk.java.net Mon Mar 15 14:17:10 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 14:17:10 GMT Subject: RFR: JMC-7158: [JFR Writer] Improve single-value types handling In-Reply-To: References: Message-ID: On Mon, 1 Mar 2021 11:49:39 GMT, Jaroslav Bachorik wrote: > JMC-7158: [JFR Writer] Improve single-value types handling Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/224 From hirt at openjdk.java.net Mon Mar 15 14:19:07 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 14:19:07 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 1 Mar 2021 11:17:39 GMT, Jaroslav Bachorik wrote: > JMC-7155: [JFR Writer] Complete the annotation handling code core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/TypedFieldImpl.java line 52: > 50: private final List annotations; > 51: > 52: public TypedFieldImpl(TypeImpl type, String name) { Now that the implementation classes are becoming public, do you wish to move them off to a separate package to signal that people shouldn't rely on them, and that they are not part of the public API? ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Mon Mar 15 15:40:10 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 15 Mar 2021 15:40:10 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 15 Mar 2021 14:16:08 GMT, Marcus Hirt wrote: >> JMC-7155: [JFR Writer] Complete the annotation handling code > > core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/TypedFieldImpl.java line 52: > >> 50: private final List annotations; >> 51: >> 52: public TypedFieldImpl(TypeImpl type, String name) { > > Now that the implementation classes are becoming public, do you wish to move them off to a separate package to signal that people shouldn't rely on them, and that they are not part of the public API? The API classes are in `org.openjdk.jmc.flightrecorder.writer.api` package which is the only one exported. However, if you feel strongly about this I will move the impl classes to `org.openjdk.jmc.flightrecorder.writer.impl` package instead. ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From hirt at openjdk.java.net Mon Mar 15 16:02:16 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 16:02:16 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 1 Mar 2021 11:17:39 GMT, Jaroslav Bachorik wrote: > JMC-7155: [JFR Writer] Complete the annotation handling code Changes requested by hirt (Lead). core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/AnnotationElementBuilderImpl.java line 1: > 1: package org.openjdk.jmc.flightrecorder.writer; Copyright header (Oracle + DD). core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/AnnotatedElementBuilder.java line 1: > 1: package org.openjdk.jmc.flightrecorder.writer.api; Copyright header. core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/AnnotationElementBuilder.java line 1: > 1: package org.openjdk.jmc.flightrecorder.writer.api; Copyright header. ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From hirt at openjdk.java.net Mon Mar 15 16:02:18 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 16:02:18 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 15 Mar 2021 15:37:26 GMT, Jaroslav Bachorik wrote: >> core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/TypedFieldImpl.java line 52: >> >>> 50: private final List annotations; >>> 51: >>> 52: public TypedFieldImpl(TypeImpl type, String name) { >> >> Now that the implementation classes are becoming public, do you wish to move them off to a separate package to signal that people shouldn't rely on them, and that they are not part of the public API? > > The API classes are in `org.openjdk.jmc.flightrecorder.writer.api` package which is the only one exported. > However, if you feel strongly about this I will move the impl classes to `org.openjdk.jmc.flightrecorder.writer.impl` package instead. Personally I think I might have gone with api being in the writer top-level package, and then an impl package, but it's probably not worth the heartache to change that. So, nah don't feel strongly about it. ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Mon Mar 15 16:02:20 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 15 Mar 2021 16:02:20 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 15 Mar 2021 15:56:56 GMT, Marcus Hirt wrote: >> JMC-7155: [JFR Writer] Complete the annotation handling code > > core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/AnnotationElementBuilderImpl.java line 1: > >> 1: package org.openjdk.jmc.flightrecorder.writer; > > Copyright header (Oracle + DD). ?? I really need to set up some templates. Always forgetting about this :( ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Mon Mar 15 16:03:06 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 15 Mar 2021 16:03:06 GMT Subject: Integrated: JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block In-Reply-To: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> References: <-BjhJDKw6eYvoPCjG4_n0h0QjaBGc171971dxpjeFaI=.97b6fb5a-e5b5-4d32-8798-5edbbaf7f138@github.com> Message-ID: <9fBo8b9ob1ktW7PN1J4wcd4G3Y0Ts9h1XH9_cBnUq8c=.fc4c2023-ccee-4c16-b39c-5cdb3391f73b@github.com> On Mon, 1 Mar 2021 10:21:22 GMT, Jaroslav Bachorik wrote: > JMC-7154: [JFR Writer] Improve lazy evaluation of the type defining block This pull request has now been integrated. Changeset: e97d9855 Author: Jaroslav Bachorik Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/e97d9855 Stats: 29 lines in 1 file changed: 25 ins; 1 del; 3 mod 7154: [JFR Writer] Improve lazy evaluation of the type defining block Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/221 From jbachorik at openjdk.java.net Mon Mar 15 17:00:09 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 15 Mar 2021 17:00:09 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 15 Mar 2021 15:56:22 GMT, Marcus Hirt wrote: >> The API classes are in `org.openjdk.jmc.flightrecorder.writer.api` package which is the only one exported. >> However, if you feel strongly about this I will move the impl classes to `org.openjdk.jmc.flightrecorder.writer.impl` package instead. > > Personally I think I might have gone with api being in the writer top-level package, and then an impl package, but it's probably not worth the heartache to change that. So, nah don't feel strongly about it. Ok. You are right, it would have been better in the top package. IDK, I just turned on auto pilot and did the `api` package - I used to put various modular/infra classes into the module package. Probably this approach is not that good any more. But given that the API has been already made public we will have to live with that :( ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Mon Mar 15 17:16:21 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Mon, 15 Mar 2021 17:16:21 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code [v2] In-Reply-To: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: <6jretdUs3lmDoFApfuxh26ZkFeNj3uUId0DlSfaIVmA=.3a94eda7-ce3a-4858-9b10-3bc67e1b896d@github.com> > JMC-7155: [JFR Writer] Complete the annotation handling code Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision: Add copyright ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/222/files - new: https://git.openjdk.java.net/jmc/pull/222/files/a4d9ac00..a7896789 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=222&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=222&range=00-01 Stats: 99 lines in 3 files changed: 99 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/222.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/222/head:pull/222 PR: https://git.openjdk.java.net/jmc/pull/222 From hirt at openjdk.java.net Mon Mar 15 18:09:16 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 15 Mar 2021 18:09:16 GMT Subject: RFR: JMC-7155: [JFR Writer] Complete the annotation handling code [v2] In-Reply-To: <6jretdUs3lmDoFApfuxh26ZkFeNj3uUId0DlSfaIVmA=.3a94eda7-ce3a-4858-9b10-3bc67e1b896d@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> <6jretdUs3lmDoFApfuxh26ZkFeNj3uUId0DlSfaIVmA=.3a94eda7-ce3a-4858-9b10-3bc67e1b896d@github.com> Message-ID: <9D45fzdpE3oSi_rOfQHiwTBY99gdYlTpMsroZo1OHAM=.abb6a8c6-2c20-4e5f-ae6d-71d625dbf513@github.com> On Mon, 15 Mar 2021 17:16:21 GMT, Jaroslav Bachorik wrote: >> JMC-7155: [JFR Writer] Complete the annotation handling code > > Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision: > > Add copyright Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Tue Mar 16 09:53:08 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 16 Mar 2021 09:53:08 GMT Subject: Integrated: JMC-7155: [JFR Writer] Complete the annotation handling code In-Reply-To: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> References: <-0vQidGQdkOedBE2p4uKHpb_rxPP5OT4XtvWDI1E-jo=.8917f933-3ed9-4bd1-86d0-03e2c74b2ed6@github.com> Message-ID: On Mon, 1 Mar 2021 11:17:39 GMT, Jaroslav Bachorik wrote: > JMC-7155: [JFR Writer] Complete the annotation handling code This pull request has now been integrated. Changeset: 20d87772 Author: Jaroslav Bachorik Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/20d87772 Stats: 633 lines in 19 files changed: 524 ins; 74 del; 35 mod 7155: [JFR Writer] Complete the annotation handling code Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/222 From jbachorik at openjdk.java.net Tue Mar 16 09:54:04 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 16 Mar 2021 09:54:04 GMT Subject: Integrated: JMC-7156: [JFR Writer] Allow providing extra recording settings In-Reply-To: References: Message-ID: On Mon, 1 Mar 2021 11:30:40 GMT, Jaroslav Bachorik wrote: > JMC-7156: [JFR Writer] Allow providing extra recording settings This pull request has now been integrated. Changeset: 21118208 Author: Jaroslav Bachorik Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/21118208 Stats: 251 lines in 7 files changed: 238 ins; 1 del; 12 mod 7156: [JFR Writer] Allow providing extra recording settings Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/223 From jbachorik at openjdk.java.net Tue Mar 16 09:54:06 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Tue, 16 Mar 2021 09:54:06 GMT Subject: Integrated: JMC-7158: [JFR Writer] Improve single-value types handling In-Reply-To: References: Message-ID: On Mon, 1 Mar 2021 11:49:39 GMT, Jaroslav Bachorik wrote: > JMC-7158: [JFR Writer] Improve single-value types handling This pull request has now been integrated. Changeset: acbc1e62 Author: Jaroslav Bachorik Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/acbc1e62 Stats: 79 lines in 7 files changed: 44 ins; 13 del; 22 mod 7158: [JFR Writer] Improve single-value types handling Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/224 From marcus.hirt at datadoghq.com Tue Mar 16 10:45:54 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 16 Mar 2021 11:45:54 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel Message-ID: I hereby nominate Jean-Phillippe Bempel to jmc Committer. Jean-Phillippe has diligently been working away at JMC issues since august last year, and has been contributing both fixes and larger enhancements, such as the new profiling page and the upcoming constant pool explorer. Votes are due by 2021-04-31 17:00 CET. Only current jmc Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.java.net/census [2] https://openjdk.java.net/projects/#committer-vote From neugens at redhat.com Tue Mar 16 10:54:08 2021 From: neugens at redhat.com (Mario Torre) Date: Tue, 16 Mar 2021 11:54:08 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Vote: yes, Cheers, Mario On Tue, Mar 16, 2021 at 11:46 AM Marcus Hirt wrote: > > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > -- Mario Torre Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Tue Mar 16 14:21:39 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 16 Mar 2021 15:21:39 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Typo - the vote due date is 2021-03-31. Sorry for the confusion. Kind regards, Marcus On Tue, Mar 16, 2021 at 11:45 AM Marcus Hirt wrote: > > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote From hdafgard at gmail.com Tue Mar 16 17:39:58 2021 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Tue, 16 Mar 2021 18:39:58 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Vote: yes Regards, Henrik Dafg?rd On Tue, 16 Mar 2021 at 11:46, Marcus Hirt wrote: > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > From miro.wengner at gmail.com Tue Mar 16 18:43:03 2021 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 16 Mar 2021 19:43:03 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: <79E5A762-41FE-4053-B867-E4562B6ED33A@gmail.com> Vote: yes Kind Regards Miro > On 16. Mar 2021, at 18:40, Henrik Dafg?rd wrote: > > ?Vote: yes > > > Regards, > Henrik Dafg?rd > > >> On Tue, 16 Mar 2021 at 11:46, Marcus Hirt wrote: >> >> I hereby nominate Jean-Phillippe Bempel to jmc Committer. >> >> Jean-Phillippe has diligently been working away at JMC issues since >> august last year, and has been contributing both fixes and larger >> enhancements, such as the new profiling page and the upcoming constant >> pool explorer. >> >> Votes are due by 2021-04-31 17:00 CET. >> >> Only current jmc Committers [1] are eligible to vote on this >> nomination. Votes must be cast in the open by replying to this mailing >> list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> Kind regards, >> Marcus >> >> [1] https://openjdk.java.net/census >> [2] https://openjdk.java.net/projects/#committer-vote >> From marcus.hirt at datadoghq.com Tue Mar 16 22:59:58 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 16 Mar 2021 23:59:58 +0100 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Vote: yes Kind regards, Marcus On Tue, Mar 16, 2021 at 11:45 AM Marcus Hirt wrote: > > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote From guru.hb at oracle.com Wed Mar 17 06:16:21 2021 From: guru.hb at oracle.com (Guru Prasad H B) Date: Wed, 17 Mar 2021 06:16:21 +0000 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: <272204C5-EC86-4E23-8D00-BF86D934A5E0@oracle.com> Vote: Yes, Thanks, Guru > On 16-Mar-2021, at 4:15 PM, Marcus Hirt wrote: > > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote From almacdon at redhat.com Wed Mar 17 14:24:11 2021 From: almacdon at redhat.com (Alex Macdonald) Date: Wed, 17 Mar 2021 10:24:11 -0400 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Vote: yes Cheers, Alex On Tue, Mar 16, 2021 at 6:46 AM Marcus Hirt wrote: > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > Jean-Phillippe has diligently been working away at JMC issues since > august last year, and has been contributing both fixes and larger > enhancements, such as the new profiling page and the upcoming constant > pool explorer. > > Votes are due by 2021-04-31 17:00 CET. > > Only current jmc Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.java.net/census > [2] https://openjdk.java.net/projects/#committer-vote > > From hirt at openjdk.java.net Wed Mar 17 17:50:00 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 17 Mar 2021 17:50:00 GMT Subject: RFR: 7191: The release notes tool should be using JDK 8 Message-ID: Right now the launcher will not work out of the box. ------------- Commit messages: - 7191: The release notes tool should be using JDK 8 Changes: https://git.openjdk.java.net/jmc/pull/229/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=229&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7191 Stats: 17 lines in 2 files changed: 17 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/229.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/229/head:pull/229 PR: https://git.openjdk.java.net/jmc/pull/229 From jmatsuok at redhat.com Wed Mar 17 18:42:18 2021 From: jmatsuok at redhat.com (Joshua Matsuoka) Date: Wed, 17 Mar 2021 14:42:18 -0400 Subject: CFV: New jmc Committer: Jean-Phillippe Bempel In-Reply-To: References: Message-ID: Vote: yes Cheers, Josh On Wed, Mar 17, 2021 at 10:25 AM Alex Macdonald wrote: > Vote: yes > > Cheers, > > Alex > > On Tue, Mar 16, 2021 at 6:46 AM Marcus Hirt > wrote: > > > I hereby nominate Jean-Phillippe Bempel to jmc Committer. > > > > Jean-Phillippe has diligently been working away at JMC issues since > > august last year, and has been contributing both fixes and larger > > enhancements, such as the new profiling page and the upcoming constant > > pool explorer. > > > > Votes are due by 2021-04-31 17:00 CET. > > > > Only current jmc Committers [1] are eligible to vote on this > > nomination. Votes must be cast in the open by replying to this mailing > > list. > > > > For Lazy Consensus voting instructions, see [2]. > > > > Kind regards, > > Marcus > > > > [1] https://openjdk.java.net/census > > [2] https://openjdk.java.net/projects/#committer-vote > > > > > > From hirt at openjdk.java.net Thu Mar 18 19:09:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 18 Mar 2021 19:09:40 GMT Subject: RFR: 6890: defineEventProbes should throw exception on malformed probe definitions [v2] In-Reply-To: <1-G9dfcckHmeOFBqERmuxBnK3mgXfUDqZYihoWKdvvY=.bdfa87c9-16eb-4557-8939-a30396c1bd4a@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> <1-G9dfcckHmeOFBqERmuxBnK3mgXfUDqZYihoWKdvvY=.bdfa87c9-16eb-4557-8939-a30396c1bd4a@github.com> Message-ID: On Fri, 12 Mar 2021 16:22:16 GMT, Joshua Matsuoka wrote: >> This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. >> >> [1] https://bugs.openjdk.java.net/browse/JMC-6890 > > Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: > > Update Copyright headers, have XML validation throw its' own exception Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/227 From jmatsuoka at openjdk.java.net Thu Mar 18 20:20:39 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Thu, 18 Mar 2021 20:20:39 GMT Subject: Integrated: 6890: defineEventProbes should throw exception on malformed probe definitions In-Reply-To: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> References: <3ypfObQ7mj69hbCsOS7oSe3pBmh33cdFs9xvV2lfNGQ=.de508f27-e3f2-41b2-adeb-d1fbf7b3f466@github.com> Message-ID: On Thu, 11 Mar 2021 21:06:50 GMT, Joshua Matsuoka wrote: > This PR addresses JMC-6890 (defineEventProbes should throw exception on malformed probe definitions) [1]. Previously the exception would be swallowed by DefaultTransformRegistry when the XML failed validation, and would simply return null. With this change the exception is rethrown and can be handled accordingly by the AgentController, which rethrows it, and the user. I've added a test for the AgentController and updated the test for DefaultTransformRegistry accordingly. > > [1] https://bugs.openjdk.java.net/browse/JMC-6890 This pull request has now been integrated. Changeset: 6149b48d Author: Joshua Matsuoka URL: https://git.openjdk.java.net/jmc/commit/6149b48d Stats: 150 lines in 10 files changed: 94 ins; 2 del; 54 mod 6890: defineEventProbes should throw exception on malformed probe definitions Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/227 From github.com+4610701+jpbempel at openjdk.java.net Thu Mar 18 21:22:51 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Thu, 18 Mar 2021 21:22:51 GMT Subject: RFR: 7031: Build a constant pool explorer page Message-ID: Add under Recording a new Page for ConstantPools Help to visualize what's inside constant pools part of a JFR recording ![JMC_ConstantPoolsPage](https://user-images.githubusercontent.com/4610701/110855759-13569700-82b7-11eb-9981-deb0b8b5e185.png) *Draft* - Icon is copy/paste from recording. If you have idea about how to replace it... - I have limited the tables to the search toolbar, visible by default - a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise ------------- Commit messages: - Constant pool icon - fix bug check - fix bug check - 7031: Build a constant pool explorer page Changes: https://git.openjdk.java.net/jmc/pull/228/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=228&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7031 Stats: 522 lines in 20 files changed: 507 ins; 1 del; 14 mod Patch: https://git.openjdk.java.net/jmc/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/228/head:pull/228 PR: https://git.openjdk.java.net/jmc/pull/228 From hirt at openjdk.java.net Tue Mar 23 15:30:39 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 23 Mar 2021 15:30:39 GMT Subject: RFR: 7031: Build a constant pool explorer page In-Reply-To: References: Message-ID: On Thu, 11 Mar 2021 21:16:35 GMT, Jean-Philippe Bempel wrote: > Add under Recording a new Page for ConstantPools > Help to visualize what's inside constant pools part of a JFR recording > > ![JMC_ConstantPoolsPage](https://user-images.githubusercontent.com/4610701/110855759-13569700-82b7-11eb-9981-deb0b8b5e185.png) > > *Draft* > - Icon is copy/paste from recording. If you have idea about how to replace it... > - I have limited the tables to the search toolbar, visible by default > - a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/228 From github.com+15711700+aureliogrb at openjdk.java.net Tue Mar 23 15:40:43 2021 From: github.com+15711700+aureliogrb at openjdk.java.net (Aurelio Garcia-Ribeyro) Date: Tue, 23 Mar 2021 15:40:43 GMT Subject: RFR: 7205: Correct URL for Oracle's JMC production binaries Message-ID: 7205: Correct URL for Oracle's JMC production binaries ------------- Commit messages: - Changed Oracle URL to a non-versioned URL - Corrected URL for Oracle's JMC production binaries Changes: https://git.openjdk.java.net/jmc/pull/216/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=216&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7205 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/216.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/216/head:pull/216 PR: https://git.openjdk.java.net/jmc/pull/216 From hirt at openjdk.java.net Tue Mar 23 15:40:43 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 23 Mar 2021 15:40:43 GMT Subject: RFR: 7205: Correct URL for Oracle's JMC production binaries In-Reply-To: References: Message-ID: On Tue, 9 Feb 2021 23:06:59 GMT, Aurelio Garcia-Ribeyro wrote: > 7205: Correct URL for Oracle's JMC production binaries Marked as reviewed by hirt (Lead). Hey! Hi Aurelio! :) You gotta enter a message only containing /covered. Ping @aureliogrb. Ping again @aureliogrb. This has been lingering for quite some time now. Can I help? README.md line 36: > 34: * Eclipse update site > 35: > 36: [https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html](https://www.oracle.com/java/technologies/javase/products-jmc7-downloads.html) Are you sure you want the URL to be the jmc7 downloads? Do you have a top level download URL that will point to the latest always? ------------- PR: https://git.openjdk.java.net/jmc/pull/216 From hirt at openjdk.java.net Tue Mar 23 15:40:44 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 23 Mar 2021 15:40:44 GMT Subject: RFR: 7205: Correct URL for Oracle's JMC production binaries In-Reply-To: References: Message-ID: On Wed, 10 Feb 2021 00:45:10 GMT, Marcus Hirt wrote: >> 7205: Correct URL for Oracle's JMC production binaries > > Hey! Hi Aurelio! :) You gotta enter a message only containing /covered. Also, there needs to be a matching JBS bug, and the PR message must be changed to <BUGID>: <issue summary>. See other already closed PRs for examples. > Marked as reviewed by hirt (Lead). Added an issue in Jira, and updated the PR name to the required format. This one is now ready to go. ------------- PR: https://git.openjdk.java.net/jmc/pull/216 From github.com+15711700+aureliogrb at openjdk.java.net Thu Mar 25 20:58:25 2021 From: github.com+15711700+aureliogrb at openjdk.java.net (Aurelio Garcia-Ribeyro) Date: Thu, 25 Mar 2021 20:58:25 GMT Subject: Integrated: 7205: Correct URL for Oracle's JMC production binaries In-Reply-To: References: Message-ID: <15ez0-X6IY91fUHM1uVh3fPZ_UJ6lVEBoAXwrrQYXm8=.3068814d-3837-4f5f-80a4-36938e654af4@github.com> On Tue, 9 Feb 2021 23:06:59 GMT, Aurelio Garcia-Ribeyro wrote: > 7205: Correct URL for Oracle's JMC production binaries This pull request has now been integrated. Changeset: 1c008c30 Author: Aurelio Garcia-Ribeyro Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/1c008c30 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7205: Correct URL for Oracle's JMC production binaries Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/216 From duke at openjdk.java.net Thu Mar 25 21:44:02 2021 From: duke at openjdk.java.net (duke) Date: Thu, 25 Mar 2021 21:44:02 GMT Subject: git: openjdk/jmc-graphics: Update README.md Message-ID: <5704ce63-6a5f-4c84-ba93-d17b64437c01@openjdk.java.net> Changeset: 7d2377aa Author: Marcus Hirt Committer: GitHub Date: 2021-03-25 22:43:44 +0000 URL: https://git.openjdk.java.net/jmc-graphics/commit/7d2377aa Update README.md ! README.md From hirt at openjdk.java.net Thu Mar 25 21:45:42 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 25 Mar 2021 21:45:42 GMT Subject: [jmc-graphics] RFR: 7102: Add new splash to graphics project [v2] In-Reply-To: References: Message-ID: > Adding the new JMC 8 splash. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: 7210: Create icon for the agent (and agent plug-in) ------------- Changes: - all: https://git.openjdk.java.net/jmc-graphics/pull/2/files - new: https://git.openjdk.java.net/jmc-graphics/pull/2/files/df858cc8..b346d6b0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=2&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=2&range=00-01 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc-graphics/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jmc-graphics pull/2/head:pull/2 PR: https://git.openjdk.java.net/jmc-graphics/pull/2 From hirt at openjdk.java.net Thu Mar 25 21:57:29 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 25 Mar 2021 21:57:29 GMT Subject: [jmc-graphics] RFR: 7210: Create icon for the agent (and agent plug-in) Message-ID: The idraw format might be a bit arbitrary, but that's what I used for this. ------------- Commit messages: - 7210: Create icon for the agent (and agent plug-in) Changes: https://git.openjdk.java.net/jmc-graphics/pull/3/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=3&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7210 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc-graphics/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/jmc-graphics pull/3/head:pull/3 PR: https://git.openjdk.java.net/jmc-graphics/pull/3 From hirt at openjdk.java.net Thu Mar 25 22:21:41 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 25 Mar 2021 22:21:41 GMT Subject: [jmc-graphics] RFR: 7102: Add new splash to graphics project [v3] In-Reply-To: References: Message-ID: > Adding the new JMC 8 splash. Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. ------------- Changes: - all: https://git.openjdk.java.net/jmc-graphics/pull/2/files - new: https://git.openjdk.java.net/jmc-graphics/pull/2/files/b346d6b0..df858cc8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=2&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=2&range=01-02 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc-graphics/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jmc-graphics pull/2/head:pull/2 PR: https://git.openjdk.java.net/jmc-graphics/pull/2 From ghb at openjdk.java.net Fri Mar 26 04:36:23 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 26 Mar 2021 04:36:23 GMT Subject: [jmc-graphics] RFR: 7102: Add new splash to graphics project [v3] In-Reply-To: References: Message-ID: <5xuagtF7mthi_06QDvRRadvz7balBRm9hLCaLKekMus=.b19bf0f9-a54b-4233-929e-6bdbf71028f2@github.com> On Thu, 25 Mar 2021 22:21:41 GMT, Marcus Hirt wrote: >> Adding the new JMC 8 splash. > > Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc-graphics/pull/2 From aptmac at openjdk.java.net Fri Mar 26 14:25:22 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 26 Mar 2021 14:25:22 GMT Subject: [jmc-graphics] RFR: 7210: Create icon for the agent (and agent plug-in) In-Reply-To: References: Message-ID: <27ZxA3qVnw6CdJymlAhlPeA8yTZW4Kxo2me4v7vB48Y=.32bcf4b4-366d-4537-b02e-ba1a29517492@github.com> On Thu, 25 Mar 2021 21:52:47 GMT, Marcus Hirt wrote: > The idraw format might be a bit arbitrary, but that's what I used for this. Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc-graphics/pull/3 From hirt at openjdk.java.net Fri Mar 26 17:47:22 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 26 Mar 2021 17:47:22 GMT Subject: [jmc-graphics] Integrated: 7210: Create icon for the agent (and agent plug-in) In-Reply-To: References: Message-ID: On Thu, 25 Mar 2021 21:52:47 GMT, Marcus Hirt wrote: > The idraw format might be a bit arbitrary, but that's what I used for this. This pull request has now been integrated. Changeset: f16156d8 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc-graphics/commit/f16156d8 Stats: 0 lines in 4 files changed: 0 ins; 0 del; 0 mod 7210: Create icon for the agent (and agent plug-in) Reviewed-by: aptmac ------------- PR: https://git.openjdk.java.net/jmc-graphics/pull/3 From hirt at openjdk.java.net Fri Mar 26 21:33:28 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 26 Mar 2021 21:33:28 GMT Subject: [jmc-graphics] Integrated: 7102: Add new splash to graphics project In-Reply-To: References: Message-ID: <8n-N7vUFKuvGoJ9smyODCSeWMofJP811Xbd27sVI_Yc=.bce2573c-c991-4d29-9d14-3fce9cb71584@github.com> On Wed, 20 Jan 2021 14:00:56 GMT, Marcus Hirt wrote: > Adding the new JMC 8 splash. This pull request has now been integrated. Changeset: d7ba7e6d Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc-graphics/commit/d7ba7e6d Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod 7102: Add new splash to graphics project Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc-graphics/pull/2 From jmatsuoka at openjdk.java.net Mon Mar 29 18:36:39 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Mon, 29 Mar 2021 18:36:39 GMT Subject: RFR: 7167: Agent Plugin Message-ID: This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) ------------- Commit messages: - Update with jmc-graphics icon for agent/agent plugn - Merge remote-tracking branch 'upstream/master' into agent-plugin - Updating copyright headers - Clean up spotbugs excludes - 7167: Agent Plugin Changes: https://git.openjdk.java.net/jmc/pull/226/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7167 Stats: 9049 lines in 73 files changed: 9049 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From hirt at openjdk.java.net Mon Mar 29 18:36:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 29 Mar 2021 18:36:40 GMT Subject: RFR: 7167: Agent Plugin In-Reply-To: References: Message-ID: <6nfB_VUa4DCR0ZABucSS54FAoOYuhoRHqBNSG0gnyTc=.9f6dac0c-a1c4-4b65-8830-a9febe09de75@github.com> On Wed, 10 Mar 2021 22:58:07 GMT, Joshua Matsuoka wrote: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) New plug-ins must have both 16x16 and 32x32 pixel versions of icons, and preferably also either a vector version, or a higher resolution variant checked into jmc-graphics. Let me know if you need help inventing something. :) application/org.openjdk.jmc.console.ext.agent/plugin.xml line 3: > 1: > 2: