RFR: 6890: defineEventProbes should throw exception on malformed probe definitions [v2]

Joshua Matsuoka jmatsuoka at openjdk.java.net
Fri Mar 12 16:22:17 UTC 2021


On Fri, 12 Mar 2021 12:22:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Copyright headers, have XML validation throw its' own exception
>
> agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java line 91:
> 
>> 89: 	 *             if the supplied XML fails to validate.
>> 90: 	 */
>> 91: 	Set<String> modify(String xmlDescription) throws XMLStreamException;
> 
> Perhaps have our own exception class (e.g. XmlValidationException)? It shouldn't depend on whatever XML parser methology we're using (StAX vs DOM etc).

Makes sense, I've added an XMLValidationException in the most recent commit and have it thrown from validateProbeDefinition

-------------

PR: https://git.openjdk.java.net/jmc/pull/227


More information about the jmc-dev mailing list