RFR: JMC-7155: [JFR Writer] Complete the annotation handling code

Jaroslav Bachorik jbachorik at openjdk.java.net
Mon Mar 15 15:40:10 UTC 2021


On Mon, 15 Mar 2021 14:16:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> JMC-7155: [JFR Writer] Complete the annotation handling code
>
> core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/TypedFieldImpl.java line 52:
> 
>> 50: 	private final List<Annotation> annotations;
>> 51: 
>> 52: 	public TypedFieldImpl(TypeImpl type, String name) {
> 
> Now that the implementation classes are becoming public, do you wish to move them off to a separate package to signal that people shouldn't rely on them, and that they are not part of the public API?

The API classes are in `org.openjdk.jmc.flightrecorder.writer.api` package which is the only one exported.
However, if you feel strongly about this I will move the impl classes to `org.openjdk.jmc.flightrecorder.writer.impl` package instead.

-------------

PR: https://git.openjdk.java.net/jmc/pull/222


More information about the jmc-dev mailing list