RFR: JMC-7155: [JFR Writer] Complete the annotation handling code
Jaroslav Bachorik
jbachorik at openjdk.java.net
Mon Mar 15 17:00:09 UTC 2021
On Mon, 15 Mar 2021 15:56:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> The API classes are in `org.openjdk.jmc.flightrecorder.writer.api` package which is the only one exported.
>> However, if you feel strongly about this I will move the impl classes to `org.openjdk.jmc.flightrecorder.writer.impl` package instead.
>
> Personally I think I might have gone with api being in the writer top-level package, and then an impl package, but it's probably not worth the heartache to change that. So, nah don't feel strongly about it.
Ok. You are right, it would have been better in the top package. IDK, I just turned on auto pilot and did the `api` package - I used to put various modular/infra classes into the module package. Probably this approach is not that good any more.
But given that the API has been already made public we will have to live with that :(
-------------
PR: https://git.openjdk.java.net/jmc/pull/222
More information about the jmc-dev
mailing list