From schaturvedi at openjdk.java.net  Sun May  2 15:30:01 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 2 May 2021 15:30:01 GMT
Subject: RFR: 7242: Adding new JDK Events to core API
Message-ID: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>

This PR will address these missing events and add them to core API.

jdk.ThreadCPULoad

jdk.NativeMethodSample

jdk.ThreadStart

jdk.ThreadEnd

-------------

Commit messages:
 - Fixed spotbugs errors
 - 7242: Adding new JDK Events to core API

Changes: https://git.openjdk.java.net/jmc/pull/245/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7242
  Stats: 23 lines in 5 files changed: 21 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/245.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245

PR: https://git.openjdk.java.net/jmc/pull/245

From schaturvedi at openjdk.java.net  Sun May  2 15:40:21 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 2 May 2021 15:40:21 GMT
Subject: RFR: 7242: Adding new JDK Events to core API [v2]
In-Reply-To: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
References: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
Message-ID: <jY4eGLWXfB18rVqAOY0L1VB2m1hu-R1nLC3pW0TQHHM=.44901abb-7634-404e-a3d5-47c3ca4539e6@github.com>

> This PR will address these missing events and add them to core API.
> 
> jdk.ThreadCPULoad
> 
> jdk.NativeMethodSample
> 
> jdk.ThreadStart
> 
> jdk.ThreadEnd

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Fixing formatting errors in core

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/245/files
  - new: https://git.openjdk.java.net/jmc/pull/245/files/fda5af22..600d38cf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=00-01

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/245.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245

PR: https://git.openjdk.java.net/jmc/pull/245

From github.com+4610701+jpbempel at openjdk.java.net  Mon May  3 19:54:50 2021
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 3 May 2021 19:54:50 GMT
Subject: Integrated: 7124: Support the new JDK 16 allocation profiling event
In-Reply-To: <Bp7iSVH_JmMzJLe8-ywyMNrm7FqaGZ6Kn6eRiNhbKSg=.a84938fa-689d-4e64-a04e-1cb54bc65c7d@github.com>
References: <Bp7iSVH_JmMzJLe8-ywyMNrm7FqaGZ6Kn6eRiNhbKSg=.a84938fa-689d-4e64-a04e-1cb54bc65c7d@github.com>
Message-ID: <vfa3j_YULpJv3kuFVKNTfl-hPZEOMbIooc5cesyonYM=.d26b566a-348b-4f04-a1b8-43650ff36006@github.com>

On Tue, 27 Apr 2021 07:17:21 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Add support of ObjectAllocationSample event in HeapPage

This pull request has now been integrated.

Changeset: 30223c71
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/30223c711da5c9d8b130f4adf0c5cc6a59043ce7
Stats:     57 lines in 7 files changed: 36 ins; 13 del; 8 mod

7124: Support the new JDK 16 allocation profiling event

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/244

From ghb at openjdk.java.net  Wed May  5 06:04:51 2021
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 5 May 2021 06:04:51 GMT
Subject: RFR: 7241: Adjust main pom.xml to more align for 3th party builds
In-Reply-To: <JB8FLdKm9f4er4Id7QqyilsQIMW0L9CFMrmOBzShboc=.4d35ede4-c7ea-4526-86f2-8af51ae5d920@github.com>
References: <JB8FLdKm9f4er4Id7QqyilsQIMW0L9CFMrmOBzShboc=.4d35ede4-c7ea-4526-86f2-8af51ae5d920@github.com>
Message-ID: <oLzfKQNxZlGGpYAGpq9kcji6pOvL23_HlVE4vNatAMs=.bbba2df2-900f-4842-b30c-b7768c9f529d@github.com>

On Wed, 14 Apr 2021 17:49:09 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

+1 looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/241

From schaturvedi at openjdk.java.net  Thu May  6 05:22:19 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 6 May 2021 05:22:19 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work consistently
 across JFRs from different JDK versions.
Message-ID: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>

This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.

Please review the change and provide your valuable comments.

-------------

Commit messages:
 - JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.

Changes: https://git.openjdk.java.net/jmc/pull/246/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=246&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7201
  Stats: 17 lines in 4 files changed: 15 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/246.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/246/head:pull/246

PR: https://git.openjdk.java.net/jmc/pull/246

From hdafgard at openjdk.java.net  Thu May  6 13:28:02 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 6 May 2021 13:28:02 GMT
Subject: RFR: 7164: Add support for hidden classes
Message-ID: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>

Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).

-------------

Commit messages:
 - Add support for hidden classes

Changes: https://git.openjdk.java.net/jmc/pull/247/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=247&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7164
  Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/247.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/247/head:pull/247

PR: https://git.openjdk.java.net/jmc/pull/247

From hdafgard at openjdk.java.net  Thu May  6 13:37:17 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 6 May 2021 13:37:17 GMT
Subject: RFR: 7164: Add support for hidden classes [v2]
In-Reply-To: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
References: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
Message-ID: <H821cwkbggnLTXKoY95_o5DYlaVCEWS_wcofLPbbh5o=.d6b5125b-d6fd-482d-85f7-5389f653c11e@github.com>

> Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/247/files
  - new: https://git.openjdk.java.net/jmc/pull/247/files/ef1f7de5..60316e62

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=247&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=247&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/247.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/247/head:pull/247

PR: https://git.openjdk.java.net/jmc/pull/247

From reinhapa at openjdk.java.net  Thu May  6 14:01:51 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 6 May 2021 14:01:51 GMT
Subject: Integrated: 7241: Adjust main pom.xml to more align for 3th party
 builds
In-Reply-To: <JB8FLdKm9f4er4Id7QqyilsQIMW0L9CFMrmOBzShboc=.4d35ede4-c7ea-4526-86f2-8af51ae5d920@github.com>
References: <JB8FLdKm9f4er4Id7QqyilsQIMW0L9CFMrmOBzShboc=.4d35ede4-c7ea-4526-86f2-8af51ae5d920@github.com>
Message-ID: <D6Q3kARSjhHFjj-iwoqnQqfyCxO4HFLWmlStz8u-Ok8=.c3134072-c764-4df2-8b9b-227f904e9928@github.com>

On Wed, 14 Apr 2021 17:49:09 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

This pull request has now been integrated.

Changeset: 8653337d
Author:    Patrick Reinhart <reinhapa at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8653337db77e39b0c4e5ebbd3f4da0ead16db291
Stats:     14 lines in 1 file changed: 4 ins; 10 del; 0 mod

7241: Adjust main pom.xml to more align for 3th party builds

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/241

From hirt at openjdk.java.net  Thu May  6 14:03:50 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 6 May 2021 14:03:50 GMT
Subject: RFR: 7164: Add support for hidden classes [v2]
In-Reply-To: <H821cwkbggnLTXKoY95_o5DYlaVCEWS_wcofLPbbh5o=.d6b5125b-d6fd-482d-85f7-5389f653c11e@github.com>
References: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
 <H821cwkbggnLTXKoY95_o5DYlaVCEWS_wcofLPbbh5o=.d6b5125b-d6fd-482d-85f7-5389f653c11e@github.com>
Message-ID: <2Vzx1VqfN2Wi85UCCJgktqZX3OWfiPtmwh0M4MTS93c=.93871b7f-a444-4d19-b0e9-278651a3914c@github.com>

On Thu, 6 May 2021 13:37:17 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).
>
> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCType.java line 68:

> 66: 
> 67: 	/**
> 68: 	 * Returns whether or not the type is hidden or not.

You can skip the "or not" at the end. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/247

From hdafgard at openjdk.java.net  Thu May  6 15:59:18 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 6 May 2021 15:59:18 GMT
Subject: RFR: 7164: Add support for hidden classes [v3]
In-Reply-To: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
References: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
Message-ID: <yYTDZZF7cOousPkAXuZ9MHja2SOvBDklYDP-gae67p4=.f91d71e2-7752-4df9-aae7-3b00dec91933@github.com>

> Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Update IMCType.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/247/files
  - new: https://git.openjdk.java.net/jmc/pull/247/files/60316e62..804d504d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=247&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=247&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/247.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/247/head:pull/247

PR: https://git.openjdk.java.net/jmc/pull/247

From hirt at openjdk.java.net  Thu May  6 16:18:53 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 6 May 2021 16:18:53 GMT
Subject: RFR: 7164: Add support for hidden classes [v3]
In-Reply-To: <yYTDZZF7cOousPkAXuZ9MHja2SOvBDklYDP-gae67p4=.f91d71e2-7752-4df9-aae7-3b00dec91933@github.com>
References: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
 <yYTDZZF7cOousPkAXuZ9MHja2SOvBDklYDP-gae67p4=.f91d71e2-7752-4df9-aae7-3b00dec91933@github.com>
Message-ID: <8prL1rkXFLQrHGb6VtHflQBqsvv6VnMSETKZc6FDoRA=.62cba412-2e0c-480c-aa1f-44a82de7fbc1@github.com>

On Thu, 6 May 2021 15:59:18 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).
>
> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update IMCType.java

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/247

From hdafgard at openjdk.java.net  Thu May  6 17:48:50 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 6 May 2021 17:48:50 GMT
Subject: Integrated: 7164: Add support for hidden classes
In-Reply-To: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
References: <XlUp1DkXTQEt2mVVpcPzpeWzB7Fi4TRHshY4dra7c-I=.d5bf379e-09b2-433e-88bd-7f0ed5d89434@github.com>
Message-ID: <k0OvT1tOuZkSbnBEWldXiEMfmNhc9jOz_SSCrQbAAKQ=.a82a7e3d-8b46-4ede-88ff-5945c2d401a5@github.com>

On Thu, 6 May 2021 13:23:04 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

> Adds support for JDK 15 hidden classes to the JFR parser and IMCType interface (defaults to `false`).

This pull request has now been integrated.

Changeset: d708be36
Author:    Henrik Dafg?rd <hdafgard at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d708be364461d82fe780898029f4ecc8aca54dee
Stats:     15 lines in 2 files changed: 15 ins; 0 del; 0 mod

7164: Add support for hidden classes

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/247

From hirt at openjdk.java.net  Tue May 11 11:38:59 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 11 May 2021 11:38:59 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
Message-ID: <c7AkTsrB3z-WTPAlOymDpZCTi4ImcZ6TyhSJYGP-58E=.acb1ed52-f31a-4302-8bba-e074d32cfc8c@github.com>

On Wed, 5 May 2021 20:08:32 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
> 
> Please review the change and provide your valuable comments.

Marked as reviewed by hirt (Lead).

The Oracle type id should be defined in OracleJdkTypeIDsPre11.

-------------

PR: https://git.openjdk.java.net/jmc/pull/246Changes requested by hirt (Lead).

From schaturvedi at openjdk.java.net  Tue May 11 14:55:54 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 May 2021 14:55:54 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <c7AkTsrB3z-WTPAlOymDpZCTi4ImcZ6TyhSJYGP-58E=.acb1ed52-f31a-4302-8bba-e074d32cfc8c@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
 <c7AkTsrB3z-WTPAlOymDpZCTi4ImcZ6TyhSJYGP-58E=.acb1ed52-f31a-4302-8bba-e074d32cfc8c@github.com>
Message-ID: <JpkTpWGSyst0S9o6k7VMzb4xtXXYAADpin2KkzpLCQg=.91890324-d61a-45cc-87c1-06e0a1c2e66a@github.com>

On Tue, 11 May 2021 11:36:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> The Oracle type id should be defined in OracleJdkTypeIDsPre11.

I feel its already there at line no 181 in OracleJdkTypeIDsPre11 as below:
private final static String CONTEXT_SWITCH_RATE = JVM_EVENT_ID_ROOT + "os/processor/context_switch_rate";

Please let me know if otherwise.

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From hirt at openjdk.java.net  Tue May 11 15:03:59 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 11 May 2021 15:03:59 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
Message-ID: <wX0nWh49gyywjiq4cqyIu727jhYldv--hDCvO3K3Q0E=.10fdd24a-9d67-4903-96df-8eff76a83be5@github.com>

On Wed, 5 May 2021 20:08:32 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
> 
> Please review the change and provide your valuable comments.

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java line 198:

> 196: 
> 197: 			} else if (eventTypeId
> 198: 					.equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")) {

This line here:
.equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From schaturvedi at openjdk.java.net  Tue May 11 15:07:54 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 May 2021 15:07:54 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <wX0nWh49gyywjiq4cqyIu727jhYldv--hDCvO3K3Q0E=.10fdd24a-9d67-4903-96df-8eff76a83be5@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
 <wX0nWh49gyywjiq4cqyIu727jhYldv--hDCvO3K3Q0E=.10fdd24a-9d67-4903-96df-8eff76a83be5@github.com>
Message-ID: <1AYef18rxvxXAwitDKdL-gYWrjVglmqrQVpQwiDPWLY=.81a0542e-eb78-4500-b9f9-404fbdf7ea08@github.com>

On Tue, 11 May 2021 15:00:42 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
>> 
>> Please review the change and provide your valuable comments.
>
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java line 198:
> 
>> 196: 
>> 197: 			} else if (eventTypeId
>> 198: 					.equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")) {
> 
> This line here:
> .equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")

Ok so it should be eventTypeId.equalsIgnoreCase(OracleJdkTypeIDsPre11.CONTEXT_SWITCH_RATE) ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From hirt at openjdk.java.net  Tue May 11 16:17:52 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 11 May 2021 16:17:52 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <1AYef18rxvxXAwitDKdL-gYWrjVglmqrQVpQwiDPWLY=.81a0542e-eb78-4500-b9f9-404fbdf7ea08@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
 <wX0nWh49gyywjiq4cqyIu727jhYldv--hDCvO3K3Q0E=.10fdd24a-9d67-4903-96df-8eff76a83be5@github.com>
 <1AYef18rxvxXAwitDKdL-gYWrjVglmqrQVpQwiDPWLY=.81a0542e-eb78-4500-b9f9-404fbdf7ea08@github.com>
Message-ID: <NoWzGNkjQ0a1bCAcsoSVVz_o0LACnR9TUSQPaBjGz70=.f004d47f-dc75-4ebb-ba58-837c901088fa@github.com>

On Tue, 11 May 2021 15:05:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java line 198:
>> 
>>> 196: 
>>> 197: 			} else if (eventTypeId
>>> 198: 					.equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")) {
>> 
>> This line here:
>> .equalsIgnoreCase("http://www.oracle.com/hotspot/jvm/os/processor/context_switch_rate")
>
> Ok so it should be eventTypeId.equalsIgnoreCase(OracleJdkTypeIDsPre11.CONTEXT_SWITCH_RATE) ?

Yes.

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From schaturvedi at openjdk.java.net  Tue May 11 16:22:45 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 May 2021 16:22:45 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions. [v2]
In-Reply-To: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
Message-ID: <6LDneIJlzGVGiNf7daZlOUwZnmAtPneGgODYIZZsr_w=.4c2d087e-18b5-423c-88db-c217918c601b@github.com>

> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
> 
> Please review the change and provide your valuable comments.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Used JdkTypeId from OracleJdkTypeIDsPre11

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/246/files
  - new: https://git.openjdk.java.net/jmc/pull/246/files/504d8b3f..5a98585c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=246&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=246&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/246.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/246/head:pull/246

PR: https://git.openjdk.java.net/jmc/pull/246

From hirt at openjdk.java.net  Tue May 11 17:54:55 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 11 May 2021 17:54:55 GMT
Subject: RFR: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions. [v2]
In-Reply-To: <6LDneIJlzGVGiNf7daZlOUwZnmAtPneGgODYIZZsr_w=.4c2d087e-18b5-423c-88db-c217918c601b@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
 <6LDneIJlzGVGiNf7daZlOUwZnmAtPneGgODYIZZsr_w=.4c2d087e-18b5-423c-88db-c217918c601b@github.com>
Message-ID: <NZuIiPKPJ2JjwMb8g9G1_Co_p2ePRdQu5OCy0VM36H8=.05f9a939-c422-4cd6-ba7a-b5d7a0c1dbb7@github.com>

On Tue, 11 May 2021 16:22:45 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
>> 
>> Please review the change and provide your valuable comments.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Used JdkTypeId from OracleJdkTypeIDsPre11

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From schaturvedi at openjdk.java.net  Tue May 11 20:01:54 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 May 2021 20:01:54 GMT
Subject: Integrated: 7201: JdkAttributes.OS_SWITCH_RATE does not work
 consistently across JFRs from different JDK versions.
In-Reply-To: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
References: <5KGWC-yvYlRk65Dss__5zxlcjfqTn8KM3EzrOPqWXaA=.777be739-bd1a-4839-be8d-1b76e7010b33@github.com>
Message-ID: <q_dNZIX_QIzHyTnH8kx40ez0hawkH8p0tyltTKYiTas=.1366561c-7399-4d38-aa2c-db16ec47b890@github.com>

On Wed, 5 May 2021 20:08:32 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the issue of switchRate attribute not accessible via core API when used for JFR generated with JDK 11 and above.
> 
> Please review the change and provide your valuable comments.

This pull request has now been integrated.

Changeset: af9df262
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/af9df26282ee2b893aeb5abf9c411f21f8893c8c
Stats:     17 lines in 5 files changed: 14 ins; 1 del; 2 mod

7201: JdkAttributes.OS_SWITCH_RATE does not work consistently across JFRs from different JDK versions.

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/246

From schaturvedi at openjdk.java.net  Tue May 11 22:40:19 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 May 2021 22:40:19 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to produce
 results for Class Leak Rule.
Message-ID: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>

This PR addresses the optimization of Class Leak Rule.

Please refer the JBS for the sample JFR which was taking ~90 minutes to generate results for Class Leak Rule. After the optimization time is reduced to ~10-15 minutes.

Please review the change and let me the know if there are any comments / suggestions.

-------------

Commit messages:
 - 7248: JMC7/8 Automated Analysis taking very long time to produce results for Class Leak Rule.

Changes: https://git.openjdk.java.net/jmc/pull/248/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=248&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7248
  Stats: 39 lines in 1 file changed: 24 ins; 2 del; 13 mod
  Patch: https://git.openjdk.java.net/jmc/pull/248.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/248/head:pull/248

PR: https://git.openjdk.java.net/jmc/pull/248

From hirt at openjdk.java.net  Wed May 12 18:26:55 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 May 2021 18:26:55 GMT
Subject: RFR: 7195: GC confguration with GC Flags
In-Reply-To: <UW6K-vra98W01Y32u_rUuwkdKIr2xf7w32tsIW3YZ9o=.18740ceb-47f2-4a10-9a7d-93211a7785d9@github.com>
References: <UW6K-vra98W01Y32u_rUuwkdKIr2xf7w32tsIW3YZ9o=.18740ceb-47f2-4a10-9a7d-93211a7785d9@github.com>
Message-ID: <A4Z81-FNurBZvjVQg0CBNa1NL0gNfFdkNTwI2jRcBWE=.c10fa1f4-be2d-4737-8dc6-7fb2cafbb436@github.com>

On Thu, 18 Mar 2021 16:30:12 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

> This pull request proposes to display related garbage collector flags.
> 
> **Motivation**
> 
> When turning the GC flag knobs, it is useful to be able to quickly see
> the GC configuration, however the _GC configuration_ page only show 3 
> events, if one wants to have a look at flags he has to either check
> the command line or inspect the _JVM internal_ page to find relevant
> GC flags. Therefore having these flags right there is useful to get
> a quick picture of the current configuration.
> 
> **Current limitations**
> 
> 1. At this time the selected flags depends on the GC algorithm which is 
>    derived from the name of the old collector name. This is simple, 
>    however it prevents to identify EpsilonGC because whose old 
>    collector name is `SerialOld`, which is the same as SerialGC.
> 
> 2. There are some global flags in `gc/shared/gc_globals.hpp` that 
>    I didn't include as I didn't use most of them. I'm not sure these 
>    flags are seen much in the wild.
> 
> 
> **Remarks**
> 
> As mentionned above the use of the OldCollector name may not be the 
> best choice, I would like to refactor this part to use the `Use*GC`
> flags instead. I am a bit unsure at this time how to use the 
> existing API.

Marked as reviewed by hirt (Lead).

Sorry for the delay @bric3, and thank you your contribution! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/230

From hirt at openjdk.java.net  Thu May 13 02:16:20 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 13 May 2021 02:16:20 GMT
Subject: RFR: 7256: Use .jcheck/conf property to control version
Message-ID: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>

See Erik Joelsson's comment in https://bugs.openjdk.java.net/browse/SKARA-1033.

-------------

Commit messages:
 - 7256: Use .jcheck/conf property to control version
 - Merge branch 'master' into 7046-update-2021-03
 - Removing chromium
 - 7046: Update to the 2021-03 platform

Changes: https://git.openjdk.java.net/jmc/pull/249/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=249&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7256
  Stats: 109 lines in 7 files changed: 90 ins; 3 del; 16 mod
  Patch: https://git.openjdk.java.net/jmc/pull/249.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/249/head:pull/249

PR: https://git.openjdk.java.net/jmc/pull/249

From hirt at openjdk.java.net  Thu May 13 02:41:08 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 13 May 2021 02:41:08 GMT
Subject: RFR: 7256: Use .jcheck/conf property to control version [v2]
In-Reply-To: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>
References: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>
Message-ID: <NGiGbzpXlxceXiJQ4GtW8LLz1uzYaoKVE1UiQE13bP8=.9361bd29-341e-4ec7-9b5e-f37d6bc29c26@github.com>

> See Erik Joelsson's comment in https://bugs.openjdk.java.net/browse/SKARA-1033.

Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  7256: Use .jcheck/conf property to control version

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/249/files
  - new: https://git.openjdk.java.net/jmc/pull/249/files/1e8785da..608cbc6a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=249&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=249&range=00-01

  Stats: 151 lines in 6 files changed: 3 ins; 137 del; 11 mod
  Patch: https://git.openjdk.java.net/jmc/pull/249.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/249/head:pull/249

PR: https://git.openjdk.java.net/jmc/pull/249

From ghb at openjdk.java.net  Thu May 13 04:18:52 2021
From: ghb at openjdk.java.net (Guru Hb)
Date: Thu, 13 May 2021 04:18:52 GMT
Subject: RFR: 7256: Use .jcheck/conf property to control version [v2]
In-Reply-To: <NGiGbzpXlxceXiJQ4GtW8LLz1uzYaoKVE1UiQE13bP8=.9361bd29-341e-4ec7-9b5e-f37d6bc29c26@github.com>
References: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>
 <NGiGbzpXlxceXiJQ4GtW8LLz1uzYaoKVE1UiQE13bP8=.9361bd29-341e-4ec7-9b5e-f37d6bc29c26@github.com>
Message-ID: <5o0po0MqyuVQy1_0aXPGHZ-hPjDktGB0SPLx0X_aIqg=.a3eb5f64-2f9b-4b1e-bf47-d17b19b33463@github.com>

On Thu, 13 May 2021 02:41:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> See Erik Joelsson's comment in https://bugs.openjdk.java.net/browse/SKARA-1033.
>
> Marcus Hirt has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/249

From hirt at openjdk.java.net  Thu May 13 13:03:52 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 13 May 2021 13:03:52 GMT
Subject: Integrated: 7256: Use .jcheck/conf property to control version
In-Reply-To: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>
References: <FeMX2PH9QuJxuqs5GMyPIZUVwuEydG6xfdBxHJYvxlQ=.99e1f49a-439a-4f61-a896-90519faf7688@github.com>
Message-ID: <Wh3ouw86TXJ6g9K7nI-EB_rW-FLe3tTiijoxG9RgTzM=.aa3bc049-9dd5-447c-b1a3-f70972e5e261@github.com>

On Thu, 13 May 2021 02:12:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> See Erik Joelsson's comment in https://bugs.openjdk.java.net/browse/SKARA-1033.

This pull request has now been integrated.

Changeset: 9852c99d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/9852c99ddf67a12fbd48be8cc3537236ea601c03
Stats:     3 lines in 1 file changed: 1 ins; 0 del; 2 mod

7256: Use .jcheck/conf property to control version

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/249

From github.com+803621+bric3 at openjdk.java.net  Mon May 17 14:43:41 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 May 2021 14:43:41 GMT
Subject: RFR: 7235: Some writer cleanup
In-Reply-To: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
References: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
Message-ID: <DWdb9csJ_cB1s6Cpx5fhWH02cVspe-Ln0i9kqTU-ZWg=.b11a05ca-664e-4955-9098-b0ccda9e5b04@github.com>

On Thu, 8 Apr 2021 19:47:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Just getting rid of a few annoying warnings. I'll add an issue once JBS is up again.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/237

From github.com+803621+bric3 at openjdk.java.net  Mon May 17 14:43:42 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 May 2021 14:43:42 GMT
Subject: RFR: 7236: Adding project specific settings to ignore forbidden
 references
In-Reply-To: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
References: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
Message-ID: <SDGUJXVZdCHtLhnKP-dR4GcxZy_1ssGJQJL3avw3_Pg=.0b903e15-9197-474a-8c4e-86efc2af5543@github.com>

On Thu, 8 Apr 2021 19:25:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Since JBS is down for maintenance, I'll add an issue once it's up and happy again.
> 
> Update: added issue.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/236

From github.com+803621+bric3 at openjdk.java.net  Mon May 17 15:48:55 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 May 2021 15:48:55 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule.
In-Reply-To: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
Message-ID: <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>

On Tue, 11 May 2021 22:35:08 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the optimization of Class Leak Rule.
> 
> Please refer the JBS for the sample JFR which was taking ~90 minutes to generate results for Class Leak Rule. After the optimization time is reduced to ~10-15 minutes.
> 
> Please review the change and let me the know if there are any comments / suggestions.

Hi,

I believe the executor code has some issues that should be tackled.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 76:

> 74: 		} catch (Exception e) {
> 75: 			e.printStackTrace();
> 76: 		}

Don't swallow the interrupted exception, if this happens, this mean the code calling awaitTermination has been interrupted, the code should make sure the current thread is interrupted.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 108:

> 106: 			if (aggregate != null) {
> 107: 				int SUM_NUM_THREADS = Runtime.getRuntime().availableProcessors();
> 108: 				ExecutorService exec = Executors.newFixedThreadPool(SUM_NUM_THREADS);

I wonder if a `ForkJoinPool` might be better suited here (maybe with `Executors.newWorkStealingPool`), in which case the code won't need to look for the number of avaialble processors.
Going furhter it might be even useful to consider `Stream::parallelStream`?

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 108:

> 106: 			if (aggregate != null) {
> 107: 				int SUM_NUM_THREADS = Runtime.getRuntime().availableProcessors();
> 108: 				ExecutorService exec = Executors.newFixedThreadPool(SUM_NUM_THREADS);

This might be useful to have a named threads. Yet I never tired this with FJP.
Maybe mission control do have some facility in that regard ?

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 126:

> 124: 									row[column + j] = rowCollection.getAggregate(aggregators.get(j));
> 125: 								}
> 126: 								data.add(row);

Shouldn't this access be synchronized ?

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 134:

> 132: 				}
> 133: 				// Higher timeout value added for worst case
> 134: 				exec.awaitTermination(1, TimeUnit.HOURS);

It may be worth to make this value configurable. IE let hte use know that how long it will allow for the background job to run.

Also, it may be worthy to actually enforce the shutdown once this delay is over. IE soemthing like that


try { 
  // allow for budget (default 1h) to process the aggregates
  if(!exec.awaitTermination(delay, delayUnit)) {
    exec.shutdownNow();
    // last grace period
    if (!pool.awaitTermination(1, TimeUnit.MINUTES)) {
      // report an issue with the pool
    }
  }
} catch (InterruptedException e) {
  Thread.currentThread().interrupt();
}


Also I think this code could moved in the same scope as the shutdown call.

-------------

Changes requested by bric3 at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jmc/pull/248

From github.com+803621+bric3 at openjdk.java.net  Mon May 17 15:53:41 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 May 2021 15:53:41 GMT
Subject: RFR: 7242: Adding new JDK Events to core API [v2]
In-Reply-To: <jY4eGLWXfB18rVqAOY0L1VB2m1hu-R1nLC3pW0TQHHM=.44901abb-7634-404e-a3d5-47c3ca4539e6@github.com>
References: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
 <jY4eGLWXfB18rVqAOY0L1VB2m1hu-R1nLC3pW0TQHHM=.44901abb-7634-404e-a3d5-47c3ca4539e6@github.com>
Message-ID: <A6g-YfNrOHDNh6Hw0L_TlctmKgYdJ7ZyardL4lh3xzk=.7dec3fc5-2032-4c0e-8c6d-bef174bd328d@github.com>

On Sun, 2 May 2021 15:40:21 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR will address these missing events and add them to core API.
>> 
>> jdk.ThreadCPULoad
>> 
>> jdk.NativeMethodSample
>> 
>> jdk.ThreadStart
>> 
>> jdk.ThreadEnd
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing formatting errors in core

Changes requested by bric3 at github.com (no known OpenJDK username).

core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties line 452:

> 450: ATTR_SYSTEM_LOAD_DESC=CPU used by Thread in System mode
> 451: ATTR_USER_LOAD=User Mode CPU Load
> 452: ATTR_USER_LOAD_DESC=CPU used by Thread in User mode

I think this files misses the `ATTR_JAVA_THREAD` and `ATTR_JAVA_THREAD_DESC`.

Also shouldn't this file be sorted alphabetically ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/245

From hdafgard at openjdk.java.net  Mon May 17 20:33:42 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Mon, 17 May 2021 20:33:42 GMT
Subject: RFR: 7235: Some writer cleanup
In-Reply-To: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
References: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
Message-ID: <6XrMRjxWimVGntEqoOvqhY_SYysqWyMuvZqNuBPE8WI=.1ce3b28b-c282-41dd-b0a4-36736a9707f3@github.com>

On Thu, 8 Apr 2021 19:47:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Just getting rid of a few annoying warnings. I'll add an issue once JBS is up again.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/237

From hdafgard at openjdk.java.net  Mon May 17 20:34:37 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Mon, 17 May 2021 20:34:37 GMT
Subject: RFR: 7236: Adding project specific settings to ignore forbidden
 references
In-Reply-To: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
References: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
Message-ID: <iaFplTBCQoaIAtLAg9utzFq2nHYBg2a2Zm9kxoYBrFo=.c00a53dc-9e1a-449f-97ff-bd2543526638@github.com>

On Thu, 8 Apr 2021 19:25:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Since JBS is down for maintenance, I'll add an issue once it's up and happy again.
> 
> Update: added issue.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/236

From hirt at openjdk.java.net  Mon May 17 20:39:39 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 17 May 2021 20:39:39 GMT
Subject: Integrated: 7235: Some writer cleanup
In-Reply-To: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
References: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com>
Message-ID: <T6yJqIYE-eLQGAbdAzcrCWK8iVJCtupgf4pg5xnp17A=.31d5003d-c8cf-44a5-bebf-3972fab8c74a@github.com>

On Thu, 8 Apr 2021 19:47:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Just getting rid of a few annoying warnings. I'll add an issue once JBS is up again.

This pull request has now been integrated.

Changeset: 278a95f5
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/278a95f58caedf213990d8a80369177794dc51e8
Stats:     5 lines in 3 files changed: 0 ins; 5 del; 0 mod

7235: Some writer cleanup

Reviewed-by: jbachorik, hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/237

From hirt at openjdk.java.net  Mon May 17 20:41:06 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 17 May 2021 20:41:06 GMT
Subject: Integrated: 7236: Adding project specific settings to ignore
 forbidden references
In-Reply-To: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
References: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com>
Message-ID: <DyvlsB36k-3wzRbGRiZU9Q9ICf2QpAW4vv1coFk8VA8=.3af338e1-a939-4707-b4e2-d01851dcc57e@github.com>

On Thu, 8 Apr 2021 19:25:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Since JBS is down for maintenance, I'll add an issue once it's up and happy again.
> 
> Update: added issue.

This pull request has now been integrated.

Changeset: 9829c205
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/9829c205fc0e36e45150731397961b9f48b36076
Stats:     102 lines in 1 file changed: 102 ins; 0 del; 0 mod

7236: Adding project specific settings to ignore forbidden references

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/236

From github.com+803621+bric3 at openjdk.java.net  Tue May 18 12:01:42 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Tue, 18 May 2021 12:01:42 GMT
Subject: Integrated: 7195: GC confguration with GC Flags
In-Reply-To: <UW6K-vra98W01Y32u_rUuwkdKIr2xf7w32tsIW3YZ9o=.18740ceb-47f2-4a10-9a7d-93211a7785d9@github.com>
References: <UW6K-vra98W01Y32u_rUuwkdKIr2xf7w32tsIW3YZ9o=.18740ceb-47f2-4a10-9a7d-93211a7785d9@github.com>
Message-ID: <lrqwZzbck2xz5r9qyI5ZjDZuCCPrCQMn6Sy93P6y2WY=.56265be8-f10f-45a2-af17-08beadf6bf5b@github.com>

On Thu, 18 Mar 2021 16:30:12 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

> This pull request proposes to display related garbage collector flags.
> 
> **Motivation**
> 
> When turning the GC flag knobs, it is useful to be able to quickly see
> the GC configuration, however the _GC configuration_ page only show 3 
> events, if one wants to have a look at flags he has to either check
> the command line or inspect the _JVM internal_ page to find relevant
> GC flags. Therefore having these flags right there is useful to get
> a quick picture of the current configuration.
> 
> **Current limitations**
> 
> 1. At this time the selected flags depends on the GC algorithm which is 
>    derived from the name of the old collector name. This is simple, 
>    however it prevents to identify EpsilonGC because whose old 
>    collector name is `SerialOld`, which is the same as SerialGC.
> 
> 2. There are some global flags in `gc/shared/gc_globals.hpp` that 
>    I didn't include as I didn't use most of them. I'm not sure these 
>    flags are seen much in the wild.
> 
> 
> **Remarks**
> 
> As mentionned above the use of the OldCollector name may not be the 
> best choice, I would like to refactor this part to use the `Use*GC`
> flags instead. I am a bit unsure at this time how to use the 
> existing API.

This pull request has now been integrated.

Changeset: 39643ce2
Author:    Brice Dutheil <brice.dutheil at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/39643ce237db1dd313b34d1c6dcd0cda91893038
Stats:     309 lines in 4 files changed: 256 ins; 1 del; 52 mod

7195: GC confguration with GC Flags

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/230

From hirt at openjdk.java.net  Thu May 20 11:55:33 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 May 2021 11:55:33 GMT
Subject: RFR: 7167: Agent Plugin [v6]
In-Reply-To: <81i7tInHHp-rf5jdplOH3TaSatjsumQ-64cgxQejyuI=.2da150e4-3cc5-4b2f-a542-ed9afee1adcc@github.com>
References: <QGKLF-w0YM4ZwpdYCYqWQcVi3EH9N8BPWkydUBR51sg=.04d0f4e1-8b01-4d85-b4c9-655b538deb92@github.com>
 <81i7tInHHp-rf5jdplOH3TaSatjsumQ-64cgxQejyuI=.2da150e4-3cc5-4b2f-a542-ed9afee1adcc@github.com>
Message-ID: <Pg5hk6ee8DoHu0umWMJr8b179EPkCkoMnxl7oGkUAM8=.14ca1d6f-a74d-42ac-89f7-3f0f7ef1212f@github.com>

On Wed, 28 Apr 2021 17:57:17 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix rcp feature to use new agent plugin name

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/226

From schaturvedi at openjdk.java.net  Thu May 20 14:34:50 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 20 May 2021 14:34:50 GMT
Subject: RFR: 7242: Adding new JDK Events to core API [v3]
In-Reply-To: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
References: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
Message-ID: <4yT_vlqrgK0Caw-Vu-HqeTdXMQFAFTtZNV8Eeo59oKg=.8ae3c2f4-812e-430d-8fbc-323ee549be9b@github.com>

> This PR will address these missing events and add them to core API.
> 
> jdk.ThreadCPULoad
> 
> jdk.NativeMethodSample
> 
> jdk.ThreadStart
> 
> jdk.ThreadEnd

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Added values in message properties file

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/245/files
  - new: https://git.openjdk.java.net/jmc/pull/245/files/600d38cf..da971145

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=01-02

  Stats: 10 lines in 1 file changed: 6 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/245.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245

PR: https://git.openjdk.java.net/jmc/pull/245

From schaturvedi at openjdk.java.net  Thu May 20 14:47:32 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 20 May 2021 14:47:32 GMT
Subject: RFR: 7242: Adding new JDK Events to core API [v2]
In-Reply-To: <A6g-YfNrOHDNh6Hw0L_TlctmKgYdJ7ZyardL4lh3xzk=.7dec3fc5-2032-4c0e-8c6d-bef174bd328d@github.com>
References: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
 <jY4eGLWXfB18rVqAOY0L1VB2m1hu-R1nLC3pW0TQHHM=.44901abb-7634-404e-a3d5-47c3ca4539e6@github.com>
 <A6g-YfNrOHDNh6Hw0L_TlctmKgYdJ7ZyardL4lh3xzk=.7dec3fc5-2032-4c0e-8c6d-bef174bd328d@github.com>
Message-ID: <bhm_StT2tX1s5OcbA9hTQYMF1rdw0P46Jeq6YTA3yT0=.2f105b82-6aa7-47cf-8354-f777fd6da914@github.com>

On Mon, 17 May 2021 15:49:22 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing formatting errors in core
>
> core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties line 452:
> 
>> 450: ATTR_SYSTEM_LOAD_DESC=CPU used by Thread in System mode
>> 451: ATTR_USER_LOAD=User Mode CPU Load
>> 452: ATTR_USER_LOAD_DESC=CPU used by Thread in User mode
> 
> I think this files misses the `ATTR_JAVA_THREAD` and `ATTR_JAVA_THREAD_DESC`.
> 
> Also shouldn't this file be sorted alphabetically ?

Thanks for pointing it out. I have added that in recent commit. Regarding alphabetical sorting I have checked the file its like all ATTR_* are grouped together and then it has all AGGR_* so I have added these new values with ATTR_*. I hope that's fine.

-------------

PR: https://git.openjdk.java.net/jmc/pull/245

From schaturvedi at openjdk.java.net  Thu May 20 18:44:42 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 20 May 2021 18:44:42 GMT
Subject: RFR: 7242: Adding new JDK Events to core API [v4]
In-Reply-To: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
References: <xjcefiOX5P-_el5Z_-tR-fOZe85bXX4srDT77Vs6pNk=.e7e5540e-e192-41a2-91e3-a3d885df0c98@github.com>
Message-ID: <iyZB-4LHzi0rGUfKu7z7v0E5stmoePB8sYpH2GbrpwM=.00f152f6-7ca0-4605-81a7-a8fdb9b2df93@github.com>

> This PR will address these missing events and add them to core API.
> 
> jdk.ThreadCPULoad
> 
> jdk.NativeMethodSample
> 
> jdk.ThreadStart
> 
> jdk.ThreadEnd

Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Merge master
 - Added values in message properties file
 - Fixing formatting errors in core
 - Fixed spotbugs errors
 - 7242: Adding new JDK Events to core API

-------------

Changes: https://git.openjdk.java.net/jmc/pull/245/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=245&range=03
  Stats: 27 lines in 5 files changed: 25 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/245.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/245/head:pull/245

PR: https://git.openjdk.java.net/jmc/pull/245

From aptmac at openjdk.java.net  Thu May 20 21:36:51 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 20 May 2021 21:36:51 GMT
Subject: RFR: 7070: Allow JMC to open compressed recordings with the extension
 .lz4
Message-ID: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>

This one-worder addresses JMC-7070 [[0]](https://bugs.openjdk.java.net/browse/JMC-7070), in which LZ4 compressed files cannot be opened while having the file extension ".

JMC-6701 added support for opening jfr files that were compressed using lz4 [[0]](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b). The functionality works, however the file association was not updated to include files ending in ".lz4" for flight recording files, so these compressed recordings must still be supplied with the file ending of ".jfr". This isn't ideal, because the default behaviour of `lz4` is to append ".lz4" to the end of the supplied file; in my example I have a file called `lol.jfr`, which when compressed becomes `lol.jfr.lz4` and cannot be opened by JMC without manually renaming it.

This one-word fix adds the file extension "lz4" to the extension list in `flightrecorder.ui`'s `plugin.xml` for `JfrEditor`, so that supplying a `*.lz4` file will result in trying to open a JfrEditor page.

[0] https://bugs.openjdk.java.net/browse/JMC-7070
[1] https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b

### Before:
- LZ4 does not exist as a valid file extension in the open file dialog
![0-before-opening](https://user-images.githubusercontent.com/10425301/119050175-7c314e00-b98f-11eb-91e6-540b8303d61b.png)
- LZ4 does not have a valid file association in the preferences
![1-before-file-associations](https://user-images.githubusercontent.com/10425301/119050200-82272f00-b98f-11eb-99cd-c102729cae8a.png)
- Dialog pops up complaining that no editor is associated with the file ending "lz4"
![2-before-opening](https://user-images.githubusercontent.com/10425301/119050186-7fc4d500-b98f-11eb-9cc3-cb37de6add2d.png)

### After:
- LZ4 is listed as a valid extension in the open file dialog
![2021-05-20-171807_192x239_scrot](https://user-images.githubusercontent.com/10425301/119050233-8fdcb480-b98f-11eb-873a-251e09d6a8ad.png)
- LZ4 appears as a valid file extension in the preferences
![3-after-file-associations](https://user-images.githubusercontent.com/10425301/119050237-91a67800-b98f-11eb-9d86-3645bf5ff752.png)
- Opening a LZ4 compressed recording works
![4-after-opened](https://user-images.githubusercontent.com/10425301/119050244-9539ff00-b98f-11eb-83fa-262fe47b2af7.png)

-------------

Commit messages:
 - 7070: Allow JMC to open compressed recordings with the extension .lz4

Changes: https://git.openjdk.java.net/jmc/pull/250/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=250&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7070
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/250.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/250/head:pull/250

PR: https://git.openjdk.java.net/jmc/pull/250

From github.com+803621+bric3 at openjdk.java.net  Fri May 21 11:54:30 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Fri, 21 May 2021 11:54:30 GMT
Subject: RFR: 7070: Allow JMC to open compressed recordings with the
 extension .lz4
In-Reply-To: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
References: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
Message-ID: <3wHdJN75L20e-u5drlZdFEYXUDXbNIQhSDhsiuhNDMg=.a51ecfa6-00ae-4029-aca2-28c7039a6821@github.com>

On Thu, 20 May 2021 21:32:39 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This one-worder addresses JMC-7070 [[0]](https://bugs.openjdk.java.net/browse/JMC-7070), in which LZ4 compressed files cannot be opened while having the file extension ".lz4"
> 
> JMC-6701 added support for opening jfr files that were compressed using lz4 [[0]](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b). The functionality works, however the file association was not updated to include files ending in ".lz4" for flight recording files, so these compressed recordings must still be supplied with the file ending of ".jfr". This isn't ideal, because the default behaviour of `lz4` is to append ".lz4" to the end of the supplied file; in my example I have a file called `lol.jfr`, which when compressed becomes `lol.jfr.lz4` and cannot be opened by JMC without manually renaming it.
> 
> This one-word fix adds the file extension "lz4" to the extension list in `flightrecorder.ui`'s `plugin.xml` for `JfrEditor`, so that supplying a `*.lz4` file will result in trying to open a JfrEditor page.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7070
> [1] https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b
> 
> ### Before:
> - LZ4 does not exist as a valid file extension in the open file dialog
> ![0-before-opening](https://user-images.githubusercontent.com/10425301/119050175-7c314e00-b98f-11eb-91e6-540b8303d61b.png)
> - LZ4 does not have a valid file association in the preferences
> ![1-before-file-associations](https://user-images.githubusercontent.com/10425301/119050200-82272f00-b98f-11eb-99cd-c102729cae8a.png)
> - Dialog pops up complaining that no editor is associated with the file ending "lz4"
> ![2-before-opening](https://user-images.githubusercontent.com/10425301/119050186-7fc4d500-b98f-11eb-9cc3-cb37de6add2d.png)
> 
> ### After:
> - LZ4 is listed as a valid extension in the open file dialog
> ![2021-05-20-171807_192x239_scrot](https://user-images.githubusercontent.com/10425301/119050233-8fdcb480-b98f-11eb-873a-251e09d6a8ad.png)
> - LZ4 appears as a valid file extension in the preferences
> ![3-after-file-associations](https://user-images.githubusercontent.com/10425301/119050237-91a67800-b98f-11eb-9d86-3645bf5ff752.png)
> - Opening a LZ4 compressed recording works
> ![4-after-opened](https://user-images.githubusercontent.com/10425301/119050244-9539ff00-b98f-11eb-83fa-262fe47b2af7.png)

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/250

From hirt at openjdk.java.net  Fri May 21 14:01:43 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 May 2021 14:01:43 GMT
Subject: RFR: 7070: Allow JMC to open compressed recordings with the
 extension .lz4
In-Reply-To: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
References: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
Message-ID: <Xnbx-Oor5QNvJenJtYRV08qU3yazz1_2z_QzAvDhS-0=.97dc2cf1-805a-43dd-beb4-7e1ef3e92634@github.com>

On Thu, 20 May 2021 21:32:39 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This one-worder addresses JMC-7070 [[0]](https://bugs.openjdk.java.net/browse/JMC-7070), in which LZ4 compressed files cannot be opened while having the file extension ".lz4"
> 
> JMC-6701 added support for opening jfr files that were compressed using lz4 [[0]](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b). The functionality works, however the file association was not updated to include files ending in ".lz4" for flight recording files, so these compressed recordings must still be supplied with the file ending of ".jfr". This isn't ideal, because the default behaviour of `lz4` is to append ".lz4" to the end of the supplied file; in my example I have a file called `lol.jfr`, which when compressed becomes `lol.jfr.lz4` and cannot be opened by JMC without manually renaming it.
> 
> This one-word fix adds the file extension "lz4" to the extension list in `flightrecorder.ui`'s `plugin.xml` for `JfrEditor`, so that supplying a `*.lz4` file will result in trying to open a JfrEditor page.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7070
> [1] https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b
> 
> ### Before:
> - LZ4 does not exist as a valid file extension in the open file dialog
> ![0-before-opening](https://user-images.githubusercontent.com/10425301/119050175-7c314e00-b98f-11eb-91e6-540b8303d61b.png)
> - LZ4 does not have a valid file association in the preferences
> ![1-before-file-associations](https://user-images.githubusercontent.com/10425301/119050200-82272f00-b98f-11eb-99cd-c102729cae8a.png)
> - Dialog pops up complaining that no editor is associated with the file ending "lz4"
> ![2-before-opening](https://user-images.githubusercontent.com/10425301/119050186-7fc4d500-b98f-11eb-9cc3-cb37de6add2d.png)
> 
> ### After:
> - LZ4 is listed as a valid extension in the open file dialog
> ![2021-05-20-171807_192x239_scrot](https://user-images.githubusercontent.com/10425301/119050233-8fdcb480-b98f-11eb-873a-251e09d6a8ad.png)
> - LZ4 appears as a valid file extension in the preferences
> ![3-after-file-associations](https://user-images.githubusercontent.com/10425301/119050237-91a67800-b98f-11eb-9d86-3645bf5ff752.png)
> - Opening a LZ4 compressed recording works
> ![4-after-opened](https://user-images.githubusercontent.com/10425301/119050244-9539ff00-b98f-11eb-83fa-262fe47b2af7.png)

Marked as reviewed by hirt (Lead).

I think we should run with it for now. AFAIK no standard plug-in included in the Eclipse IDE distributions will use the lz4 extension. Also, it's becoming less common to run the Eclipse plug-in version of JMC.

-------------

PR: https://git.openjdk.java.net/jmc/pull/250

From egahlin at openjdk.java.net  Fri May 21 14:02:03 2021
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Fri, 21 May 2021 14:02:03 GMT
Subject: RFR: 7070: Allow JMC to open compressed recordings with the
 extension .lz4
In-Reply-To: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
References: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
Message-ID: <RpyPrzm8_8gcLyxhcmE0-QHnrNjNTi5aE9NtFmS7VkQ=.8cea23bc-ac04-413b-9a19-3711706e1c46@github.com>

On Thu, 20 May 2021 21:32:39 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This one-worder addresses JMC-7070 [[0]](https://bugs.openjdk.java.net/browse/JMC-7070), in which LZ4 compressed files cannot be opened while having the file extension ".lz4"
> 
> JMC-6701 added support for opening jfr files that were compressed using lz4 [[0]](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b). The functionality works, however the file association was not updated to include files ending in ".lz4" for flight recording files, so these compressed recordings must still be supplied with the file ending of ".jfr". This isn't ideal, because the default behaviour of `lz4` is to append ".lz4" to the end of the supplied file; in my example I have a file called `lol.jfr`, which when compressed becomes `lol.jfr.lz4` and cannot be opened by JMC without manually renaming it.
> 
> This one-word fix adds the file extension "lz4" to the extension list in `flightrecorder.ui`'s `plugin.xml` for `JfrEditor`, so that supplying a `*.lz4` file will result in trying to open a JfrEditor page.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7070
> [1] https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b
> 
> ### Before:
> - LZ4 does not exist as a valid file extension in the open file dialog
> ![0-before-opening](https://user-images.githubusercontent.com/10425301/119050175-7c314e00-b98f-11eb-91e6-540b8303d61b.png)
> - LZ4 does not have a valid file association in the preferences
> ![1-before-file-associations](https://user-images.githubusercontent.com/10425301/119050200-82272f00-b98f-11eb-99cd-c102729cae8a.png)
> - Dialog pops up complaining that no editor is associated with the file ending "lz4"
> ![2-before-opening](https://user-images.githubusercontent.com/10425301/119050186-7fc4d500-b98f-11eb-9cc3-cb37de6add2d.png)
> 
> ### After:
> - LZ4 is listed as a valid extension in the open file dialog
> ![2021-05-20-171807_192x239_scrot](https://user-images.githubusercontent.com/10425301/119050233-8fdcb480-b98f-11eb-873a-251e09d6a8ad.png)
> - LZ4 appears as a valid file extension in the preferences
> ![3-after-file-associations](https://user-images.githubusercontent.com/10425301/119050237-91a67800-b98f-11eb-9d86-3645bf5ff752.png)
> - Opening a LZ4 compressed recording works
> ![4-after-opened](https://user-images.githubusercontent.com/10425301/119050244-9539ff00-b98f-11eb-83fa-262fe47b2af7.png)

Many years ago I looked into using multiple file associations for JMC, but it had to work (without conflicts) when using JMC as an Eclipse plug-in as well. I don't think ".lz4" is used in Eclipse + common plug-ins, but it is an aspect to consider.

-------------

PR: https://git.openjdk.java.net/jmc/pull/250

From aptmac at openjdk.java.net  Fri May 21 16:20:58 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 21 May 2021 16:20:58 GMT
Subject: RFR: 7070: Allow JMC to open compressed recordings with the
 extension .lz4
In-Reply-To: <RpyPrzm8_8gcLyxhcmE0-QHnrNjNTi5aE9NtFmS7VkQ=.8cea23bc-ac04-413b-9a19-3711706e1c46@github.com>
References: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
 <RpyPrzm8_8gcLyxhcmE0-QHnrNjNTi5aE9NtFmS7VkQ=.8cea23bc-ac04-413b-9a19-3711706e1c46@github.com>
Message-ID: <Uk-JM4g8RGw11KF3zNxF_0mVJ1HUI_rkkN_Ychozl34=.ad1b6b54-f7c8-4c34-9a3b-8e13b0acf822@github.com>

On Fri, 21 May 2021 12:50:13 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Many years ago I looked into using multiple file associations for JMC, but it had to work (without conflicts) when using JMC as an Eclipse plug-in as well. I don't think ".lz4" is used in Eclipse + common plug-ins, but it is an aspect to consider.

Thanks for the heads up. I tried using the JMC run configuration for eclipse and plugins, and it seemed to still work okay.

Eclipse:
![eclipse-jmc-lz4](https://user-images.githubusercontent.com/10425301/119168007-73dc2000-ba2e-11eb-9b04-99e3d370425e.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/250

From aptmac at openjdk.java.net  Fri May 21 19:21:58 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 21 May 2021 19:21:58 GMT
Subject: Integrated: 7070: Allow JMC to open compressed recordings with the
 extension .lz4
In-Reply-To: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
References: <ov13_OrYhR1P3njy7rZ3U5-p-IdfNNj_mUNDWw286WQ=.3ee71a61-20a2-469e-9344-ec7dc069bd98@github.com>
Message-ID: <S_YIVrHn3sU5BTNHoAURl44XtEsppJgSUfy4IuO8_5w=.fcd9abc4-fa2e-4849-bfd6-785ac02b8987@github.com>

On Thu, 20 May 2021 21:32:39 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This one-worder addresses JMC-7070 [[0]](https://bugs.openjdk.java.net/browse/JMC-7070), in which LZ4 compressed files cannot be opened while having the file extension ".lz4"
> 
> JMC-6701 added support for opening jfr files that were compressed using lz4 [[0]](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b). The functionality works, however the file association was not updated to include files ending in ".lz4" for flight recording files, so these compressed recordings must still be supplied with the file ending of ".jfr". This isn't ideal, because the default behaviour of `lz4` is to append ".lz4" to the end of the supplied file; in my example I have a file called `lol.jfr`, which when compressed becomes `lol.jfr.lz4` and cannot be opened by JMC without manually renaming it.
> 
> This one-word fix adds the file extension "lz4" to the extension list in `flightrecorder.ui`'s `plugin.xml` for `JfrEditor`, so that supplying a `*.lz4` file will result in trying to open a JfrEditor page.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7070
> [1] https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b
> 
> ### Before:
> - LZ4 does not exist as a valid file extension in the open file dialog
> ![0-before-opening](https://user-images.githubusercontent.com/10425301/119050175-7c314e00-b98f-11eb-91e6-540b8303d61b.png)
> - LZ4 does not have a valid file association in the preferences
> ![1-before-file-associations](https://user-images.githubusercontent.com/10425301/119050200-82272f00-b98f-11eb-99cd-c102729cae8a.png)
> - Dialog pops up complaining that no editor is associated with the file ending "lz4"
> ![2-before-opening](https://user-images.githubusercontent.com/10425301/119050186-7fc4d500-b98f-11eb-9cc3-cb37de6add2d.png)
> 
> ### After:
> - LZ4 is listed as a valid extension in the open file dialog
> ![2021-05-20-171807_192x239_scrot](https://user-images.githubusercontent.com/10425301/119050233-8fdcb480-b98f-11eb-873a-251e09d6a8ad.png)
> - LZ4 appears as a valid file extension in the preferences
> ![3-after-file-associations](https://user-images.githubusercontent.com/10425301/119050237-91a67800-b98f-11eb-9d86-3645bf5ff752.png)
> - Opening a LZ4 compressed recording works
> ![4-after-opened](https://user-images.githubusercontent.com/10425301/119050244-9539ff00-b98f-11eb-83fa-262fe47b2af7.png)

This pull request has now been integrated.

Changeset: 713f93eb
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/713f93eb843a7bf372f6b962d38a70dae27afa15
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7070: Allow JMC to open compressed recordings with the extension .lz4

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/250

From schaturvedi at openjdk.java.net  Wed May 26 13:20:15 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 26 May 2021 13:20:15 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule.
In-Reply-To: <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
 <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
Message-ID: <vXvJemqDdMB3c28EsUYq4rZBlGyBlN17oSKsh2uXK-w=.0c147ce4-152a-4528-9250-20fd19bb8296@github.com>

On Mon, 17 May 2021 15:45:24 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> This PR addresses the optimization of Class Leak Rule.
>> 
>> Please refer the JBS for the sample JFR which was taking ~90 minutes to generate results for Class Leak Rule. After the optimization time is reduced to ~10-15 minutes.
>> 
>> Please review the change and let me the know if there are any comments / suggestions.
>
> Hi,
> 
> I believe the executor code has some issues that should be tackled.

Hi @bric3 thanks for your review. Looks like we need to redesign this rule because 15 min is too much time in itself to calculate rule results. I tried Stream::parallelStream approach as well but unfortunately that is taking around 25-30 min which is unacceptable. So I will look into it again.

-------------

PR: https://git.openjdk.java.net/jmc/pull/248

From github.com+28612+gunnarmorling at openjdk.java.net  Wed May 26 19:52:17 2021
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 26 May 2021 19:52:17 GMT
Subject: RFR: 7259: README.md should mention that the build script works for
 Mac OS
Message-ID: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>

Found that the build.sh script works on macOS, too.

-------------

Commit messages:
 - Update README.md

Changes: https://git.openjdk.java.net/jmc/pull/251/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=251&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7259
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/251.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/251/head:pull/251

PR: https://git.openjdk.java.net/jmc/pull/251

From hirt at openjdk.java.net  Wed May 26 19:52:17 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 26 May 2021 19:52:17 GMT
Subject: RFR: 7259: README.md should mention that the build script works
 for Mac OS
In-Reply-To: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
References: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
Message-ID: <NYU8wkpK-pQ-1XvFLwqDwQ5kQfzqClfMJjhj27bBs-Y=.0fd50acc-d093-4df1-8950-83c9e5af6a6f@github.com>

On Mon, 24 May 2021 08:38:59 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> Found that the build.sh script works on macOS, too.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/251

From github.com+28612+gunnarmorling at openjdk.java.net  Wed May 26 19:52:17 2021
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 26 May 2021 19:52:17 GMT
Subject: RFR: 7259: README.md should mention that the build script works
 for Mac OS
In-Reply-To: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
References: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
Message-ID: <5m3igRkLpAf1frXvVlqhphgcGOI8xze-wy5Ea9ignQ0=.483ae55d-2d46-4542-8e77-e470780c4e9e@github.com>

On Mon, 24 May 2021 08:38:59 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> Found that the build.sh script works on macOS, too.

@thegreystone That's a quick one to review ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/251

From github.com+803621+bric3 at openjdk.java.net  Thu May 27 09:44:07 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Thu, 27 May 2021 09:44:07 GMT
Subject: RFR: 7167: Agent Plugin [v6]
In-Reply-To: <81i7tInHHp-rf5jdplOH3TaSatjsumQ-64cgxQejyuI=.2da150e4-3cc5-4b2f-a542-ed9afee1adcc@github.com>
References: <QGKLF-w0YM4ZwpdYCYqWQcVi3EH9N8BPWkydUBR51sg=.04d0f4e1-8b01-4d85-b4c9-655b538deb92@github.com>
 <81i7tInHHp-rf5jdplOH3TaSatjsumQ-64cgxQejyuI=.2da150e4-3cc5-4b2f-a542-ed9afee1adcc@github.com>
Message-ID: <Kz_WmZr4L5YPxYpfBl-n0I0s7SNvv_NZbAj2VZQ3bWc=.0e7be013-53d3-4a6d-bbc2-3967fb516703@github.com>

On Wed, 28 Apr 2021 17:57:17 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets.
>> 
>> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :)
>
> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix rcp feature to use new agent plugin name

This is a big PR !
There's a few nitpick around non localisable strings, that might be worth checking.
I think I'll build JMC to see it in action ;)

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/manager/model/PresetRepositoryFactory.java line 85:

> 83: 		for (File file : files) {
> 84: 			if (file.length() == 0) {
> 85: 				// FIXME: delete or just ignore empty files? 

Maybe ignore empty files but report them in a logger ?

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlDocumentProvider.java line 74:

> 72: 		if (!out.exists()) {
> 73: 			try {
> 74: 				out.createNewFile();

I am not really aware of how `ei.getStorage().getFullPath()`, but could there be non-existant folders as well ?
Additionnally the code here could use `Files.*` methods.

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlDocumentProvider.java line 81:

> 79: 		}
> 80: 
> 81: 		try (FileOutputStream fos = new FileOutputStream(out)) {

I think the FOS should be decorated by a `BufferedOutputStream`.

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlDocumentProvider.java line 82:

> 80: 
> 81: 		try (FileOutputStream fos = new FileOutputStream(out)) {
> 82: 			fos.write(document.get().getBytes()); // TODO: encoding?

Yes I think the code should impose UTF-8, this is better for XML.

application/org.openjdk.jmc.console.agent/src/main/java/org/openjdk/jmc/console/agent/raweditor/internal/XmlPartitionScanner.java line 44:

> 42: public class XmlPartitionScanner extends RuleBasedPartitionScanner {
> 43: 	public final static String XML_COMMENT = "__xml_comment";
> 44: 	public final static String XML_TAG = "__xml_tag";

SHouldn't those be commented by `//$NON-NLS-1$`

configuration/spotbugs/spotbugs-exclude.xml line 85:

> 83: 		<Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
> 84: 	</Match>
> 85: 	

Tabulation instead of spaces in this file

-------------

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jmc/pull/226

From github.com+803621+bric3 at openjdk.java.net  Thu May 27 10:10:05 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Thu, 27 May 2021 10:10:05 GMT
Subject: RFR: 7259: README.md should mention that the build script works
 for Mac OS
In-Reply-To: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
References: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
Message-ID: <moj1RG6TT2rMCr-w4jC3yKiqqEWgbOOXgh_oD4ANZ10=.17fef458-fd06-4ded-b304-9c568c40143f@github.com>

On Mon, 24 May 2021 08:38:59 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> Found that the build.sh script works on macOS, too.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/251

From reinhapa at openjdk.java.net  Thu May 27 18:54:14 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 27 May 2021 18:54:14 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
Message-ID: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>

Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Commit messages:
 - JMC-7258: Use the public XLST classes for the release notes

Changes: https://git.openjdk.java.net/jmc/pull/252/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=252&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7258
  Stats: 77 lines in 1 file changed: 75 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/252.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/252/head:pull/252

PR: https://git.openjdk.java.net/jmc/pull/252

From reinhapa at openjdk.java.net  Thu May 27 19:24:18 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 27 May 2021 19:24:18 GMT
Subject: RFR: JMC-7261: Enhance agent pom.xml for future library deployment
Message-ID: <3GIb8tldehpZGfu3D6tdN0KheVAICDwenThseG47jOU=.e43fb392-fab2-4d24-8cf2-a44c93caf5a0@github.com>

Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Commit messages:
 - JMC-7261: Enhance agent pom.xml for future library deployment

Changes: https://git.openjdk.java.net/jmc/pull/253/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=253&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7261
  Stats: 48 lines in 1 file changed: 46 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/253.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/253/head:pull/253

PR: https://git.openjdk.java.net/jmc/pull/253

From hirt at openjdk.java.net  Thu May 27 20:11:10 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 27 May 2021 20:11:10 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
In-Reply-To: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
Message-ID: <Ow0vgmvp86Z8Lxey_eRpkSuayqnaFif7CGdtC22fZjs=.ecd8c3ae-ec19-4145-8877-a810efcbb21f@github.com>

On Thu, 27 May 2021 18:50:34 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 60:

> 58: 
> 59: 	public static void main(String[] args) {
> 60: 		final ArrayDeque<String> deque = new ArrayDeque<>(Arrays.asList(args));

Style: Deque<String> deque = ...

releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 64:

> 62: 		Path outputFile = null;
> 63: 		Path sylesheetFile = null;
> 64: 		for (; !deque.isEmpty();) {

Personally, I kinda prefer while(!deque.isEmpty()) - less semicolons - but that's just my personal preference.

-------------

PR: https://git.openjdk.java.net/jmc/pull/252

From github.com+28612+gunnarmorling at openjdk.java.net  Thu May 27 20:13:05 2021
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 27 May 2021 20:13:05 GMT
Subject: Integrated: 7259: README.md should mention that the build script
 works for Mac OS
In-Reply-To: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
References: <GTz8ahU4dVj7KY60ThDk2SV0goo1MeD71skHwBLVrZs=.81411473-8e1c-4704-ae13-df86f83d3847@github.com>
Message-ID: <ZJ6l8FaPwLBlLGtgShfRB_S-YFiuejFV4vagXOeABow=.9f2d52e2-208e-469f-9303-f455223f3611@github.com>

On Mon, 24 May 2021 08:38:59 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> Found that the build.sh script works on macOS, too.

This pull request has now been integrated.

Changeset: b273c968
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/b273c9688467d27af80f92ab5546f1fe7f5f17fd
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7259: README.md should mention that the build script works for Mac OS

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/251

From reinhapa at openjdk.java.net  Thu May 27 20:28:23 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 27 May 2021 20:28:23 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
 [v2]
In-Reply-To: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
Message-ID: <5bvbBH9W0Z_VY-zE4LiUPwhobNTyeESGg35qXpibleI=.e6371186-f214-4969-a390-a6ef03ff317e@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has updated the pull request incrementally with one additional commit since the last revision:

  Integrated review feedback
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/252/files
  - new: https://git.openjdk.java.net/jmc/pull/252/files/3623024d..32657ecc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=252&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=252&range=00-01

  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/252.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/252/head:pull/252

PR: https://git.openjdk.java.net/jmc/pull/252

From reinhapa at openjdk.java.net  Thu May 27 20:32:06 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 27 May 2021 20:32:06 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
 [v2]
In-Reply-To: <Ow0vgmvp86Z8Lxey_eRpkSuayqnaFif7CGdtC22fZjs=.ecd8c3ae-ec19-4145-8877-a810efcbb21f@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
 <Ow0vgmvp86Z8Lxey_eRpkSuayqnaFif7CGdtC22fZjs=.ecd8c3ae-ec19-4145-8877-a810efcbb21f@github.com>
Message-ID: <1Q89oTc85iiVpuTlc4we88vSv02w5C5zV3AXGwpK19M=.46fc4782-7bad-432d-b2df-4dd52e884f41@github.com>

On Thu, 27 May 2021 20:06:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Patrick Reinhart has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Integrated review feedback
>>   
>>   Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 60:
> 
>> 58: 
>> 59: 	public static void main(String[] args) {
>> 60: 		final ArrayDeque<String> deque = new ArrayDeque<>(Arrays.asList(args));
> 
> Style: Deque<String> deque = ...

Changed, the idea was to use less imports as it is only used within this method. Would be an excellent `var` case..

> releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 64:
> 
>> 62: 		Path outputFile = null;
>> 63: 		Path sylesheetFile = null;
>> 64: 		for (; !deque.isEmpty();) {
> 
> Personally, I kinda prefer while(!deque.isEmpty()) - less semicolons - but that's just my personal preference.

Changed for you only ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/252

From hirt at openjdk.java.net  Thu May 27 20:52:11 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 27 May 2021 20:52:11 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
 [v2]
In-Reply-To: <5bvbBH9W0Z_VY-zE4LiUPwhobNTyeESGg35qXpibleI=.e6371186-f214-4969-a390-a6ef03ff317e@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
 <5bvbBH9W0Z_VY-zE4LiUPwhobNTyeESGg35qXpibleI=.e6371186-f214-4969-a390-a6ef03ff317e@github.com>
Message-ID: <llrXaP8Hhoy14TAc22UJvczGjB83whXT9t-JkNKDTBw=.bc6cc780-1c6d-4943-b72a-5613a802e1c7@github.com>

On Thu, 27 May 2021 20:28:23 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Integrated review feedback
>   
>   Signed-off-by: Patrick Reinhart <patrick at reini.net>

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/252

From hirt at openjdk.java.net  Thu May 27 20:52:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 27 May 2021 20:52:12 GMT
Subject: RFR: JMC-7258: Use the public XLST classes for the release notes
 [v2]
In-Reply-To: <1Q89oTc85iiVpuTlc4we88vSv02w5C5zV3AXGwpK19M=.46fc4782-7bad-432d-b2df-4dd52e884f41@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
 <Ow0vgmvp86Z8Lxey_eRpkSuayqnaFif7CGdtC22fZjs=.ecd8c3ae-ec19-4145-8877-a810efcbb21f@github.com>
 <1Q89oTc85iiVpuTlc4we88vSv02w5C5zV3AXGwpK19M=.46fc4782-7bad-432d-b2df-4dd52e884f41@github.com>
Message-ID: <wXZFFo9SdsvJCh_HUX89663bUWqEBGPqsZKvbzl1k-k=.8077e4f4-cfb5-4ccf-b5db-e918a0501d99@github.com>

On Thu, 27 May 2021 20:29:37 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 64:
>> 
>>> 62: 		Path outputFile = null;
>>> 63: 		Path sylesheetFile = null;
>>> 64: 		for (; !deque.isEmpty();) {
>> 
>> Personally, I kinda prefer while(!deque.isEmpty()) - less semicolons - but that's just my personal preference.
>
> Changed for you only ??

Awwww. ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/252

From reinhapa at openjdk.java.net  Fri May 28 00:24:05 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 28 May 2021 00:24:05 GMT
Subject: Integrated: JMC-7258: Use the public XLST classes for the release
 notes
In-Reply-To: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
References: <wST8bhQTJ0UmEfMdBqwd1ZgTitQlJXiwuzg0kcwjOEs=.c15d6656-8580-439a-a47f-402cc5d20eee@github.com>
Message-ID: <amwRsFkI93fJpZ8PT9TyvVTpSEBSe58NTend4h-NPWk=.89b07311-7fd5-4add-a60f-2728758883b6@github.com>

On Thu, 27 May 2021 18:50:34 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

This pull request has now been integrated.

Changeset: 6478ba9f
Author:    Patrick Reinhart <reinhapa at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/6478ba9f83a0986e50981d9e77c69dfe8f318d34
Stats:     78 lines in 1 file changed: 76 ins; 0 del; 2 mod

7258: Use the public XLST classes for the release notes

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/252

From reinhapa at openjdk.java.net  Fri May 28 04:55:14 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 28 May 2021 04:55:14 GMT
Subject: RFR: JMC-7261: Enhance agent pom.xml for future library
 deployment [v2]
In-Reply-To: <3GIb8tldehpZGfu3D6tdN0KheVAICDwenThseG47jOU=.e43fb392-fab2-4d24-8cf2-a44c93caf5a0@github.com>
References: <3GIb8tldehpZGfu3D6tdN0KheVAICDwenThseG47jOU=.e43fb392-fab2-4d24-8cf2-a44c93caf5a0@github.com>
Message-ID: <l2IlUR2QlHPXbkhSzDdBX8AMHJow5HKUrgTUP1vEudM=.8a7227e3-5426-4c83-a797-1dc5fc67898d@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  JMC-7261: Enhance agent pom.xml for future library deployment
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes: https://git.openjdk.java.net/jmc/pull/253/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=253&range=01
  Stats: 48 lines in 1 file changed: 46 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/253.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/253/head:pull/253

PR: https://git.openjdk.java.net/jmc/pull/253

From github.com+803621+bric3 at openjdk.java.net  Fri May 28 08:13:06 2021
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Fri, 28 May 2021 08:13:06 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule.
In-Reply-To: <vXvJemqDdMB3c28EsUYq4rZBlGyBlN17oSKsh2uXK-w=.0c147ce4-152a-4528-9250-20fd19bb8296@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
 <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
 <vXvJemqDdMB3c28EsUYq4rZBlGyBlN17oSKsh2uXK-w=.0c147ce4-152a-4528-9250-20fd19bb8296@github.com>
Message-ID: <JUAnqyYvgKrXTyeYCo92az3AjwZePumKKLbLRnesNDA=.84655c95-8158-4884-a06d-0d5d2c0a3067@github.com>

On Wed, 26 May 2021 13:17:20 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Hi,
>> 
>> I believe the executor code has some issues that should be tackled.
>
> Hi @bric3 thanks for your review. Looks like we need to redesign this rule because 15 min is too much time in itself to calculate rule results. I tried Stream::parallelStream approach as well but unfortunately that is taking around 25-30 min which is unacceptable. So I will look into it again.

@Suchitainf, Yes indeed this looks long, maybe be redesigning the [task](https://github.com/openjdk/jmc/pull/248/files#diff-57837560471be78246f836664b328e28ee5ed8305a4bae809aae15d571bd0634R114-R125) itself it might be possible to better leverage an FJP.

-------------

PR: https://git.openjdk.java.net/jmc/pull/248

From hirt at openjdk.java.net  Fri May 28 12:52:23 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 28 May 2021 12:52:23 GMT
Subject: RFR: 7260: Create a new serializers bundle
Message-ID: <GdqzOH5xGLQOYTLaOgyeLdHeZGqWXOprEwEcT2eUUSM=.948ce6af-f502-414d-a6de-05a6de70b130@github.com>

WIP

-------------

Commit messages:
 - Cleanup and main methods
 - Updated text and dictionary
 - Spotless
 - Fixes and cleanup
 - 7260: Create a new serializing bundle

Changes: https://git.openjdk.java.net/jmc/pull/254/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=254&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7260
  Stats: 1288 lines in 37 files changed: 769 ins; 491 del; 28 mod
  Patch: https://git.openjdk.java.net/jmc/pull/254.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/254/head:pull/254

PR: https://git.openjdk.java.net/jmc/pull/254