RFR: 7242: Adding new JDK Events to core API [v2]

Suchita Chaturvedi schaturvedi at openjdk.java.net
Thu May 20 14:47:32 UTC 2021


On Mon, 17 May 2021 15:49:22 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing formatting errors in core
>
> core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties line 452:
> 
>> 450: ATTR_SYSTEM_LOAD_DESC=CPU used by Thread in System mode
>> 451: ATTR_USER_LOAD=User Mode CPU Load
>> 452: ATTR_USER_LOAD_DESC=CPU used by Thread in User mode
> 
> I think this files misses the `ATTR_JAVA_THREAD` and `ATTR_JAVA_THREAD_DESC`.
> 
> Also shouldn't this file be sorted alphabetically ?

Thanks for pointing it out. I have added that in recent commit. Regarding alphabetical sorting I have checked the file its like all ATTR_* are grouped together and then it has all AGGR_* so I have added these new values with ATTR_*. I hope that's fine.

-------------

PR: https://git.openjdk.java.net/jmc/pull/245


More information about the jmc-dev mailing list