RFR: JMC-7258: Use the public XLST classes for the release notes [v2]

Patrick Reinhart reinhapa at openjdk.java.net
Thu May 27 20:32:06 UTC 2021


On Thu, 27 May 2021 20:06:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Patrick Reinhart has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Integrated review feedback
>>   
>>   Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 60:
> 
>> 58: 
>> 59: 	public static void main(String[] args) {
>> 60: 		final ArrayDeque<String> deque = new ArrayDeque<>(Arrays.asList(args));
> 
> Style: Deque<String> deque = ...

Changed, the idea was to use less imports as it is only used within this method. Would be an excellent `var` case..

> releng/tools/org.openjdk.jmc.util.releasenotes/src/org/openjdk/jmc/utils/releasenotes/Transform.java line 64:
> 
>> 62: 		Path outputFile = null;
>> 63: 		Path sylesheetFile = null;
>> 64: 		for (; !deque.isEmpty();) {
> 
> Personally, I kinda prefer while(!deque.isEmpty()) - less semicolons - but that's just my personal preference.

Changed for you only ��

-------------

PR: https://git.openjdk.java.net/jmc/pull/252


More information about the jmc-dev mailing list