From marcus.hirt at datadoghq.com  Mon Nov  8 14:29:51 2021
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 8 Nov 2021 15:29:51 +0100
Subject: New jmc Committer: Patrick Reinhart
Message-ID: <CAOpWGx0a=uHxU1GN3TYAjWvCpd90CuZR723kuT6-75C=VXc0SQ@mail.gmail.com>

Voting for Patrick Reinhart [1] is now closed.

Yes: 5
Veto: 0
Abstain: 0

According to the Bylaws definition of Lazy Consensus, this is
sufficient to approve the nomination.

Kind regards,
Marcus

[1] https://mail.openjdk.java.net/pipermail/jmc-dev/2021-October/004101.html

From duke at openjdk.java.net  Mon Nov  8 19:22:46 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Mon, 8 Nov 2021 19:22:46 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v3]
In-Reply-To: <n-p7eMBZyI_1FhKY7-KuJyJieglXY_FUoADyUVBkhfc=.ac1c0a7e-2a46-4ed7-a02b-416b8f053e7e@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <n-p7eMBZyI_1FhKY7-KuJyJieglXY_FUoADyUVBkhfc=.ac1c0a7e-2a46-4ed7-a02b-416b8f053e7e@github.com>
Message-ID: <gKsCfipDxE1k7eHBFobMUginnIc9pkcthAvLRfcZtSU=.423a6d44-29f7-43cd-a824-cb0c631aadb7@github.com>

On Fri, 29 Oct 2021 20:50:44 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved
>> and constant pools fully resolved to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add default for existing IParserExtension methods

I haven't CPed anything. Look at my commit history - it contains the changes from jpbempel - even if I did it differently than you propsed.
But OK, I just spent a another 2hrs to set up a another Eclipse project with jpbempels fork. The usual problems with the setup - I'll had to repeat project importing and platform reloading a lot of times until all dependencies where available. And Maven internal error from Eclipse all the time. It's a pain.
I'll continue tests within the next days.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From jpbempel at openjdk.java.net  Tue Nov  9 08:23:38 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 9 Nov 2021 08:23:38 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v3]
In-Reply-To: <n-p7eMBZyI_1FhKY7-KuJyJieglXY_FUoADyUVBkhfc=.ac1c0a7e-2a46-4ed7-a02b-416b8f053e7e@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <n-p7eMBZyI_1FhKY7-KuJyJieglXY_FUoADyUVBkhfc=.ac1c0a7e-2a46-4ed7-a02b-416b8f053e7e@github.com>
Message-ID: <W_aPUvaSZ_Qo0Att1RPXcp_2XgOl0RCfiH2zOUDIryY=.68ad638e-0e41-4988-80ef-24f48e297793@github.com>

On Fri, 29 Oct 2021 20:50:44 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved
>> and constant pools fully resolved to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add default for existing IParserExtension methods

FYI, I am reworking the PR to match better with my needs and the dependencies

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From schaturvedi at openjdk.java.net  Tue Nov  9 21:15:05 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 9 Nov 2021 21:15:05 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v3]
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Enhanced error handling

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/323/files
  - new: https://git.openjdk.java.net/jmc/pull/323/files/da3b53c5..92c3e071

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=01-02

  Stats: 11 lines in 1 file changed: 9 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/323/head:pull/323

PR: https://git.openjdk.java.net/jmc/pull/323

From schaturvedi at openjdk.java.net  Tue Nov  9 21:20:40 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 9 Nov 2021 21:20:40 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v3]
In-Reply-To: <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
Message-ID: <FSg4X_9ukk6FkJlLO7QVf_fRQmqOtEbN9a-MwNQNDM8=.033e0e9c-f5a7-453c-8fe2-34cf5f0b23b7@github.com>

On Tue, 9 Nov 2021 21:15:05 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enhanced error handling

I have enhanced the error handling for both the flows. I have tested it by creating a new twitter app which is having only read-only access and in preference added that app for my twitter username. When I tried triggering update status and send direct message I am getting below error messages.

<img width="956" alt="SendDirectMessageError" src="https://user-images.githubusercontent.com/11155712/141005969-c3bb7715-3056-411d-8401-36befc5773dc.png">

<img width="952" alt="UpdateStatusError" src="https://user-images.githubusercontent.com/11155712/141006145-e8307bdd-2c59-4d3d-bf5e-032bd4749ab4.png">

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From jpbempel at openjdk.java.net  Wed Nov 10 07:53:16 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 10 Nov 2021 07:53:16 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v4]
In-Reply-To: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
Message-ID: <gg6O1LYPf3ND4SzHXLF34VLYPzFoh9TPfa8hYEFJsY0=.7ad03c79-5f5b-4405-976f-ab78bec83f89@github.com>

> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
> 
>  * track constant pool usage inside events
>  * replace or translate symbols, method names, etc... like
> de-obfuscations of stack traces

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  added new extension methods
  
  - getId
  - eventsLoaded
  - getItemCollection to expose data gathered
  
  and exposed in IParserStats all ConstantPool extensions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/333/files
  - new: https://git.openjdk.java.net/jmc/pull/333/files/ff798074..33732c9a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=02-03

  Stats: 92 lines in 8 files changed: 70 ins; 15 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/333.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/333/head:pull/333

PR: https://git.openjdk.java.net/jmc/pull/333

From aptmac at openjdk.java.net  Wed Nov 10 16:31:47 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 10 Nov 2021 16:31:47 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v3]
In-Reply-To: <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
Message-ID: <0Yc1CMq5aR7bpn5Py1C8JKbyhyI-qiZ6PLoBTjtQwxs=.88fba139-2abd-4f3d-98c7-9f586912a997@github.com>

On Tue, 9 Nov 2021 21:15:05 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enhanced error handling

It looks good! I added a couple comments mentioning that it'd be nice to include the error code along with the dialog.

Also, there are quite a few strings that could be externalized, it would be nice to pull them into a Messages class

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterPlugin.java line 247:

> 245: 		if (response.statusCode() != 200) {
> 246: 			JOptionPane.showMessageDialog(null,
> 247: 					" Some error occured while updating Twitter status. Please verify your twitter app settings. ");

Similar to the string usage below, it'd be nice to include the error code along with this message.

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterPlugin.java line 396:

> 394: 		if (response.statusCode() != 200) {
> 395: 			JOptionPane.showMessageDialog(null,
> 396: 					" Some error occured while sending direct message. Please verify your twitter app settings. ");

There are trailing spaces at the beginning and end of this string. It would also be nice to have the error status included with this string, so the user has a better idea of where an issue might have happened if it occurs. The string in the dialog might be something like:

"An error occured while __________. Please verify your Twitter app settings. (Error code: XXX)"

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From jpbempel at openjdk.java.net  Wed Nov 10 17:19:04 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 10 Nov 2021 17:19:04 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
Message-ID: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>

> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
> 
>  * track constant pool usage inside events
>  * replace or translate symbols, method names, etc... like
> de-obfuscations of stack traces

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/333/files
  - new: https://git.openjdk.java.net/jmc/pull/333/files/33732c9a..47c9b726

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=03-04

  Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/333.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/333/head:pull/333

PR: https://git.openjdk.java.net/jmc/pull/333

From schaturvedi at openjdk.java.net  Wed Nov 10 21:35:08 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 10 Nov 2021 21:35:08 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v4]
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <Ts60TY8sUKgoLWVUV6llNI-e5RLxJzyXvjNDoYm3KGs=.91ce15aa-1b1e-4db7-a3db-603975538b85@github.com>

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Moved all error messages to properties file and added error code

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/323/files
  - new: https://git.openjdk.java.net/jmc/pull/323/files/92c3e071..c769e32b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=02-03

  Stats: 21 lines in 3 files changed: 12 ins; 2 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/323/head:pull/323

PR: https://git.openjdk.java.net/jmc/pull/323

From schaturvedi at openjdk.java.net  Wed Nov 10 21:37:43 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 10 Nov 2021 21:37:43 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v3]
In-Reply-To: <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <T7iLYjS1KkdX8RBmG3KZ9bnm1dFv6aggkf_sK_5EyGE=.d18c1bca-f20b-4736-8927-b33455f9ca4f@github.com>
Message-ID: <7G393aQUARq9WZdc0YtxjT55Lu6dnkZXXf0YBPsY7jQ=.37586fa6-960c-414b-a0f7-521e6da3b568@github.com>

On Tue, 9 Nov 2021 21:15:05 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enhanced error handling

The new error message screen looks like this:

<img width="960" alt="NewErrorMessage" src="https://user-images.githubusercontent.com/11155712/141196931-759e6d34-5a4d-43c2-9e11-7826da0ed79d.PNG">

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From duke at openjdk.java.net  Sat Nov 13 11:10:34 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Sat, 13 Nov 2021 11:10:34 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
Message-ID: <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>

On Wed, 10 Nov 2021 17:19:04 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

Back to the tests - this time with the JPs clone and branch "pool-extension". I realized that in my Eclipse setup the ConstantPoolExtensionTest class doesn't get compiled unless I do a
- cd core
- mvn package
on console. That's why I obiously got the ClassNotFoundException previously. I realized that when I finally found the "Show command line" option with the class path.
Now I can run the test but have to do "mvn package" always if I want to make changes, which is obviously very clumsy. 
Sorry that I report more about my Eclipse setup problems here than regarding the PR...

Regarding the PR, I have the same test result as last time. I just can't seenany of my own classes in the Parsewr Extension callbacks when I replaced the test JFR file with my own. As I said, I probably didn't got the idea.

I would suggest that you provide a test JFR file with a custom class like fr.jpbempel.HelloWorld and demonstrate in the test how to get it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From jpbempel at openjdk.java.net  Sat Nov 13 21:01:39 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 13 Nov 2021 21:01:39 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>
Message-ID: <owOwBanPiMMtkm4dvvag1V_LjnP1dD6mnAa9tMWzVI4=.25a89a42-4540-4e56-829b-4f007b00fd6d@github.com>

On Sat, 13 Nov 2021 11:07:26 GMT, Michael S?dkamp <duke at openjdk.java.net> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> Back to the tests - this time with the JPs clone and branch "pool-extension". I realized that in my Eclipse setup the ConstantPoolExtensionTest class doesn't get compiled unless I do a
> - cd core
> - mvn package
> on console. That's why I obiously got the ClassNotFoundException previously. I realized that when I finally found the "Show command line" option with the class path.
> Now I can run the test but have to do "mvn package" always if I want to make changes, which is obviously very clumsy. 
> Sorry that I report more about my Eclipse setup problems here than regarding the PR...
> 
> Regarding the PR, I have the same test result as last time. I just can't seenany of my own classes in the Parsewr Extension callbacks when I replaced the test JFR file with my own. As I said, I probably didn't got the idea.
> 
> I would suggest that you provide a test JFR file with a custom class like fr.jpbempel.HelloWorld and demonstrate in the test how to get it.

hello @docwarems 
My test is focusing on event Types that referencing constants.

when using the callback:

Object constantRead(long constantIndex, Object constant, String eventTypeId) {
	return constant;
}

you should look at constant argument that should be what you would like to de-obfuscate and return a translated value instead of the original one:


Object constantRead(long constantIndex, Object constant, String eventTypeId) {
	return deobfuscate(constant);
}

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From aptmac at openjdk.java.net  Mon Nov 15 19:47:43 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 15 Nov 2021 19:47:43 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v4]
In-Reply-To: <Ts60TY8sUKgoLWVUV6llNI-e5RLxJzyXvjNDoYm3KGs=.91ce15aa-1b1e-4db7-a3db-603975538b85@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <Ts60TY8sUKgoLWVUV6llNI-e5RLxJzyXvjNDoYm3KGs=.91ce15aa-1b1e-4db7-a3db-603975538b85@github.com>
Message-ID: <h7NXWfPGc0flECJ_eWMHtnDYUJhDzbd79Ua-rm7TPCc=.4b765a97-b84b-4b38-88aa-90efcbbaaf1c@github.com>

On Wed, 10 Nov 2021 21:35:08 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved all error messages to properties file and added error code

The updated error message looks great, thanks.

I've commented on a handful of lines that could also be externalized.

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 122:

> 120: 			return oauth_token;
> 121: 		} catch (Exception e) {
> 122: 			LOGGER.log(Level.SEVERE, "Unable to get request token", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 178:

> 176: 			return accessToken;
> 177: 		} catch (Exception e) {
> 178: 			LOGGER.log(Level.SEVERE, "Unable to authenticate.", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 203:

> 201: 		} catch (URISyntaxException e) {
> 202: 			// Should never happen...
> 203: 			LOGGER.log(Level.SEVERE, "Failed to parse URI", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 226:

> 224: 
> 225: 		byte[] keyBytes = keyString.getBytes();
> 226: 		secretKey = new SecretKeySpec(keyBytes, "HmacSHA1");

Perhaps the "HmacSHA1" could be a global variable instead of a quoted string here (as it's used again below)?

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java line 150:

> 148: 			mac.init(key);
> 149: 		} catch (NoSuchAlgorithmException | InvalidKeyException e) {
> 150: 			LOGGER.log(Level.SEVERE, "Failed to encrypt.", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java line 168:

> 166: 			encoded = Encode.forUriComponent(value);
> 167: 		} catch (Exception e) {
> 168: 			LOGGER.log(Level.SEVERE, "Failed to encode the URL.", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterPlugin.java line 178:

> 176: 		} catch (URISyntaxException e) {
> 177: 			// Should never happen...
> 178: 			LOGGER.log(Level.SEVERE, "Failed to parse URI", e);

This string could be placed in `Messages.java`

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterPlugin.java line 305:

> 303: 					storeAndSavePrefs();
> 304: 				} else {
> 305: 					DialogToolkit.showError(null, "Invalid User", "The authorized user is invalid.");

This string could be placed in `Messages.java`

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From duke at openjdk.java.net  Tue Nov 16 09:08:58 2021
From: duke at openjdk.java.net (duke)
Date: Tue, 16 Nov 2021 09:08:58 GMT
Subject: git: openjdk/jmc: Added tag 8.1.1-ga for changeset 14d2f6ca
Message-ID: <f0d6b416-838b-43fa-848a-5efc2d526fd2@openjdk.java.net>

Tagged by: Marcus Hirt <marcus at hirt.se>
Date:      2021-11-16 10:08:14 +0000

GA source release for JMC 8.1.1
Changeset: 14d2f6ca
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2021-10-26 08:25:16 +0000
URL:       https://git.openjdk.java.net/jmc/commit/14d2f6ca7a404a71c8aa8676cfd301dcab647093


From aptmac at openjdk.java.net  Tue Nov 16 19:20:53 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 16 Nov 2021 19:20:53 GMT
Subject: RFR: 7198: add websocket server that pushes data on selection
 updates [v8]
In-Reply-To: <YorFbhdMhAwgd4Vl-Sji9q0SI449SwaSMvM4hZaAusg=.1ee69e75-c631-4d99-b3e4-6435b66115ed@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
 <OvgUJIdFd7Pth_1OLmOBKMJwL6INDXTTOZupY2YQvFQ=.c095ace8-5e31-40b4-88cd-512f2e9fe157@github.com>
 <mU8pkgg_IdmHkknUe7o4PKgQafivHPMPP92dAZsufWM=.08c592a3-461c-497b-9b77-a8f9289798b9@github.com>
 <YorFbhdMhAwgd4Vl-Sji9q0SI449SwaSMvM4hZaAusg=.1ee69e75-c631-4d99-b3e4-6435b66115ed@github.com>
Message-ID: <zreh_D3aoMbJA9VUEquGdaN1n-QilRW5S4qKjEbMC1U=.6450f0e3-e240-4bce-a714-2b47d0a1ced6@github.com>

On Wed, 27 Oct 2021 16:52:31 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> I've updated the Eclipse launchers to include the additional `asm` plugins and now I'm no longer seeing startup errors, everything seems to work fine. I've added a commit with these changes.

I think these look good, after fighting with my Eclipse for a bit I was able to verify that the additional plugins here get it working.

Having said that, I wonder if the  `JMC-Eclipse-JDK-8.launch` should be removed.. the jetty dependencies are having a fit because they require jdk 11, and using certain target platforms it's not even possible to launch JMC with jdk 8 anyways.

-------------

PR: https://git.openjdk.java.net/jmc/pull/306

From schaturvedi at openjdk.java.net  Wed Nov 17 20:28:25 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 17 Nov 2021 20:28:25 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v5]
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Moved all the hard coded strings to generic Messages

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/323/files
  - new: https://git.openjdk.java.net/jmc/pull/323/files/c769e32b..a89db1cb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=03-04

  Stats: 37 lines in 5 files changed: 22 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/jmc/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/323/head:pull/323

PR: https://git.openjdk.java.net/jmc/pull/323

From aptmac at openjdk.java.net  Wed Nov 17 20:47:48 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 17 Nov 2021 20:47:48 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v5]
In-Reply-To: <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
Message-ID: <QgOLxden_YtLK6vb1xyETfPaxveInRjPA3eA1-wEUok=.3a43902d-642a-44d7-89b8-272e9e432643@github.com>

On Wed, 17 Nov 2021 20:28:25 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved all the hard coded strings to generic Messages

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From hirt at openjdk.java.net  Fri Nov 19 18:25:07 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 19 Nov 2021 18:25:07 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
Message-ID: <d2FK-gZw9tg2trfLNdYGErgZHE8oXKrdd2Z7Sr5ORnU=.495e18a9-5b8f-488c-b4c4-ebd785704a37@github.com>

On Wed, 10 Nov 2021 17:19:04 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/LoaderContext.java line 48:

> 46: import org.openjdk.jmc.common.item.IAttribute;
> 47: import org.openjdk.jmc.common.item.IItem;
> 48: import org.openjdk.jmc.common.unit.ContentType;

Not needed, right?

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From hirt at openjdk.java.net  Fri Nov 19 18:28:14 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 19 Nov 2021 18:28:14 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
Message-ID: <Ye0ZfFDCshUqvGht-yjWbnKjZ3K7N-KZetZPOKFxPuw=.0495d3d4-b1f3-4b79-869b-616dc3f1abd8@github.com>

On Wed, 10 Nov 2021 17:19:04 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/ParserStats.java line 42:

> 40: import java.util.List;
> 41: import java.util.Map;
> 42: import java.util.Set;

Using Maps, not Sets - not needed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From omikhaltcova at openjdk.java.net  Sat Nov 20 01:18:19 2021
From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova)
Date: Sat, 20 Nov 2021 01:18:19 GMT
Subject: RFR: 7440: JMC fails on Apple M1
Message-ID: <qPlMzPmQsUbcZiLO_2gMwiApepER2DtnFRjNd7FSRVg=.1adeafb4-2477-4cfe-a481-e4529336cff4@github.com>

I would like to add support for the macOS AArch64 platform to JMC. 
Please review this change!

Our build for macOS AArch64 can be downloaded from here: 
https://www.azul.com/products/components/zulu-mission-control/#block-download

-------------

Commit messages:
 - 7440: JMC fails on Apple M1

Changes: https://git.openjdk.java.net/jmc/pull/334/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=334&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7440
  Stats: 27 lines in 1 file changed: 26 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/334.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/334/head:pull/334

PR: https://git.openjdk.java.net/jmc/pull/334

From hirt at openjdk.java.net  Sat Nov 20 13:05:10 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 20 Nov 2021 13:05:10 GMT
Subject: RFR: 7440: JMC fails on Apple M1
In-Reply-To: <qPlMzPmQsUbcZiLO_2gMwiApepER2DtnFRjNd7FSRVg=.1adeafb4-2477-4cfe-a481-e4529336cff4@github.com>
References: <qPlMzPmQsUbcZiLO_2gMwiApepER2DtnFRjNd7FSRVg=.1adeafb4-2477-4cfe-a481-e4529336cff4@github.com>
Message-ID: <fSDewMeJiMf-LDOpYchttBJNOkY6cDKXBz9H5u6jOs0=.d3453817-93e3-4bf8-8a19-ec4ee1f7f899@github.com>

On Sat, 20 Nov 2021 01:14:08 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I would like to add support for the macOS AArch64 platform to JMC. 
> Please review this change!
> 
> Our build for macOS AArch64 can be downloaded from here: 
> https://www.azul.com/products/components/zulu-mission-control/#block-download

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/334

From duke at openjdk.java.net  Sat Nov 20 13:11:09 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Sat, 20 Nov 2021 13:11:09 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <owOwBanPiMMtkm4dvvag1V_LjnP1dD6mnAa9tMWzVI4=.25a89a42-4540-4e56-829b-4f007b00fd6d@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>
 <owOwBanPiMMtkm4dvvag1V_LjnP1dD6mnAa9tMWzVI4=.25a89a42-4540-4e56-829b-4f007b00fd6d@github.com>
Message-ID: <Vq43wMKnt8HkQD0uq38XfVH120yVrYoesgfZT8JRrao=.ea87f70f-462d-4525-88c9-95ad0d07a314@github.com>

On Sat, 13 Nov 2021 20:58:38 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> My test is focusing on event Types that referencing constants.

Yeah, that's more or less what I expected. Maybe I'm unable to find my constant of interest in the mass of other classes. Could you provide a breakpoint condition for the breakpoint condition shown below which would stop at a class "fr.jpbempel.HelloWorld"?

![grafik](https://user-images.githubusercontent.com/29914148/142727338-e7d0e27d-1c21-409e-a543-a4826b45bfbf.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From jpbempel at openjdk.java.net  Sun Nov 21 21:45:10 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 21 Nov 2021 21:45:10 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <Vq43wMKnt8HkQD0uq38XfVH120yVrYoesgfZT8JRrao=.ea87f70f-462d-4525-88c9-95ad0d07a314@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>
 <owOwBanPiMMtkm4dvvag1V_LjnP1dD6mnAa9tMWzVI4=.25a89a42-4540-4e56-829b-4f007b00fd6d@github.com>
 <Vq43wMKnt8HkQD0uq38XfVH120yVrYoesgfZT8JRrao=.ea87f70f-462d-4525-88c9-95ad0d07a314@github.com>
Message-ID: <nS3tF5Q0Eh1KS1ZIdCT3afWtCRb_V6oqZpiFDMV06Ls=.95058682-0a9c-4470-bb3c-6cbe6d4c97b0@github.com>

On Sat, 20 Nov 2021 13:08:28 GMT, Michael S?dkamp <duke at openjdk.java.net> wrote:

>> hello @docwarems 
>> My test is focusing on event Types that referencing constants.
>> 
>> when using the callback:
>> 
>> Object constantRead(long constantIndex, Object constant, String eventTypeId) {
>> 	return constant;
>> }
>> 
>> you should look at constant argument that should be what you would like to de-obfuscate and return a translated value instead of the original one:
>> 
>> 
>> Object constantRead(long constantIndex, Object constant, String eventTypeId) {
>> 	return deobfuscate(constant);
>> }
>
>> My test is focusing on event Types that referencing constants.
> 
> Yeah, that's more or less what I expected. Maybe I'm unable to find my constant of interest in the mass of other classes. Could you provide a breakpoint condition for the breakpoint condition shown below which would stop at a class "fr.jpbempel.HelloWorld"?
> 
> ![grafik](https://user-images.githubusercontent.com/29914148/142727338-e7d0e27d-1c21-409e-a543-a4826b45bfbf.png)

Hey, @docwarems 

I have created a custom event:


package com.bempel.events;

import jdk.jfr.Event;
import jdk.jfr.Label;
import jdk.jfr.Name;

@Name("com.bempel.events.MyEvent")
@Label("MyEvent")
public class MyEvent extends Event {
	@Label("message")
	public String message;
}


I have used like this:

MyEvent myEvent = new MyEvent();
myEvent.message = "showVetList " + uuid;
myEvent.commit();


I have recording with this event in it:

<img width="979" alt="Screenshot 2021-11-21 at 22 31 13" src="https://user-images.githubusercontent.com/4610701/142779645-585707c9-b345-4171-9a5a-d40c014d835c.png">

You can look at constant pools :

in `java.lang.Class`
<img width="562" alt="Screenshot 2021-11-21 at 22 32 25" src="https://user-images.githubusercontent.com/4610701/142779684-e2e78175-1529-43d9-8dbd-a5c2550f57cb.png">

but also in `jdk.Types.Symbol`:
<img width="570" alt="Screenshot 2021-11-21 at 22 32 58" src="https://user-images.githubusercontent.com/4610701/142779819-83333f9a-3fde-48fd-ac11-38f4427054f9.png">


in debugging ConstantPoolExtensionTest:
<img width="1424" alt="Screenshot 2021-11-21 at 22 34 38" src="https://user-images.githubusercontent.com/4610701/142779795-38f03d70-06fb-4659-aa8c-045bac354bc4.png">

But it's a little bit complex because:
a class constant is not having directly the name of the class but reference another symbol constant for that
see:
https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java#L277-L287

That's why it may have more sense to look for the symbol constant instead of directly the class constant.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Mon Nov 22 20:18:11 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Mon, 22 Nov 2021 20:18:11 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <nS3tF5Q0Eh1KS1ZIdCT3afWtCRb_V6oqZpiFDMV06Ls=.95058682-0a9c-4470-bb3c-6cbe6d4c97b0@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <ElZO5W6d639KrZmSf6m7C0UW5RweVsYYfVq-QnReGh8=.58130de0-0090-470e-b81e-3cdedda27714@github.com>
 <owOwBanPiMMtkm4dvvag1V_LjnP1dD6mnAa9tMWzVI4=.25a89a42-4540-4e56-829b-4f007b00fd6d@github.com>
 <Vq43wMKnt8HkQD0uq38XfVH120yVrYoesgfZT8JRrao=.ea87f70f-462d-4525-88c9-95ad0d07a314@github.com>
 <nS3tF5Q0Eh1KS1ZIdCT3afWtCRb_V6oqZpiFDMV06Ls=.95058682-0a9c-4470-bb3c-6cbe6d4c97b0@github.com>
Message-ID: <E40YaVE2RQUCom-fYRxP2Knjj-R5UJMEess1pNZas3o=.eba777db-d123-4b1b-aa24-59f911bb6936@github.com>

On Sun, 21 Nov 2021 21:41:34 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>>> My test is focusing on event Types that referencing constants.
>> 
>> Yeah, that's more or less what I expected. Maybe I'm unable to find my constant of interest in the mass of other classes. Could you provide a breakpoint condition for the breakpoint condition shown below which would stop at a class "fr.jpbempel.HelloWorld"?
>> 
>> ![grafik](https://user-images.githubusercontent.com/29914148/142727338-e7d0e27d-1c21-409e-a543-a4826b45bfbf.png)
>
> Hey, @docwarems 
> 
> I have created a custom event:
> 
> 
> package com.bempel.events;
> 
> import jdk.jfr.Event;
> import jdk.jfr.Label;
> import jdk.jfr.Name;
> 
> @Name("com.bempel.events.MyEvent")
> @Label("MyEvent")
> public class MyEvent extends Event {
> 	@Label("message")
> 	public String message;
> }
> 
> 
> I have used like this:
> 
> MyEvent myEvent = new MyEvent();
> myEvent.message = "showVetList " + uuid;
> myEvent.commit();
> 
> 
> I have recording with this event in it:
> 
> <img width="979" alt="Screenshot 2021-11-21 at 22 31 13" src="https://user-images.githubusercontent.com/4610701/142779645-585707c9-b345-4171-9a5a-d40c014d835c.png">
> 
> You can look at constant pools :
> 
> in `java.lang.Class`
> <img width="562" alt="Screenshot 2021-11-21 at 22 32 25" src="https://user-images.githubusercontent.com/4610701/142779684-e2e78175-1529-43d9-8dbd-a5c2550f57cb.png">
> 
> but also in `jdk.Types.Symbol`:
> <img width="570" alt="Screenshot 2021-11-21 at 22 32 58" src="https://user-images.githubusercontent.com/4610701/142779819-83333f9a-3fde-48fd-ac11-38f4427054f9.png">
> 
> 
> in debugging ConstantPoolExtensionTest:
> <img width="1424" alt="Screenshot 2021-11-21 at 22 34 38" src="https://user-images.githubusercontent.com/4610701/142779795-38f03d70-06fb-4659-aa8c-045bac354bc4.png">
> 
> But it's a little bit complex because:
> a class constant is not having directly the name of the class but reference another symbol constant for that
> see:
> https://github.com/openjdk/jmc/blob/master/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java#L277-L287
> 
> That's why it may have more sense to look for the symbol constant instead of directly the class constant.

Hello @jpbempel, the breakpoint condition was the breakthrough - I just wasn't able to catch the desired constant before. Even with the simplest HelloWork console program I ended up with a JFR file where I wasn't able to step through all constants in a reasonable time and find my desired constant.

Next I should be able to take my deobfuscator remapping code and build a true extension. I'll come back then. Regarding the PR review, I wonder if you want to wait for my further work, or if you prefer to merge.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From aptmac at openjdk.java.net  Mon Nov 22 21:05:26 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 22 Nov 2021 21:05:26 GMT
Subject: RFR: 7447: add serializers and writer modules to core test coverage
Message-ID: <0ODPS5mpWlEPu3ZbUUElANDl3yuxvcjCfRSu95OvEVc=.fd1bfc83-5b2a-44f4-b5f7-8ebdaebd507c@github.com>

This PR addresses JMC-7447 [[0]](https://bugs.openjdk.java.net/browse/JMC-7447), in which the core coverage reports are missing the serializers and writer modules. The changes here simply add the missing modules to the coverage dependency list.

Additionally, the jdp.test module is missing the `<scope>test</scope>` attribute, so I've added it in here.

[0] https://bugs.openjdk.java.net/browse/JMC-7447

-------------

Commit messages:
 - 7447: add serializers and writer modules to core test coverage

Changes: https://git.openjdk.java.net/jmc/pull/335/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=335&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7447
  Stats: 25 lines in 1 file changed: 23 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/335.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/335/head:pull/335

PR: https://git.openjdk.java.net/jmc/pull/335

From aptmac at openjdk.java.net  Mon Nov 22 21:06:57 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 22 Nov 2021 21:06:57 GMT
Subject: RFR: 5904: Merge org.openjdk.jmc.ui.celleditors with
 org.openjdk.jmc.rjmx.ui.celleditors [v6]
In-Reply-To: <U9YY7_Yst0dzuwPDbz_PhKZ4L3fHdNOGtxjt-f5fD88=.efc5d4a1-2e71-4e8e-bcac-41ebf8e71b4f@github.com>
References: <U9YY7_Yst0dzuwPDbz_PhKZ4L3fHdNOGtxjt-f5fD88=.efc5d4a1-2e71-4e8e-bcac-41ebf8e71b4f@github.com>
Message-ID: <60k9D7ZmeN8xynOPgDhnlxocUYtQ9iWzDtEOg_4r3gM=.dd1f0223-e266-42dd-8c44-0ad68f75f876@github.com>

> This PR addresses JMC-5904 [[0]](https://bugs.openjdk.java.net/browse/JMC-5904), in which it is noted that org.openjdk.jmc.ui.celleditors could be merged with org.openjdk.jmc.rjmx.ui.celleditors instead of separating the code.
> 
> This is achieved by combining the celleditors code into a new package; org.openjdk.jmc.ui.celleditors. Originally the intent was to throw the jmc.ui.celleditors code into rjmx.ui.celleditors. however this gets complicated because jmc.ui.misc.FilterEditor (which requires CommonCellEditors) gets used in flightrecorder.ui. As a result, moving the celleditors code into rjmx.ui.celleditors would add a dependency on rjmx.ui from flightrecorder.ui, which is not ideal.
> 
> To alleviate this, FilterEditor has been moved to flightrecorder.ui (which is the only place it's used currently anyways), and celleditors have been moved to it's own package so it can be imported by rjmx.ui and jmc.ui (and subsequently flightrecorder.ui) as required. This removes the dependency from rjmx.ui to flightrecorder.ui.
> 
> EDIT (November 19th): below is the original concept for this PR; to merge jmc.ui.celleditors into rjmx.ui.celleditors. However, this creates a situation where rjmx.ui becomes a dependency of flightrecorder.ui, which is not ideal. For reference, I'll leave the original PR body below.
> 
> For the most part this is a fairly straightforward migration of code. There are three classes in jmc.ui.celleditors that needed to be moved into rjmx.ui.celleditors:
> 1. ClearableTextCellEditor
> 2. CommonCellEditors
> 3. NullableTextCellEditor
> 
> Once these files are moved there is a slight problem: org.openjdk.jmc.ui.misc.FilterEditor uses CommonCellEditors, and org.openjdk.jmc.rjmx.ui requires org.openjdk.jmc.ui. In this case, adding a dependency from org.openjdk.jmc.rjmx.ui.celleditors.CommonCellEditors to org.openjdk.jmc.ui.misc.FilterEditors would introduce a circular dependency.
> 
> The solution I've gone with here is to move FilterEditor to org.openjdk.jmc.flightrecorder.ui, which IMO makes sense anyways because it's closer to the code it gets consumed by. FilterEditor is used in:
> - _org.openjdk.jmc.flightrecorder.ui_.common.DataPageToolkit
> - _org.openjdk.jmc.flightrecorder.ui_.common.FilterComponent
> - _org.openjdk.jmc.flightrecorder.ui_.common.LaneEditor
> - _org.openjdk.jmc.flightrecorder.ui_.pages.ItemHandlerPage
> 
> **Note:** this issue was originally targeted for 8.1.0, but isn't really critical (it's a P4 task), so if desired we can hold off on integrating it now and keep this around for integration into 8.2.0 as discussed in the jmc bi-weekly calls
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-5904

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - move celleditors to org.openjdk.jmc.ui.celleditors
   
   This commit moves the celleditors code into it's own package: org.openjdk.jmc.ui.celleditors. This removes the dependency on rjmx.ui for flightrecorder.ui. Now, both rjmx.ui and flightrecorder.ui import org.openjdk.jmc.ui.celleditors. The l10n packages have also been updated with their respective strings.
 - update license headers
 - 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/271/files
  - new: https://git.openjdk.java.net/jmc/pull/271/files/347873cb..a510e72d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=271&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=271&range=04-05

  Stats: 556 lines in 80 files changed: 376 ins; 43 del; 137 mod
  Patch: https://git.openjdk.java.net/jmc/pull/271.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/271/head:pull/271

PR: https://git.openjdk.java.net/jmc/pull/271

From aptmac at openjdk.java.net  Mon Nov 22 21:09:30 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 22 Nov 2021 21:09:30 GMT
Subject: RFR: 7446: add Maven profile for enabling test coverage
Message-ID: <9gf7itOF5K_DD5Vp3CaF8olU1Y-jgNp15_EvRIk7tgc=.a33725cd-a9fa-4e03-91f3-5f1cc9c96db8@github.com>

This PR addresses JMC-7446 [[0]](https://bugs.openjdk.java.net/browse/JMC-7446), in which it would be nice to have a Maven profile for enabling test coverage.

At the moment, test coverage is enabled by default with no way of disabling it. This PR adds a Maven profile (in a similar vein to how uitests are run) that allows coverage reports to be enabled or disabled as desired. This profile is included in both the core and application poms.

Usage: `mvn clean install -P coverage`, or `mvn clean verify -P coverage -P uitests`, etc.

[0] https://bugs.openjdk.java.net/browse/JMC-7446

-------------

Commit messages:
 - 7446: add Maven profile for enabling test coverage

Changes: https://git.openjdk.java.net/jmc/pull/336/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=336&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7446
  Stats: 218 lines in 7 files changed: 129 ins; 78 del; 11 mod
  Patch: https://git.openjdk.java.net/jmc/pull/336.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/336/head:pull/336

PR: https://git.openjdk.java.net/jmc/pull/336

From aptmac at openjdk.java.net  Mon Nov 22 21:09:42 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 22 Nov 2021 21:09:42 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core [v3]
In-Reply-To: <L7gWCRuM7LXgjuNh3ENuHOJgxqXdJPcv3O0FQKCVZts=.589c3b2f-1fa5-4e7f-94d5-c1c896fd7880@github.com>
References: <L7gWCRuM7LXgjuNh3ENuHOJgxqXdJPcv3O0FQKCVZts=.589c3b2f-1fa5-4e7f-94d5-c1c896fd7880@github.com>
Message-ID: <ETuuO--QFGGn37jxRWFO73RjcBdlHlzBQTsSXufcrlI=.058605d5-23e8-4080-a956-63dd5e23aad0@github.com>

> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.
> 
> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.
> 
> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7307

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:

 - fix package name in JFCXMLValidator logger
 - re-order flightrecorder.configuration.test in test pom
 - update license headers
 - migrate VolatileStorageDelegate to flightrecorder.configuration.model
 - revert .classpath files to their original from application
 - minor cleanup
 - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
   
   The controlpanel.ui.configuration only had the XML test, which is now
   located in flightrecorder.configuration.test in core. Currently all
   tests in both core and application will pass.
 - move flightrecorder.configuration coverage from application to core
 - temporarily silence test modules that are moved, will cleanup after
 - migrate controlpanel.ui.configuration.model.xml to core
 - ... and 1 more: https://git.openjdk.java.net/jmc/compare/77580fe1...6dd54405

-------------

Changes: https://git.openjdk.java.net/jmc/pull/299/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=299&range=02
  Stats: 1003 lines in 99 files changed: 373 ins; 475 del; 155 mod
  Patch: https://git.openjdk.java.net/jmc/pull/299.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/299/head:pull/299

PR: https://git.openjdk.java.net/jmc/pull/299

From jpbempel at openjdk.java.net  Mon Nov 22 21:23:10 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 22 Nov 2021 21:23:10 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
Message-ID: <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>

On Wed, 10 Nov 2021 17:19:04 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

It would be nice to have your feedback on this, because I came back a lot on the design to implement my needs. So depending on yours, we may revisit some parts...

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From hirt at openjdk.java.net  Wed Nov 24 15:41:11 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 24 Nov 2021 15:41:11 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v5]
In-Reply-To: <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
Message-ID: <ZHTCAZQ2XViDGV2L7x1ThrFn-8gOdNeHXMkUzOJBajg=.cee2d0e5-a869-4671-8b14-ca22b25bfc92@github.com>

On Wed, 17 Nov 2021 20:28:25 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved all the hard coded strings to generic Messages

Since we are removing the dependency on Twitter4J, we should also remove it from https://github.com/openjdk/jmc/blob/master/license/THIRDPARTYREADME.txt#L265.

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From schaturvedi at openjdk.java.net  Wed Nov 24 17:48:37 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 24 Nov 2021 17:48:37 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v6]
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <-1KfczXQpwy2ehm97NMqiZBGbxYPRnWGN6KRzsyuZyo=.f269baed-36ce-46b2-be2f-bc2e42f47188@github.com>

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Removed third party dependency of Twitter4J from license file

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/323/files
  - new: https://git.openjdk.java.net/jmc/pull/323/files/a89db1cb..33fb63dd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=04-05

  Stats: 181 lines in 1 file changed: 0 ins; 181 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/323/head:pull/323

PR: https://git.openjdk.java.net/jmc/pull/323

From hirt at openjdk.java.net  Wed Nov 24 18:08:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 24 Nov 2021 18:08:12 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v5]
In-Reply-To: <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <NDi-jLYqlpx3mmVGVUkSCvtXumKdw0g95qKwZLb8KXI=.f6a018c8-a6ff-44f6-8d03-9b17fd1b85f4@github.com>
Message-ID: <13zsRU-VTcgjb-ryeMVtoKBzN1Nx0MvJzw7Nz273ycQ=.3eecdf60-878a-42bd-ae8e-472259ab4a99@github.com>

On Wed, 17 Nov 2021 20:28:25 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved all the hard coded strings to generic Messages

Changes requested by hirt (Lead).

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 60:

> 58: import org.openjdk.jmc.rjmx.triggers.actions.internal.Messages;
> 59: 
> 60: class TwitterOAuthAunthenticator {

Should be TwitterOAuthAuthenticator.

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 72:

> 70: 	final static Logger LOGGER = Logger.getLogger("TwitterOAuthAunthenticator");
> 71: 
> 72: 	TwitterOAuthAunthenticator() {

Unless you explicitly want this to be package private, I'd just remove and fall back to the default constructor.

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 217:

> 215: 			addr = null;
> 216: 		}
> 217: 		HttpClient httpClient = HttpClient.newBuilder().version(HttpClient.Version.HTTP_2)

I'd inline the httpClient - don't declare the variable.

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From omikhaltcova at openjdk.java.net  Wed Nov 24 18:38:07 2021
From: omikhaltcova at openjdk.java.net (Olga Mikhaltsova)
Date: Wed, 24 Nov 2021 18:38:07 GMT
Subject: Integrated: 7440: JMC fails on Apple M1
In-Reply-To: <qPlMzPmQsUbcZiLO_2gMwiApepER2DtnFRjNd7FSRVg=.1adeafb4-2477-4cfe-a481-e4529336cff4@github.com>
References: <qPlMzPmQsUbcZiLO_2gMwiApepER2DtnFRjNd7FSRVg=.1adeafb4-2477-4cfe-a481-e4529336cff4@github.com>
Message-ID: <KMA5VoNFRPlrsoxwh4Z7UUS4D4t9bWuLkwi2FGo4rGA=.7bdb7c19-b8ff-49fd-bdb1-b14bd71ba3f9@github.com>

On Sat, 20 Nov 2021 01:14:08 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

> I would like to add support for the macOS AArch64 platform to JMC. 
> Please review this change!
> 
> Our build for macOS AArch64 can be downloaded from here: 
> https://www.azul.com/products/components/zulu-mission-control/#block-download

This pull request has now been integrated.

Changeset: d218205f
Author:    Olga Mikhaltsova <omikhaltcova at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d218205fd4113daea82de1b813d5ef1ed740983d
Stats:     27 lines in 1 file changed: 26 ins; 0 del; 1 mod

7440: JMC fails on Apple M1

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/334

From hirt at openjdk.java.net  Wed Nov 24 18:49:06 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 24 Nov 2021 18:49:06 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v3]
In-Reply-To: <5WhBBvRJ2eoylwz-MY2tjFK_G3bTlC-J9fRq3QSrFJ0=.b4874f12-5043-414c-8e52-8b4c28c6917e@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <5WhBBvRJ2eoylwz-MY2tjFK_G3bTlC-J9fRq3QSrFJ0=.b4874f12-5043-414c-8e52-8b4c28c6917e@github.com>
Message-ID: <rTX6CVqF32DM4XDJU_ZjjnckrvKWmk9uxeiUZzjw_6s=.4235849b-a7c8-4c17-a8fe-bc858ae575e4@github.com>

On Wed, 27 Oct 2021 19:23:35 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Temporary disable certain tests
>  - 7432: Update the spotbugs maven plugin
>    
>    Signed-off-by: Patrick Reinhart <patrick at reini.net>

Have you hade time to take a look at the failing tests yet?

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From schaturvedi at openjdk.java.net  Wed Nov 24 19:00:10 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 24 Nov 2021 19:00:10 GMT
Subject: RFR: 7231: JMC createReport for JMC8 Automated Analysis fails to
 evaluate several rules
In-Reply-To: <7A74lcRU7j2A9qas1BwWturLRNFuLIcUs5fAhv5IoTY=.8e9f35d2-07ec-4347-b5ee-c2c9a2926cce@github.com>
References: <7A74lcRU7j2A9qas1BwWturLRNFuLIcUs5fAhv5IoTY=.8e9f35d2-07ec-4347-b5ee-c2c9a2926cce@github.com>
Message-ID: <LR0lbtfatHaAaD_a7ktf7oLGiwpwyf29JXjAmhzfpRE=.80b8209c-ebaf-4559-bbd4-f711e581056a@github.com>

On Mon, 9 Aug 2021 23:15:26 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the NullPointerException issue in core module for the following rules:
> 
> 1. GCs Caused by System.gc()
> 2. GCs Caused by Heap Inspection
> 3. GC Stall
> 4. String Deduplication
> 5. GCs Caused by GC Locker

Already fixed as part of another PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/302

From schaturvedi at openjdk.java.net  Wed Nov 24 19:00:10 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 24 Nov 2021 19:00:10 GMT
Subject: Withdrawn: 7231: JMC createReport for JMC8 Automated Analysis fails to
 evaluate several rules
In-Reply-To: <7A74lcRU7j2A9qas1BwWturLRNFuLIcUs5fAhv5IoTY=.8e9f35d2-07ec-4347-b5ee-c2c9a2926cce@github.com>
References: <7A74lcRU7j2A9qas1BwWturLRNFuLIcUs5fAhv5IoTY=.8e9f35d2-07ec-4347-b5ee-c2c9a2926cce@github.com>
Message-ID: <fAC5lskpsuY53GfvQhtYoFpRKl0bcQjkvtDAa2ESWNQ=.a0477240-d050-471a-af60-3373e76253ef@github.com>

On Mon, 9 Aug 2021 23:15:26 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the NullPointerException issue in core module for the following rules:
> 
> 1. GCs Caused by System.gc()
> 2. GCs Caused by Heap Inspection
> 3. GC Stall
> 4. String Deduplication
> 5. GCs Caused by GC Locker

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmc/pull/302

From hirt at openjdk.java.net  Wed Nov 24 19:01:12 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 24 Nov 2021 19:01:12 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v6]
In-Reply-To: <-1KfczXQpwy2ehm97NMqiZBGbxYPRnWGN6KRzsyuZyo=.f269baed-36ce-46b2-be2f-bc2e42f47188@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <-1KfczXQpwy2ehm97NMqiZBGbxYPRnWGN6KRzsyuZyo=.f269baed-36ce-46b2-be2f-bc2e42f47188@github.com>
Message-ID: <WZPQuEtuwxN8WABeZJyKG0cAdykSzUiA7k-R_U1no1U=.9b5178c1-3fee-4060-a676-01b91e5996d0@github.com>

On Wed, 24 Nov 2021 17:48:37 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed third party dependency of Twitter4J from license file

Changes requested by hirt (Lead).

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAunthenticator.java line 234:

> 232: 		mac.init(secretKey);
> 233: 
> 234: 		byte[] text = baseString.getBytes();

I'd probably inline the text local variable, since it's only used once.

application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java line 188:

> 186: 		Random random = new Random();
> 187: 
> 188: 		String generatedString = random.ints(leftLimit, rightLimit + 1)

I'd inline generatedString.

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From hdafgard at openjdk.java.net  Wed Nov 24 19:06:10 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 24 Nov 2021 19:06:10 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule. [v2]
In-Reply-To: <8MN9KvyumUkhdcxel1wQHcDioJF3WNyuPqWHxjLgkeA=.f38fc47e-2e64-45cd-adfd-22bcadef6b71@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
 <8MN9KvyumUkhdcxel1wQHcDioJF3WNyuPqWHxjLgkeA=.f38fc47e-2e64-45cd-adfd-22bcadef6b71@github.com>
Message-ID: <GDP_qFkacuXdNAT8usRd2aSTUpVUd6TFZT0fk4WZ7uU=.18fabb8d-36cf-4533-ac09-076dde63159d@github.com>

On Tue, 27 Jul 2021 14:37:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the optimization of Class Leak Rule.
>> 
>> Please refer the JBS for the sample JFR which was taking ~90 minutes to generate results for Class Leak Rule. After the optimization time is reduced to ~10-15 minutes.
>> 
>> Please review the change and let me the know if there are any comments / suggestions.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Calculation maximum timeout is set via preference and hardcoding removed.

I also agree with Brice's suggestions for changes.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java line 159:

> 157: 		IItemCollection items, IPreferenceValueProvider valueProvider, IResultValueProvider dependencyResults) {
> 158: 		int warningLimit = (int) valueProvider.getPreferenceValue(WARNING_LIMIT).longValue();
> 159: 		CONFIGURED_TIMEOUT = (int) valueProvider.getPreferenceValue(MAX_TIMEOUT).longValue();

This adds state to a rule and is going to cause issues if you're evaluating rules in parallel with different timeout configurations. Any such field must be final instead.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 83:

> 81: 	private void calculateData(IItemCollection input) throws InterruptedException {
> 82: 		input = input.apply(query.getFilter());
> 83: 		final IItemCollection newInput = input;

Can't this be done in the calling function instead of here? This should also be where the timeout is passed into this method instead of as a public static variable.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 135:

> 133: 				}
> 134: 				// Timeout can be configured in prefrences (default value is set to 5 minutes)
> 135: 				exec.awaitTermination(ClassLeakingRule.CONFIGURED_TIMEOUT, TimeUnit.MINUTES);

This means that the generic DefaultIItemResultSet class has an explicit dependency on the configuration of one rule, much better to add a timeout parameter at the creation of the instance.

-------------

Changes requested by hdafgard (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/248

From hdafgard at openjdk.java.net  Wed Nov 24 19:06:11 2021
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 24 Nov 2021 19:06:11 GMT
Subject: RFR: 7248: JMC7/8 Automated Analysis taking very long time to
 produce results for Class Leak Rule. [v2]
In-Reply-To: <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
References: <Z3iBC1F9opjtmLT4pLMnbppdQ6n8HtShSr6VGKPZ9TI=.88ec1592-1ec6-4d2c-901f-e215f6d3dfd5@github.com>
 <HNM7GkfvFzkYhzGVT0Tq4vLCyzCMrkzQ98upmJlG54w=.b227c920-302e-4882-bd15-dc533622cab9@github.com>
Message-ID: <gwPLT4YB1iTj-8Lwoi4TQozMWUKSDiFLRO2A3weBZZg=.0d57d263-1a63-410c-8bd9-83ae12e1e759@github.com>

On Mon, 17 May 2021 15:44:26 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Calculation maximum timeout is set via preference and hardcoding removed.
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 76:
> 
>> 74: 		} catch (Exception e) {
>> 75: 			e.printStackTrace();
>> 76: 		}
> 
> Don't swallow the interrupted exception, if this happens, this mean the code calling awaitTermination has been interrupted, the code should make sure the current thread is interrupted.

This should really be logged properly rather than just printing the exception, and it definitely shouldn't catch all exceptions.

-------------

PR: https://git.openjdk.java.net/jmc/pull/248

From hirt at openjdk.java.net  Thu Nov 25 09:57:07 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 09:57:07 GMT
Subject: RFR: 5904: Merge org.openjdk.jmc.ui.celleditors with
 org.openjdk.jmc.rjmx.ui.celleditors [v6]
In-Reply-To: <60k9D7ZmeN8xynOPgDhnlxocUYtQ9iWzDtEOg_4r3gM=.dd1f0223-e266-42dd-8c44-0ad68f75f876@github.com>
References: <U9YY7_Yst0dzuwPDbz_PhKZ4L3fHdNOGtxjt-f5fD88=.efc5d4a1-2e71-4e8e-bcac-41ebf8e71b4f@github.com>
 <60k9D7ZmeN8xynOPgDhnlxocUYtQ9iWzDtEOg_4r3gM=.dd1f0223-e266-42dd-8c44-0ad68f75f876@github.com>
Message-ID: <pn0zecZDQh2XgrruwKBqJ3bHzz6JM8PYsCn4HrpjL6U=.cc2868f4-523b-4f4b-b517-2cd828808aa3@github.com>

On Mon, 22 Nov 2021 21:06:57 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-5904 [[0]](https://bugs.openjdk.java.net/browse/JMC-5904), in which it is noted that org.openjdk.jmc.ui.celleditors could be merged with org.openjdk.jmc.rjmx.ui.celleditors instead of separating the code.
>> 
>> This is achieved by combining the celleditors code into a new package; org.openjdk.jmc.ui.celleditors. Originally the intent was to throw the jmc.ui.celleditors code into rjmx.ui.celleditors. however this gets complicated because jmc.ui.misc.FilterEditor (which requires CommonCellEditors) gets used in flightrecorder.ui. As a result, moving the celleditors code into rjmx.ui.celleditors would add a dependency on rjmx.ui from flightrecorder.ui, which is not ideal.
>> 
>> To alleviate this, FilterEditor has been moved to flightrecorder.ui (which is the only place it's used currently anyways), and celleditors have been moved to it's own package so it can be imported by rjmx.ui and jmc.ui (and subsequently flightrecorder.ui) as required. This removes the dependency from rjmx.ui to flightrecorder.ui.
>> 
>> EDIT (November 19th): below is the original concept for this PR; to merge jmc.ui.celleditors into rjmx.ui.celleditors. However, this creates a situation where rjmx.ui becomes a dependency of flightrecorder.ui, which is not ideal. For reference, I'll leave the original PR body below.
>> 
>> For the most part this is a fairly straightforward migration of code. There are three classes in jmc.ui.celleditors that needed to be moved into rjmx.ui.celleditors:
>> 1. ClearableTextCellEditor
>> 2. CommonCellEditors
>> 3. NullableTextCellEditor
>> 
>> Once these files are moved there is a slight problem: org.openjdk.jmc.ui.misc.FilterEditor uses CommonCellEditors, and org.openjdk.jmc.rjmx.ui requires org.openjdk.jmc.ui. In this case, adding a dependency from org.openjdk.jmc.rjmx.ui.celleditors.CommonCellEditors to org.openjdk.jmc.ui.misc.FilterEditors would introduce a circular dependency.
>> 
>> The solution I've gone with here is to move FilterEditor to org.openjdk.jmc.flightrecorder.ui, which IMO makes sense anyways because it's closer to the code it gets consumed by. FilterEditor is used in:
>> - _org.openjdk.jmc.flightrecorder.ui_.common.DataPageToolkit
>> - _org.openjdk.jmc.flightrecorder.ui_.common.FilterComponent
>> - _org.openjdk.jmc.flightrecorder.ui_.common.LaneEditor
>> - _org.openjdk.jmc.flightrecorder.ui_.pages.ItemHandlerPage
>> 
>> **Note:** this issue was originally targeted for 8.1.0, but isn't really critical (it's a P4 task), so if desired we can hold off on integrating it now and keep this around for integration into 8.2.0 as discussed in the jmc bi-weekly calls
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-5904
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - move celleditors to org.openjdk.jmc.ui.celleditors
>    
>    This commit moves the celleditors code into it's own package: org.openjdk.jmc.ui.celleditors. This removes the dependency on rjmx.ui for flightrecorder.ui. Now, both rjmx.ui and flightrecorder.ui import org.openjdk.jmc.ui.celleditors. The l10n packages have also been updated with their respective strings.
>  - update license headers
>  - 5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/271

From hirt at openjdk.java.net  Thu Nov 25 14:27:22 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 14:27:22 GMT
Subject: [jmc-graphics] RFR: 7453: Add heat map icon
Message-ID: <SZGkWGEAJhbhCHFFDcVdPNmgymiJMp74xkI8bBgTtbs=.07a527da-4885-470d-b4ab-aca9b9e1370c@github.com>

For cimi's heat map view.

-------------

Commit messages:
 - 7453: Add heat map icon

Changes: https://git.openjdk.java.net/jmc-graphics/pull/7/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=7&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7453
  Stats: 0 lines in 3 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc-graphics/pull/7.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc-graphics pull/7/head:pull/7

PR: https://git.openjdk.java.net/jmc-graphics/pull/7

From aptmac at openjdk.java.net  Thu Nov 25 19:03:07 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 25 Nov 2021 19:03:07 GMT
Subject: Integrated: 5904: Merge org.openjdk.jmc.ui.celleditors with
 org.openjdk.jmc.rjmx.ui.celleditors
In-Reply-To: <U9YY7_Yst0dzuwPDbz_PhKZ4L3fHdNOGtxjt-f5fD88=.efc5d4a1-2e71-4e8e-bcac-41ebf8e71b4f@github.com>
References: <U9YY7_Yst0dzuwPDbz_PhKZ4L3fHdNOGtxjt-f5fD88=.efc5d4a1-2e71-4e8e-bcac-41ebf8e71b4f@github.com>
Message-ID: <yCNbRvP4uVFBmvV-9VJvvL27lfqgbUkHvlLu25FV9iI=.74d0dec1-9da2-480f-b7da-80dd0389cc21@github.com>

On Tue, 29 Jun 2021 16:52:20 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-5904 [[0]](https://bugs.openjdk.java.net/browse/JMC-5904), in which it is noted that org.openjdk.jmc.ui.celleditors could be merged with org.openjdk.jmc.rjmx.ui.celleditors instead of separating the code.
> 
> This is achieved by combining the celleditors code into a new package; org.openjdk.jmc.ui.celleditors. Originally the intent was to throw the jmc.ui.celleditors code into rjmx.ui.celleditors. however this gets complicated because jmc.ui.misc.FilterEditor (which requires CommonCellEditors) gets used in flightrecorder.ui. As a result, moving the celleditors code into rjmx.ui.celleditors would add a dependency on rjmx.ui from flightrecorder.ui, which is not ideal.
> 
> To alleviate this, FilterEditor has been moved to flightrecorder.ui (which is the only place it's used currently anyways), and celleditors have been moved to it's own package so it can be imported by rjmx.ui and jmc.ui (and subsequently flightrecorder.ui) as required. This removes the dependency from rjmx.ui to flightrecorder.ui.
> 
> EDIT (November 19th): below is the original concept for this PR; to merge jmc.ui.celleditors into rjmx.ui.celleditors. However, this creates a situation where rjmx.ui becomes a dependency of flightrecorder.ui, which is not ideal. For reference, I'll leave the original PR body below.
> 
> For the most part this is a fairly straightforward migration of code. There are three classes in jmc.ui.celleditors that needed to be moved into rjmx.ui.celleditors:
> 1. ClearableTextCellEditor
> 2. CommonCellEditors
> 3. NullableTextCellEditor
> 
> Once these files are moved there is a slight problem: org.openjdk.jmc.ui.misc.FilterEditor uses CommonCellEditors, and org.openjdk.jmc.rjmx.ui requires org.openjdk.jmc.ui. In this case, adding a dependency from org.openjdk.jmc.rjmx.ui.celleditors.CommonCellEditors to org.openjdk.jmc.ui.misc.FilterEditors would introduce a circular dependency.
> 
> The solution I've gone with here is to move FilterEditor to org.openjdk.jmc.flightrecorder.ui, which IMO makes sense anyways because it's closer to the code it gets consumed by. FilterEditor is used in:
> - _org.openjdk.jmc.flightrecorder.ui_.common.DataPageToolkit
> - _org.openjdk.jmc.flightrecorder.ui_.common.FilterComponent
> - _org.openjdk.jmc.flightrecorder.ui_.common.LaneEditor
> - _org.openjdk.jmc.flightrecorder.ui_.pages.ItemHandlerPage
> 
> **Note:** this issue was originally targeted for 8.1.0, but isn't really critical (it's a P4 task), so if desired we can hold off on integrating it now and keep this around for integration into 8.2.0 as discussed in the jmc bi-weekly calls
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-5904

This pull request has now been integrated.

Changeset: 24f4cb0e
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/24f4cb0e5cbf862c51aa6eca40a24ae4312406a4
Stats:     776 lines in 67 files changed: 293 ins; 394 del; 89 mod

5904: Merge org.openjdk.jmc.ui.celleditors with org.openjdk.jmc.rjmx.ui.celleditors

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/271

From aptmac at openjdk.java.net  Thu Nov 25 19:04:03 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 25 Nov 2021 19:04:03 GMT
Subject: [jmc-graphics] RFR: 7453: Add heat map icon
In-Reply-To: <SZGkWGEAJhbhCHFFDcVdPNmgymiJMp74xkI8bBgTtbs=.07a527da-4885-470d-b4ab-aca9b9e1370c@github.com>
References: <SZGkWGEAJhbhCHFFDcVdPNmgymiJMp74xkI8bBgTtbs=.07a527da-4885-470d-b4ab-aca9b9e1370c@github.com>
Message-ID: <_SG_TyCJKRURuu68-z3Zrca3XlFdel9ysaKUlQSiA6Q=.b846dae1-9a7f-48c5-b6dc-5a77bef22886@github.com>

On Thu, 25 Nov 2021 14:21:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> For cimi's heat map view.

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc-graphics/pull/7

From hirt at openjdk.java.net  Thu Nov 25 19:07:11 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 19:07:11 GMT
Subject: [jmc-graphics] Integrated: 7453: Add heat map icon
In-Reply-To: <SZGkWGEAJhbhCHFFDcVdPNmgymiJMp74xkI8bBgTtbs=.07a527da-4885-470d-b4ab-aca9b9e1370c@github.com>
References: <SZGkWGEAJhbhCHFFDcVdPNmgymiJMp74xkI8bBgTtbs=.07a527da-4885-470d-b4ab-aca9b9e1370c@github.com>
Message-ID: <QW8ihOE_ajozrJ7QBjwpf2xQ-NhpyVER-8Pkd9jwOqA=.620a07ec-53aa-496b-a7ed-f438531718b0@github.com>

On Thu, 25 Nov 2021 14:21:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> For cimi's heat map view.

This pull request has now been integrated.

Changeset: bd34acb1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc-graphics/commit/bd34acb1eef1ec74409c02b3950dfe69aa79376f
Stats:     0 lines in 3 files changed: 0 ins; 0 del; 0 mod

7453: Add heat map icon

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc-graphics/pull/7

From hirt at openjdk.java.net  Thu Nov 25 19:30:06 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 19:30:06 GMT
Subject: RFR: 7446: Add Maven profile for enabling test coverage
In-Reply-To: <9gf7itOF5K_DD5Vp3CaF8olU1Y-jgNp15_EvRIk7tgc=.a33725cd-a9fa-4e03-91f3-5f1cc9c96db8@github.com>
References: <9gf7itOF5K_DD5Vp3CaF8olU1Y-jgNp15_EvRIk7tgc=.a33725cd-a9fa-4e03-91f3-5f1cc9c96db8@github.com>
Message-ID: <YRF-x8B34gOVQqzVckoQhf8rKT5xMVAZr_DsoFYXzfI=.6c125574-2e39-4a97-be9b-0302f2dc505e@github.com>

On Mon, 22 Nov 2021 21:03:13 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7446 [[0]](https://bugs.openjdk.java.net/browse/JMC-7446), in which it would be nice to have a Maven profile for enabling test coverage.
> 
> At the moment, test coverage is enabled by default with no way of disabling it. This PR adds a Maven profile (in a similar vein to how uitests are run) that allows coverage reports to be enabled or disabled as desired. This profile is included in both the core and application poms.
> 
> Usage: `mvn clean install -P coverage`, or `mvn clean verify -P coverage -P uitests`, etc.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7446

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/336

From hirt at openjdk.java.net  Thu Nov 25 19:31:09 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 19:31:09 GMT
Subject: RFR: 7447: Add serializers and writer modules to core test
 coverage
In-Reply-To: <0ODPS5mpWlEPu3ZbUUElANDl3yuxvcjCfRSu95OvEVc=.fd1bfc83-5b2a-44f4-b5f7-8ebdaebd507c@github.com>
References: <0ODPS5mpWlEPu3ZbUUElANDl3yuxvcjCfRSu95OvEVc=.fd1bfc83-5b2a-44f4-b5f7-8ebdaebd507c@github.com>
Message-ID: <C8rPAiJcpu9TSky-82bPNfQ9jfvLMsoDqrcX3NI5_lI=.52380853-3f78-4836-8ad9-ee3b0a706329@github.com>

On Mon, 22 Nov 2021 21:00:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7447 [[0]](https://bugs.openjdk.java.net/browse/JMC-7447), in which the core coverage reports are missing the serializers and writer modules. The changes here simply add the missing modules to the coverage dependency list.
> 
> Additionally, the jdp.test module is missing the `<scope>test</scope>` attribute, so I've added it in here.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7447

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/335

From aptmac at openjdk.java.net  Thu Nov 25 19:34:05 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 25 Nov 2021 19:34:05 GMT
Subject: Integrated: 7446: Add Maven profile for enabling test coverage
In-Reply-To: <9gf7itOF5K_DD5Vp3CaF8olU1Y-jgNp15_EvRIk7tgc=.a33725cd-a9fa-4e03-91f3-5f1cc9c96db8@github.com>
References: <9gf7itOF5K_DD5Vp3CaF8olU1Y-jgNp15_EvRIk7tgc=.a33725cd-a9fa-4e03-91f3-5f1cc9c96db8@github.com>
Message-ID: <XP1WZOAdGMd6hh4K6kTQ3no_QJ2biX56u1eHiy7h8OU=.16d525c2-8e9b-4e9b-97dd-3bcf91cdbd3c@github.com>

On Mon, 22 Nov 2021 21:03:13 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7446 [[0]](https://bugs.openjdk.java.net/browse/JMC-7446), in which it would be nice to have a Maven profile for enabling test coverage.
> 
> At the moment, test coverage is enabled by default with no way of disabling it. This PR adds a Maven profile (in a similar vein to how uitests are run) that allows coverage reports to be enabled or disabled as desired. This profile is included in both the core and application poms.
> 
> Usage: `mvn clean install -P coverage`, or `mvn clean verify -P coverage -P uitests`, etc.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7446

This pull request has now been integrated.

Changeset: 35c8e0e2
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/35c8e0e2e555caeea4fd3760f054c0dffdd137a6
Stats:     218 lines in 7 files changed: 129 ins; 78 del; 11 mod

7446: Add Maven profile for enabling test coverage

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/336

From aptmac at openjdk.java.net  Thu Nov 25 19:38:06 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 25 Nov 2021 19:38:06 GMT
Subject: Integrated: 7447: Add serializers and writer modules to core test
 coverage
In-Reply-To: <0ODPS5mpWlEPu3ZbUUElANDl3yuxvcjCfRSu95OvEVc=.fd1bfc83-5b2a-44f4-b5f7-8ebdaebd507c@github.com>
References: <0ODPS5mpWlEPu3ZbUUElANDl3yuxvcjCfRSu95OvEVc=.fd1bfc83-5b2a-44f4-b5f7-8ebdaebd507c@github.com>
Message-ID: <YrufEXS3tnDFGNXmwuEfUYqKeybbdQEHDf_1qOpX44k=.e68755c4-71ca-465b-bb3b-5e3be40b4bfa@github.com>

On Mon, 22 Nov 2021 21:00:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7447 [[0]](https://bugs.openjdk.java.net/browse/JMC-7447), in which the core coverage reports are missing the serializers and writer modules. The changes here simply add the missing modules to the coverage dependency list.
> 
> Additionally, the jdp.test module is missing the `<scope>test</scope>` attribute, so I've added it in here.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7447

This pull request has now been integrated.

Changeset: 3ce64837
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/3ce6483718c7a1ae5d490ded7f34cefde63fc42e
Stats:     23 lines in 1 file changed: 23 ins; 0 del; 0 mod

7447: Add serializers and writer modules to core test coverage

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/335

From duke at openjdk.java.net  Thu Nov 25 21:28:22 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Thu, 25 Nov 2021 21:28:22 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v10]
In-Reply-To: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
Message-ID: <ZKHkYa0J3_Fb3fqby5zDsjL6ZIZ6b_Hsw7PH10sJ3j0=.5f1e3fe7-e0b2-4a6d-9b86-76fa51fdf521@github.com>

> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
> 
> ![Screenshot 2021-09-15 at 12 08 56](https://user-images.githubusercontent.com/348973/133478041-ee436fbd-de3a-471d-955d-d0fe4cc854bf.png)
> 
> ### Dependency management
> 
> 
> Brice pointed out that there are newer versions of the Jetty websocket server available under a different artefact name - I used the same version as required in the UI tests (`10.0.5`) and this made the build succeed in both eclipse and CLI. I've had to add SPI fly since it was required by jetty, but I don't really understand what it does.
> 
> Initially I struggled to add the required dependencies to the project. Initially I was only testing in eclipse with the setup from #225 and it worked fine.`mvn package` also worked on the command line. However, the spotless task from our CI script failed with the following error:
> 
> 
> org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"] because it is exposed to package 'javax.servlet' from resources javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"] and jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"] via two dependency chains.
> [ERROR] 
> [ERROR] Chain 1:
> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
> [ERROR]     require: (osgi.wiring.bundle=javax.servlet)
> [ERROR]      |
> [ERROR]     provide: osgi.wiring.bundle: javax.servlet
> [ERROR]   javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"]
> [ERROR] 
> [ERROR] Chain 2:
> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
> [ERROR]     require: (osgi.wiring.bundle=org.eclipse.jetty.server)
> [ERROR]      |
> [ERROR]     provide: osgi.wiring.bundle; bundle-version:Version="10.0.5"; osgi.wiring.bundle="org.eclipse.jetty.server"
> [ERROR]   org.eclipse.jetty.server [osgi.identity; osgi.identity="org.eclipse.jetty.server"; type="osgi.bundle"; version:Version="10.0.5"]
> [ERROR]     import: (&(osgi.wiring.package=javax.servlet)(&(version>=4.0.0)(!(version>=5.0.0))))
> [ERROR]      |
> [ERROR]     export: osgi.wiring.package: javax.servlet
> [ERROR]   jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"]
> 
> 
> This is because the task is run with the `-P uitests` and something in the UI test configuration pulls in jetty.server 10.0.5. Since [the latest available version](https://mvnrepository.com/artifact/org.eclipse.jetty.websocket/websocket-server) for the jetty websocket server is `9.4.43.v20210629` we can't use the newer `10.x` for the transitive dependencies.
> 
> I was able to work around this problem by setting bundle-version constraints in the `flightrecorder.ui` manifest. This makes all CI checks pass, but unfortunately it also breaks the JFR editor view in eclipse ?? 
> 
> 
> org.osgi.framework.BundleException: Could not resolve module: org.openjdk.jmc.joverflow.ui [457]
>   Unresolved requirement: Import-Package: org.openjdk.jmc.flightrecorder.ui
>     -> Export-Package: org.openjdk.jmc.flightrecorder.ui; bundle-symbolic-name="org.openjdk.jmc.flightrecorder.ui"; bundle-version="8.2.0.qualifier"; version="0.0.0"
>        org.openjdk.jmc.flightrecorder.ui [445]
>          Unresolved requirement: Require-Bundle: org.eclipse.jetty.server; bundle-version="[9.4.43,10.0.0)"

Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits:

 - Merge branch 'master' into cimi/websocket-server
 - Add additional asm and asm.tree plugins to eclipse launchers
 - Fix websocket UI messages and copyright notices
 - Use CopyOnWriteArrayList for websocket handlers; remove useless cast
 - Fix copyright statememnts: remove Datadog in existing files, use year ranges
 - Remove 2019-12 platform definition, leftover after rebase
 - Add tree and graph handlers to websocket server
 - Revert whitespace changes in core/features.xml
 - Make websocket server port configurable
 - Make port a constructor argument for WebsocketServer
 - ... and 9 more: https://git.openjdk.java.net/jmc/compare/3ce64837...3d0d3e5c

-------------

Changes: https://git.openjdk.java.net/jmc/pull/306/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=09
  Stats: 513 lines in 19 files changed: 460 ins; 0 del; 53 mod
  Patch: https://git.openjdk.java.net/jmc/pull/306.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/306/head:pull/306

PR: https://git.openjdk.java.net/jmc/pull/306

From hirt at openjdk.java.net  Thu Nov 25 21:28:22 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 25 Nov 2021 21:28:22 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v9]
In-Reply-To: <FYBuZGXCUtqi3tnikUAOhx0d_aGcQqiWqcB8FB6nfFs=.551e2b5e-4ebb-427b-ac91-f98d0093a0b4@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
 <FYBuZGXCUtqi3tnikUAOhx0d_aGcQqiWqcB8FB6nfFs=.551e2b5e-4ebb-427b-ac91-f98d0093a0b4@github.com>
Message-ID: <jsO8u13Jn85jSNzig1mqcU5lpy_1auTaZWnFLCIaTng=.9ef790cb-9b28-492d-9c1d-822e8ba1f3df@github.com>

On Wed, 27 Oct 2021 16:55:41 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
>> 
>> ![Screenshot 2021-09-15 at 12 08 56](https://user-images.githubusercontent.com/348973/133478041-ee436fbd-de3a-471d-955d-d0fe4cc854bf.png)
>> 
>> ### Dependency management
>> 
>> 
>> Brice pointed out that there are newer versions of the Jetty websocket server available under a different artefact name - I used the same version as required in the UI tests (`10.0.5`) and this made the build succeed in both eclipse and CLI. I've had to add SPI fly since it was required by jetty, but I don't really understand what it does.
>> 
>> Initially I struggled to add the required dependencies to the project. Initially I was only testing in eclipse with the setup from #225 and it worked fine.`mvn package` also worked on the command line. However, the spotless task from our CI script failed with the following error:
>> 
>> 
>> org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"] because it is exposed to package 'javax.servlet' from resources javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"] and jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"] via two dependency chains.
>> [ERROR] 
>> [ERROR] Chain 1:
>> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
>> [ERROR]     require: (osgi.wiring.bundle=javax.servlet)
>> [ERROR]      |
>> [ERROR]     provide: osgi.wiring.bundle: javax.servlet
>> [ERROR]   javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"]
>> [ERROR] 
>> [ERROR] Chain 2:
>> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
>> [ERROR]     require: (osgi.wiring.bundle=org.eclipse.jetty.server)
>> [ERROR]      |
>> [ERROR]     provide: osgi.wiring.bundle; bundle-version:Version="10.0.5"; osgi.wiring.bundle="org.eclipse.jetty.server"
>> [ERROR]   org.eclipse.jetty.server [osgi.identity; osgi.identity="org.eclipse.jetty.server"; type="osgi.bundle"; version:Version="10.0.5"]
>> [ERROR]     import: (&(osgi.wiring.package=javax.servlet)(&(version>=4.0.0)(!(version>=5.0.0))))
>> [ERROR]      |
>> [ERROR]     export: osgi.wiring.package: javax.servlet
>> [ERROR]   jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"]
>> 
>> 
>> This is because the task is run with the `-P uitests` and something in the UI test configuration pulls in jetty.server 10.0.5. Since [the latest available version](https://mvnrepository.com/artifact/org.eclipse.jetty.websocket/websocket-server) for the jetty websocket server is `9.4.43.v20210629` we can't use the newer `10.x` for the transitive dependencies.
>> 
>> I was able to work around this problem by setting bundle-version constraints in the `flightrecorder.ui` manifest. This makes all CI checks pass, but unfortunately it also breaks the JFR editor view in eclipse ?? 
>> 
>> 
>> org.osgi.framework.BundleException: Could not resolve module: org.openjdk.jmc.joverflow.ui [457]
>>   Unresolved requirement: Import-Package: org.openjdk.jmc.flightrecorder.ui
>>     -> Export-Package: org.openjdk.jmc.flightrecorder.ui; bundle-symbolic-name="org.openjdk.jmc.flightrecorder.ui"; bundle-version="8.2.0.qualifier"; version="0.0.0"
>>        org.openjdk.jmc.flightrecorder.ui [445]
>>          Unresolved requirement: Require-Bundle: org.eclipse.jetty.server; bundle-version="[9.4.43,10.0.0)"
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add additional asm and asm.tree plugins to eclipse launchers

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/306

From aptmac at openjdk.java.net  Thu Nov 25 21:37:11 2021
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 25 Nov 2021 21:37:11 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v10]
In-Reply-To: <ZKHkYa0J3_Fb3fqby5zDsjL6ZIZ6b_Hsw7PH10sJ3j0=.5f1e3fe7-e0b2-4a6d-9b86-76fa51fdf521@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
 <ZKHkYa0J3_Fb3fqby5zDsjL6ZIZ6b_Hsw7PH10sJ3j0=.5f1e3fe7-e0b2-4a6d-9b86-76fa51fdf521@github.com>
Message-ID: <vvahCwl5t8s26IToUjdjd4XJKfJ61heFeS8o9HnG8UE=.1e33bfde-c121-40bd-bb8f-09d1ac4328ad@github.com>

On Thu, 25 Nov 2021 21:28:22 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
>> 
>> ![Screenshot 2021-09-15 at 12 08 56](https://user-images.githubusercontent.com/348973/133478041-ee436fbd-de3a-471d-955d-d0fe4cc854bf.png)
>> 
>> ### Dependency management
>> 
>> 
>> Brice pointed out that there are newer versions of the Jetty websocket server available under a different artefact name - I used the same version as required in the UI tests (`10.0.5`) and this made the build succeed in both eclipse and CLI. I've had to add SPI fly since it was required by jetty, but I don't really understand what it does.
>> 
>> Initially I struggled to add the required dependencies to the project. Initially I was only testing in eclipse with the setup from #225 and it worked fine.`mvn package` also worked on the command line. However, the spotless task from our CI script failed with the following error:
>> 
>> 
>> org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"] because it is exposed to package 'javax.servlet' from resources javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"] and jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"] via two dependency chains.
>> [ERROR] 
>> [ERROR] Chain 1:
>> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
>> [ERROR]     require: (osgi.wiring.bundle=javax.servlet)
>> [ERROR]      |
>> [ERROR]     provide: osgi.wiring.bundle: javax.servlet
>> [ERROR]   javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"]
>> [ERROR] 
>> [ERROR] Chain 2:
>> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
>> [ERROR]     require: (osgi.wiring.bundle=org.eclipse.jetty.server)
>> [ERROR]      |
>> [ERROR]     provide: osgi.wiring.bundle; bundle-version:Version="10.0.5"; osgi.wiring.bundle="org.eclipse.jetty.server"
>> [ERROR]   org.eclipse.jetty.server [osgi.identity; osgi.identity="org.eclipse.jetty.server"; type="osgi.bundle"; version:Version="10.0.5"]
>> [ERROR]     import: (&(osgi.wiring.package=javax.servlet)(&(version>=4.0.0)(!(version>=5.0.0))))
>> [ERROR]      |
>> [ERROR]     export: osgi.wiring.package: javax.servlet
>> [ERROR]   jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"]
>> 
>> 
>> This is because the task is run with the `-P uitests` and something in the UI test configuration pulls in jetty.server 10.0.5. Since [the latest available version](https://mvnrepository.com/artifact/org.eclipse.jetty.websocket/websocket-server) for the jetty websocket server is `9.4.43.v20210629` we can't use the newer `10.x` for the transitive dependencies.
>> 
>> I was able to work around this problem by setting bundle-version constraints in the `flightrecorder.ui` manifest. This makes all CI checks pass, but unfortunately it also breaks the JFR editor view in eclipse ?? 
>> 
>> 
>> org.osgi.framework.BundleException: Could not resolve module: org.openjdk.jmc.joverflow.ui [457]
>>   Unresolved requirement: Import-Package: org.openjdk.jmc.flightrecorder.ui
>>     -> Export-Package: org.openjdk.jmc.flightrecorder.ui; bundle-symbolic-name="org.openjdk.jmc.flightrecorder.ui"; bundle-version="8.2.0.qualifier"; version="0.0.0"
>>        org.openjdk.jmc.flightrecorder.ui [445]
>>          Unresolved requirement: Require-Bundle: org.eclipse.jetty.server; bundle-version="[9.4.43,10.0.0)"
>
> Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits:
> 
>  - Merge branch 'master' into cimi/websocket-server
>  - Add additional asm and asm.tree plugins to eclipse launchers
>  - Fix websocket UI messages and copyright notices
>  - Use CopyOnWriteArrayList for websocket handlers; remove useless cast
>  - Fix copyright statememnts: remove Datadog in existing files, use year ranges
>  - Remove 2019-12 platform definition, leftover after rebase
>  - Add tree and graph handlers to websocket server
>  - Revert whitespace changes in core/features.xml
>  - Make websocket server port configurable
>  - Make port a constructor argument for WebsocketServer
>  - ... and 9 more: https://git.openjdk.java.net/jmc/compare/3ce64837...3d0d3e5c

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/306

From reinhapa at openjdk.java.net  Thu Nov 25 21:56:07 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 25 Nov 2021 21:56:07 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v2]
In-Reply-To: <iscua9kM9T_lKFyQhO5gTdOIw44pCAzfFrV02pv4q8A=.229bd2e8-4b44-4015-8e63-cbf984347197@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
 <_b0KCu_bxmsBArxhi28X7TkgUrl-MDtOhdcTS6nOVYs=.80650324-da4d-464a-84c0-b4eb3e018780@github.com>
 <iscua9kM9T_lKFyQhO5gTdOIw44pCAzfFrV02pv4q8A=.229bd2e8-4b44-4015-8e63-cbf984347197@github.com>
Message-ID: <FNwJ9yUZpD_bFCN0DkAWFM4-UcaXVmBJiyMvp9biaLw=.ff751968-a538-48b9-98a9-d6b76cc95781@github.com>

On Thu, 21 Oct 2021 20:17:26 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> I saw it, when running it locally. It also seems to have some issues with a lot of static methods returning static class variables, that in my opinion do not seem to be a problem as those `getInstance()` methods on a different plugin classes.
> 
> There seem to be already an issue opened on the spotbugs project. I will still check the other issues and include potential class changes within this PR later next week.

> Have you had time to take a look at the failing tests yet @reinhapa?

@thegreystone unfortunately not, actually swamped in work ??, hope it get's better this week...

-------------

PR: https://git.openjdk.java.net/jmc/pull/324

From duke at openjdk.java.net  Fri Nov 26 06:08:33 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Fri, 26 Nov 2021 06:08:33 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection
Message-ID: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>

Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

-------------

Commit messages:
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - Added copyright notices. Removed author tag and meaningless comments
 - No reason more than Java 8 should be required
 - Working on spotbugs errors and build problems
 - [WIP] Jolokia support

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7455
  Stats: 3142 lines in 47 files changed: 3142 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From reinhapa at openjdk.java.net  Fri Nov 26 06:08:34 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 26 Nov 2021 06:08:34 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <4pE_e3FIk0ZgheSUUGNOderWqYQk7tzO_MReA3AgAp8=.eae103dd-89d9-4f94-a515-d579f27498c3@github.com>

On Tue, 26 Oct 2021 19:58:20 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

@skarsaune do you have an JMC issue already or do you need help creating one?

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Fri Nov 26 06:08:38 2021
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Fri, 26 Nov 2021 06:08:38 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <u0KyxsHA1r-YLdWX-NYqkrjAsY0Zt9OJ3-gZ6Ex-p7o=.8b90f189-854b-4489-8568-b3467d622a40@github.com>

On Tue, 26 Oct 2021 19:58:20 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

> 

@reinhapa : Please help creating an issue. I do not have access.

application/org.openjdk.jmc.jolokia/pom.xml line 64:

> 62: 			</plugin>
> 63: 			<plugin>
> 64: 				<groupId>org.apache.maven.plugins</groupId>

Sooo .... I am not sure about the preferred way to pull in external dependencies. I can add that both jolokia libraries come as shaded jars with some OSGi packaging, but I do not know enough about that to say whether that would be a workable or better solution. These are quite new components, so we can probably modify the OSGI packaging in Jolokia going forwards if needed. 
POM: https://github.com/rhuss/jolokia/blob/556b58e63a125fb79d516d7f7833e22270f591b0/client/jmx-adapter/pom.xml#L129
Artifact: https://repo1.maven.org/maven2/org/jolokia/jolokia-jmx-adapter/1.7.0/jolokia-jmx-adapter-1.7.0-standalone.jar

application/org.openjdk.jmc.kubernetes/pom.xml line 65:

> 63: 			<plugin>
> 64: 				<groupId>org.apache.maven.plugins</groupId>
> 65: 				<artifactId>maven-dependency-plugin</artifactId>

Same question as for jolokia pom.xml. 
Corresponding resources:
https://github.com/rhuss/jolokia/blob/556b58e63a125fb79d516d7f7833e22270f591b0/client/kubernetes/pom.xml#L44
https://repo1.maven.org/maven2/org/jolokia/jolokia-kubernetes/1.7.0/jolokia-kubernetes-1.7.0-standalone.jar

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 102:

> 100: 	public void testReadAttributesOverJolokia() throws MalformedURLException, IOException, OperationsException,
> 101: 			IntrospectionException, AttributeNotFoundException, ReflectionException, MBeanException {
> 102: 		for (ObjectName objectName : jolokiaConnection.queryNames(null, null)) {

Iterating over all attributes may require some maintenance. However it will also detect any problems with this connector for new JVM developments. 
I can consider just testing a few select attributes instead.

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 127:

> 125: 	}
> 126: 
> 127: 	private static MBeanServerConnection getJolokiaMBeanConnector() throws IOException, MalformedURLException {

Testing discovery may pose for CI environments (?). We can consider making it manual if networking is an issue

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From reinhapa at openjdk.java.net  Fri Nov 26 06:08:39 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 26 Nov 2021 06:08:39 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection
In-Reply-To: <u0KyxsHA1r-YLdWX-NYqkrjAsY0Zt9OJ3-gZ6Ex-p7o=.8b90f189-854b-4489-8568-b3467d622a40@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <u0KyxsHA1r-YLdWX-NYqkrjAsY0Zt9OJ3-gZ6Ex-p7o=.8b90f189-854b-4489-8568-b3467d622a40@github.com>
Message-ID: <s0di7FTV2UTtqP-aeIeZbaQJBhcD2XXZO3kxXG2Hnxo=.1529b3e8-caa6-45ba-a17e-3344995be4aa@github.com>

On Tue, 23 Nov 2021 08:15:22 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
>> 
> 
> @reinhapa : Please help creating an issue. I do not have access.

@skarsaune created [JMC-7455](https://bugs.openjdk.java.net/browse/JMC-7455) change the title to: _7455: Add support for jolokia JMX service connection_

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From hirt at openjdk.java.net  Fri Nov 26 06:08:44 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 26 Nov 2021 06:08:44 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <wyAHwN-Sm4T3pveYYTiaSYqiCk5Ze0bXhPRLvZ6r5_g=.f4d05237-759c-4464-9392-2e69d36d9cf4@github.com>

On Tue, 26 Oct 2021 19:58:20 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

application/org.openjdk.jmc.jolokia/build.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

For new files, don't forget to add the right copyright year (2021), and a line for your current employer (if it makes sense). See Datadog copyrights.

application/org.openjdk.jmc.jolokia/plugin.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--   
> 3:    Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.

I won't comment regarding copyright in any more files, but the comment before of course applies to all of them.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 10:

> 8:  *
> 9:  * or the following license:
> 10:  *

A short class description in public classes is nice. ;)

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 26:

> 24:  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
> 25:  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> 26:  * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR

We typically don't use the author tag in the project.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 11:

> 9:  * or the following license:
> 10:  *
> 11:  * Redistribution and use in source and binary forms, with or without modification, are permitted

Comments that don't really add to the understanding, we typically try to avoid.

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From schaturvedi at openjdk.java.net  Fri Nov 26 07:27:35 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 26 Nov 2021 07:27:35 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v7]
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <ouLN-8dEjX7YPQcLmF-BJCCQ-52XbIHCezAOJ0VmILE=.53f91902-e272-40e7-b8e3-c69f912a35c3@github.com>

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Implemented some review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/323/files
  - new: https://git.openjdk.java.net/jmc/pull/323/files/33fb63dd..f2b0a354

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=323&range=05-06

  Stats: 18 lines in 3 files changed: 0 ins; 10 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/323.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/323/head:pull/323

PR: https://git.openjdk.java.net/jmc/pull/323

From hirt at openjdk.java.net  Fri Nov 26 13:07:06 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 26 Nov 2021 13:07:06 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
Message-ID: <8nWCPpGEyiob9OwqsIp5XY85GpCiIE-tHaX_j31phWo=.1ef2f3f8-b913-4858-aa44-eacba7b34565@github.com>

On Wed, 10 Nov 2021 17:19:04 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

One last nit for this PR - can you please check the files for unnecessary imports? I'll add an issue for ensuring that this is done automatically.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Fri Nov 26 18:18:22 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Fri, 26 Nov 2021 18:18:22 GMT
Subject: RFR: 7451: Add heat map view
Message-ID: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>

This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).

The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.

Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.

I still have some TODOs to take care of (see below) but the code is ready for a first-pass review ?? 

- [ ] Add/fix copyright notices
- [ ] Ensure axes are always visible (when cells are very large sometimes the axes get cut off)
- [ ] Ensure minimum cell size - now the heatmap disappears if the window is too small (i.e. computed cell size is < 1px).
- [ ] Add a title to the chart? ('Showing `x` events collected between `tStart` and `tEnd`'?)
- [ ] Display a colour legend (like we have in the notebook) and some indicator that a cell represents 100ms
- [ ] Display 'no-data' message or banner when the selection is empty
- [ ] Display error message when rendering the heatmap fails? (this should be unlikely)

![Screenshot 2021-11-26 at 18 13 34](https://user-images.githubusercontent.com/348973/143618682-335d5877-8070-4a42-a8dc-5d4753a67667.png)

![Screenshot 2021-11-26 at 18 13 54](https://user-images.githubusercontent.com/348973/143618710-002acf31-00ea-41f4-908b-631e33eb7360.png)

-------------

Commit messages:
 - Extract heatmap javascript to a separate file to avoid escaping %
 - Remove debug logging from heatmap javascript
 - Make heatmap cell size auto-adjust depending on window size
 - Update heatmap icon
 - Rename references to d3 in heatmap to v6
 - Cleanup HeatmapView, remove unused code copied from GraphView
 - Update icon for heatmap plugin
 - Support multiple attributes for extracting the event time from a JFR event
 - Add logging helper in heatmap JS visualisation
 - Resize heatmap when parent window is resized
 - ... and 2 more: https://git.openjdk.java.net/jmc/compare/c7250786...3c71b4b2

Changes: https://git.openjdk.java.net/jmc/pull/337/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7451
  Stats: 635 lines in 15 files changed: 607 ins; 0 del; 28 mod
  Patch: https://git.openjdk.java.net/jmc/pull/337.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/337/head:pull/337

PR: https://git.openjdk.java.net/jmc/pull/337

From duke at openjdk.java.net  Fri Nov 26 18:26:40 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Fri, 26 Nov 2021 18:26:40 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v11]
In-Reply-To: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
Message-ID: <dPu5hpaTTfvjlewQvNlGyGCw1TrkJGvEyar0ySrejos=.d54930ba-7ca8-4109-b7c5-3d9b03323f7f@github.com>

> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
> 
> ![Screenshot 2021-09-15 at 12 08 56](https://user-images.githubusercontent.com/348973/133478041-ee436fbd-de3a-471d-955d-d0fe4cc854bf.png)
> 
> ### Dependency management
> 
> 
> Brice pointed out that there are newer versions of the Jetty websocket server available under a different artefact name - I used the same version as required in the UI tests (`10.0.5`) and this made the build succeed in both eclipse and CLI. I've had to add SPI fly since it was required by jetty, but I don't really understand what it does.
> 
> Initially I struggled to add the required dependencies to the project. Initially I was only testing in eclipse with the setup from #225 and it worked fine.`mvn package` also worked on the command line. However, the spotless task from our CI script failed with the following error:
> 
> 
> org.apache.felix.resolver.reason.ReasonException: Uses constraint violation. Unable to resolve resource org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"] because it is exposed to package 'javax.servlet' from resources javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"] and jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"] via two dependency chains.
> [ERROR] 
> [ERROR] Chain 1:
> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
> [ERROR]     require: (osgi.wiring.bundle=javax.servlet)
> [ERROR]      |
> [ERROR]     provide: osgi.wiring.bundle: javax.servlet
> [ERROR]   javax.servlet [osgi.identity; osgi.identity="javax.servlet"; type="osgi.bundle"; version:Version="3.1.0.v201410161800"]
> [ERROR] 
> [ERROR] Chain 2:
> [ERROR]   org.openjdk.jmc.flightrecorder.ui [osgi.identity; osgi.identity="org.openjdk.jmc.flightrecorder.ui"; type="osgi.bundle"; version:Version="8.2.0.qualifier"; singleton:="true"]
> [ERROR]     require: (osgi.wiring.bundle=org.eclipse.jetty.server)
> [ERROR]      |
> [ERROR]     provide: osgi.wiring.bundle; bundle-version:Version="10.0.5"; osgi.wiring.bundle="org.eclipse.jetty.server"
> [ERROR]   org.eclipse.jetty.server [osgi.identity; osgi.identity="org.eclipse.jetty.server"; type="osgi.bundle"; version:Version="10.0.5"]
> [ERROR]     import: (&(osgi.wiring.package=javax.servlet)(&(version>=4.0.0)(!(version>=5.0.0))))
> [ERROR]      |
> [ERROR]     export: osgi.wiring.package: javax.servlet
> [ERROR]   jakarta.servlet-api [osgi.identity; osgi.identity="jakarta.servlet-api"; type="osgi.bundle"; version:Version="4.0.0"]
> 
> 
> This is because the task is run with the `-P uitests` and something in the UI test configuration pulls in jetty.server 10.0.5. Since [the latest available version](https://mvnrepository.com/artifact/org.eclipse.jetty.websocket/websocket-server) for the jetty websocket server is `9.4.43.v20210629` we can't use the newer `10.x` for the transitive dependencies.
> 
> I was able to work around this problem by setting bundle-version constraints in the `flightrecorder.ui` manifest. This makes all CI checks pass, but unfortunately it also breaks the JFR editor view in eclipse ?? 
> 
> 
> org.osgi.framework.BundleException: Could not resolve module: org.openjdk.jmc.joverflow.ui [457]
>   Unresolved requirement: Import-Package: org.openjdk.jmc.flightrecorder.ui
>     -> Export-Package: org.openjdk.jmc.flightrecorder.ui; bundle-symbolic-name="org.openjdk.jmc.flightrecorder.ui"; bundle-version="8.2.0.qualifier"; version="0.0.0"
>        org.openjdk.jmc.flightrecorder.ui [445]
>          Unresolved requirement: Require-Bundle: org.eclipse.jetty.server; bundle-version="[9.4.43,10.0.0)"

Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:

  Update full name

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/306/files
  - new: https://git.openjdk.java.net/jmc/pull/306/files/3d0d3e5c..b120657c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=09-10

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/306.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/306/head:pull/306

PR: https://git.openjdk.java.net/jmc/pull/306

From jpbempel at openjdk.java.net  Fri Nov 26 20:46:41 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 26 Nov 2021 20:46:41 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
Message-ID: <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>

> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
> 
>  * track constant pool usage inside events
>  * replace or translate symbols, method names, etc... like
> de-obfuscations of stack traces

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  remove unused import

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/333/files
  - new: https://git.openjdk.java.net/jmc/pull/333/files/47c9b726..5edf67da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=333&range=04-05

  Stats: 4 lines in 3 files changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/333.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/333/head:pull/333

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Sat Nov 27 09:26:05 2021
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Sat, 27 Nov 2021 09:26:05 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v5]
In-Reply-To: <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <tEPoe4rCFtYF8UlIJjqL37kF8Yi0r01TT2KTLUhlPpQ=.4a30577c-c270-46ba-be1c-0124a80d0d80@github.com>
 <YgJDaJ6M4ud3pW06DLelKWVQ-24LzwWBdXQF1ZCZVsI=.2a057cda-8ee6-48ec-a288-ca7e6c7e5de6@github.com>
Message-ID: <tqXlFlWyRXMkkydgrPH-e-Gudrb9e3PYEX0fLRQskc0=.73a13184-7b6f-49dc-8eb7-de4da066bfbf@github.com>

On Mon, 22 Nov 2021 21:19:42 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> It would be nice to have your feedback on this, because I came back a lot on the design to implement my needs. So depending on yours, we may revisit some parts...

@jpbempel I will not find enough time to continue before my holidays starting in mid December. It's better than one hour this day, one hour another day.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From hirt at openjdk.java.net  Sat Nov 27 12:14:04 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 27 Nov 2021 12:14:04 GMT
Subject: RFR: 7247: Alternate for Twitter4J to support twitter plug-in [v7]
In-Reply-To: <ouLN-8dEjX7YPQcLmF-BJCCQ-52XbIHCezAOJ0VmILE=.53f91902-e272-40e7-b8e3-c69f912a35c3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
 <ouLN-8dEjX7YPQcLmF-BJCCQ-52XbIHCezAOJ0VmILE=.53f91902-e272-40e7-b8e3-c69f912a35c3@github.com>
Message-ID: <Op0zIXuI1H9iRFRGjK8AzB-TlFNsKBSmLUEyVLwmKpc=.2de97e31-58cc-4c94-a49a-9769e77f67c7@github.com>

On Fri, 26 Nov 2021 07:27:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
>> 
>> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
>> 
>> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
>> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
>> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
>> 
>> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
>> 
>> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
>> 
>> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented some review comments

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From reinhapa at openjdk.java.net  Sun Nov 28 16:54:26 2021
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Sun, 28 Nov 2021 16:54:26 GMT
Subject: RFR: 7432: Update the spotbugs maven plugin [v4]
In-Reply-To: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
References: <NogwuacUT7-ztkHijbnhluiiz_FDlrP36v9t3ggK0g0=.d3f15cbf-44ea-4f94-b470-8e0c15deba5d@github.com>
Message-ID: <9nFE55aD2IV32RaOaJiAiH5mKvAxGlizufrsRle0dUE=.8714b79d-ec8e-4642-847b-e7b8efa393a5@github.com>

> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Patrick Reinhart has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  7432: Update the spotbugs maven plugin
  
  Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Changes: https://git.openjdk.java.net/jmc/pull/324/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=324&range=03
  Stats: 94 lines in 3 files changed: 91 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/324.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/324/head:pull/324

PR: https://git.openjdk.java.net/jmc/pull/324

From schaturvedi at openjdk.java.net  Sun Nov 28 19:54:10 2021
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 28 Nov 2021 19:54:10 GMT
Subject: Integrated: 7247: Alternate for Twitter4J to support twitter plug-in
In-Reply-To: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
References: <hnfOrBqO2eiVLbe-1NJu20MOEnjq3YBESq8QDrvyf9E=.1e671bbd-7f4e-471c-8862-08e25e1a5da3@github.com>
Message-ID: <l5yTLJnofff_Qhw89YaLX2zon-PF4HwUmdByTdYIUzg=.7a93332e-a20a-4936-a8ba-cb88db810645@github.com>

On Sat, 16 Oct 2021 13:13:32 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the issue of using Twitter4J as third party library for JMC, which is not actively maintained by the owner of Twitter4J. The last release was 3 years back. We have tried contacting the owner for the next release dates but couldn't get a proper response. Hence, we would need to remove the dependency from JMC because we should not use any dependency which is not well maintained. 
> 
> JMC Console gives the functionality of setting up triggers for particular conditions which can be set in configuration. Twitter is used as one of the trigger methods to notify users (or tweeters in case of Twitter). I have removed the Twitter4J dependency completely and using all the twitter related APIs directly. There are mainly three parts of this PR (functionality for which Twitter4J was used).
> 
> 1. Authentication : The authentication of twitter users i.e. tweeters are done as part of preference settings. Twitter follows 3-legged OAuth authentication process for authenticating any user. So there are 3 steps which I have implemented in order to authenticate any user and save his details in preferences. Once the tweeter is verified the JMC application will use his details for verification before any action is triggered for that user. In order to use any user name we need to authorize his/her credentials in JMC preference.
> 2. Send Direct Message : A verified user (tweeter) can send a direct message to another user (tweeter). The first user should be verified user i.e. it should be one of the users listed in preference. The second user need not be a part of authorized users list but before sending any message we are checking whether the user exists or not.
> 3. Update Status : A JMC user can update the status of any verified user (tweeter) on Twitter which can be seen on twitter wall of that user.
> 
> I have used http classes of JDK 11 for making REST API calls, so this plugin will be dependent on JDK 11.
> 
> There is a scope of using a JSON library to make the code better but as of now I haven't used any third party library for this implementation may be we can modify the code in future if we have some JSON library dependency in future.
> 
> Please review the same and let me know your valuable comments (if any). Also, feel free to ping me if you want to test it and stuck somewhere. I can help with the steps to test it.

This pull request has now been integrated.

Changeset: 4d1c087b
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/4d1c087b1143b6b4eb8765ccb2a711c3b860d44e
Stats:     1053 lines in 18 files changed: 719 ins; 275 del; 59 mod

7247: Alternate for Twitter4J to support twitter plug-in

Reviewed-by: aptmac, hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/323

From hirt at openjdk.java.net  Mon Nov 29 12:01:11 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 29 Nov 2021 12:01:11 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
Message-ID: <qVAhNIcmryjaFe5bJa5c7fKs9W8JkPJ5U4_R6XC7HDo=.2926eaf3-39de-4cfc-9432-caf3aac4e001@github.com>

On Fri, 26 Nov 2021 20:46:41 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused import

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Mon Nov 29 12:04:23 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 29 Nov 2021 12:04:23 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v12]
In-Reply-To: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
Message-ID: <-N0CU9ssv7XmFCsGI-GH7obrYAZnaSbLPKEvM-_kd2s=.2cb18b6b-cd2d-40cc-b11d-ddc093733e1d@github.com>

> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
> 
> <img width="714" alt="Screenshot 2021-11-27 at 21 13 54" src="https://user-images.githubusercontent.com/348973/143722590-949ad362-6486-4f96-bae0-0fc9afcd7002.png">
> 
> The three endpoints available on the server are:
> 
> * `/events/` - raw serialised events
> * `/tree/` - `StacktraceTreeModel`, data used in the flame graph view
> * `/graph/` - `StacktraceGraphModel`, data used in the graph view
> 
> Please see [this Observable collection](https://observablehq.com/collection/@cimi/java-mission-control) for examples on how to connect.
> 
> This PR adds several new dependencies:
> * **org.eclipse.jetty.websocket:websocket-jetty-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-javax-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-jetty-api:10.0.5**
> * **org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.34**
> 
> After adding the new dependencies, I had issues with resolving transitive dependency conflicts (when I was trying to use Jetty 9.x) then with fixing the eclipse launcher - please see the comments for details.

Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits:

 - Merge branch 'master' into cimi/websocket-server
 - Update full name
 - Merge branch 'master' into cimi/websocket-server
 - Add additional asm and asm.tree plugins to eclipse launchers
 - Fix websocket UI messages and copyright notices
 - Use CopyOnWriteArrayList for websocket handlers; remove useless cast
 - Fix copyright statememnts: remove Datadog in existing files, use year ranges
 - Remove 2019-12 platform definition, leftover after rebase
 - Add tree and graph handlers to websocket server
 - Revert whitespace changes in core/features.xml
 - ... and 11 more: https://git.openjdk.java.net/jmc/compare/4d1c087b...5f544a36

-------------

Changes: https://git.openjdk.java.net/jmc/pull/306/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=11
  Stats: 511 lines in 19 files changed: 460 ins; 0 del; 51 mod
  Patch: https://git.openjdk.java.net/jmc/pull/306.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/306/head:pull/306

PR: https://git.openjdk.java.net/jmc/pull/306

From duke at openjdk.java.net  Mon Nov 29 12:36:37 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 29 Nov 2021 12:36:37 GMT
Subject: RFR: 7198: Add websocket server that pushes data on selection
 updates [v13]
In-Reply-To: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
Message-ID: <iNTWmIfq1NPnAOyb6PE5XtlFY_LcReqduRudubPqCuA=.ebed87ce-34e6-4c63-bd22-c60571d909c6@github.com>

> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
> 
> <img width="714" alt="Screenshot 2021-11-27 at 21 13 54" src="https://user-images.githubusercontent.com/348973/143722590-949ad362-6486-4f96-bae0-0fc9afcd7002.png">
> 
> The three endpoints available on the server are:
> 
> * `/events/` - raw serialised events
> * `/tree/` - `StacktraceTreeModel`, data used in the flame graph view
> * `/graph/` - `StacktraceGraphModel`, data used in the graph view
> 
> Please see [this Observable collection](https://observablehq.com/collection/@cimi/java-mission-control) for examples on how to connect.
> 
> This PR adds several new dependencies:
> * **org.eclipse.jetty.websocket:websocket-jetty-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-javax-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-jetty-api:10.0.5**
> * **org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.34**
> 
> After adding the new dependencies, I had issues with resolving transitive dependency conflicts (when I was trying to use Jetty 9.x) then with fixing the eclipse launcher - please see the comments for details.

Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:

  Update full name

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/306/files
  - new: https://git.openjdk.java.net/jmc/pull/306/files/5f544a36..63817ca8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=306&range=11-12

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/306.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/306/head:pull/306

PR: https://git.openjdk.java.net/jmc/pull/306

From duke at openjdk.java.net  Mon Nov 29 13:12:15 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 29 Nov 2021 13:12:15 GMT
Subject: Integrated: 7198: Add websocket server that pushes data on selection
 updates
In-Reply-To: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
References: <Wvhv5whIZpZUXtYGa6x6cna8FAVINcYICAI9uSP3qtA=.62eb96dd-9ecc-4d68-ad9f-b3880a8c492f@github.com>
Message-ID: <ScVxPKrXc6MUG_GASaPGikSC6kEZgNgp5rfpkFdU1WM=.3359e2dc-926b-4b39-8b24-31c55f1a36cb@github.com>

On Thu, 9 Sep 2021 16:32:58 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR adds a websocket server that pushes event data as JSON to all connected clients whenever the user updates their current selection in JMC. The server is disabled by default and can be enabled and disabled from JMC preferences. This is a rework of the proof-of-concept code in https://github.com/openjdk/jmc/pull/225 and uses the JSON serialiser introduced in #279.
> 
> <img width="714" alt="Screenshot 2021-11-27 at 21 13 54" src="https://user-images.githubusercontent.com/348973/143722590-949ad362-6486-4f96-bae0-0fc9afcd7002.png">
> 
> The three endpoints available on the server are:
> 
> * `/events/` - raw serialised events
> * `/tree/` - `StacktraceTreeModel`, data used in the flame graph view
> * `/graph/` - `StacktraceGraphModel`, data used in the graph view
> 
> Please see [this Observable collection](https://observablehq.com/collection/@cimi/java-mission-control) for examples on how to connect.
> 
> This PR adds several new dependencies:
> * **org.eclipse.jetty.websocket:websocket-jetty-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-javax-server:10.0.5**
> * **org.eclipse.jetty.websocket:websocket-jetty-api:10.0.5**
> * **org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle:1.34**
> 
> After adding the new dependencies, I had issues with resolving transitive dependency conflicts (when I was trying to use Jetty 9.x) then with fixing the eclipse launcher - please see the comments for details.

This pull request has now been integrated.

Changeset: ca204424
Author:    Alex Ciminian <alexandru.ciminian at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ca204424ce32336f2923aff66f619d571b1fc720
Stats:     511 lines in 19 files changed: 460 ins; 0 del; 51 mod

7198: Add websocket server that pushes data on selection updates

Reviewed-by: hirt, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/306

From jpbempel at openjdk.java.net  Tue Nov 30 11:04:33 2021
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 30 Nov 2021 11:04:33 GMT
Subject: RFR: 7463: JfrEditor instances are kept in memory by NavigationHistory
Message-ID: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>

Provide a sub class of NavigationHistory instead of implementing a
full INavigationHistory.
JfrEditor is not kept anymore when releasing state/disposing.

Provide a sub class of NavigationHistory instead of implementing a
full INavigationHistory.
JfrEditor is not kept anymore when releasing state/disposing.

JMC 8.1, opening 13 recordings, then closing them:

COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
55089:
 garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
  class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
55089:
Command executed successfully
COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
55089:
 garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
  class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K

memory is not released even after GC

JMC 8.2 + fix:

COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
56259:
 garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
  class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
56259:
Command executed successfully
COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
56259:
 garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
  class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K

-------------

Commit messages:
 - 7463: JfrEditor instances are kept in memory by NavigationHistory

Changes: https://git.openjdk.java.net/jmc/pull/338/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=338&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7463
  Stats: 44 lines in 2 files changed: 2 ins; 32 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/338.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/338/head:pull/338

PR: https://git.openjdk.java.net/jmc/pull/338

From hirt at openjdk.java.net  Tue Nov 30 18:16:09 2021
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 30 Nov 2021 18:16:09 GMT
Subject: RFR: 7463: JfrEditor instances are kept in memory by
 NavigationHistory
In-Reply-To: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
References: <I3otvvCcgDHzI1e35HUsmqk5H9gpWcL0uqmz0NOIvJI=.17b8d56b-22f2-4c84-b68b-17f5b2013d2f@github.com>
Message-ID: <xEvu63EkFDXGwbXc69z_h0Tr7k3l4i1z2Ikb4wLbW0g=.e6876620-7427-4321-b0ab-6530cdd2bbc1@github.com>

On Tue, 30 Nov 2021 10:48:47 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> Provide a sub class of NavigationHistory instead of implementing a
> full INavigationHistory.
> JfrEditor is not kept anymore when releasing state/disposing.
> 
> JMC 8.1, opening 13 recordings, then closing them:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
>   class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
> 55089:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
> 55089:
>  garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
>   class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K
> 
> memory is not released even after GC
> 
> JMC 8.2 + fix:
> 
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
>   class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
> 56259:
> Command executed successfully
> COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
> 56259:
>  garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
>   region size 1024K, 1 young (1024K), 0 survivors (0K)
>  Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
>   class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K

Do we want to keep the ability to open on the right page?

-------------

PR: https://git.openjdk.java.net/jmc/pull/338

From duke at openjdk.java.net  Tue Nov 30 22:20:34 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Tue, 30 Nov 2021 22:20:34 GMT
Subject: RFR: 7451: Add heat map view [v2]
In-Reply-To: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
Message-ID: <PiduifcAcRtqxI7YGnwFyUQt8BW84vQWRRCVJNcucc4=.e94bb243-94a3-4467-93f5-f3dda7353b12@github.com>

> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
> 
> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
> 
> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
> 
> I still have some TODOs to take care of (see below) but the code is ready for a first-pass review ?? 
> 
> - [x] Add/fix copyright notices
> - [x] Ensure axes are always visible (when cells are very large sometimes the axes get cut off)
> - [x] Ensure minimum cell size - now the heatmap disappears if the window is too small (i.e. computed cell size is < 1px).
> - [x] Add a title to the chart? ('Showing `x` events collected between `tStart` and `tEnd`'?)
> - [ ] Display a colour legend (like we have in the notebook) and some indicator that a cell represents 100ms
> - [x] Display 'no-data' message or banner when the selection is empty
> - [x] Display error message when rendering the heatmap fails? (this should be unlikely)
> 
> ![Screenshot 2021-11-26 at 18 13 34](https://user-images.githubusercontent.com/348973/143618682-335d5877-8070-4a42-a8dc-5d4753a67667.png)
> 
> ![Screenshot 2021-11-26 at 18 13 54](https://user-images.githubusercontent.com/348973/143618710-002acf31-00ea-41f4-908b-631e33eb7360.png)

Alex Ciminian has updated the pull request incrementally with six additional commits since the last revision:

 - Add right margin to prevent horizontal scroll
 - Add 'no data' message to heatmap
 - Add heatmap title with event count and start end time
 - Remove right margin, fix axes misalignment
 - Set minimum heatmap cell size to 4px
 - Fix copyright notices

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/337/files
  - new: https://git.openjdk.java.net/jmc/pull/337/files/3c71b4b2..f6286af5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=00-01

  Stats: 318 lines in 6 files changed: 117 ins; 78 del; 123 mod
  Patch: https://git.openjdk.java.net/jmc/pull/337.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/337/head:pull/337

PR: https://git.openjdk.java.net/jmc/pull/337

From duke at openjdk.java.net  Tue Nov 30 22:38:12 2021
From: duke at openjdk.java.net (Alex Ciminian)
Date: Tue, 30 Nov 2021 22:38:12 GMT
Subject: RFR: 7451: Add heat map view [v3]
In-Reply-To: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
References: <aU949NSHXUvfLxLOb4ULNjmVg3RShI7gw1U4To4jvds=.6c9c7080-fa42-4297-a53f-286584ac521f@github.com>
Message-ID: <LFE83KLJ913gorp3RLYDyHLurB1xCDynvP08UoObEHw=.9455d95d-58d9-4acb-b25a-706b6b1c8002@github.com>

> This PR adds a new plugin (`flightrecorder.heatmap`) which renders a visualisation similar to the one in [this Observable notebook](https://observablehq.com/@cimi/jfr-heatmap).
> 
> The code is simpler than both the flame view and the graph view, because of less rendering options and less dependencies - the heatmap only requires d3 and currently does not support any user configuration.
> 
> Each cell represents 100 milliseconds from the recording. We decided to automatically adjust the size of the cell so that the entire heatmap fits inside the window. This is different from the observable notebook which ensured each row represented 6s (i.e. it had a fixed number of 60 columns). The auto-sizing seems to work well with both small and large recordings, although we lose consistency when we resize the window and some periodic patterns are no longer visible when we vary the number of columns.
> 
> I still have some TODOs to take care of (see below) but the code is ready for a first-pass review ?? 
> 
> - [x] Add/fix copyright notices
> - [x] Ensure axes are always visible (when cells are very large sometimes the axes get cut off)
> - [x] Ensure minimum cell size - now the heatmap disappears if the window is too small (i.e. computed cell size is < 1px).
> - [x] Add a title to the chart? ('Showing `x` events collected between `tStart` and `tEnd`'?)
> - [ ] Display a colour legend (like we have in the notebook) and some indicator that a cell represents 100ms
> - [x] Display 'no-data' message or banner when the selection is empty
> - [x] Display error message when rendering the heatmap fails? (this should be unlikely)
> 
> ![Screenshot 2021-11-26 at 18 13 34](https://user-images.githubusercontent.com/348973/143618682-335d5877-8070-4a42-a8dc-5d4753a67667.png)
> 
> ![Screenshot 2021-11-26 at 18 13 54](https://user-images.githubusercontent.com/348973/143618710-002acf31-00ea-41f4-908b-631e33eb7360.png)

Alex Ciminian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:

 - Add comment about setting 0 to white in heatmap
 - Clean up logging and unused variables from heatmap.js
 - Add right margin to prevent horizontal scroll
 - Add 'no data' message to heatmap
 - Add heatmap title with event count and start end time
 - Remove right margin, fix axes misalignment
 - Set minimum heatmap cell size to 4px
 - Fix copyright notices
 - Extract heatmap javascript to a separate file to avoid escaping %
 - Remove debug logging from heatmap javascript
 - ... and 10 more: https://git.openjdk.java.net/jmc/compare/ca204424...768ec2a0

-------------

Changes: https://git.openjdk.java.net/jmc/pull/337/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=337&range=02
  Stats: 651 lines in 15 files changed: 638 ins; 0 del; 13 mod
  Patch: https://git.openjdk.java.net/jmc/pull/337.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/337/head:pull/337

PR: https://git.openjdk.java.net/jmc/pull/337