RFR: 7439: Introduced IConstantPoolExtension for Constant Pools [v5]

[Jean-Philippe Bempel]

On Sat, 13 Nov 2021 11:07:26 GMT, Michael Südkamp <duke at openjdk.java.net> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> Back to the tests - this time with the JPs clone and branch "pool-extension". I realized that in my Eclipse setup the ConstantPoolExtensionTest class doesn't get compiled unless I do a
> - cd core
> - mvn package
> on console. That's why I obiously got the ClassNotFoundException previously. I realized that when I finally found the "Show command line" option with the class path.
> Now I can run the test but have to do "mvn package" always if I want to make changes, which is obviously very clumsy. 
> Sorry that I report more about my Eclipse setup problems here than regarding the PR...
> 
> Regarding the PR, I have the same test result as last time. I just can't seenany of my own classes in the Parsewr Extension callbacks when I replaced the test JFR file with my own. As I said, I probably didn't got the idea.
> 
> I would suggest that you provide a test JFR file with a custom class like fr.jpbempel.HelloWorld and demonstrate in the test how to get it.

hello @docwarems 
My test is focusing on event Types that referencing constants.

when using the callback:

Object constantRead(long constantIndex, Object constant, String eventTypeId) {
	return constant;
}

you should look at constant argument that should be what you would like to de-obfuscate and return a translated value instead of the original one:


Object constantRead(long constantIndex, Object constant, String eventTypeId) {
	return deobfuscate(constant);
}

-------------

PR: https://git.openjdk.java.net/jmc/pull/333