RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v3]
Alex Macdonald
aptmac at openjdk.java.net
Mon Nov 22 21:09:42 UTC 2021
> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.
>
> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.
>
> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult
>
> [0] https://bugs.openjdk.java.net/browse/JMC-7307
Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- fix package name in JFCXMLValidator logger
- re-order flightrecorder.configuration.test in test pom
- update license headers
- migrate VolatileStorageDelegate to flightrecorder.configuration.model
- revert .classpath files to their original from application
- minor cleanup
- move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
The controlpanel.ui.configuration only had the XML test, which is now
located in flightrecorder.configuration.test in core. Currently all
tests in both core and application will pass.
- move flightrecorder.configuration coverage from application to core
- temporarily silence test modules that are moved, will cleanup after
- migrate controlpanel.ui.configuration.model.xml to core
- ... and 1 more: https://git.openjdk.java.net/jmc/compare/77580fe1...6dd54405
-------------
Changes: https://git.openjdk.java.net/jmc/pull/299/files
Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=299&range=02
Stats: 1003 lines in 99 files changed: 373 ins; 475 del; 155 mod
Patch: https://git.openjdk.java.net/jmc/pull/299.diff
Fetch: git fetch https://git.openjdk.java.net/jmc pull/299/head:pull/299
PR: https://git.openjdk.java.net/jmc/pull/299
More information about the jmc-dev
mailing list