RFR: 7248: JMC7/8 Automated Analysis taking very long time to produce results for Class Leak Rule. [v2]

[Henrik Dafgård]

On Mon, 17 May 2021 15:44:26 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Calculation maximum timeout is set via preference and hardcoding removed.
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 76:
> 
>> 74: 		} catch (Exception e) {
>> 75: 			e.printStackTrace();
>> 76: 		}
> 
> Don't swallow the interrupted exception, if this happens, this mean the code calling awaitTermination has been interrupted, the code should make sure the current thread is interrupted.

This should really be logged properly rather than just printing the exception, and it definitely shouldn't catch all exceptions.

-------------

PR: https://git.openjdk.java.net/jmc/pull/248