RFR: 7455: Add support for jolokia JMX service connection

[Marcus Hirt]

On Tue, 26 Oct 2021 19:58:20 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

application/org.openjdk.jmc.jolokia/build.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

For new files, don't forget to add the right copyright year (2021), and a line for your current employer (if it makes sense). See Datadog copyrights.

application/org.openjdk.jmc.jolokia/plugin.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--   
> 3:    Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.

I won't comment regarding copyright in any more files, but the comment before of course applies to all of them.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 10:

> 8:  *
> 9:  * or the following license:
> 10:  *

A short class description in public classes is nice. ;)

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 26:

> 24:  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
> 25:  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> 26:  * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR

We typically don't use the author tag in the project.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 11:

> 9:  * or the following license:
> 10:  *
> 11:  * Redistribution and use in source and binary forms, with or without modification, are permitted

Comments that don't really add to the understanding, we typically try to avoid.

-------------

PR: https://git.openjdk.java.net/jmc/pull/332