RFR: 7432: Update the spotbugs maven plugin [v2]

[Alex Macdonald]

On Mon, 18 Oct 2021 18:17:20 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Signed-off-by: Patrick Reinhart <patrick at reini.net>
>
> Patrick Reinhart has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   7432: Update the spotbugs maven plugin
>   
>   Signed-off-by: Patrick Reinhart <patrick at reini.net>

It doesn't look like this as trivial an upgrade as the other dependencies, something must have been updated on the dependency side that is finding new potential bugs in the JMC code.

At the moment there are 3 issues with jmc.ui.common: https://github.com/openjdk/jmc/runs/3964924803?check_suite_focus=true#step:7:7015

The code either has to be adjusted, or if appropriate can be added to the spotbugs exclude file to filter the results when spotbugs runs: https://github.com/openjdk/jmc/blob/master/configuration/spotbugs/spotbugs-exclude.xml

-------------

PR: https://git.openjdk.java.net/jmc/pull/324