RFR: 7439: Introduced IConstantPoolExtension for Constant Pools [v3]

Marcus Hirt hirt at openjdk.java.net
Sat Oct 30 20:39:41 UTC 2021


On Fri, 29 Oct 2021 20:50:44 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved
>> and constant pools fully resolved to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add default for existing IParserExtension methods

Normally I just have separate clones and workspaces for various people that contribute, e.g.:

Directory of C:\Users\Marcus\git\jmcreviews
2021-10-30  16:26    <DIR>          .
2021-10-30  16:26    <DIR>          ..
2021-09-14  10:52    <DIR>          cimi
2020-11-13  22:19    <DIR>          guru
2021-03-17  22:51    <DIR>          jpbempel
2021-01-12  17:31    <DIR>          miro
2020-12-07  23:57    <DIR>          Suchitainf
and so on... (Yep, I'm on my Windows machine right now.)

I then copy my eclipse workspace and simply remove all the projects and re-import them, so that I have separate Eclipse workspaces for various people that I need to review, and separate clones to try their various PRs.

For running the tests:
cd core
mvn verify

To run the test from within Eclipse, I simply right clicked on the class and selected Run as JUnit Test:
![image](https://user-images.githubusercontent.com/16906077/139537793-05237988-e140-44b8-83ca-927c7b7e5a30.png)

This gave me:
![image](https://user-images.githubusercontent.com/16906077/139537843-460b6d7c-cc9b-4a35-a1d7-e2c649a2fb64.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/333


More information about the jmc-dev mailing list