RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core

[Brice Dutheil]

On Mon, 9 Aug 2021 21:30:09 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.
> 
> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.
> 
> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7307

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

core/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/model/xml/JFCXMLValidator.java line 61:

> 59: 
> 60: 	private static final Logger LOGGER = Logger.getLogger("org.openjdk.jmc.flightrecorder.configuration");
> 61: 

Is it intended to trim the end of the package (`.model.xml`) ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/299