RFR: 7198: add websocket server that pushes data on selection updates [v6]
Alex Ciminian
github.com+348973+cimi at openjdk.java.net
Mon Sep 20 16:43:15 UTC 2021
On Mon, 20 Sep 2021 15:37:12 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:
>> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Add tree and graph handlers to websocket server
>> - Revert whitespace changes in core/features.xml
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java line 130:
>
>> 128: };
>> 129: if (FlightRecorderUI.getDefault().isWebsocketServerEnabled()) {
>> 130: long websocketServerPort = FlightRecorderUI.getDefault().getWebsocketPort();
>
> why `long` for the variable type? it forces you to cast to int when calling `WebsocketServer` constructor below while `getWebsocketPort()` returns int anyway
This is a leftover after refactoring, I was initially using IQuantity for the port because other numeric configs were using that, then I changed to long and finally to int. Good spot, fixed now!
-------------
PR: https://git.openjdk.java.net/jmc/pull/306
More information about the jmc-dev
mailing list