From hirt at openjdk.java.net Fri Apr 1 17:29:42 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 1 Apr 2022 17:29:42 GMT Subject: RFR: 7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher In-Reply-To: References: Message-ID: On Thu, 31 Mar 2022 19:04:43 GMT, Virag Purnam wrote: > Below mentioned required plugins are missing in JMC-RCP and JMC-RCP-plug-ins launcher. Added them as an additional plugins. > org.eclipse.jetty.http (10.0.7) > org.eclipse.jetty.io (10.0.7) > org.eclipse.jetty.security (10.0.7) > org.eclipse.jetty.server (10.0.7) > org.eclipse.jetty.servlet (10.0.7) > org.eclipse.jetty.util (10.0.7) > > ![MissingRequiredPlugins](https://user-images.githubusercontent.com/97600378/161130307-0e56892a-b435-4db6-bf50-2b9fc121a2db.png) Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/393 From hirt at openjdk.java.net Fri Apr 1 17:31:42 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 1 Apr 2022 17:31:42 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) Would we want a qualifier for core? It might be hard to not have a qualifier, if we for example need to provide an updated release build. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Fri Apr 1 20:22:45 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Fri, 1 Apr 2022 20:22:45 GMT Subject: Integrated: 7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher In-Reply-To: References: Message-ID: On Thu, 31 Mar 2022 19:04:43 GMT, Virag Purnam wrote: > Below mentioned required plugins are missing in JMC-RCP and JMC-RCP-plug-ins launcher. Added them as an additional plugins. > org.eclipse.jetty.http (10.0.7) > org.eclipse.jetty.io (10.0.7) > org.eclipse.jetty.security (10.0.7) > org.eclipse.jetty.server (10.0.7) > org.eclipse.jetty.servlet (10.0.7) > org.eclipse.jetty.util (10.0.7) > > ![MissingRequiredPlugins](https://user-images.githubusercontent.com/97600378/161130307-0e56892a-b435-4db6-bf50-2b9fc121a2db.png) This pull request has now been integrated. Changeset: 15da4dce Author: vpurnam Committer: Jean-Philippe Bempel URL: https://git.openjdk.java.net/jmc/commit/15da4dce2dde842e201b8afd6953b16722d97534 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod 7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher Reviewed-by: jpbempel, hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/393 From marcus.hirt at datadoghq.com Mon Apr 4 13:09:42 2022 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 4 Apr 2022 15:09:42 +0200 Subject: support IUnit of Allocation Rate In-Reply-To: <1f891868-4cea-8f71-7068-bf3fe6df9c75@amazon.com> References: <2f5b073f-6431-d249-e946-be2b66b9828c@amazon.com> <1f891868-4cea-8f71-7068-bf3fe6df9c75@amazon.com> Message-ID: Hi Xin Liu, JFR already has compound units: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/jfr/metadata/metadata.xml I think adding special cases is likely not the right way forward. Kind regards, Marcus On Tue, Mar 29, 2022 at 1:37 AM Liu, Xin wrote: > hi, Marcus, > > Yes, I am looking for a general approach to combine two units and get a > compound unit. Is there any other scenarios besides B/s. > > Or we treat B/s as a special case. I look up wikipedia, maybe it's not > an appalling hack to create a unit called "data-rate" > https://en.wikipedia.org/wiki/Data-rate_units. It has a clear > definition, symbol and scales. > > I plan to create a map in UnitLookup. it maps MEMORY to MEMORY/s. does > it sound reasonable? > > thanks, > --lx > > On 3/28/22 5:19 AM, Marcus Hirt wrote: > > *CAUTION*: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > > > > Hi Xin Liu, > > > > Fixing this properly is probably a bit bigger. We'd probably want to > > have a compound unit and add support for compound units in a general way. > > > > Kind regards, > > Marcus > > > > On Mon, Mar 28, 2022 at 8:37 AM Liu, Xin > > wrote: > > > > Hi, Developers, > > > > I am new for the codebase of Java mission control. I would like to > add > > allocation Rate in Summary page(JMC-7301). > > > > I manage to extend aggregators ALLOC_INSIDE_TLAB_SUM and > > ALLOC_OUTSIDE_TLAB_SUM. The duration is known from > > TlabPage::visibleRange. > > > > The biggest challenge is to align with the new unit. IUnit of > Allocation > > Rate is B/s. I haven't found similar IUnit like that. Is there a way > to > > derive B/s from Memory? > > > > To display the correct unit of allocation rate, I create a new > > LinearKindOfQuantity "memory bandwidth". The only difference of it > from > > memory is that its atom unit is B/s. > > > > Here is my attempt. sorry it looks awful. Any suggest to make it more > > elegant? > > > > > https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793 > > < > https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793 > > > > > > > > thanks, > > --lx > > > > > > > > > > From reinhapa at openjdk.java.net Mon Apr 4 14:39:40 2022 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Mon, 4 Apr 2022 14:39:40 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) @viragpurnam how does this change impacts snapshot builds? In this case the `.qualifier` get's replaced with the current build date/time. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From hirt at openjdk.java.net Tue Apr 5 14:50:46 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 5 Apr 2022 14:50:46 GMT Subject: RFR: 7576: Remove the need for a local jetty server for dependencies In-Reply-To: References: Message-ID: On Fri, 18 Mar 2022 21:33:49 GMT, Austin Brooks wrote: > Using newer Tycho features to achieve result: > > Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations > Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets > > Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions Update for this PR: Eclipse can't resolve the third party dependencies in the manifest. This seems to be a known PDE issue: https://stackoverflow.com/questions/13728801/why-cant-manifest-mf-see-packages-from-mavens-pom ------------- PR: https://git.openjdk.java.net/jmc/pull/387 From hirt at openjdk.java.net Tue Apr 5 18:47:55 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 5 Apr 2022 18:47:55 GMT Subject: RFR: 7859: Add 2022-03 target platform Message-ID: ...and switch to using it by default. ------------- Commit messages: - 7859: Add 2022-03 target platform Changes: https://git.openjdk.java.net/jmc/pull/394/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=394&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7859 Stats: 51 lines in 5 files changed: 43 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jmc/pull/394.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/394/head:pull/394 PR: https://git.openjdk.java.net/jmc/pull/394 From xliu at openjdk.java.net Tue Apr 5 21:16:47 2022 From: xliu at openjdk.java.net (Xin Liu) Date: Tue, 5 Apr 2022 21:16:47 GMT Subject: Withdrawn: 7301: Add allocation rate aggregators to TLAB Allocation General screen In-Reply-To: References: Message-ID: On Tue, 29 Mar 2022 23:30:24 GMT, Xin Liu wrote: > Add allocation rate aggregators to TLAB Allocation General screen: > 1. Allocation rate for TLABs (inside of TLAB) > 2. Allocation rate for Objects (outside of TLAB) > > Two new items are added to TLAB Allocations/Summary. > ![allocate_rate](https://user-images.githubusercontent.com/2386768/160754980-78001095-565f-4d62-b5fa-e16e0de4b959.png) > > There are 2 extra locales(Chinese and Japanese) besides English. I am not sure I am qualified to provide translation. If it is possible, I will add them in next revision. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jmc/pull/391 From jpbempel at openjdk.java.net Wed Apr 6 05:43:44 2022 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 6 Apr 2022 05:43:44 GMT Subject: RFR: 7589: Add 2022-03 target platform In-Reply-To: References: Message-ID: On Tue, 5 Apr 2022 18:42:43 GMT, Marcus Hirt wrote: > ...and switch to using it by default. releng/platform-definitions/platform-definition-2022-03/platform-definition-2022-03.target line 36: > 34: --> > 35: > 36: should be `jmc-target-2022-03`, no ? ------------- PR: https://git.openjdk.java.net/jmc/pull/394 From hirt at openjdk.java.net Wed Apr 6 18:19:28 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 6 Apr 2022 18:19:28 GMT Subject: RFR: 7589: Add 2022-03 target platform [v2] In-Reply-To: References: Message-ID: > ...and switch to using it by default. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Typo ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/394/files - new: https://git.openjdk.java.net/jmc/pull/394/files/a39e32ce..f6669a60 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=394&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=394&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/394.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/394/head:pull/394 PR: https://git.openjdk.java.net/jmc/pull/394 From hirt at openjdk.java.net Wed Apr 6 18:19:29 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 6 Apr 2022 18:19:29 GMT Subject: RFR: 7589: Add 2022-03 target platform [v2] In-Reply-To: References: Message-ID: <3ixDHJfkR2V-jJxnoNM8jWOgL-ITibkR9CMLZ6SpiQM=.a17a1be4-8d7b-474b-af88-f9e3e0a4dafa@github.com> On Wed, 6 Apr 2022 05:38:47 GMT, Jean-Philippe Bempel wrote: >> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: >> >> Typo > > releng/platform-definitions/platform-definition-2022-03/platform-definition-2022-03.target line 36: > >> 34: --> >> 35: >> 36: > > should be `jmc-target-2022-03`, no ? Indeed. ------------- PR: https://git.openjdk.java.net/jmc/pull/394 From aptmac at openjdk.java.net Wed Apr 6 18:39:46 2022 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 6 Apr 2022 18:39:46 GMT Subject: RFR: 7589: Add 2022-03 target platform [v2] In-Reply-To: References: Message-ID: On Wed, 6 Apr 2022 18:19:28 GMT, Marcus Hirt wrote: >> ...and switch to using it by default. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Typo Marked as reviewed by aptmac (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/394 From hirt at openjdk.java.net Wed Apr 6 18:47:46 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 6 Apr 2022 18:47:46 GMT Subject: Integrated: 7589: Add 2022-03 target platform In-Reply-To: References: Message-ID: On Tue, 5 Apr 2022 18:42:43 GMT, Marcus Hirt wrote: > ...and switch to using it by default. This pull request has now been integrated. Changeset: 912007d9 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/912007d9429d6db5fb3d31049572a26156c6b786 Stats: 52 lines in 5 files changed: 43 ins; 3 del; 6 mod 7589: Add 2022-03 target platform Reviewed-by: aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/394 From clanger at openjdk.java.net Sun Apr 10 22:22:47 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Sun, 10 Apr 2022 22:22:47 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 4 Apr 2022 14:36:18 GMT, Patrick Reinhart wrote: > @viragpurnam how does this change impacts snapshot builds? In this case the `.qualifier` get's replaced with the current build date/time. @reinhapa How does that work? When I build locally, `.qualifier` remains `.qualifier`, no traces of current date/time. Where is the mechanism located to replace .qualifier in manifests in any build? ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From reinhapa at openjdk.java.net Mon Apr 11 07:21:38 2022 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Mon, 11 Apr 2022 07:21:38 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 4 Apr 2022 14:36:18 GMT, Patrick Reinhart wrote: >> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. >> Plug-in details in JMC shows 8.3.0.qualifier. >> BundleVersionIssue >> >> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) >> e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 >> With the above change Plug-in details in JMC shows 8.3.0. >> BundleVersionIssueResolved >> >> **Issue:** Bundle names are not uniform. >> JOverFlowBundleNameIssue >> >> Duplicate bundle name. >> DuplicateBundleName >> >> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. >> >> - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow >> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui >> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui >> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui >> - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers >> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk >> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) >> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test >> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test >> >> JOverFlowBundleNameIssueResolved >> DuplicateBundleNameResolved >> >> **Issue:** Duplicate Bundle-SymbolicName >> >> **Solution:** Bundle-SymbolicName has been modified >> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > > @viragpurnam how does this change impacts snapshot builds? In this case the `.qualifier` get's replaced with the current build date/time. > @reinhapa How does that work? When I build locally, `.qualifier` remains `.qualifier`, no traces of current date/time. Where is the mechanism located to replace .qualifier in manifests in any build? @RealCLanger Seems to be done automatically when deploying artefacts see [Adoptium 8.3.0-SNAPSHOT](https://github.com/adoptium/jmc-build/releases/tag/8.3.0-SNAPSHOT) or do I misunderstood something? ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Mon Apr 11 07:49:39 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Mon, 11 Apr 2022 07:49:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Fri, 1 Apr 2022 17:28:27 GMT, Marcus Hirt wrote: > Would we want a qualifier for core? It might be hard to not have a qualifier, if we for example need to provide an updated release build. Hi, Sorry for late reply. I was occupied with some work. Actually Tycho takes care of updating .qualifier with build timestamp. We are not using tycho for building core. We use tycho only for application. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Mon Apr 11 07:49:39 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Mon, 11 Apr 2022 07:49:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:39:07 GMT, Virag Purnam wrote: >> Would we want a qualifier for core? It might be hard to not have a qualifier, if we for example need to provide an updated release build. > >> Would we want a qualifier for core? It might be hard to not have a qualifier, if we for example need to provide an updated release build. > > Hi, Sorry for late reply. I was occupied with some work. Actually Tycho takes care of updating .qualifier with build timestamp. We are not using tycho for building core. We use tycho only for application. > @viragpurnam how does this change impacts snapshot builds? In this case the `.qualifier` get's replaced with the current build date/time. Hi @reinhapa, First of all sorry for late reply. Even for snapshot build, .qualifier is not getting replaced with build timestamp. We are not using tycho for building core. ( core -> pom.xml). ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Mon Apr 11 07:49:39 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Mon, 11 Apr 2022 07:49:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:18:19 GMT, Patrick Reinhart wrote: > > @reinhapa How does that work? When I build locally, `.qualifier` remains `.qualifier`, no traces of current date/time. Where is the mechanism located to replace .qualifier in manifests in any build? > > @RealCLanger Seems to be done automatically when deploying artefacts see [Adoptium 8.3.0-SNAPSHOT](https://github.com/adoptium/jmc-build/releases/tag/8.3.0-SNAPSHOT) or do I misunderstood something? @RealCLanger, Tycho is replacing .qualifier with build time stamp. For core we are not using that. May be you can have a look for any of the plugins present in application folder. For those .qualifier gets replaced with build timestamp properly. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Mon Apr 11 07:49:39 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Mon, 11 Apr 2022 07:49:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From reinhapa at openjdk.java.net Mon Apr 11 07:58:39 2022 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Mon, 11 Apr 2022 07:58:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:46:15 GMT, Virag Purnam wrote: > Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. @viragpurnam I just checked my build script for the adoptium build and found that at the moment I manually remove those `.qualifier` endings prior a release build. I'm sure there must be a better way to tell tycho to do that :-) ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From clanger at openjdk.java.net Mon Apr 11 07:58:39 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 11 Apr 2022 07:58:39 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:46:15 GMT, Virag Purnam wrote: >> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. >> Plug-in details in JMC shows 8.3.0.qualifier. >> BundleVersionIssue >> >> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) >> e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 >> With the above change Plug-in details in JMC shows 8.3.0. >> BundleVersionIssueResolved >> >> **Issue:** Bundle names are not uniform. >> JOverFlowBundleNameIssue >> >> Duplicate bundle name. >> DuplicateBundleName >> >> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. >> >> - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow >> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui >> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui >> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui >> - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers >> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk >> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) >> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test >> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test >> >> JOverFlowBundleNameIssueResolved >> DuplicateBundleNameResolved >> >> **Issue:** Duplicate Bundle-SymbolicName >> >> **Solution:** Bundle-SymbolicName has been modified >> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > > Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. @viragpurnam @reinhapa Thanks for your replies. That was my understanding, too. The replacement of version like 8.3.0-SNAPSHOT is done via POM magic from [these lines](https://github.com/openjdk/jmc/blob/912007d9429d6db5fb3d31049572a26156c6b786/pom.xml#L78). And it seems for every release these values are manually changed. And, you can of course set them via property from outside. So, if we don't build core via tycho and such qualifier is important, we have to add some maven functionality to modify the manifests. I think in general this change is nice. Will have a closer look later to give a full review. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From reinhapa at openjdk.java.net Mon Apr 11 08:02:41 2022 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Mon, 11 Apr 2022 08:02:41 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:46:15 GMT, Virag Purnam wrote: >> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. >> Plug-in details in JMC shows 8.3.0.qualifier. >> BundleVersionIssue >> >> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) >> e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 >> With the above change Plug-in details in JMC shows 8.3.0. >> BundleVersionIssueResolved >> >> **Issue:** Bundle names are not uniform. >> JOverFlowBundleNameIssue >> >> Duplicate bundle name. >> DuplicateBundleName >> >> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. >> >> - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow >> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui >> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui >> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui >> - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers >> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk >> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) >> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test >> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test >> >> JOverFlowBundleNameIssueResolved >> DuplicateBundleNameResolved >> >> **Issue:** Duplicate Bundle-SymbolicName >> >> **Solution:** Bundle-SymbolicName has been modified >> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > > Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. > @viragpurnam @reinhapa Thanks for your replies. That was my understanding, too. The replacement of version like 8.3.0-SNAPSHOT is done via POM magic from [these lines](https://github.com/openjdk/jmc/blob/912007d9429d6db5fb3d31049572a26156c6b786/pom.xml#L78). And it seems for every release these values are manually changed. And, you can of course set them via property from outside. So, if we don't build core via tycho and such qualifier is important, we have to add some maven functionality to modify the manifests. @RealCLanger @viragpurnam would it be possible to specify the `.qualifier` part as a variable having the current value as default, and setting it to empty via build option in case of the release? ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Mon Apr 11 08:43:34 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Mon, 11 Apr 2022 08:43:34 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 07:46:15 GMT, Virag Purnam wrote: >> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. >> Plug-in details in JMC shows 8.3.0.qualifier. >> BundleVersionIssue >> >> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) >> e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 >> With the above change Plug-in details in JMC shows 8.3.0. >> BundleVersionIssueResolved >> >> **Issue:** Bundle names are not uniform. >> JOverFlowBundleNameIssue >> >> Duplicate bundle name. >> DuplicateBundleName >> >> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. >> >> - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow >> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui >> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui >> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui >> - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers >> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk >> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) >> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test >> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test >> >> JOverFlowBundleNameIssueResolved >> DuplicateBundleNameResolved >> >> **Issue:** Duplicate Bundle-SymbolicName >> >> **Solution:** Bundle-SymbolicName has been modified >> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > > Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. > > @viragpurnam @reinhapa Thanks for your replies. That was my understanding, too. The replacement of version like 8.3.0-SNAPSHOT is done via POM magic from [these lines](https://github.com/openjdk/jmc/blob/912007d9429d6db5fb3d31049572a26156c6b786/pom.xml#L78). And it seems for every release these values are manually changed. And, you can of course set them via property from outside. So, if we don't build core via tycho and such qualifier is important, we have to add some maven functionality to modify the manifests. > > @RealCLanger @viragpurnam would it be possible to specify the `.qualifier` part as a variable having the current value as default, and setting it to empty via build option in case of the release? Thanks for the pointer. Yes, I will explore this option too. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From clanger at openjdk.java.net Tue Apr 12 14:02:15 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 14:02:15 GMT Subject: RFR: 7765: Bump some Maven plugins Message-ID: Several maven plugins should be updated to a more current version. Here's a list with some reasoning: junit 4.13.1 -> 4.13.2 (minor update) maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs) mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17) tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support) jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build) p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support) To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version. I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome https://github.com/eclipse/tycho/issues/876 In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom. ------------- Commit messages: - Bump some maven plugins Changes: https://git.openjdk.java.net/jmc/pull/395/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=395&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7765 Stats: 14 lines in 7 files changed: 3 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/jmc/pull/395.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/395/head:pull/395 PR: https://git.openjdk.java.net/jmc/pull/395 From clanger at openjdk.java.net Tue Apr 12 15:00:54 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 15:00:54 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Mon, 11 Apr 2022 08:40:06 GMT, Virag Purnam wrote: >> Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects. > >> > @viragpurnam @reinhapa Thanks for your replies. That was my understanding, too. The replacement of version like 8.3.0-SNAPSHOT is done via POM magic from [these lines](https://github.com/openjdk/jmc/blob/912007d9429d6db5fb3d31049572a26156c6b786/pom.xml#L78). And it seems for every release these values are manually changed. And, you can of course set them via property from outside. So, if we don't build core via tycho and such qualifier is important, we have to add some maven functionality to modify the manifests. >> >> @RealCLanger @viragpurnam would it be possible to specify the `.qualifier` part as a variable having the current value as default, and setting it to empty via build option in case of the release? > > Thanks for the pointer. Yes, I will explore this option too. Just discussed with @viragpurnam - I will work on a solution to correctly handle .qualifier in the core modules manifests in a separate PR. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From marcus.hirt at datadoghq.com Tue Apr 12 15:10:08 2022 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 12 Apr 2022 17:10:08 +0200 Subject: Plan for JMC 8.3 Message-ID: Hi all, I am hereby proposing the following plan for JMC 8.3. Plan: * RDS 2022-08-03 * RDP2 2022-08-31 * GA 2022-09-28 It is off-set by a quarter compared to our normal cadence due to various scheduling issues. Note that this is planned to be the last release of JMC 8, and that work on JMC 9 will be the main effort after this release. Please let me know if you have any concerns! Kind regards, Marcus From clanger at openjdk.java.net Tue Apr 12 18:15:49 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 18:15:49 GMT Subject: RFR: 7765: Bump some Maven plugins [v2] In-Reply-To: References: Message-ID: > Several maven plugins should be updated to a more current version. > > Here's a list with some reasoning: > junit 4.13.1 -> 4.13.2 (minor update) > maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs) > mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17) > tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support) > jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build) > p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support) > build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update) > > To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version. > > I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome https://github.com/eclipse/tycho/issues/876 > > In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Also update build-helper-maven-plugin and update copyright headers ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/395/files - new: https://git.openjdk.java.net/jmc/pull/395/files/de4b508d..714c37b1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=395&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=395&range=00-01 Stats: 7 lines in 5 files changed: 0 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/395.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/395/head:pull/395 PR: https://git.openjdk.java.net/jmc/pull/395 From hirt at openjdk.java.net Tue Apr 12 18:44:07 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 12 Apr 2022 18:44:07 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) Ok. Let's go with these changes for now then. ------------- Marked as reviewed by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/390 From hirt at openjdk.java.net Tue Apr 12 18:44:52 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 12 Apr 2022 18:44:52 GMT Subject: RFR: 7765: Bump some Maven plugins [v2] In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 18:15:49 GMT, Christoph Langer wrote: >> Several maven plugins should be updated to a more current version. >> >> Here's a list with some reasoning: >> junit 4.13.1 -> 4.13.2 (minor update) >> maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs) >> mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17) >> tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support) >> jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build) >> p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support) >> build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update) >> >> To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version. >> >> I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome https://github.com/eclipse/tycho/issues/876 >> >> In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Also update build-helper-maven-plugin and update copyright headers Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/395 From clanger at openjdk.java.net Tue Apr 12 19:16:46 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 19:16:46 GMT Subject: RFR: 7765: Bump some Maven plugins [v2] In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 18:15:49 GMT, Christoph Langer wrote: >> Several maven plugins should be updated to a more current version. >> >> Here's a list with some reasoning: >> junit 4.13.1 -> 4.13.2 (minor update) >> maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs) >> mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17) >> tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support) >> jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build) >> p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support) >> build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update) >> >> To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version. >> >> I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome https://github.com/eclipse/tycho/issues/876 >> >> In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Also update build-helper-maven-plugin and update copyright headers Thanks for the review. ------------- PR: https://git.openjdk.java.net/jmc/pull/395 From clanger at openjdk.java.net Tue Apr 12 19:18:50 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 19:18:50 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 18:40:24 GMT, Marcus Hirt wrote: > Ok. Let's go with these changes for now then. Yes, but maybe keep the .qualifier entries in the core manifests for now. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From clanger at openjdk.java.net Tue Apr 12 23:36:29 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 23:36:29 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) Please keep the .qualifier entries in the core manifests. I found a solution how to correctly handle them during build. Check https://github.com/openjdk/jmc/pull/396 for a possible solution. ------------- Changes requested by clanger (Author). PR: https://git.openjdk.java.net/jmc/pull/390 From clanger at openjdk.java.net Tue Apr 12 23:38:57 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Tue, 12 Apr 2022 23:38:57 GMT Subject: RFR: 7767: Fix handling of version qualifier in core plugins Message-ID: This PR adds some maven antrun magic to handle the .qualifier version property in core modules ------------- Commit messages: - JMC-7767 Changes: https://git.openjdk.java.net/jmc/pull/396/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=396&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7767 Stats: 59 lines in 1 file changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/396.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/396/head:pull/396 PR: https://git.openjdk.java.net/jmc/pull/396 From clanger at openjdk.java.net Wed Apr 13 08:15:18 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 08:15:18 GMT Subject: Integrated: 7765: Bump some Maven plugins In-Reply-To: References: Message-ID: On Tue, 12 Apr 2022 13:56:27 GMT, Christoph Langer wrote: > Several maven plugins should be updated to a more current version. > > Here's a list with some reasoning: > junit 4.13.1 -> 4.13.2 (minor update) > maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs) > mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17) > tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support) > jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build) > p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support) > build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update) > > To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version. > > I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome https://github.com/eclipse/tycho/issues/876 > > In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom. This pull request has now been integrated. Changeset: 97403f7d Author: Christoph Langer Committer: Jean-Philippe Bempel URL: https://git.openjdk.java.net/jmc/commit/97403f7d40fae9dcea6e1aa66307f0d1c87108ce Stats: 21 lines in 8 files changed: 3 ins; 3 del; 15 mod 7765: Bump some Maven plugins Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/395 From clanger at openjdk.java.net Wed Apr 13 08:21:55 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 08:21:55 GMT Subject: RFR: 7767: Fix handling of version qualifier in core plugins [v2] In-Reply-To: References: Message-ID: <_Rv7pmlI_qlBLNec9PPkvLwh4bJdRWxVigkMDPnVOHg=.0467c743-4fb1-40b9-991d-62798342ecb6@github.com> > This PR adds some maven antrun magic to handle the .qualifier version property in core modules Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JMC-7767 ------------- Changes: https://git.openjdk.java.net/jmc/pull/396/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=396&range=01 Stats: 59 lines in 1 file changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/396.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/396/head:pull/396 PR: https://git.openjdk.java.net/jmc/pull/396 From clanger at openjdk.java.net Wed Apr 13 08:25:16 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 08:25:16 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v14] In-Reply-To: References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: On Thu, 10 Mar 2022 14:05:21 GMT, Johannes Bechberger wrote: >> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix formatting > > The next tycho version is properly tested with JDK 17: https://github.com/eclipse/tycho/commit/4e7ca10e61f585966a7a8091e1418cc29ac2e63d https://github.com/openjdk/jmc/commit/97403f7d40fae9dcea6e1aa66307f0d1c87108ce was just integrated into master which updates to latest tycho. @parttimenerd, can you update your PR to merge the changes and try to remove the workarounds? ------------- PR: https://git.openjdk.java.net/jmc/pull/363 From duke at openjdk.java.net Wed Apr 13 11:22:56 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Wed, 13 Apr 2022 11:22:56 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins [v2] In-Reply-To: References: Message-ID: <1q4lMdlCxqxIHo0gR6O61Lt8ZXIbvrJbsfpOrEMfGJM=.0e7e5e26-82a4-4339-af65-4035f6d7d4c2@github.com> > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: 6972: Reverted the changes with respect to .qualifier. ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/390/files - new: https://git.openjdk.java.net/jmc/pull/390/files/435e6980..f18366a2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=390&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=390&range=00-01 Stats: 14 lines in 14 files changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jmc/pull/390.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/390/head:pull/390 PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Wed Apr 13 11:24:40 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Wed, 13 Apr 2022 11:24:40 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > Please keep the .qualifier entries in the core manifests. I found a solution how to correctly handle them during build. Check #396 for a possible solution. Reverted the changes with respect to '.qualifier'. Thanks. ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From hirt at openjdk.java.net Wed Apr 13 12:02:22 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 13 Apr 2022 12:02:22 GMT Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins [v2] In-Reply-To: <1q4lMdlCxqxIHo0gR6O61Lt8ZXIbvrJbsfpOrEMfGJM=.0e7e5e26-82a4-4339-af65-4035f6d7d4c2@github.com> References: <1q4lMdlCxqxIHo0gR6O61Lt8ZXIbvrJbsfpOrEMfGJM=.0e7e5e26-82a4-4339-af65-4035f6d7d4c2@github.com> Message-ID: On Wed, 13 Apr 2022 11:22:56 GMT, Virag Purnam wrote: >> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. >> Plug-in details in JMC shows 8.3.0.qualifier. >> BundleVersionIssue >> >> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) >> e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 >> With the above change Plug-in details in JMC shows 8.3.0. >> BundleVersionIssueResolved >> >> **Issue:** Bundle names are not uniform. >> JOverFlowBundleNameIssue >> >> Duplicate bundle name. >> DuplicateBundleName >> >> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. >> >> - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow >> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui >> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui >> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui >> - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers >> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk >> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) >> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test >> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test >> >> JOverFlowBundleNameIssueResolved >> DuplicateBundleNameResolved >> >> **Issue:** Duplicate Bundle-SymbolicName >> >> **Solution:** Bundle-SymbolicName has been modified >> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > > Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: > > 6972: Reverted the changes with respect to .qualifier. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From duke at openjdk.java.net Wed Apr 13 12:58:18 2022 From: duke at openjdk.java.net (Virag Purnam) Date: Wed, 13 Apr 2022 12:58:18 GMT Subject: Integrated: 6972: Naming and Version Numbering Issues with Plugins In-Reply-To: References: Message-ID: On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam wrote: > **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. > Plug-in details in JMC shows 8.3.0.qualifier. > BundleVersionIssue > > **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) > e.g Bundle-Version: 8.3.0.qualifier to Bundle-Version: 8.3.0 > With the above change Plug-in details in JMC shows 8.3.0. > BundleVersionIssueResolved > > **Issue:** Bundle names are not uniform. > JOverFlowBundleNameIssue > > Duplicate bundle name. > DuplicateBundleName > > **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform. > > - _Joverflow_ to _JOverFlow Plug-in_ for org.openjdk.jmc.joverflow > - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui > - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_ for org.openjdk.jmc.greychart.ui > - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui > - _Common Plug-in_ to _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers > - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk > - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) > - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test > - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test > > JOverFlowBundleNameIssueResolved > DuplicateBundleNameResolved > > **Issue:** Duplicate Bundle-SymbolicName > > **Solution:** Bundle-SymbolicName has been modified > _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin) This pull request has now been integrated. Changeset: 95fe7394 Author: vpurnam Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/95fe7394d4fe26f5e22e49de8656c968ab2acc2a Stats: 11 lines in 10 files changed: 0 ins; 0 del; 11 mod 6972: Naming and Version Numbering Issues with Plugins Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/390 From clanger at openjdk.java.net Wed Apr 13 13:25:59 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 13:25:59 GMT Subject: RFR: 7767: Fix handling of version qualifier in core plugins [v3] In-Reply-To: References: Message-ID: > This PR adds some maven antrun magic to handle the .qualifier version property in core modules Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: JMC-7767 ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/396/files - new: https://git.openjdk.java.net/jmc/pull/396/files/f1827ab8..9fcaa7ff Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=396&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=396&range=01-02 Stats: 11 lines in 10 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jmc/pull/396.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/396/head:pull/396 PR: https://git.openjdk.java.net/jmc/pull/396 From clanger at openjdk.java.net Wed Apr 13 15:25:14 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 15:25:14 GMT Subject: RFR: 7508: Use preferred way for test-jars In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel wrote: > based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html > I have modified the way test jars are structured: > we put all classes in src/main/java instead of src/test/java > and changed scope from test to compile accordingly > we now don't need to create explicitly test-jar neither reference them > as is. > Help to build/run/debug correctly in Intellij This is a nice change. Why don't you integrate it... ?? ------------- Marked as reviewed by clanger (Author). PR: https://git.openjdk.java.net/jmc/pull/354 From duke at openjdk.java.net Wed Apr 13 15:34:59 2022 From: duke at openjdk.java.net (Johannes Bechberger) Date: Wed, 13 Apr 2022 15:34:59 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v15] In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: > Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64. Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'master' into parttimenerd_java17 - Remove exports workaround - Fix formatting - Improve GitHub actions - Fix PropertyContentBuilderTest Related to differences in events between JDK11 and later JDKs - Mention JVMKeepAlive Using a predefinied launcher does not work properly (in my setting) - Improve devguide - Bump javadoc version - Add another -version - Add JDK 17 to CI - ... and 3 more: https://git.openjdk.java.net/jmc/compare/95fe7394...dc5af324 ------------- Changes: https://git.openjdk.java.net/jmc/pull/363/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=14 Stats: 95 lines in 5 files changed: 47 ins; 24 del; 24 mod Patch: https://git.openjdk.java.net/jmc/pull/363.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363 PR: https://git.openjdk.java.net/jmc/pull/363 From duke at openjdk.java.net Wed Apr 13 15:56:29 2022 From: duke at openjdk.java.net (Johannes Bechberger) Date: Wed, 13 Apr 2022 15:56:29 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v15] In-Reply-To: References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: <6PrUqd6A0Y__FSpAo6dtriVJ4IKPXF_71Gg62KunWSw=.7952adc8-cc59-4279-937a-763c76e6f67d@github.com> On Wed, 13 Apr 2022 15:34:59 GMT, Johannes Bechberger wrote: >> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64. > > Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: > > - Merge branch 'master' into parttimenerd_java17 > - Remove exports workaround > - Fix formatting > - Improve GitHub actions > - Fix PropertyContentBuilderTest > > Related to differences in events between JDK11 and later JDKs > - Mention JVMKeepAlive > > Using a predefinied launcher does not work properly (in my setting) > - Improve devguide > - Bump javadoc version > - Add another -version > - Add JDK 17 to CI > - ... and 3 more: https://git.openjdk.java.net/jmc/compare/95fe7394...dc5af324 Removing the workarounds does not seem to work? ------------- PR: https://git.openjdk.java.net/jmc/pull/363 From duke at openjdk.java.net Wed Apr 13 16:19:10 2022 From: duke at openjdk.java.net (Johannes Bechberger) Date: Wed, 13 Apr 2022 16:19:10 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v16] In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: <-aWBARZr7NEn19ruDFvThPYHb5hMypkwc1xHJqJokHA=.fcefcde8-e863-4f12-ae7c-8c4225d14712@github.com> > Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Readd workaround ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/363/files - new: https://git.openjdk.java.net/jmc/pull/363/files/dc5af324..2dd7b5e0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=15 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=14-15 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/363.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363 PR: https://git.openjdk.java.net/jmc/pull/363 From hirt at openjdk.java.net Wed Apr 13 20:59:25 2022 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 13 Apr 2022 20:59:25 GMT Subject: RFR: 7508: Use preferred way for test-jars In-Reply-To: References: Message-ID: <2GUisTF7caNfSiSH8yc5HK2MmV33PR8iCIuk00GRnj4=.48376163-846f-4d1d-be14-2011b8cb78f2@github.com> On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel wrote: > based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html > I have modified the way test jars are structured: > we put all classes in src/main/java instead of src/test/java > and changed scope from test to compile accordingly > we now don't need to create explicitly test-jar neither reference them > as is. > Help to build/run/debug correctly in Intellij Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/354 From jpbempel at openjdk.java.net Wed Apr 13 21:05:17 2022 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 13 Apr 2022 21:05:17 GMT Subject: Integrated: 7508: Use preferred way for test-jars In-Reply-To: References: Message-ID: On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel wrote: > based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html > I have modified the way test jars are structured: > we put all classes in src/main/java instead of src/test/java > and changed scope from test to compile accordingly > we now don't need to create explicitly test-jar neither reference them > as is. > Help to build/run/debug correctly in Intellij This pull request has now been integrated. Changeset: ee50a200 Author: Jean-Philippe Bempel URL: https://git.openjdk.java.net/jmc/commit/ee50a2000c408378329a8a1a5628a7250db13a89 Stats: 119 lines in 166 files changed: 1 ins; 78 del; 40 mod 7508: Use preferred way for test-jars Reviewed-by: clanger, hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/354 From clanger at openjdk.java.net Wed Apr 13 23:42:33 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Wed, 13 Apr 2022 23:42:33 GMT Subject: RFR: 7769: Cleanup pom and project files for JMC core Message-ID: There is a lot of redundancy, whitespace errors, inconsistencies, obsolete stuff, errors, outdated plugin versions etc. in JMC core pom and project files. org.openjdk.jmc.flightrecorder.writer.test and org.openjdk.jmc.jdp.test have been refactored in terms of layout like the other test projects. ------------- Commit messages: - Cleanup pom and project files for JMC core Changes: https://git.openjdk.java.net/jmc/pull/398/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=398&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7769 Stats: 697 lines in 73 files changed: 142 ins; 191 del; 364 mod Patch: https://git.openjdk.java.net/jmc/pull/398.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/398/head:pull/398 PR: https://git.openjdk.java.net/jmc/pull/398 From clanger at openjdk.java.net Thu Apr 14 05:52:26 2022 From: clanger at openjdk.java.net (Christoph Langer) Date: Thu, 14 Apr 2022 05:52:26 GMT Subject: RFR: 7767: Fix handling of version qualifier in core plugins [v4] In-Reply-To: References: Message-ID: > This PR adds some maven antrun magic to handle the .qualifier version property in core modules Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: JMC-7767 ------------- Changes: https://git.openjdk.java.net/jmc/pull/396/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=396&range=03 Stats: 59 lines in 1 file changed: 58 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/396.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/396/head:pull/396 PR: https://git.openjdk.java.net/jmc/pull/396 From jpbempel at openjdk.java.net Thu Apr 14 20:50:14 2022 From: jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Thu, 14 Apr 2022 20:50:14 GMT Subject: RFR: 7769: Cleanup pom and project files for JMC core In-Reply-To: References: Message-ID: <0cICGPojT9l5D0_NK1H_iMWlONfSe-j140XjsgR9TwA=.305f126a-8151-438d-82eb-c01217653295@github.com> On Wed, 13 Apr 2022 23:36:58 GMT, Christoph Langer wrote: > There is a lot of redundancy, whitespace errors, inconsistencies, obsolete stuff, errors, outdated plugin versions etc. in JMC core pom and project files. > > org.openjdk.jmc.flightrecorder.writer.test and org.openjdk.jmc.jdp.test have been refactored in terms of layout like the other test projects. please review the Copyright years. also all build.properties modified ones core/org.openjdk.jmc.common/pom.xml line 3: > 1: > 2: