RFR: 6972: Naming and Version Numbering Issues with Plugins

[Virag Purnam]

On Wed, 23 Mar 2022 18:30:45 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> **Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. 
> Plug-in details in JMC shows 8.3.0.qualifier.
> <img width="597" alt="BundleVersionIssue" src="https://user-images.githubusercontent.com/97600378/159768661-e4928c03-e986-4a83-9886-51f27a026605.png">
> 
> **Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) 
> e.g Bundle-Version: 8.3.0.qualifier  to Bundle-Version: 8.3.0
> With the above change Plug-in details in JMC shows 8.3.0.
> <img width="591" alt="BundleVersionIssueResolved" src="https://user-images.githubusercontent.com/97600378/159768955-32ee9cae-2fdd-4c19-90ad-a4767b2b5364.png">
> 
> **Issue:** Bundle names are not uniform.
> <img width="594" alt="JOverFlowBundleNameIssue" src="https://user-images.githubusercontent.com/97600378/159769336-d08fe913-af2b-489f-8980-162f31620ea2.png">
> 
> Duplicate bundle name.
> <img width="686" alt="DuplicateBundleName" src="https://user-images.githubusercontent.com/97600378/159769670-2507094e-2379-4b89-8350-b8b34d70154d.png">
> 
> **Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform.
> 
> - _Joverflow_ to _JOverFlow Plug-in_  for  org.openjdk.jmc.joverflow
> - _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui
> - _Greychart UI Plug-in_ to _GreyChart UI Plug-in_  for org.openjdk.jmc.greychart.ui
> - _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui
> - _Common Plug-in_ to  _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers
> - _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk
> - _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin)
> - _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test
> - _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test
> 
> <img width="593" alt="JOverFlowBundleNameIssueResolved" src="https://user-images.githubusercontent.com/97600378/159770397-d063a268-db9d-45dc-80d7-06c8b2237256.png">
> <img width="682" alt="DuplicateBundleNameResolved" src="https://user-images.githubusercontent.com/97600378/159770398-1a0eb6e9-ab9e-4af5-9641-c3055f3222f4.png">
> 
> **Issue:** Duplicate Bundle-SymbolicName
> 
> **Solution:**  Bundle-SymbolicName has been modified
> _org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin)

Let me dig further on this and I will post my investigation over here. I will look for how tycho replaces this .qualifier with build timestamp in manifest first projects.

-------------

PR: https://git.openjdk.java.net/jmc/pull/390