From hirt at openjdk.org  Wed Aug  3 14:38:01 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Aug 2022 14:38:01 GMT
Subject: RFR: 6757: Selector for attribute in the flame graph
In-Reply-To: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
References: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
Message-ID: <KqdVqYEtLg3rqlJsybJ1Gm8YqvaX_cl2Jeb3purJTN8=.9641aeeb-ec9d-4ee3-99f9-0a85f1180ddd@github.com>

On Wed, 19 Jan 2022 13:04:35 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add support for aggregating flamegraph by custom attribute.
> 
> Available attributes are chosen by their content type (number or memory).
> 
> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
> 
> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
> 
> Added support on StacktraceView:
> 
> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">

Great work!

A few general comments:
* When selecting an attribute only present in certain event types, perhaps it would make sense to first filter on those types? Now the source event count will remain the same, even when only a few events actually has the attribute in question.
* Perhaps "Samples" should always be on the top of the menu, with a delimiter after, and with a small description. E.g. Samples (Event Count).

-------------

PR: https://git.openjdk.org/jmc/pull/365

From hirt at openjdk.org  Wed Aug  3 14:43:03 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Aug 2022 14:43:03 GMT
Subject: RFR: 6757: Selector for attribute in the flame graph
In-Reply-To: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
References: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
Message-ID: <KirgnqcYlApmEd4-rloidQIGy6A-YjHpYMEBwFRZWgc=.07852ee9-bb8b-4c0c-adda-6bcf74f6f73e@github.com>

On Wed, 19 Jan 2022 13:04:35 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add support for aggregating flamegraph by custom attribute.
> 
> Available attributes are chosen by their content type (number or memory).
> 
> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
> 
> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
> 
> Added support on StacktraceView:
> 
> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 50:

> 48: import static org.openjdk.jmc.flightrecorder.flameview.MessagesUtils.getFlameviewMessage;
> 49: 
> 50: import java.io.BufferedWriter;

Need to update the copyright year.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AttributeSelection.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.ui.common;

Need a copyright header.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 99:

> 97: import org.openjdk.jmc.common.IState;
> 98: import org.openjdk.jmc.common.collection.SimpleArray;
> 99: import org.openjdk.jmc.common.item.IAttribute;

Need to update the copyright year.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 800:

> 798: 		String attrName = currentAttribute != null ? currentAttribute.getName() : null;
> 799: 		createAttributeSelection(attrName, attrList);
> 800: 

Unnecessary new line.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 59:

> 57: 
> 58: import org.openjdk.jmc.common.IMCFrame;
> 59: import org.openjdk.jmc.common.item.Aggregators;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceFrame.java line 37:

> 35: import org.openjdk.jmc.common.IMCFrame;
> 36: import org.openjdk.jmc.common.collection.SimpleArray;
> 37: import org.openjdk.jmc.common.item.Aggregators;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceModel.java line 47:

> 45: import org.openjdk.jmc.common.collection.ArrayToolkit;
> 46: import org.openjdk.jmc.common.collection.SimpleArray;
> 47: import org.openjdk.jmc.common.item.IAttribute;

Need to update the copyright year.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/StacktraceTreeModel.java line 48:

> 46: import org.openjdk.jmc.common.item.IMemberAccessor;
> 47: import org.openjdk.jmc.common.unit.IQuantity;
> 48: import org.openjdk.jmc.common.unit.UnitLookup;

Need to update the copyright year.

core/tests/org.openjdk.jmc.flightrecorder.test/src/main/java/org/openjdk/jmc/flightrecorder/test/StacktraceTreeModelTest.java line 85:

> 83: 		assertEquals(leafValues.size(), 3);
> 84: 		Map<String, List<Double>> expected = new HashMap<>();
> 85: 		expected.put("Arrays.copyOfRange(char[], int, int)", asList(104.0 / 1024));

Need to update the copyright year.

-------------

PR: https://git.openjdk.org/jmc/pull/365

From hirt at openjdk.org  Thu Aug  4 13:09:15 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Aug 2022 13:09:15 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <LOttfCtuQajYVL2oZjS_5XKWfX3QXVMC2vIbZxBBZLQ=.5ef3eea9-1418-4f9c-8c46-9cc6752df169@github.com>

On Tue, 28 Jun 2022 13:18:45 GMT, Brice Dutheil <duke at openjdk.org> wrote:

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

@cimi is adding alternative visualization for chord dependency diagrams towards the end of this week, and then we'll take the changes for 8.3.0.

application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:

> 201: 
> 202:    <plugin
> 203:          id="org.openjdk.jmc.flightrecorder.hierarchical-edge"

Nit: I'd prefer to skip the dash.

application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:

> 201: 
> 202:    <plugin
> 203:          id="org.openjdk.jmc.flightrecorder.hierarchical-edge"

Nit: I'd prefer skipping the dash.

application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 1:

> 1: function updateGraph(eventsJson) {

First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)

application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 2:

> 1: function updateGraph(eventsJson) {
> 2: 	const data = JSON.parse(eventsJson);

First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)

-------------

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 11:43:40 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 11:43:40 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v2]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <RnFa_vCgWZ5Vwvcq3goWt0en1uBITR9WrBz_PvB2y-Y=.46dff1b2-d098-4a7e-ba3b-06624c7e63ed@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with eight additional commits since the last revision:

 - Rebuild dependency chart when window is resized
 - Resize chart on update; hide debug logs in html
 - Set minimum innerRadius for chord diagram to 100px
 - Update dependency chart on chart type change
 - Use tabs for indentation in JS files, auto-reformat
 - Add JS code for chord diagram and ability to switch from edge-bundling
 - Add icons in toolbar to switch between different chart types
 - Extract JS utility functions in separate file

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/64f3602c..ad2eda4b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=00-01

  Stats: 646 lines in 10 files changed: 405 ins; 230 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From hirt at openjdk.org  Fri Aug  5 12:13:05 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 5 Aug 2022 12:13:05 GMT
Subject: RFR: 7820: Add validations for master password [v4]
In-Reply-To: <i-Hm-xyVBlsiaeTxfsKL580DEOOuzBztk6Bwzx3XS4Y=.c35cdb9b-cf5e-4ebc-99ed-2debbb49ce05@github.com>
References: <YFuF5ugn6sBTzPmK903_6LMg7cUTua5jhujSGPnGQE4=.4ce2df18-4318-499d-a758-0094ffbc5fd6@github.com>
 <i-Hm-xyVBlsiaeTxfsKL580DEOOuzBztk6Bwzx3XS4Y=.c35cdb9b-cf5e-4ebc-99ed-2debbb49ce05@github.com>
Message-ID: <rOI90FOx1soNrgeD6vyZjeIoBSLNADV8R19MBvlgzS8=.c903ac3a-7cd5-4b32-8786-ed39662fb13d@github.com>

On Thu, 28 Jul 2022 00:59:54 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR adds password validations for master password field.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor modifications as per review

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/406

From schaturvedi at openjdk.org  Fri Aug  5 12:24:55 2022
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 5 Aug 2022 12:24:55 GMT
Subject: Integrated: 7820: Add validations for master password
In-Reply-To: <YFuF5ugn6sBTzPmK903_6LMg7cUTua5jhujSGPnGQE4=.4ce2df18-4318-499d-a758-0094ffbc5fd6@github.com>
References: <YFuF5ugn6sBTzPmK903_6LMg7cUTua5jhujSGPnGQE4=.4ce2df18-4318-499d-a758-0094ffbc5fd6@github.com>
Message-ID: <k5kS_h_yoNAvKXTJrm_0XWnUU7J-LRtukM4dLvCZsYY=.c7c899b3-65a1-4fe4-af83-46a6bda32c8b@github.com>

On Wed, 29 Jun 2022 22:16:18 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR adds password validations for master password field.

This pull request has now been integrated.

Changeset: 266643e4
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/266643e4f305ce1ce7fc981cd3f1998119f47455
Stats:     110 lines in 5 files changed: 98 ins; 4 del; 8 mod

7820: Add validations for master password

Reviewed-by: clanger, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/406

From duke at openjdk.org  Fri Aug  5 12:35:14 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 12:35:14 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v3]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <sB71LwzVuzRFMh6HcYbv6V2ufBe_IH4N8fPrI1Xj08k=.ed9143bc-4233-42c6-bc08-093ff89389c8@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision:

 - Add localized tooltips to the dependency diagram switcher icons
 - Make edge bundling and chord diagrams use the same formula for radius

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/ad2eda4b..15e0b757

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=01-02

  Stats: 28 lines in 7 files changed: 10 ins; 6 del; 12 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 12:37:19 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 12:37:19 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v4]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <a6RyzMreDNFM5JqVmuWx2ZkEJRMFIwgH7e001jUA_80=.eed28340-6f97-41c9-894a-5a4d67a9c9ba@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Convert indentation in all dependency chart JS files to tabs

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/15e0b757..a8278ece

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=02-03

  Stats: 390 lines in 5 files changed: 0 ins; 0 del; 390 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 12:48:10 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 12:48:10 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v5]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <2rGhxlGUto_GqEzF7EWVLHFRyYifbl1k9aQYSJgJ9io=.d29d93bc-3411-4fba-9c7d-4cce18a08fdf@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Check multiple attributes to get event time

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/a8278ece..c46682ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=03-04

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 16:43:43 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 16:43:43 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v6]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <vRvgSa_QgP9aJlDUAoZF6p4keF4eIyTcgK80i893Ndc=.a2d90293-669b-497e-b6bb-0904938537bd@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Add chord and edge bundling diagram icons

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/c46682ff..d90aa65d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=05
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=04-05

  Stats: 3 lines in 12 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 17:30:05 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 17:30:05 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v7]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <GJ_IwYW_VRn-pdM_c9nbeqKBnRt5KGy8Y8Mk-4f-jt0=.b5b89b60-3f5a-4069-8c9f-14a030c24b04@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision:

 - Make chord diagram default dependency view
 - Add warning banner showing hidden edges on chord diagram

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/d90aa65d..7e8dc2d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=06
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=05-06

  Stats: 53 lines in 3 files changed: 45 ins; 2 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 17:38:14 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 17:38:14 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v8]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <527DXY8e7N3kbi6fi_0_CX_EnfdOuoNplaT3Zgt-cXQ=.ababefee-9fa4-4b80-9b54-8cca7c732de7@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Make chord diagram default dependency view

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/7e8dc2d6..e8c342b0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=07
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 18:51:26 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 18:51:26 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v9]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <Xmtv4yJ1TfzwZHFfW2dRofRt7-ObheLQcCVTPso-Os4=.f6e651a7-e3a3-40bd-85fd-2c4f585520af@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Rename hierarchical-edge to dependencyview

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/e8c342b0..568f8d81

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=08
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=07-08

  Stats: 1006 lines in 28 files changed: 478 ins; 510 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 18:54:27 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 18:54:27 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v10]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <oQGtzBq5Tyh2GsZ2O9MVFVXvBr3arV5uedtKg6T55dQ=.8467ce5d-ec5f-4554-aca2-d9f1633cf2aa@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Add ISC license to scripts ported from Observable

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/568f8d81..43e16f09

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=09
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=08-09

  Stats: 28 lines in 2 files changed: 28 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 18:57:49 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 18:57:49 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v11]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <Bs8yIz4Y0mTs_X5XHGbB4i2MUhRAVGKR1PTATuPxx_M=.48ce8f02-7ee1-46d4-9a3b-a33a42d4be50@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Prevent NPE when switching diagrams with nothing loaded

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/43e16f09..710f4066

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=10
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=09-10

  Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 19:00:09 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 19:00:09 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v12]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <MJ1HVflxnryBxyfJxz5y5SWPEYZuc-4w8ysgvAPcyuY=.d89d566a-0712-4aa2-a0a2-7f8fb60f8218@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Update .gitignore, remove .sdkmanrc

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/710f4066..49054481

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=11
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=10-11

  Stats: 4 lines in 2 files changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 19:02:29 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 19:02:29 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v13]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <8bvuBPFZmEyNG9Kj9erBpO53IzN5lDKZ7m1PmVsNtA4=.fd8b2ec9-8aa6-4ab5-bb7b-2977153b94e1@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Update .gitignore, remove .sdkmanrc and d3

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/49054481..bee03a55

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=12
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=11-12

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 19:04:34 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 19:04:34 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v14]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Add newlines to end of all files

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/bee03a55..1ae425a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=13
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=12-13

  Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 19:14:12 2022
From: duke at openjdk.org (Alex Ciminian)
Date: Fri, 5 Aug 2022 19:14:12 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v14]
In-Reply-To: <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
 <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
Message-ID: <XwG7WEFFei5lIm3btmpyrzDw-geH6VWLVVOZmIyhcCU=.46887785-9f9c-4e0f-9c08-6a92c1ca0549@github.com>

On Fri, 5 Aug 2022 19:04:34 GMT, Brice Dutheil <duke at openjdk.org> wrote:

>> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>> 
>> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
>> 
>> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>> 
>> 
>> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add newlines to end of all files

I've renamed the plugin to `dependencyview`, added the chord diagram and made it the default.

It now looks like this:
<img width="2672" alt="Screenshot 2022-08-05 at 20 05 20" src="https://user-images.githubusercontent.com/348973/183144613-e72530c9-bbc1-46d6-8ad8-7adc3f5f293d.png">

The chord diagram prunes the edges it renders depending on the window size - when edges are hidden we display a warning message in the top right corner of the window.

The hierarchical edge view now fits in the window, rendering at the same size as the chord diagram. This prevents overflow and scrolling.

<img width="2672" alt="Screenshot 2022-08-05 at 20 08 53" src="https://user-images.githubusercontent.com/348973/183144871-802f56db-e07c-4820-8e34-94851d4d2cf4.png">

-------------

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 19:14:15 2022
From: duke at openjdk.org (Alex Ciminian)
Date: Fri, 5 Aug 2022 19:14:15 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v14]
In-Reply-To: <LOttfCtuQajYVL2oZjS_5XKWfX3QXVMC2vIbZxBBZLQ=.5ef3eea9-1418-4f9c-8c46-9cc6752df169@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
 <LOttfCtuQajYVL2oZjS_5XKWfX3QXVMC2vIbZxBBZLQ=.5ef3eea9-1418-4f9c-8c46-9cc6752df169@github.com>
Message-ID: <G49MkeMubCMd_DMCY_oKzZzUTsZtG_uWVE_9xFQu1hI=.c7caed7f-3798-4bc1-aa75-abce72a0ae1a@github.com>

On Thu, 4 Aug 2022 12:57:36 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add newlines to end of all files
>
> application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 203:
> 
>> 201: 
>> 202:    <plugin
>> 203:          id="org.openjdk.jmc.flightrecorder.hierarchical-edge"
> 
> Nit: I'd prefer to skip the dash.

Renamed to `dependencyview` since now we have two types of diagrams: chord and edge bundling.

> application/org.openjdk.jmc.flightrecorder.hierarchical-edge/src/main/resources/hierarchical-edge.js line 2:
> 
>> 1: function updateGraph(eventsJson) {
>> 2: 	const data = JSON.parse(eventsJson);
> 
> First part here is indented with tabs. The rest with spaces. JMC uses 1-tab, 1-level-indent. (Yup, I know that we may be failing this in other parts of our JS code.)

Fixed, now all JS files should have tab indentation.

-------------

PR: https://git.openjdk.org/jmc/pull/405

From hirt at openjdk.org  Fri Aug  5 20:13:15 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 5 Aug 2022 20:13:15 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v14]
In-Reply-To: <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
 <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
Message-ID: <PAwCGFxSEpodOfe2cEk_uFiDS0_laq4rcSPhXtHJNJA=.91654556-79b3-45fd-9887-b56f11c85a01@github.com>

On Fri, 5 Aug 2022 19:04:34 GMT, Brice Dutheil <duke at openjdk.org> wrote:

>> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>> 
>> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
>> 
>> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>> 
>> 
>> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add newlines to end of all files

The saturation / contrast in the icons could probably be a bit higher, but it looks great! Well done!

application/org.openjdk.jmc.flightrecorder.dependencyview/src/main/java/org/openjdk/jmc/flightrecorder/dependencyview/DependencyView.java line 197:

> 195: 	private volatile ModelState modelState = ModelState.NONE;
> 196: 	private ModelRebuildRunnable modelRebuildRunnable;
> 197: 	private int packageDepth = 3;

Would it perhaps be better to start with 2 here? The hierarchical edge bundling gets pretty busy with 3.

-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.org/jmc/pull/405

From hirt at openjdk.org  Fri Aug  5 20:18:14 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 5 Aug 2022 20:18:14 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v14]
In-Reply-To: <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
 <YcYHTsmuMNSfCi1_YfxCsrE-Iir_vkkYGy96lB7qhkE=.25470699-9a41-4870-be7c-da5418970cba@github.com>
Message-ID: <J-h5RjygIdvYbjs6UL0PJ31sfz64DlxVlP9Y12mE71E=.686c24f6-1e2a-4e64-b7e3-65f73476967a@github.com>

On Fri, 5 Aug 2022 19:04:34 GMT, Brice Dutheil <duke at openjdk.org> wrote:

>> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>> 
>> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
>> 
>> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>> 
>> 
>> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add newlines to end of all files

Ugh. @bric3, please use the /contributor command to add cimi. :)

-------------

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Fri Aug  5 23:29:07 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Fri, 5 Aug 2022 23:29:07 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v15]
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <c9ocTV9rn19ag46R_ckuDmbv4ZZGZUprYuX6b7rul5k=.9838c0d9-e66c-4381-9ec3-ab15e7ff3e2f@github.com>

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision:

 - Set default package depth in dependency view to 2
 - Increase contrast on dependency view icons

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/405/files
  - new: https://git.openjdk.org/jmc/pull/405/files/1ae425a5..41b08758

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=14
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=13-14

  Stats: 1 line in 5 files changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405

PR: https://git.openjdk.org/jmc/pull/405

From hirt at openjdk.org  Sat Aug  6 18:13:09 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 6 Aug 2022 18:13:09 GMT
Subject: RFR: 7831: Add new view for hierarchical edge bundling [v15]
In-Reply-To: <c9ocTV9rn19ag46R_ckuDmbv4ZZGZUprYuX6b7rul5k=.9838c0d9-e66c-4381-9ec3-ab15e7ff3e2f@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
 <c9ocTV9rn19ag46R_ckuDmbv4ZZGZUprYuX6b7rul5k=.9838c0d9-e66c-4381-9ec3-ab15e7ff3e2f@github.com>
Message-ID: <eEncRL73GIpm69f-6EYnG-YFg0gJc8aLMKN_iElQ4cA=.db9f8c17-0e2b-4616-8069-de3382715931@github.com>

On Fri, 5 Aug 2022 23:29:07 GMT, Brice Dutheil <duke at openjdk.org> wrote:

>> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>> 
>> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
>> 
>> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>> 
>> 
>> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
>
> Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Set default package depth in dependency view to 2
>  - Increase contrast on dependency view icons

Hi @bric3 - you should be able to /integrate now.

-------------

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Sun Aug  7 13:16:50 2022
From: duke at openjdk.org (Brice Dutheil)
Date: Sun, 7 Aug 2022 13:16:50 GMT
Subject: Integrated: 7831: Add new view for hierarchical edge bundling
In-Reply-To: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
References: <NoLnGaX1chLD8RGh5d4iAqZ3BLzQKsNtpTaGnSo8yAs=.db409a1d-c2f0-4461-9c71-910db01d98d3@github.com>
Message-ID: <lL2NTxVe8DJSOMymZpyjaoGx6XGGdOugwULBPe1HteU=.bb19ade3-e0d1-437e-b3d7-0f611a4ae94e@github.com>

On Tue, 28 Jun 2022 13:18:45 GMT, Brice Dutheil <duke at openjdk.org> wrote:

> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
> 
> ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png)
> 
> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
> 
> 
> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling

This pull request has now been integrated.

Changeset: b9d1f1e6
Author:    Alex Ciminian <alexandru.ciminian at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/b9d1f1e65a5f53489c4bbfa410d2b7cea288ccaa
Stats:     1172 lines in 23 files changed: 1158 ins; 8 del; 6 mod

7831: Add new view for hierarchical edge bundling

Co-authored-by: Alexandru Ciminian <aciminian at openjdk.org>
Co-authored-by: Brice Dutheil <bdutheil at openjdk.org>
Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/405

From duke at openjdk.org  Tue Aug  9 06:05:53 2022
From: duke at openjdk.org (Virag Purnam)
Date: Tue, 9 Aug 2022 06:05:53 GMT
Subject: RFR: 7872: Adding artifacts to third-party pom file,
 which are not getting resolved by maven
Message-ID: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>

Sometimes below mentioned artifacts are not getting resolved by *mvn p2:site*. 
* jetty-security
* jetty-server
* websocket-core-server
* jetty-xml

These plugins will be missing in jmc -> releng -> third-party -> target ->repository -> plugins.
So adding these to third-party pom file. Adding these artifacts is not creating any effect on existing behavior. These artifacts will be just hosted on local p2 site.

-------------

Commit messages:
 - 7872: Adding artifacts to third-party pom file, which are not getting resolved by maven
 - 7872: Adding artifacts to third-party pom file, which are not getting resolved by maven

Changes: https://git.openjdk.org/jmc/pull/418/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=418&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7872
  Stats: 37 lines in 2 files changed: 20 ins; 6 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/418.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/418/head:pull/418

PR: https://git.openjdk.org/jmc/pull/418

From duke at openjdk.org  Tue Aug  9 06:05:53 2022
From: duke at openjdk.org (Virag Purnam)
Date: Tue, 9 Aug 2022 06:05:53 GMT
Subject: RFR: 7872: Adding artifacts to third-party pom file,
 which are not getting resolved by maven
In-Reply-To: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
References: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
Message-ID: <lB2Yfm-vHIpCad8p3UFjAZJGbWbeEeRytpbAZ5L7Dok=.096d498b-5af5-45a4-b406-5c269b227ef5@github.com>

On Tue, 9 Aug 2022 06:00:21 GMT, Virag Purnam <duke at openjdk.org> wrote:

> Sometimes below mentioned artifacts are not getting resolved by *mvn p2:site*. 
> * jetty-security
> * jetty-server
> * websocket-core-server
> * jetty-xml
> 
> These plugins will be missing in jmc -> releng -> third-party -> target ->repository -> plugins.
> So adding these to third-party pom file. Adding these artifacts is not creating any effect on existing behavior. These artifacts will be just hosted on local p2 site.

Formatting issues have been corrected in **DependencyView.java**. No code changes have been done to this class.

-------------

PR: https://git.openjdk.org/jmc/pull/418

From duke at openjdk.org  Wed Aug 10 20:31:28 2022
From: duke at openjdk.org (Austin Brooks)
Date: Wed, 10 Aug 2022 20:31:28 GMT
Subject: RFR: 7576: Remove the need for a local jetty server for
 dependencies [v2]
In-Reply-To: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>
References: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>
Message-ID: <r23jHJhDKlvBAjTLfL5CNvt4vgDPAo6G25YjU89Y_9Y=.58e03a28-b22a-455e-acc6-b819167ff2bb@github.com>

> Using newer Tycho features to achieve result:
> 
> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations
> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets
> 
> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions

Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Update latest targets to point to third-party
 - Merge branch 'master' into removeJettyMerged
 - Remove references to third-party from scripts/
 - Fix clean target trying to access third-party directory
 - XXX: Remove needing to use a local jetty server for dependencies

-------------

Changes: https://git.openjdk.org/jmc/pull/387/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=387&range=01
  Stats: 503 lines in 9 files changed: 138 ins; 362 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/387.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/387/head:pull/387

PR: https://git.openjdk.org/jmc/pull/387

From hirt at openjdk.org  Mon Aug 15 18:45:23 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 15 Aug 2022 18:45:23 GMT
Subject: RFR: 7872: Adding artifacts to third-party pom file,
 which are not getting resolved by maven
In-Reply-To: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
References: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
Message-ID: <FN-cnYLjK98y1v-bt7oa19xmCL1KDXJCorPHgTo2Clo=.59a97077-ba71-4331-aa4e-07a1811f3b88@github.com>

On Tue, 9 Aug 2022 06:00:21 GMT, Virag Purnam <duke at openjdk.org> wrote:

> Sometimes below mentioned artifacts are not getting resolved by *mvn p2:site*. 
> * jetty-security
> * jetty-server
> * websocket-core-server
> * jetty-xml
> 
> These plugins will be missing in jmc -> releng -> third-party -> target ->repository -> plugins.
> So adding these to third-party pom file. Adding these artifacts is not creating any effect on existing behavior. These artifacts will be just hosted on local p2 site.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/418

From duke at openjdk.org  Tue Aug 16 08:57:25 2022
From: duke at openjdk.org (Virag Purnam)
Date: Tue, 16 Aug 2022 08:57:25 GMT
Subject: Integrated: 7872: Adding artifacts to third-party pom file,
 which are not getting resolved by maven
In-Reply-To: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
References: <4iLsWMe8k5A062d-8IlyblTwmKlA-eow_9PNEp3SVss=.d7004a0e-f2e4-41a8-ae96-3cec80562073@github.com>
Message-ID: <N8j_KIol7O9_dxovg6HkJ5Clq5feLxSEX-91vjdrRNg=.fc795da5-1934-4d72-b85f-5b5fa8e89a72@github.com>

On Tue, 9 Aug 2022 06:00:21 GMT, Virag Purnam <duke at openjdk.org> wrote:

> Sometimes below mentioned artifacts are not getting resolved by *mvn p2:site*. 
> * jetty-security
> * jetty-server
> * websocket-core-server
> * jetty-xml
> 
> These plugins will be missing in jmc -> releng -> third-party -> target ->repository -> plugins.
> So adding these to third-party pom file. Adding these artifacts is not creating any effect on existing behavior. These artifacts will be just hosted on local p2 site.

This pull request has now been integrated.

Changeset: 195d32c0
Author:    vpurnam <vpurnam at VPURNAM-7420.in.oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/195d32c00510f28b77756a7f262af5877d371606
Stats:     37 lines in 2 files changed: 20 ins; 6 del; 11 mod

7872: Adding artifacts to third-party pom file, which are not getting resolved by maven

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/418

From duke at openjdk.org  Tue Aug 16 21:42:43 2022
From: duke at openjdk.org (duke)
Date: Tue, 16 Aug 2022 21:42:43 GMT
Subject: git: openjdk/jmc: Added tag 8.2.1-rc for changeset bfa2e068
Message-ID: <17b26837-2bd7-48d6-9f22-d85ea7229444@openjdk.org>

Tagged by: thegreystone <marcus at hirt.se>
Date:      2022-08-16 23:40:18 +0000

Release candidate for JMC 8.2.1
Changeset: bfa2e068
Author:    schaturvedi <suchita.chaturvedi at oracle.com>
Committer: thegreystone <marcus at hirt.se>
Date:      2022-05-02 02:16:33 +0000
URL:       https://git.openjdk.org/jmc/commit/bfa2e068986bd10ca05b189fe7146a9d8f09016a


From schaturvedi at openjdk.org  Sat Aug 20 19:03:24 2022
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sat, 20 Aug 2022 19:03:24 GMT
Subject: RFR: 7879: Automated Analysis taking very long time to produce results
 for Class Leak Rule and showing wrong results.
Message-ID: <O1zBHVRTCZY4R-YebBwcj-VuqnoX8gTh52GpFqR9Kww=.03e244f7-c76c-444c-a1aa-58b8fb240381@github.com>

This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.

-------------

Commit messages:
 - 7879 : Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results.

Changes: https://git.openjdk.org/jmc/pull/419/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=419&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7879
  Stats: 63 lines in 5 files changed: 38 ins; 1 del; 24 mod
  Patch: https://git.openjdk.org/jmc/pull/419.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/419/head:pull/419

PR: https://git.openjdk.org/jmc/pull/419

From duke at openjdk.org  Tue Aug 23 08:03:59 2022
From: duke at openjdk.org (Virag Purnam)
Date: Tue, 23 Aug 2022 08:03:59 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap.
Message-ID: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>

In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics". 

- Avg Live Count
- Avg Live Size
- Live Instances Increase
- Percentage of Heap

![ObjectStatistics](https://user-images.githubusercontent.com/97600378/186091512-b434560a-96b1-4e62-80b8-029ae95169bf.jpg)

-------------

Commit messages:
 - 7096: Bring back Object statistics table for heap.

Changes: https://git.openjdk.org/jmc/pull/420/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=420&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7096
  Stats: 71 lines in 9 files changed: 69 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/420.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/420/head:pull/420

PR: https://git.openjdk.org/jmc/pull/420

From hirt at openjdk.org  Wed Aug 24 14:28:22 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 24 Aug 2022 14:28:22 GMT
Subject: RFR: 7877: Update the jmc version in jmc8 branch to 8.2.1
Message-ID: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>

Unless there is any other feedback before next Wednesday, I'll set the ga tag at the next JMC dev meeting.

-------------

Commit messages:
 - Minor fixes
 - 7877: Update version to 8.2.1

Changes: https://git.openjdk.org/jmc/pull/421/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=421&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7877
  Stats: 212 lines in 147 files changed: 0 ins; 0 del; 212 mod
  Patch: https://git.openjdk.org/jmc/pull/421.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/421/head:pull/421

PR: https://git.openjdk.org/jmc/pull/421

From aptmac at openjdk.org  Wed Aug 24 14:33:39 2022
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 24 Aug 2022 14:33:39 GMT
Subject: RFR: 7877: Update the jmc version in jmc8 branch to 8.2.1
In-Reply-To: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
References: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
Message-ID: <ZpaH9MA4BhI3y7U-5XGfaYIxR2ZrUx4fTww8zf7b4f8=.b0c3398b-f9eb-4a23-8876-d3b5f5d519ff@github.com>

On Wed, 24 Aug 2022 14:20:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Unless there is any other feedback before next Wednesday, I'll set the ga tag at the next JMC dev meeting.

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.org/jmc/pull/421

From clanger at openjdk.org  Wed Aug 24 18:30:41 2022
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 24 Aug 2022 18:30:41 GMT
Subject: RFR: 7877: Update the jmc version in jmc8 branch to 8.2.1
In-Reply-To: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
References: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
Message-ID: <OqdKH9QXXa_9EO8BvusYAsbCejRNNR84Egb5UmeZXyI=.5c26a3e8-f132-4f85-a4b8-7291e38bc1de@github.com>

On Wed, 24 Aug 2022 14:20:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Unless there is any other feedback before next Wednesday, I'll set the ga tag at the next JMC dev meeting.

Marked as reviewed by clanger (Committer).

-------------

PR: https://git.openjdk.org/jmc/pull/421

From hirt at openjdk.org  Thu Aug 25 17:51:32 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 25 Aug 2022 17:51:32 GMT
Subject: Integrated: 7877: Update the jmc version in jmc8 branch to 8.2.1
In-Reply-To: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
References: <l_EWRYKV5vZNTUmdqyv9-vwZ1igy8T8AbE42qq0VptY=.e4d9cd2a-5bbd-4da9-a414-50e754dc56b7@github.com>
Message-ID: <eEBu7OHwYqDjT4M4AWGtfm7p12-nliLDvYRVosIDHOs=.7e5b18ad-251b-4779-bffa-65d9455c5221@github.com>

On Wed, 24 Aug 2022 14:20:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Unless there is any other feedback before next Wednesday, I'll set the ga tag at the next JMC dev meeting.

This pull request has now been integrated.

Changeset: ed260098
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/ed260098c92989d60d1058a53fd74a96fd8f78be
Stats:     212 lines in 147 files changed: 0 ins; 0 del; 212 mod

7877: Update the jmc version in jmc8 branch to 8.2.1

Reviewed-by: aptmac, clanger

-------------

PR: https://git.openjdk.org/jmc/pull/421

From duke at openjdk.org  Fri Aug 26 15:47:29 2022
From: duke at openjdk.org (Virag Purnam)
Date: Fri, 26 Aug 2022 15:47:29 GMT
Subject: RFR: 7874: Update thirdpartyreadme.txt file for upgraded third party
 libraries
Message-ID: <MjXIjyjbURYdhogVk7ZmaI3qOORRkc_FQH8a2ZwFsac=.25def72e-5aa7-4af9-8108-7ccb23db8795@github.com>

Updated the License information in thirdpartyreadme.txt file.

-------------

Commit messages:
 - 7874: Update thirdpartyreadme.txt file for upgraded third party libraries

Changes: https://git.openjdk.org/jmc/pull/422/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=422&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7874
  Stats: 6894 lines in 1 file changed: 5547 ins; 857 del; 490 mod
  Patch: https://git.openjdk.org/jmc/pull/422.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/422/head:pull/422

PR: https://git.openjdk.org/jmc/pull/422

From aptmac at openjdk.org  Mon Aug 29 02:31:19 2022
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 29 Aug 2022 02:31:19 GMT
Subject: RFR: 7879: Automated Analysis taking very long time to produce
 results for Class Leak Rule and showing wrong results.
In-Reply-To: <O1zBHVRTCZY4R-YebBwcj-VuqnoX8gTh52GpFqR9Kww=.03e244f7-c76c-444c-a1aa-58b8fb240381@github.com>
References: <O1zBHVRTCZY4R-YebBwcj-VuqnoX8gTh52GpFqR9Kww=.03e244f7-c76c-444c-a1aa-58b8fb240381@github.com>
Message-ID: <CZLub4FArE_eLJrjiH6bo22PtHzIPMWUdzCVsSBV0xo=.6a19a0b4-430f-4509-a8a1-646349ab8bdc@github.com>

On Sat, 20 Aug 2022 18:59:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.

Is https://bugs.openjdk.org/browse/JMC-7879 a duplicate of https://bugs.openjdk.org/browse/JMC-7248?

It looks like this PR is https://github.com/openjdk/jmc/pull/248 with some of the review comments addressed, should the former PR be closed in favor of this?

There are a couple of review comments that didn't receive any changes in this PR:
https://github.com/openjdk/jmc/pull/248/files#r756349943
https://github.com/openjdk/jmc/pull/248/files#r756353644

It looks like the consensus on https://github.com/openjdk/jmc/pull/248 was that it was good enough to go in, maybe ping @bric3 and/or @Gunde for a re-review/approval?

-------------

PR: https://git.openjdk.org/jmc/pull/419

From hirt at openjdk.org  Mon Aug 29 13:57:16 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 29 Aug 2022 13:57:16 GMT
Subject: RFR: 7874: Update thirdpartyreadme.txt file for upgraded third
 party libraries
In-Reply-To: <MjXIjyjbURYdhogVk7ZmaI3qOORRkc_FQH8a2ZwFsac=.25def72e-5aa7-4af9-8108-7ccb23db8795@github.com>
References: <MjXIjyjbURYdhogVk7ZmaI3qOORRkc_FQH8a2ZwFsac=.25def72e-5aa7-4af9-8108-7ccb23db8795@github.com>
Message-ID: <5lyuQ6H9y7hvt8DO74pdGKDTeZEa1noWJKecvDHh3Zc=.e4520531-cb2d-47b4-9774-f640f410bbff@github.com>

On Fri, 26 Aug 2022 15:41:20 GMT, Virag Purnam <duke at openjdk.org> wrote:

> Updated the License information in thirdpartyreadme.txt file.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/422

From hirt at openjdk.org  Mon Aug 29 14:04:18 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 29 Aug 2022 14:04:18 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap.
In-Reply-To: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
Message-ID: <n1qUYoOxez0tb9_gVclM4fqXfUE0fskmy0OdtKXCEt0=.c5a76014-f171-4ca9-8f74-3ec5329b09b5@github.com>

On Tue, 23 Aug 2022 07:56:19 GMT, Virag Purnam <duke at openjdk.org> wrote:

> In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics". 
> 
> - Avg Live Count
> - Avg Live Size
> - Live Instances Increase
> - Percentage of Heap
> 
> ![ObjectStatistics](https://user-images.githubusercontent.com/97600378/186091512-b434560a-96b1-4e62-80b8-029ae95169bf.jpg)

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/ObjectStatisticsDataProvider.java line 105:

> 103: 
> 104: 	/**
> 105: 	 * @return an aggregator for the increase in the live size set between the first and last

Perhaps "live set size"?

-------------

PR: https://git.openjdk.org/jmc/pull/420

From duke at openjdk.org  Mon Aug 29 15:32:17 2022
From: duke at openjdk.org (Virag Purnam)
Date: Mon, 29 Aug 2022 15:32:17 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap. [v2]
In-Reply-To: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
Message-ID: <UCDn-m2CTuujkGORf_olOWHLKlncz3CZMqEk6Wt1mg0=.5781a057-2b7d-47d2-8459-aebfddde1345@github.com>

> In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics". 
> 
> - Avg Live Count
> - Avg Live Size
> - Live Instances Increase
> - Percentage of Heap
> 
> ![ObjectStatistics](https://user-images.githubusercontent.com/97600378/186091512-b434560a-96b1-4e62-80b8-029ae95169bf.jpg)

Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:

  7096: Bring back Object statistics table for heap.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/420/files
  - new: https://git.openjdk.org/jmc/pull/420/files/202a1caa..887bdf75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=420&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=420&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/420.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/420/head:pull/420

PR: https://git.openjdk.org/jmc/pull/420

From duke at openjdk.org  Mon Aug 29 15:32:20 2022
From: duke at openjdk.org (Virag Purnam)
Date: Mon, 29 Aug 2022 15:32:20 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap. [v2]
In-Reply-To: <n1qUYoOxez0tb9_gVclM4fqXfUE0fskmy0OdtKXCEt0=.c5a76014-f171-4ca9-8f74-3ec5329b09b5@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
 <n1qUYoOxez0tb9_gVclM4fqXfUE0fskmy0OdtKXCEt0=.c5a76014-f171-4ca9-8f74-3ec5329b09b5@github.com>
Message-ID: <Sr54EKj8ZEfhm1m6_g9WJL8adQvAsYkuoyols5InWUA=.75e56db9-93c8-418e-b3c4-95825a1d2d50@github.com>

On Mon, 29 Aug 2022 13:56:35 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Perhaps "live set size"?

Thanks Marcus. I have done the changes accordingly. I have committed and pushed the changes.

-------------

PR: https://git.openjdk.org/jmc/pull/420

From aptmac at openjdk.org  Mon Aug 29 16:01:25 2022
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 29 Aug 2022 16:01:25 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap. [v2]
In-Reply-To: <Sr54EKj8ZEfhm1m6_g9WJL8adQvAsYkuoyols5InWUA=.75e56db9-93c8-418e-b3c4-95825a1d2d50@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
 <n1qUYoOxez0tb9_gVclM4fqXfUE0fskmy0OdtKXCEt0=.c5a76014-f171-4ca9-8f74-3ec5329b09b5@github.com>
 <Sr54EKj8ZEfhm1m6_g9WJL8adQvAsYkuoyols5InWUA=.75e56db9-93c8-418e-b3c4-95825a1d2d50@github.com>
Message-ID: <OlPh6-tecDEHg7dLksFYQOq-XE-I6VC9EQE-WHfZUjE=.8c179aec-7c0c-4049-8e49-d5249e34687d@github.com>

On Mon, 29 Aug 2022 15:29:04 GMT, Virag Purnam <duke at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/ObjectStatisticsDataProvider.java line 105:
>> 
>>> 103: 
>>> 104: 	/**
>>> 105: 	 * @return an aggregator for the increase in the live size set between the first and last
>> 
>> Perhaps "live set size"?
>
>> Perhaps "live set size"?
> 
> Thanks Marcus. I have done the changes accordingly. I have committed and pushed the changes.

`[..] increase in the live size set between [..]`

It looks like you shuffled the set & size around

-------------

PR: https://git.openjdk.org/jmc/pull/420

From duke at openjdk.org  Mon Aug 29 16:29:13 2022
From: duke at openjdk.org (Virag Purnam)
Date: Mon, 29 Aug 2022 16:29:13 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap. [v2]
In-Reply-To: <OlPh6-tecDEHg7dLksFYQOq-XE-I6VC9EQE-WHfZUjE=.8c179aec-7c0c-4049-8e49-d5249e34687d@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
 <n1qUYoOxez0tb9_gVclM4fqXfUE0fskmy0OdtKXCEt0=.c5a76014-f171-4ca9-8f74-3ec5329b09b5@github.com>
 <Sr54EKj8ZEfhm1m6_g9WJL8adQvAsYkuoyols5InWUA=.75e56db9-93c8-418e-b3c4-95825a1d2d50@github.com>
 <OlPh6-tecDEHg7dLksFYQOq-XE-I6VC9EQE-WHfZUjE=.8c179aec-7c0c-4049-8e49-d5249e34687d@github.com>
Message-ID: <tDnl_JM06-u70M4gAPO6l7UJs77reckIhCB3nfbIqnc=.527ce6e2-ce2f-4449-9e44-ebf38246bf60@github.com>

On Mon, 29 Aug 2022 15:57:37 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> `[..] increase in the live size set between [..]`
> 
> It looks like you shuffled the set & size around

I have changed the comment to [..] increase in the live set size between [..] . Actually I have added a new method which returns the "increase in instances". The method which is already present returns the "increase in size".

-------------

PR: https://git.openjdk.org/jmc/pull/420

From jpbempel at openjdk.org  Mon Aug 29 20:59:07 2022
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Mon, 29 Aug 2022 20:59:07 GMT
Subject: RFR: 6757: Selector for attribute in the flame graph [v2]
In-Reply-To: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
References: <Fk1SjXj1_FdWj_lzwzpcy1Z96ZvF1xc-iFCJ4atyFTU=.f3827ce4-1f77-46e2-9c80-53c4b466c9f7@github.com>
Message-ID: <8ChKbGOuqVMi-l5FCae_Jlsw7or7DDBIo13wR6Yrum4=.5a250de2-5906-4770-b11c-7ca98a9bf443@github.com>

> Add support for aggregating flamegraph by custom attribute.
> 
> Available attributes are chosen by their content type (number or memory).
> 
> <img width="1435" alt="Screenshot 2022-04-22 at 08 35 
> 47" src="https://user-images.githubusercontent.com/4610701/164617514-34d56474-768a-4f96-8d92-5ba617aca45a.png">
> 
> <img width="1437" alt="Screenshot 2022-04-22 at 08 36 06" src="https://user-images.githubusercontent.com/4610701/164617547-c0da25a8-d5f2-4739-bbd9-d41a3dd98d02.png">
> 
> Added support on StacktraceView:
> 
> <img width="1098" alt="Screenshot 2022-05-10 at 22 20 13" src="https://user-images.githubusercontent.com/4610701/167715364-04ca6580-4389-4c21-b6da-5d7d0fcae63b.png">

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Filter items containing selected attribute
  
  Add separator and Samples as first in attribute selection
  Fix copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/365/files
  - new: https://git.openjdk.org/jmc/pull/365/files/62b7c4d2..b2e48e13

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=00-01

  Stats: 70 lines in 9 files changed: 49 ins; 3 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/365.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/365/head:pull/365

PR: https://git.openjdk.org/jmc/pull/365

From schaturvedi at openjdk.org  Mon Aug 29 22:13:05 2022
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 29 Aug 2022 22:13:05 GMT
Subject: RFR: 7879: Automated Analysis taking very long time to produce
 results for Class Leak Rule and showing wrong results.
In-Reply-To: <O1zBHVRTCZY4R-YebBwcj-VuqnoX8gTh52GpFqR9Kww=.03e244f7-c76c-444c-a1aa-58b8fb240381@github.com>
References: <O1zBHVRTCZY4R-YebBwcj-VuqnoX8gTh52GpFqR9Kww=.03e244f7-c76c-444c-a1aa-58b8fb240381@github.com>
Message-ID: <RNkCraS9nL0eFBzjKOoPT9ztwR6tcWcdpUrtWoOmI9Y=.65f78947-92c7-4dae-a998-1051db9d8f24@github.com>

On Sat, 20 Aug 2022 18:59:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.

> Is https://bugs.openjdk.org/browse/JMC-7879 a duplicate of https://bugs.openjdk.org/browse/JMC-7248?
> 
> It looks like this PR is #248 with some of the review comments addressed, should the former PR be closed in favor of this?
> 
> There are a couple of review comments that didn't receive any changes in this PR: https://github.com/openjdk/jmc/pull/248/files#r756349943 https://github.com/openjdk/jmc/pull/248/files#r756353644
> 
> It looks like the consensus on #248 was that it was good enough to go in, maybe ping @bric3 and/or @Gunde for a re-review/approval?

This PR is a superset of the previous one. The older one deals with only optimization of the class leak rule but this one deals with the optimization as well as the correction of the results shown on automated analysis page for class leak rule. I have implemented all the review comments given on the previous PR. With respect to the two comments mentioned above, the configured timeout is being fetched from preference hence I am finding it difficult to make it final. The interrupted exception handling is done where the method is called in catch block. I had already pinged about this issue in general slack channel and it was discussed in hangout also. 

@Gunde and @bric3 Request both of you to please take a look at this PR and let me know your review comments. Thanks in advance.

-------------

PR: https://git.openjdk.org/jmc/pull/419

From hirt at openjdk.org  Wed Aug 31 17:24:26 2022
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 31 Aug 2022 17:24:26 GMT
Subject: RFR: 7096: Bring back Object statistics table for heap. [v2]
In-Reply-To: <UCDn-m2CTuujkGORf_olOWHLKlncz3CZMqEk6Wt1mg0=.5781a057-2b7d-47d2-8459-aebfddde1345@github.com>
References: <KzucTQaRxhmga0OH9SoNL6Ony92e_t42zA9LB6ekfak=.f60b7257-ec4e-4f1d-911e-361125710ff1@github.com>
 <UCDn-m2CTuujkGORf_olOWHLKlncz3CZMqEk6Wt1mg0=.5781a057-2b7d-47d2-8459-aebfddde1345@github.com>
Message-ID: <s6jSzR3JcqXvAgtnVIXz9QBLAWjecGOIigrB7Yt4oW4=.4fd17386-6312-459a-bdfb-7f5d6a0b8e1f@github.com>

On Mon, 29 Aug 2022 15:32:17 GMT, Virag Purnam <duke at openjdk.org> wrote:

>> In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics". 
>> 
>> - Avg Live Count
>> - Avg Live Size
>> - Live Instances Increase
>> - Percentage of Heap
>> 
>> ![ObjectStatistics](https://user-images.githubusercontent.com/97600378/186091512-b434560a-96b1-4e62-80b8-029ae95169bf.jpg)
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7096: Bring back Object statistics table for heap.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/420