RFR: 7831: Add new view for hierarchical edge bundling [v14]
Marcus Hirt
hirt at openjdk.org
Fri Aug 5 20:13:15 UTC 2022
On Fri, 5 Aug 2022 19:04:34 GMT, Brice Dutheil <duke at openjdk.org> wrote:
>> Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC.
>>
>> 
>>
>> Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages.
>>
>>
>> Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>
> Add newlines to end of all files
The saturation / contrast in the icons could probably be a bit higher, but it looks great! Well done!
application/org.openjdk.jmc.flightrecorder.dependencyview/src/main/java/org/openjdk/jmc/flightrecorder/dependencyview/DependencyView.java line 197:
> 195: private volatile ModelState modelState = ModelState.NONE;
> 196: private ModelRebuildRunnable modelRebuildRunnable;
> 197: private int packageDepth = 3;
Would it perhaps be better to start with 2 here? The hierarchical edge bundling gets pretty busy with 3.
-------------
Marked as reviewed by hirt (Lead).
PR: https://git.openjdk.org/jmc/pull/405
More information about the jmc-dev
mailing list