From duke at openjdk.org Mon Dec 5 16:44:40 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Mon, 5 Dec 2022 16:44:40 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v28] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-7455: Handle unlocking of credentials if set ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/4ed92653..0028a086 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=27 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=26-27 Stats: 48 lines in 2 files changed: 35 ins; 4 del; 9 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Tue Dec 6 20:52:20 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Tue, 6 Dec 2022 20:52:20 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v28] In-Reply-To: References: Message-ID: On Mon, 5 Dec 2022 16:44:40 GMT, Martin Skarsaune wrote: >> Setting back for review. The azure problem requires a fix in Jolokia. >> >> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-7455: Handle unlocking of credentials if set Manual tests look good. Solved a problem with stored credentials. Have requested merges and a release on the jolokia side. Still problems running the test though. Would it be possible to request a CI run on this PR? ------------- PR: https://git.openjdk.org/jmc/pull/332 From erik.gahlin at oracle.com Thu Dec 8 07:00:38 2022 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 8 Dec 2022 07:00:38 +0000 Subject: Minor change in JFR file format Message-ID: Hello, Sometimes the size of a check point event can be larger than what can fit in an integer (32-bits). Both the JDK and JMC parser read the size field as a compressed long, but casts it to an int. In JMC, see SeekableInputStream: int CompressedIntsDataInput::readInt() throws IOException { return (int) readCompressedLong(); } ChunkLoaderV1::readConstantPoolEvent(...) Today: input.readInt(); // size Should be changed to: input.readLong(); // size We are considering bumping the minor version (a non-breaking change) of the file format, but we are not sure if it is necessary as it was already treated as a long value by the JMC parser? It's more of a problem for the JDK parser, it checks that the number of bytes read matches that of the event size, but since it is already broken for large check point events, a change will not make it more broken. See this JDK bug for details: https://bugs.openjdk.org/browse/JDK-8298129 This change will not impact the size of ordinary events. Erik [https://opengraph.githubassets.com/5bce3a4387800bd74848b1e763ac6ab97f987eba35c7583bb37c8a666782fe3c/openjdk/jmc] jmc/ChunkLoaderV1.java at 68387c5bd454fcf4bdda07d0cbe8d6eb59e2a840 ? openjdk/jmc Repository for OpenJDK Mission Control, a production time profiling and diagnostics tools suite. https://openjdk.org/projects/jmc - jmc/ChunkLoaderV1.java at 68387c5bd454fcf4bdda07d0cbe8d6eb59e2a84... github.com ? ? ? -------------- next part -------------- An HTML attachment was scrubbed... URL: From jclf at azul.com Mon Dec 12 20:03:26 2022 From: jclf at azul.com (Jason Fordham) Date: Mon, 12 Dec 2022 15:03:26 -0500 Subject: Minor change in JFR file format In-Reply-To: References: Message-ID: <30588c22-0327-1b90-d3f9-cc5b0441bb69@azul.com> Hi Erik, > Sometimes the size of a check point event can be larger than what can > fit in an integer (32-bits). Both the JDK and JMC parser read the size > field as a compressed long, but casts it to an int. In JMC, see > SeekableInputStream: > > int CompressedIntsDataInput::readInt() throws IOException { > return (int) readCompressedLong(); > } > > ChunkLoaderV1::readConstantPoolEvent(...) > > Today: > input.readInt(); // size > > Should be changed to: > input.readLong(); // size > > We are considering bumping the minor version (a non-breaking change) of > the file format, but we are not sure if it is necessary as it was already > treated as a long value by the JMC parser? > > It's more of a problem for the JDK parser, it checks that the number of > bytes read matches that of the event size, but since it is already broken > for large check point events, a change will not make it more broken. See > this JDK bug for details: > https://bugs.openjdk.org/browse/JDK-8298129 > > This change will not impact the size of ordinary events. I thought you should know that this issue is not purely theoretical: it actually came up at a customer site, and they reported that InvalidJfrFileException occurred for "multiple hosts on production instances". This led to us providing them with a short-term fix, and opening JDK-8297402. They're using their own jfr reader, and using the JMC parser classes. It's possible that the customer would like to be able to read their historical collection of JFRs using a single tool, and I believe the new parser code for command line jfr and the JMC GUI will still fail for any existing recordings that need more than 28 bits to encode an integer value. If this doesn't make up your mind to bump the minor version number, would you mind waiting to make a decision on this until I've heard back from the customer to see if they need to continue to read existing JFRs? Kind regards, Jason -------------- next part -------------- An HTML attachment was scrubbed... URL: From jclf at azul.com Thu Dec 15 01:52:34 2022 From: jclf at azul.com (Jason Fordham) Date: Wed, 14 Dec 2022 20:52:34 -0500 Subject: Minor change in JFR file format In-Reply-To: <30588c22-0327-1b90-d3f9-cc5b0441bb69@azul.com> References: <30588c22-0327-1b90-d3f9-cc5b0441bb69@azul.com> Message-ID: <600dc728-5f3a-c7c9-8eba-2bcea6baf0c3@azul.com> Hi Erik, On 12/12/22 3:03 PM, Jason Fordham wrote: > On 12/08/22, Erik Gahlin wrote: > >> We are considering bumping the minor version (a non-breaking change) of >> the file format, but we are not sure if it is necessary as it was already >> treated as a long value by the JMC parser? >> >> It's more of a problem for the JDK parser, it checks that the number of >> bytes read matches that of the event size, but since it is already broken >> for large check point events, a change will not make it more broken. See >> this JDK bug for details: >> https://bugs.openjdk.org/browse/JDK-8298129 >> >> This change will not impact the size of ordinary events. The customer involved has confirmed that they would like to be able to read their historical collection of JFRs using a single tool, and so a bump in the minor version number would make maintaining their automated tools easier going forward. I hope this information doesn't come too late. Kind regards, Jason -------------- next part -------------- An HTML attachment was scrubbed... URL: From schaturvedi at openjdk.org Fri Dec 16 07:06:14 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 16 Dec 2022 07:06:14 GMT Subject: RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v5] In-Reply-To: References: <0mioSkY_ti5RLq-M3K5DGfXwv4WbQKjpsiNmxei5spo=.35ddaaf5-1bce-4ea0-b4ec-01a8c4027264@github.com> Message-ID: On Fri, 7 Oct 2022 07:28:55 GMT, Brice Dutheil wrote: >>> > @bric3 We need to show the names of top 5 classes which were loaded maximum times without being unloaded. So the ordering matters here. That's why I have skipped that comment. >>> >>> I'm a bit confused, as in `DefaultIItemResultSet` the _insertion_ in `data` order is dependent on the iteration order of the aggregate collection, since it's a set, there's no ordering guarantees. Although I lack knowledge of the actual type and the implementation is a `TreeSet` or something alike. >>> >>> https://github.com/openjdk/jmc/blob/1696e03a1fddb9cc68d32bf21a281ef24366e552/core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java#L95-L99 >>> >>> Moreover the usage of the thread pool here will not guarantee the `add` operation will happen in the same order as the tasks have been submitted. Which leads me to think that the code should be reworked here to ensure that the results will be inserted in order. >> >> I have used a synchronized block for data. After that I am getting consistent results. Without that I was getting different results every time. I mean when I was working for test JFR wldf.jfr without synchronized block on data, the top 5 results varied every time. > >> I have used a synchronized block for data. After that I am getting consistent results. Without that I was getting different results every time. I mean when I was working for test JFR wldf.jfr without synchronized block on data, the top 5 results varied every time. > > Have you tried with an intermediate `ConcurrentLinkedQueue`, then copy the results in the data array list ? Hi @bric3 @Gunde @aptmac , Did you get a chance to check the latest patch? Please let me know what else is required, so that we can close this PR. ------------- PR: https://git.openjdk.org/jmc/pull/419 From hirt at openjdk.org Mon Dec 19 22:51:56 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 19 Dec 2022 22:51:56 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v28] In-Reply-To: References: Message-ID: On Tue, 6 Dec 2022 20:48:30 GMT, Martin Skarsaune wrote: >> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: >> >> JMC-7455: Handle unlocking of credentials if set > > Manual tests look good. Solved a problem with stored credentials. Have requested merges and a release on the jolokia side. > Still problems running the test though. Would it be possible to request a CI run on this PR? Hi @skarsaune! Are you ready to make this PR ready for review? Regarding the tests, typically the tests would be run in your fork, on commits to your branch. I can try running them on a few OSes locally here though. ------------- PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Tue Dec 20 11:10:41 2022 From: duke at openjdk.org (Virag Purnam) Date: Tue, 20 Dec 2022 11:10:41 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 Message-ID: Upgrade to Eclipse 2022-12 ------------- Commit messages: - 7997: Upgrade to Eclipse 2022-12 Changes: https://git.openjdk.org/jmc/pull/459/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=459&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7997 Stats: 36 lines in 5 files changed: 22 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jmc/pull/459.diff Fetch: git fetch https://git.openjdk.org/jmc pull/459/head:pull/459 PR: https://git.openjdk.org/jmc/pull/459 From bdutheil at openjdk.org Tue Dec 20 11:42:02 2022 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 20 Dec 2022 11:42:02 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 releng/platform-definitions/platform-definition-2022-12/platform-definition-2022-12.target line 63: > 61: > 62: > 63: Is there a 4.26 version ? ------------- PR: https://git.openjdk.org/jmc/pull/459 From hirt at openjdk.org Tue Dec 20 12:14:57 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 20 Dec 2022 12:14:57 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: <0aJ-KONE5GBUCWOsa_ISeDoOiwLtUUPBuM-GmZsWLKo=.f9527079-f6c7-4e9d-86a8-87ee4c3feb75@github.com> On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 Haha. I did 7996 at the same time. :) ------------- PR: https://git.openjdk.org/jmc/pull/459 From hirt at openjdk.org Tue Dec 20 12:14:58 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 20 Dec 2022 12:14:58 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 11:38:53 GMT, Brice Dutheil wrote: >> Upgrade to Eclipse 2022-12 > > releng/platform-definitions/platform-definition-2022-12/platform-definition-2022-12.target line 63: > >> 61: >> 62: >> 63: > > Is there a 4.26 version ? Nope, there isn't. ------------- PR: https://git.openjdk.org/jmc/pull/459 From hirt at openjdk.org Tue Dec 20 12:18:37 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 20 Dec 2022 12:18:37 GMT Subject: RFR: 7996: Upgrade to 2022-12 Message-ID: Also adding missing project file for 2022-09. ------------- Commit messages: - 7996: Upgrade to 2022-12 Changes: https://git.openjdk.org/jmc/pull/460/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=460&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7996 Stats: 295 lines in 11 files changed: 36 ins; 241 del; 18 mod Patch: https://git.openjdk.org/jmc/pull/460.diff Fetch: git fetch https://git.openjdk.org/jmc pull/460/head:pull/460 PR: https://git.openjdk.org/jmc/pull/460 From hirt at openjdk.org Tue Dec 20 12:18:58 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 20 Dec 2022 12:18:58 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 Wanna take mine or yours @viragpurnam? I also deleted a few old (more than a year old) platforms, and fixed the project files in #460. ------------- PR: https://git.openjdk.org/jmc/pull/459 From duke at openjdk.org Tue Dec 20 12:23:58 2022 From: duke at openjdk.org (Virag Purnam) Date: Tue, 20 Dec 2022 12:23:58 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: <0aJ-KONE5GBUCWOsa_ISeDoOiwLtUUPBuM-GmZsWLKo=.f9527079-f6c7-4e9d-86a8-87ee4c3feb75@github.com> References: <0aJ-KONE5GBUCWOsa_ISeDoOiwLtUUPBuM-GmZsWLKo=.f9527079-f6c7-4e9d-86a8-87ee4c3feb75@github.com> Message-ID: On Tue, 20 Dec 2022 12:11:33 GMT, Marcus Hirt wrote: > Haha. I did 7996 at the same time. :) :) Will take Yours 7996. I will close my PR. ------------- PR: https://git.openjdk.org/jmc/pull/459 From duke at openjdk.org Tue Dec 20 12:26:53 2022 From: duke at openjdk.org (Virag Purnam) Date: Tue, 20 Dec 2022 12:26:53 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: <0aJ-KONE5GBUCWOsa_ISeDoOiwLtUUPBuM-GmZsWLKo=.f9527079-f6c7-4e9d-86a8-87ee4c3feb75@github.com> Message-ID: On Tue, 20 Dec 2022 12:20:57 GMT, Virag Purnam wrote: >> Haha. I did 7996 at the same time. :) > >> Haha. I did 7996 at the same time. :) > > :) Will take Yours 7996. I will close my PR. > Wanna take mine or yours @viragpurnam? I also deleted a few old (more than a year old) platforms, and fixed the project files in #460. Will take yours.. :) Later I will upgrade spifly version to 1.3.6 ------------- PR: https://git.openjdk.org/jmc/pull/459 From hirt at openjdk.org Tue Dec 20 12:33:53 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 20 Dec 2022 12:33:53 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 Ok. Sounds good! ------------- PR: https://git.openjdk.org/jmc/pull/459 From bdutheil at openjdk.org Tue Dec 20 12:33:55 2022 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 20 Dec 2022 12:33:55 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 12:12:30 GMT, Marcus Hirt wrote: >> releng/platform-definitions/platform-definition-2022-12/platform-definition-2022-12.target line 63: >> >>> 61: >>> 62: >>> 63: >> >> Is there a 4.26 version ? > > Nope, there isn't. oh ok ------------- PR: https://git.openjdk.org/jmc/pull/459 From bdutheil at openjdk.org Tue Dec 20 12:35:54 2022 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 20 Dec 2022 12:35:54 GMT Subject: RFR: 7996: Upgrade to 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 12:10:37 GMT, Marcus Hirt wrote: > Also adding missing project file for 2022-09. Marked as reviewed by bdutheil (Author). ------------- PR: https://git.openjdk.org/jmc/pull/460 From duke at openjdk.org Tue Dec 20 12:47:59 2022 From: duke at openjdk.org (Virag Purnam) Date: Tue, 20 Dec 2022 12:47:59 GMT Subject: RFR: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 Duplicate of https://github.com/openjdk/jmc/pull/460 ------------- PR: https://git.openjdk.org/jmc/pull/459 From duke at openjdk.org Tue Dec 20 12:48:00 2022 From: duke at openjdk.org (Virag Purnam) Date: Tue, 20 Dec 2022 12:48:00 GMT Subject: Withdrawn: 7997: Upgrade to Eclipse 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 10:59:59 GMT, Virag Purnam wrote: > Upgrade to Eclipse 2022-12 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/459 From marcus.hirt at datadoghq.com Tue Dec 20 15:34:50 2022 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 20 Dec 2022 16:34:50 +0100 Subject: New jmc Committer: Virag Purnam Message-ID: Hi all, I hereby nominate Virag Purnam to jmc Committer. Virag has contributed to JMC since joining Oracle, not only helping out with commits in the project, but also with related work internally at Oracle, such as getting third-party approvals etc. Here is a list of some of Virag's direct contributions: https://github.com/openjdk/jmc/pulls?q=viragpurnam Votes are due by the 29th of December 2022, 17:00 CET. Only current jmc Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.java.net/census [2] https://openjdk.java.net/projects/#committer-vote From suchita.chaturvedi at oracle.com Tue Dec 20 15:39:54 2022 From: suchita.chaturvedi at oracle.com (Suchita Chaturvedi) Date: Tue, 20 Dec 2022 15:39:54 +0000 Subject: New jmc Committer: Virag Purnam In-Reply-To: References: Message-ID: Yes. Sent from Outlook for Android ________________________________ From: jmc-dev on behalf of Marcus Hirt Sent: Tuesday, December 20, 2022 9:04:50 PM To: jmc-dev at openjdk.java.net Subject: New jmc Committer: Virag Purnam Hi all, I hereby nominate Virag Purnam to jmc Committer. Virag has contributed to JMC since joining Oracle, not only helping out with commits in the project, but also with related work internally at Oracle, such as getting third-party approvals etc. Here is a list of some of Virag's direct contributions: https://github.com/openjdk/jmc/pulls?q=viragpurnam Votes are due by the 29th of December 2022, 17:00 CET. Only current jmc Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.java.net/census [2] https://openjdk.java.net/projects/#committer-vote -------------- next part -------------- An HTML attachment was scrubbed... URL: From aptmac at openjdk.org Tue Dec 20 20:58:55 2022 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 20 Dec 2022 20:58:55 GMT Subject: RFR: 7996: Upgrade to 2022-12 In-Reply-To: References: Message-ID: On Tue, 20 Dec 2022 12:10:37 GMT, Marcus Hirt wrote: > Also adding missing project file for 2022-09. releng/platform-definitions/pom.xml line 3: > 1: > 2: