RFR: 7467: Only use one version of d3 [v2]

Marcus Hirt hirt at openjdk.java.net
Thu Feb 3 11:58:11 UTC 2022


On Thu, 3 Feb 2022 09:30:43 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Better execution ids
>
> application/org.openjdk.jmc.flightrecorder.graphview/pom.xml line 68:
> 
>> 66: 						</goals>
>> 67: 						<configuration>
>> 68: 							<url>https://d3js.org/d3.v6.min.js</url>
> 
> Maybe put this in a property

Smallest possible changes this close to release.

> application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java line 89:
> 
>> 87: 	private static final String HTML_PAGE;
>> 88: 	static {
>> 89: 		String jsD3 = "jslibs/d3.v6.min.js";
> 
> I wonder if we can rename the js lib to avoid code modification. And only update the pom when changing version.

That's a good idea! Feel free to open a separate PR for this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/372


More information about the jmc-dev mailing list