RFR: 7532: Delay in realtime rendering of graphs in JMX Console [v2]

Marcus Hirt hirt at openjdk.java.net
Wed Feb 9 14:52:15 UTC 2022


On Wed, 9 Feb 2022 11:38:45 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

>> Issue: Dials and Charts in JMX Console was not rendering with the change. 
>> 
>> <img width="1302" alt="image-2022-01-18-21-36-49-712" src="https://user-images.githubusercontent.com/97600378/152590022-262d4ce1-fe1a-4b52-bb43-d1b61b96d4d0.png">
>>  
>> Root cause: Control redraw() method was conditionally called. This method was called for windows and Linux OS. For mac OS, this redraw() method was not called to solve "console dials causing high CPU load on Mac". But because of this rendering was not happening for dials and charts. 
>> I do not see any high CPU load (May be issue with older versions of OS). Could you please review the changes and let me know if you see any performance issue with this fix (mainly on macOS) ? 
>> 
>> Fix: Control redraw() method has been called for macOS as well.
>> 
>> <img width="928" alt="Fix_7532" src="https://user-images.githubusercontent.com/97600378/152590703-0c385f22-be14-4ad6-b592-927c37fa2385.png">
>
> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7532: Delay in realtime rendering of graphs in JMX Console

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/375


More information about the jmc-dev mailing list