From duke at openjdk.java.net  Sat Jan  1 00:33:47 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Sat, 1 Jan 2022 00:33:47 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v7]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <tZrMiDJSqJulx-aWvWqE6-K8O3C4wUkzut3VePzpGoE=.d43c1c33-b3d4-438b-8514-bf9e38a96008@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  Review corrections: Javadoc and refactoring attempt to use local operation info

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/955e3f8a..800a31d5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=05-06

  Stats: 77 lines in 7 files changed: 38 ins; 17 del; 22 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Sat Jan  1 11:26:19 2022
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Sat, 1 Jan 2022 11:26:19 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <sd2T8w8yxy7TlvtA9kPvceJQjxVsyeBIleNH5bD5TDU=.cf4f7bb9-cb1a-4a13-85fe-012b0d07691e@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
 <sd2T8w8yxy7TlvtA9kPvceJQjxVsyeBIleNH5bD5TDU=.cf4f7bb9-cb1a-4a13-85fe-012b0d07691e@github.com>
Message-ID: <bLWyogL5VMaMJxDBiGRLQmbwMfig80Fcobg2heAR6oo=.018c7b12-5618-448b-80d4-d5750fabf938@github.com>

On Wed, 29 Dec 2021 21:23:43 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove unused import
>
> is your stacktrace for the error similar to:
> 
> java.lang.StringIndexOutOfBoundsException: String index out of range: -11
>         at java.base/java.lang.String.substring(String.java:1841)
>         at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.convertNames(StructTypes.java:331)
>         at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.getFullName(StructTypes.java:315)
>         at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrJavaClass.hashCode(StructTypes.java:341)
>         at java.base/java.util.Objects.hashCode(Objects.java:116)
>         at org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrMethod.hashCode(StructTypes.java:625)
>         at org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.hashCode(AggregatableFrame.java:90)
>         at java.base/java.util.HashMap.hash(HashMap.java:339)
>         at java.base/java.util.HashMap.get(HashMap.java:552)
> 
> ?
> in that case it's because you have changed the class name but not the package name associated. 
> Then when referencing a class or a method, package name & class name are not the same, which is not expected.
> 
> in your example to fix the issue:
> 
> 
>     private static Deobfuscator createFooDeobfuscator() {
>     	Map<String, String> obfuscatorClassMap = new HashMap<String, String>();  // obfuscated class -> class
>     	obfuscatorClassMap.put("se/hirt/jmc/tutorial/hotmethods/HotMethods", "de/docware/ms/foo/Foo");
> 		Map<String, String> obfuscatorPackageMap = new HashMap<String, String>();  // obfuscated package -> package
> +++             obfuscatorPackageMap.put("se/hirt/jmc/tutorial/hotmethods", "de/docware/ms/foo");
> 		Map<String, Map<String, String>> obfuscatorClassMethodsMap = new HashMap<String, Map<String, String>>();  // (class, obfuscated method) -> method
>     	return new Deobfuscator(obfuscatorClassMap, obfuscatorPackageMap, obfuscatorClassMethodsMap);
>     }

@jpbempel A happy new to year to you and everyone of the JMC team :-)

Yes, that's very obvious, once I replaced the package too, the error was gone and I could see the replacement effect inside JMC.
I should now be able to complete my code. I will provide a new PR for review in a while.

Thanks a lot!

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Sun Jan  2 17:57:12 2022
From: duke at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=)
Date: Sun, 2 Jan 2022 17:57:12 GMT
Subject: RFR: 7439: Introduced IConstantPoolExtension for Constant Pools
 [v6]
In-Reply-To: <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
References: <yr6Hwt8RLp5vDKKxZNrB55aBiyZaP00et_A_BsBw6Dc=.32b3e0bd-ffdb-4a43-8020-c0305d586a52@github.com>
 <IFFEOXHsROnNc9MbR_ULppUzr0GnRQE69UP2ZA-TghE=.7849d5da-2a7d-4d08-9f63-e104ddc9d0ad@github.com>
Message-ID: <qn6o6iidb50F4QDlOUo-Ewy5iJcC0LBHea1aQyMK0CI=.a611154f-c4d6-4018-a026-211f9f311408@github.com>

On Fri, 26 Nov 2021 20:46:41 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Add extension methods when constants are read, referenced, resolved, constant pools fully resolved and parsing finished to be able for example:
>> 
>>  * track constant pool usage inside events
>>  * replace or translate symbols, method names, etc... like
>> de-obfuscations of stack traces
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unused import

Back to my real deobfuscation mapping, I found that of course I DID handle the package remapping there, but using real Proguard obfuscation mapping the situation is more complex (or real) than the demo I provided. 

When I debugged one of these StringIndexOutOfBoundsExceptions, I have this situation  in StructTypes.convertNames()

**name**=de.docware.apps.etk.base.db.cache.EtkDbsCacheElems, **getPackageName()**=de.docware.apps.etk.base.db.AbstractRevisionChangeSet

And these are the relevant entries from the Proguard mapping file.

de.docware.apps.etk.base.db.cache.EtkDbsCacheElems -> de.docware.apps.etk.base.d.a.e:
de.docware.apps.etk.base.db.AbstractRevisionChangeSet -> de.docware.apps.etk.base.d.a:

What I do obviously (or maybe naively) when I find a hit for ""de.docware.apps.etk.base.d.a.e", I assume "de.docware.apps.etk.base.d.a" to be the package name. But as you can see Proguard uses this String for another class mapping.
I can only guess but I think this can only work because Proguard obfuscates on byte code level. 

I haven't observed this problem with my existing deobfuscation solution on formatting level. Probably I was just interested in class and methods, and packages had no importance so far - that's why it worked there.

When I return to work I will discuss this with a smart colleague, but maybe we are stuck here.

-------------

PR: https://git.openjdk.java.net/jmc/pull/333

From duke at openjdk.java.net  Sun Jan  2 21:00:19 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Sun, 2 Jan 2022 21:00:19 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v7]
In-Reply-To: <u0KyxsHA1r-YLdWX-NYqkrjAsY0Zt9OJ3-gZ6Ex-p7o=.8b90f189-854b-4489-8568-b3467d622a40@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <u0KyxsHA1r-YLdWX-NYqkrjAsY0Zt9OJ3-gZ6Ex-p7o=.8b90f189-854b-4489-8568-b3467d622a40@github.com>
Message-ID: <SV8picNl8xHHYSR45q3dCQ7I_l6OfhDfnizbCcXesLU=.8f024512-44d6-4118-b8ec-b7815cc4d483@github.com>

On Thu, 11 Nov 2021 09:11:21 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review corrections: Javadoc and refactoring attempt to use local operation info
>
> application/org.openjdk.jmc.jolokia/pom.xml line 64:
> 
>> 62: 			</plugin>
>> 63: 			<plugin>
>> 64: 				<groupId>org.apache.maven.plugins</groupId>
> 
> Sooo .... I am not sure about the preferred way to pull in external dependencies. I can add that both jolokia libraries come as shaded jars with some OSGi packaging, but I do not know enough about that to say whether that would be a workable or better solution. These are quite new components, so we can probably modify the OSGI packaging in Jolokia going forwards if needed. 
> POM: https://github.com/rhuss/jolokia/blob/556b58e63a125fb79d516d7f7833e22270f591b0/client/jmx-adapter/pom.xml#L129
> Artifact: https://repo1.maven.org/maven2/org/jolokia/jolokia-jmx-adapter/1.7.0/jolokia-jmx-adapter-1.7.0-standalone.jar

I'm working in a separate branch to expose the dependencies via releng/thirdparty, but have not been able to make it work yet.

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From schaturvedi at openjdk.java.net  Wed Jan  5 19:21:38 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 5 Jan 2022 19:21:38 GMT
Subject: RFR: 7493: Update versions and copyright on Update site pages
Message-ID: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>

This PR updates the copyright year and Eclipse pre-requisite version.

-------------

Commit messages:
 - 7493: Update versions and copyright on Update site pages
 - 7493: Update versions and copyright on Update site pages

Changes: https://git.openjdk.java.net/jmc/pull/346/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=346&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7493
  Stats: 9 lines in 4 files changed: 1 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/346.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/346/head:pull/346

PR: https://git.openjdk.java.net/jmc/pull/346

From hirt at openjdk.java.net  Wed Jan  5 21:54:21 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 5 Jan 2022 21:54:21 GMT
Subject: RFR: 7493: Update versions and copyright on Update site pages
In-Reply-To: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
References: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
Message-ID: <Mr8IsWtGGeiNMj0BXTBQxrIrlsyp-HEvHCLD9HlLaUk=.3a9a86a7-c631-4e2e-b0ab-937263096b9d@github.com>

On Wed, 5 Jan 2022 19:15:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR updates the copyright year and Eclipse pre-requisite version.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/346

From schaturvedi at openjdk.java.net  Wed Jan  5 22:44:56 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 5 Jan 2022 22:44:56 GMT
Subject: git: openjdk/jmc: 7493: Update versions and copyright on Update site
 pages
Message-ID: <70d87b4e-5a85-403b-99e0-c43e70e7fc83@openjdk.org>

Changeset: f077a406
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
Date:      2022-01-05 22:44:29 +0000
URL:       https://git.openjdk.java.net/jmc/commit/f077a406946ccab1ca1f3a09e36ace76cda3243c

7493: Update versions and copyright on Update site pages

Reviewed-by: hirt

! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html
! application/org.openjdk.jmc.updatesite.ide/src/main/resources/run-on-jdk-instructions/index.html
! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html
! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html


From duke at openjdk.java.net  Sun Jan  9 15:08:45 2022
From: duke at openjdk.java.net (Alex Ciminian)
Date: Sun, 9 Jan 2022 15:08:45 GMT
Subject: RFR: 7494: Unable to view JMC Help Contents
Message-ID: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>

This PR fixes a problem that makes all JMC help pages fail. 

We use the eclipse help plugin, it plugin starts a web server which renders the XML content in the docs plugin via JSP. When the user clicks help in the JMC UI they are sent to the browser, which tries to render one of these JSP pages. 

In #306 we introduced new dependencies on multiple Jetty packages so we can run a websocket server inside JMC. After these changes we notice that the help pages fail to render with the following error:


javax.servlet.ServletException: non-HTTP request or response
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:578)
	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:308)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:508)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)


This is the code that throws the exception:


    @Override
    public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
        HttpServletRequest request;
        HttpServletResponse response;

        if (!(req instanceof HttpServletRequest && res instanceof HttpServletResponse)) {
            throw new ServletException("non-HTTP request or response");
        }

        request = (HttpServletRequest) req;
        response = (HttpServletResponse) res;

        service(request, response);
    }


The help plugin has Jetty as a transitive dependency so it's likely this error is caused by the new `servlet-api` dependency that we've introduced. Using the debugger, we can set a breakpoint before the exception is thrown and we can inspect `req` and `res` to see why the `instanceof` check fails. The result of this is very strange:

<img width="443" alt="Screenshot 2022-01-08 at 18 05 43" src="https://user-images.githubusercontent.com/348973/148687951-006c9a92-f6d2-4039-b38d-137a74fb2af0.png">

I don't understand why this fails here, since we can see with reflection that `req` implements the expected `javax.servlet.http.HttpServletRequest` interface. It's likely this is because we have two `servlet-api` bundles loaded, `org.eclipse.jetty.servlet-api` (explicit dependency of `flightrecorder.ui`) and `jakarta.servlet-api` (transitive dependency of the help plugin). 

I also don't understand if it's possible that `instanceof` fails because it tries to compare `javax.servlet.http.HttpServletRequest` loaded from the different bundles, given that the package and interface names are identical.

Regardless of the root cause, removing the explicit dependency on `org.eclipse.jetty.servlet-api` from the target platform and depending on `jakarta.servlet-api` in the `flightrecorder.ui` manifest fixes the issue. Now help pages load successfully and the websocket server works as before.

-------------

Commit messages:
 - Remove dependency on jetty.servlet-api, use jakarta instead

Changes: https://git.openjdk.java.net/jmc/pull/347/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=347&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7494
  Stats: 6 lines in 6 files changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/347.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/347/head:pull/347

PR: https://git.openjdk.java.net/jmc/pull/347

From hirt at openjdk.java.net  Sun Jan  9 17:53:30 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 9 Jan 2022 17:53:30 GMT
Subject: RFR: 7494: Unable to view JMC Help Contents
In-Reply-To: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
References: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
Message-ID: <PBmTYDC6gBTDpuOLeluzNbMjvmzn8xUGCMAg_OxAYlM=.649c0f03-1cb9-4dd6-9e7f-50ec42188924@github.com>

On Sun, 9 Jan 2022 15:04:38 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR fixes a problem that makes all JMC help pages fail. 
> 
> We use the eclipse help plugin, it plugin starts a web server which renders the XML content in the docs plugin via JSP. When the user clicks help in the JMC UI they are sent to the browser, which tries to render one of these JSP pages. 
> 
> In #306 we introduced new dependencies on multiple Jetty packages so we can run a websocket server inside JMC. After these changes we notice that the help pages fail to render with the following error:
> 
> 
> javax.servlet.ServletException: non-HTTP request or response
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:578)
> 	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:308)
> 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
> 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:508)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
> 
> 
> This is the code that throws the exception:
> 
> 
>     @Override
>     public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
>         HttpServletRequest request;
>         HttpServletResponse response;
> 
>         if (!(req instanceof HttpServletRequest && res instanceof HttpServletResponse)) {
>             throw new ServletException("non-HTTP request or response");
>         }
> 
>         request = (HttpServletRequest) req;
>         response = (HttpServletResponse) res;
> 
>         service(request, response);
>     }
> 
> 
> The help plugin has Jetty as a transitive dependency so it's likely this error is caused by the new `servlet-api` dependency that we've introduced. Using the debugger, we can set a breakpoint before the exception is thrown and we can inspect `req` and `res` to see why the `instanceof` check fails. The result of this is very strange:
> 
> <img width="443" alt="Screenshot 2022-01-08 at 18 05 43" src="https://user-images.githubusercontent.com/348973/148687951-006c9a92-f6d2-4039-b38d-137a74fb2af0.png">
> 
> I don't understand why this fails here, since we can see with reflection that `req` implements the expected `javax.servlet.http.HttpServletRequest` interface. It's likely this is because we have two `servlet-api` bundles loaded, `org.eclipse.jetty.servlet-api` (explicit dependency of `flightrecorder.ui`) and `jakarta.servlet-api` (transitive dependency of the help plugin). 
> 
> I also don't understand if it's possible that `instanceof` fails because it tries to compare `javax.servlet.http.HttpServletRequest` loaded from the different bundles, given that the package and interface names are identical.
> 
> Regardless of the root cause, removing the explicit dependency on `org.eclipse.jetty.servlet-api` from the target platform and depending on `jakarta.servlet-api` in the `flightrecorder.ui` manifest fixes the issue. Now help pages load successfully and the websocket server works as before.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/347

From duke at openjdk.java.net  Sun Jan  9 21:48:01 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Sun, 9 Jan 2022 21:48:01 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v8]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <oYKsSi9oLdRbIk7BJBK7XF931fcuCoWMJ0X_De9JkqI=.c8240ac0-38f6-43d7-a6a1-e44ef70432ae@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:

 - Merge pull request #1 from skarsaune/jolokia-dependencies-via-thirdparty
   
   JMC-7455: Use third party to pull inn Jolokia modules
 - JMC-7455: Use third party to pull inn Jolokia modules

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/800a31d5..d64cb38a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=06-07

  Stats: 91 lines in 10 files changed: 30 ins; 57 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Mon Jan 10 11:01:32 2022
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 10 Jan 2022 11:01:32 GMT
Subject: RFR: 7494: Unable to view JMC Help Contents
In-Reply-To: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
References: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
Message-ID: <Tdk-ssiymXator9er691zbQKHf3HgTd5K-fgAQ_ro2Y=.25b96a66-d9a3-4ef6-9326-d8e291a21bb1@github.com>

On Sun, 9 Jan 2022 15:04:38 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR fixes a problem that makes all JMC help pages fail. 
> 
> We use the eclipse help plugin, it plugin starts a web server which renders the XML content in the docs plugin via JSP. When the user clicks help in the JMC UI they are sent to the browser, which tries to render one of these JSP pages. 
> 
> In #306 we introduced new dependencies on multiple Jetty packages so we can run a websocket server inside JMC. After these changes we notice that the help pages fail to render with the following error:
> 
> 
> javax.servlet.ServletException: non-HTTP request or response
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:578)
> 	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:308)
> 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
> 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:508)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
> 
> 
> This is the code that throws the exception:
> 
> 
>     @Override
>     public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
>         HttpServletRequest request;
>         HttpServletResponse response;
> 
>         if (!(req instanceof HttpServletRequest && res instanceof HttpServletResponse)) {
>             throw new ServletException("non-HTTP request or response");
>         }
> 
>         request = (HttpServletRequest) req;
>         response = (HttpServletResponse) res;
> 
>         service(request, response);
>     }
> 
> 
> The help plugin has Jetty as a transitive dependency so it's likely this error is caused by the new `servlet-api` dependency that we've introduced. Using the debugger, we can set a breakpoint before the exception is thrown and we can inspect `req` and `res` to see why the `instanceof` check fails. The result of this is very strange:
> 
> <img width="443" alt="Screenshot 2022-01-08 at 18 05 43" src="https://user-images.githubusercontent.com/348973/148687951-006c9a92-f6d2-4039-b38d-137a74fb2af0.png">
> 
> I don't understand why this fails here, since we can see with reflection that `req` implements the expected `javax.servlet.http.HttpServletRequest` interface. It's likely this is because we have two `servlet-api` bundles loaded, `org.eclipse.jetty.servlet-api` (explicit dependency of `flightrecorder.ui`) and `jakarta.servlet-api` (transitive dependency of the help plugin). 
> 
> I also don't understand if it's possible that `instanceof` fails because it tries to compare `javax.servlet.http.HttpServletRequest` loaded from the different bundles, given that the package and interface names are identical.
> 
> Regardless of the root cause, removing the explicit dependency on `org.eclipse.jetty.servlet-api` from the target platform and depending on `jakarta.servlet-api` in the `flightrecorder.ui` manifest fixes the issue. Now help pages load successfully and the websocket server works as before.

Since the ticket mentioned the help pages didn't work if we run JMC with JDK 17, I tried it out. I could reproduce it, here is the error:


org.apache.jasper.JasperException: PWC6033: Error in Javac compilation for JSP

PWC6197: An error occurred at line: 41 in the jsp file: /index.jsp
PWC6199: Generated servlet error:
System cannot be resolved


	at org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:129)
	at org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:299)
	at org.apache.jasper.compiler.Compiler.generateClass(Compiler.java:392)
	at org.apache.jasper.compiler.Compiler.compile(Compiler.java:453)
	at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:625)
	at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)


I didn't know how to open the jsp in eclipse so I couldn't play with it there, but looking [at the source](https://git.eclipse.org/c/platform/eclipse.platform.ua.git/tree/org.eclipse.help.webapp/index.jsp) it seems that because of the `System.getProperty` call the JSP fails to compile. Searching online for similar problems, I found [this issue](https://github.com/OpenLiberty/open-liberty/issues/18043) which suggests upgrading JDT (and specifically the eclipse compiler) might fix it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/347

From aptmac at openjdk.java.net  Mon Jan 10 15:37:32 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 10 Jan 2022 15:37:32 GMT
Subject: RFR: 7494: Unable to view JMC Help Contents
In-Reply-To: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
References: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
Message-ID: <pCppYpu0ZqI_18crma1Ui2x7duRpE1GkPXgzcByl5M4=.d8078629-3812-4958-9c7e-03c6a94c7f7f@github.com>

On Sun, 9 Jan 2022 15:04:38 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR fixes a problem that makes all JMC help pages fail. 
> 
> We use the eclipse help plugin, it plugin starts a web server which renders the XML content in the docs plugin via JSP. When the user clicks help in the JMC UI they are sent to the browser, which tries to render one of these JSP pages. 
> 
> In #306 we introduced new dependencies on multiple Jetty packages so we can run a websocket server inside JMC. After these changes we notice that the help pages fail to render with the following error:
> 
> 
> javax.servlet.ServletException: non-HTTP request or response
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:578)
> 	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:308)
> 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
> 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:508)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
> 
> 
> This is the code that throws the exception:
> 
> 
>     @Override
>     public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
>         HttpServletRequest request;
>         HttpServletResponse response;
> 
>         if (!(req instanceof HttpServletRequest && res instanceof HttpServletResponse)) {
>             throw new ServletException("non-HTTP request or response");
>         }
> 
>         request = (HttpServletRequest) req;
>         response = (HttpServletResponse) res;
> 
>         service(request, response);
>     }
> 
> 
> The help plugin has Jetty as a transitive dependency so it's likely this error is caused by the new `servlet-api` dependency that we've introduced. Using the debugger, we can set a breakpoint before the exception is thrown and we can inspect `req` and `res` to see why the `instanceof` check fails. The result of this is very strange:
> 
> <img width="443" alt="Screenshot 2022-01-08 at 18 05 43" src="https://user-images.githubusercontent.com/348973/148687951-006c9a92-f6d2-4039-b38d-137a74fb2af0.png">
> 
> I don't understand why this fails here, since we can see with reflection that `req` implements the expected `javax.servlet.http.HttpServletRequest` interface. It's likely this is because we have two `servlet-api` bundles loaded, `org.eclipse.jetty.servlet-api` (explicit dependency of `flightrecorder.ui`) and `jakarta.servlet-api` (transitive dependency of the help plugin). 
> 
> I also don't understand if it's possible that `instanceof` fails because it tries to compare `javax.servlet.http.HttpServletRequest` loaded from the different bundles, given that the package and interface names are identical.
> 
> Regardless of the root cause, removing the explicit dependency on `org.eclipse.jetty.servlet-api` from the target platform and depending on `jakarta.servlet-api` in the `flightrecorder.ui` manifest fixes the issue. Now help pages load successfully and the websocket server works as before.

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/347

From aptmac at openjdk.java.net  Mon Jan 10 15:42:34 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 10 Jan 2022 15:42:34 GMT
Subject: RFR: 7494: Unable to view JMC Help Contents
In-Reply-To: <Tdk-ssiymXator9er691zbQKHf3HgTd5K-fgAQ_ro2Y=.25b96a66-d9a3-4ef6-9326-d8e291a21bb1@github.com>
References: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
 <Tdk-ssiymXator9er691zbQKHf3HgTd5K-fgAQ_ro2Y=.25b96a66-d9a3-4ef6-9326-d8e291a21bb1@github.com>
Message-ID: <uQSS9lYutWtsQEJHSB0mJNZgfAKoqnVMyLUQFA78moI=.641310d5-edf0-43fa-86d7-6eb2378e7dee@github.com>

On Mon, 10 Jan 2022 10:57:37 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> I didn't know how to open the jsp in eclipse so I couldn't play with it there, but looking [at the source](https://git.eclipse.org/c/platform/eclipse.platform.ua.git/tree/org.eclipse.help.webapp/index.jsp) it seems that because of the `System.getProperty` call the JSP fails to compile. Searching online for similar problems, I found [this issue](https://github.com/OpenLiberty/open-liberty/issues/18043) which suggests upgrading JDT (and specifically the eclipse compiler) might fix it.

Guru had opened an Eclipse bug for JDT explaining our issue [[0]](https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937), there hasn't been a lot of comments on it recently though. Interesting that the update to JDT 3.26.0 fixed the issue for open-library, we're currently consuming 3.18 via 2021-06 [[1]](https://download.eclipse.org/releases/2021-06/202106161001/features/) (and it looks like even through to 2021-12 the same version will be used).  

[0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937
[1] https://download.eclipse.org/releases/2021-06/202106161001/features/

-------------

PR: https://git.openjdk.java.net/jmc/pull/347

From aptmac at openjdk.java.net  Mon Jan 10 16:03:54 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 10 Jan 2022 16:03:54 GMT
Subject: RFR: 7473: Unable to view constants in constant pool page.
Message-ID: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>

This PR addresses JMC-7473 [[0]](https://bugs.openjdk.java.net/browse/JMC-7473), in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame. 

Before:
![2022-01-10-105031_790x151_scrot](https://user-images.githubusercontent.com/10425301/148796099-b32c4802-7b12-4489-ab09-0aa65a73cea9.png)

After:
![2022-01-10-105044_668x458_scrot](https://user-images.githubusercontent.com/10425301/148796118-d066f332-d0a3-4982-9502-b26efd2ef01b.png)

-------------

Commit messages:
 - 7473: Unable to view constants in constant pool page

Changes: https://git.openjdk.java.net/jmc/pull/348/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=348&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7473
  Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/348.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/348/head:pull/348

PR: https://git.openjdk.java.net/jmc/pull/348

From aptmac at openjdk.java.net  Mon Jan 10 16:26:02 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 10 Jan 2022 16:26:02 GMT
Subject: RFR: 7473: Unable to view constants in constant pool page. [v2]
In-Reply-To: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
References: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
Message-ID: <A2kj754sd4KPees4qMIeWUXUy5tzAgEinFYx9C2JrwA=.f3e90638-52ec-4914-be5d-40cb17d463df@github.com>

> This PR addresses JMC-7473 [[0]](https://bugs.openjdk.java.net/browse/JMC-7473), in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame. 
> 
> Before:
> ![2022-01-10-105031_790x151_scrot](https://user-images.githubusercontent.com/10425301/148796099-b32c4802-7b12-4489-ab09-0aa65a73cea9.png)
> 
> After:
> ![2022-01-10-105044_668x458_scrot](https://user-images.githubusercontent.com/10425301/148796118-d066f332-d0a3-4982-9502-b26efd2ef01b.png)

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  spotless

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/348/files
  - new: https://git.openjdk.java.net/jmc/pull/348/files/80e49e19..b21b4f4c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=348&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=348&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/348.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/348/head:pull/348

PR: https://git.openjdk.java.net/jmc/pull/348

From aptmac at openjdk.java.net  Mon Jan 10 16:55:35 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 10 Jan 2022 16:55:35 GMT
Subject: RFR: 7482: Confusing display of stack traces when selecting event
 types with no events
In-Reply-To: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
References: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
Message-ID: <2al9RiLiuBTl0ZC8-_2mzhmQ2oVdyScRdXBF_yhj2mk=.f2f7c2ff-9d05-47a4-9cd1-e7299ad54858@github.com>

On Wed, 29 Dec 2021 16:48:22 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> ?th no events
> 
> In EventBrowser page, when there is no selection all events are
> considered but if there is a selection we filtered events based on
> this selection event if there is no events

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/344

From duke at openjdk.java.net  Mon Jan 10 17:30:33 2022
From: duke at openjdk.java.net (Alex Ciminian)
Date: Mon, 10 Jan 2022 17:30:33 GMT
Subject: Integrated: 7494: Unable to view JMC Help Contents
In-Reply-To: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
References: <qYYdJDnj4hY8icFobRBOPAdu3in-p0X4fyT2yNZuyhY=.0f95d03b-6d93-417a-9719-cbe237eac18a@github.com>
Message-ID: <TCNtS8a4paQaLd0S5SC4RmXXYnL4fvM-1n1nuX7Ssac=.ec5b6ef0-4c54-4dc7-a9dd-f01774bed493@github.com>

On Sun, 9 Jan 2022 15:04:38 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR fixes a problem that makes all JMC help pages fail. 
> 
> We use the eclipse help plugin, it plugin starts a web server which renders the XML content in the docs plugin via JSP. When the user clicks help in the JMC UI they are sent to the browser, which tries to render one of these JSP pages. 
> 
> In #306 we introduced new dependencies on multiple Jetty packages so we can run a websocket server inside JMC. After these changes we notice that the help pages fail to render with the following error:
> 
> 
> javax.servlet.ServletException: non-HTTP request or response
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:578)
> 	at org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManager.java:308)
> 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
> 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:508)
> 	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
> 
> 
> This is the code that throws the exception:
> 
> 
>     @Override
>     public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
>         HttpServletRequest request;
>         HttpServletResponse response;
> 
>         if (!(req instanceof HttpServletRequest && res instanceof HttpServletResponse)) {
>             throw new ServletException("non-HTTP request or response");
>         }
> 
>         request = (HttpServletRequest) req;
>         response = (HttpServletResponse) res;
> 
>         service(request, response);
>     }
> 
> 
> The help plugin has Jetty as a transitive dependency so it's likely this error is caused by the new `servlet-api` dependency that we've introduced. Using the debugger, we can set a breakpoint before the exception is thrown and we can inspect `req` and `res` to see why the `instanceof` check fails. The result of this is very strange:
> 
> <img width="443" alt="Screenshot 2022-01-08 at 18 05 43" src="https://user-images.githubusercontent.com/348973/148687951-006c9a92-f6d2-4039-b38d-137a74fb2af0.png">
> 
> I don't understand why this fails here, since we can see with reflection that `req` implements the expected `javax.servlet.http.HttpServletRequest` interface. It's likely this is because we have two `servlet-api` bundles loaded, `org.eclipse.jetty.servlet-api` (explicit dependency of `flightrecorder.ui`) and `jakarta.servlet-api` (transitive dependency of the help plugin). 
> 
> I also don't understand if it's possible that `instanceof` fails because it tries to compare `javax.servlet.http.HttpServletRequest` loaded from the different bundles, given that the package and interface names are identical.
> 
> Regardless of the root cause, removing the explicit dependency on `org.eclipse.jetty.servlet-api` from the target platform and depending on `jakarta.servlet-api` in the `flightrecorder.ui` manifest fixes the issue. Now help pages load successfully and the websocket server works as before.

This pull request has now been integrated.

Changeset: b65e3512
Author:    Alex Ciminian <alexandru.ciminian at datadoghq.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/b65e3512c86ed1f59e26c08fc817079532d10752
Stats:     6 lines in 6 files changed: 0 ins; 5 del; 1 mod

7494: Unable to view JMC Help Contents

Reviewed-by: hirt, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/347

From hirt at openjdk.java.net  Mon Jan 10 19:44:32 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 10 Jan 2022 19:44:32 GMT
Subject: RFR: 7482: Confusing display of stack traces when selecting event
 types with no events
In-Reply-To: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
References: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
Message-ID: <UHiLdcRgSLYb0eGf9MwK-CZOc3WD_i2BVUU_snANKOw=.c5789405-eee3-47f0-b97f-ce399bf7ddb0@github.com>

On Wed, 29 Dec 2021 16:48:22 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> ?th no events
> 
> In EventBrowser page, when there is no selection all events are
> considered but if there is a selection we filtered events based on
> this selection event if there is no events

@jpbempel - this is ready to integrate - @aptmac is a reviewer now. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/344

From jpbempel at openjdk.java.net  Mon Jan 10 21:45:33 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 10 Jan 2022 21:45:33 GMT
Subject: RFR: 7473: Unable to view constants in constant pool page. [v2]
In-Reply-To: <A2kj754sd4KPees4qMIeWUXUy5tzAgEinFYx9C2JrwA=.f3e90638-52ec-4914-be5d-40cb17d463df@github.com>
References: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
 <A2kj754sd4KPees4qMIeWUXUy5tzAgEinFYx9C2JrwA=.f3e90638-52ec-4914-be5d-40cb17d463df@github.com>
Message-ID: <BWu2pgVJxqlxg3ogwtbeDfw34RmqVDDbk0qCv3-I4Es=.e95f6b14-e11e-4797-b2db-1b6e7c2e7e48@github.com>

On Mon, 10 Jan 2022 16:26:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7473 [[0]](https://bugs.openjdk.java.net/browse/JMC-7473), in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame. 
>> 
>> Before:
>> ![2022-01-10-105031_790x151_scrot](https://user-images.githubusercontent.com/10425301/148796099-b32c4802-7b12-4489-ab09-0aa65a73cea9.png)
>> 
>> After:
>> ![2022-01-10-105044_668x458_scrot](https://user-images.githubusercontent.com/10425301/148796118-d066f332-d0a3-4982-9502-b26efd2ef01b.png)
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spotless

Marked as reviewed by jpbempel (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/348

From jpbempel at openjdk.java.net  Mon Jan 10 21:47:32 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 10 Jan 2022 21:47:32 GMT
Subject: Integrated: 7482: Confusing display of stack traces when selecting
 event types with no events
In-Reply-To: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
References: <g3okfxG-AECC_KiMiPJUK-86qDiL8W1g9fycunp9oXM=.63c9157c-5b73-4d09-a25d-617ed97a56a6@github.com>
Message-ID: <ZyOIZS8CYPstC4gnE2aX1lpAQ38oobSMxKUxQMpqRZ8=.fb097528-7865-42dc-97ef-d04fd7a6bcbe@github.com>

On Wed, 29 Dec 2021 16:48:22 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> ?th no events
> 
> In EventBrowser page, when there is no selection all events are
> considered but if there is a selection we filtered events based on
> this selection event if there is no events

This pull request has now been integrated.

Changeset: ce10e3f9
Author:    Jean-Philippe Bempel <jpbempel at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ce10e3f99d7644f14099bde14be7cff74e5f8b85
Stats:     29 lines in 2 files changed: 28 ins; 0 del; 1 mod

7482: Confusing display of stack traces when selecting event types with no events

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/344

From duke at openjdk.java.net  Tue Jan 11 05:33:01 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 11 Jan 2022 05:33:01 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v9]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <P9Rs2k-hs9b8MV-plcBPWQ0rISdxqUjD3NEkQZJ4UZg=.14fe5ece-41fd-4fca-86be-1be8707f8d53@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - JMC-7455: Use third party to pull inn Jolokia modules
 - Review corrections: Javadoc and refactoring attempt to use local operation info
 - Removed -XstartOnFirstThread as it is not valid for some JVMs
 - Used spotbugs to format more code
 - Used spotbugs to format according to convention
 - json.simple is needed by kubernetes plugin downstream
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - Added copyright notices. Removed author tag and meaningless comments
 - No reason more than Java 8 should be required
 - ... and 2 more: https://git.openjdk.java.net/jmc/compare/f077a406...da30ca75

-------------

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=08
  Stats: 3140 lines in 53 files changed: 3140 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Tue Jan 11 05:41:48 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Tue, 11 Jan 2022 05:41:48 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v10]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <OPjKaDEULcwDoD7eBccDaWsc_Djlc-LYJbsa1fh3zd8=.a4733ca4-a27e-4678-935f-029761eeeeb4@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - JMC-7455: Use third party to pull inn Jolokia modules
 - Review corrections: Javadoc and refactoring attempt to use local operation info
 - Removed -XstartOnFirstThread as it is not valid for some JVMs
 - Used spotbugs to format more code
 - Used spotbugs to format according to convention
 - json.simple is needed by kubernetes plugin downstream
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - Added copyright notices. Removed author tag and meaningless comments
 - No reason more than Java 8 should be required
 - ... and 2 more: https://git.openjdk.java.net/jmc/compare/ce10e3f9...eb20109f

-------------

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=09
  Stats: 3140 lines in 53 files changed: 3140 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From schaturvedi at openjdk.java.net  Tue Jan 11 21:34:47 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 11 Jan 2022 21:34:47 GMT
Subject: RFR: 7485: JMC Application,
 Plugins and License Copyright year requires update
Message-ID: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>

This PR addresses the copyright update task for JMC 8.2 release.

-------------

Commit messages:
 - 7485: JMC Application, Plugins and License Copyright year requires update

Changes: https://git.openjdk.java.net/jmc/pull/350/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=350&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7485
  Stats: 575 lines in 311 files changed: 0 ins; 0 del; 575 mod
  Patch: https://git.openjdk.java.net/jmc/pull/350.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/350/head:pull/350

PR: https://git.openjdk.java.net/jmc/pull/350

From hirt at openjdk.java.net  Wed Jan 12 02:55:33 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 02:55:33 GMT
Subject: RFR: 7485: JMC Application,
 Plugins and License Copyright year requires update
In-Reply-To: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
References: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
Message-ID: <eITHEWGAIMgMs9_7eQGIJIkSvJicAhbiBRwq-1tjm2s=.fe58236d-a4f4-42b8-bed7-db8b4b3f5bf8@github.com>

On Tue, 11 Jan 2022 21:29:26 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the copyright update task for JMC 8.2 release.

Changes requested by hirt (Lead).

application/org.openjdk.jmc.browser.jdp/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.browser/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.mbeanbrowser/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.notification/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.subscriptions/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.docs/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.flightrecorder.controlpanel.ui/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.flightrecorder.pde/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.flightrecorder.ui/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.ide.jdt/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.ide.ui/html/img_text/open_method_context_01.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.ide.ui/html/preface.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using001.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using002.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using003.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using004.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using005.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using006.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using007.htm line 4:

> 2:     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> 3: <!--
> 4:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.rcp.intro/plugin.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.

File not changed - don't change copyright.

-------------

PR: https://git.openjdk.java.net/jmc/pull/350

From hirt at openjdk.java.net  Wed Jan 12 02:57:25 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 02:57:25 GMT
Subject: RFR: 7473: Unable to view constants in constant pool page. [v2]
In-Reply-To: <A2kj754sd4KPees4qMIeWUXUy5tzAgEinFYx9C2JrwA=.f3e90638-52ec-4914-be5d-40cb17d463df@github.com>
References: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
 <A2kj754sd4KPees4qMIeWUXUy5tzAgEinFYx9C2JrwA=.f3e90638-52ec-4914-be5d-40cb17d463df@github.com>
Message-ID: <u2D1zfNVZRCy6GcgOdNRCorE8akW9LjtkJ2rphuMALs=.b0a82df8-5388-4992-90c1-86b7098e2013@github.com>

On Mon, 10 Jan 2022 16:26:02 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7473 [[0]](https://bugs.openjdk.java.net/browse/JMC-7473), in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame. 
>> 
>> Before:
>> ![2022-01-10-105031_790x151_scrot](https://user-images.githubusercontent.com/10425301/148796099-b32c4802-7b12-4489-ab09-0aa65a73cea9.png)
>> 
>> After:
>> ![2022-01-10-105044_668x458_scrot](https://user-images.githubusercontent.com/10425301/148796118-d066f332-d0a3-4982-9502-b26efd2ef01b.png)
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spotless

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/348

From duke at openjdk.java.net  Wed Jan 12 05:32:07 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 12 Jan 2022 05:32:07 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v11]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <efHs0T9btZm3mY8KUyRGmc0Nyd7atdYN0-68rfe7HqM=.d7cd9ff4-69f5-4bb3-9b63-87bbf4f98a56@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Re-export jolokia JMX adapter for simplicity

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/332/files
  - new: https://git.openjdk.java.net/jmc/pull/332/files/eb20109f..1b543ec0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=09-10

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From schaturvedi at openjdk.java.net  Wed Jan 12 08:04:06 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 12 Jan 2022 08:04:06 GMT
Subject: RFR: 7485: JMC Application,
 Plugins and License Copyright year requires update [v2]
In-Reply-To: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
References: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
Message-ID: <fI9KJZ7MBwwO4Fia7l38xybNUrcsUJs2sjLBaToFLtI=.46ed8205-fe42-41ce-8f2d-323d0cde921d@github.com>

> This PR addresses the copyright update task for JMC 8.2 release.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/350/files
  - new: https://git.openjdk.java.net/jmc/pull/350/files/440415c8..5da555a3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=350&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=350&range=00-01

  Stats: 22 lines in 22 files changed: 0 ins; 0 del; 22 mod
  Patch: https://git.openjdk.java.net/jmc/pull/350.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/350/head:pull/350

PR: https://git.openjdk.java.net/jmc/pull/350

From hirt at openjdk.java.net  Wed Jan 12 11:25:34 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 11:25:34 GMT
Subject: RFR: 7485: JMC Application,
 Plugins and License Copyright year requires update [v2]
In-Reply-To: <fI9KJZ7MBwwO4Fia7l38xybNUrcsUJs2sjLBaToFLtI=.46ed8205-fe42-41ce-8f2d-323d0cde921d@github.com>
References: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
 <fI9KJZ7MBwwO4Fia7l38xybNUrcsUJs2sjLBaToFLtI=.46ed8205-fe42-41ce-8f2d-323d0cde921d@github.com>
Message-ID: <tdQyW3k4X9GjzF1XvH48ujap5_EGweAEzrCIxVZ3euI=.4061be1a-24b1-4866-862d-b31cfdf6bf27@github.com>

On Wed, 12 Jan 2022 08:04:06 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR addresses the copyright update task for JMC 8.2 release.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/350

From hirt at openjdk.java.net  Wed Jan 12 11:25:44 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 11:25:44 GMT
Subject: RFR: 7503: Fix serializers.test dependency
In-Reply-To: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
References: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
Message-ID: <c0gyBm_AFk40QWhKnfkQEhcfZ6kUD4vTFdObtuiWcxc=.86967ce9-208b-4e58-951a-15b23c762f1e@github.com>

On Wed, 12 Jan 2022 10:07:19 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> This simple fix properly declares the `flightrecorder.test` dependency as a `test-jar`. This fixes compilation issues in IntelliJ especially.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/351

From schaturvedi at openjdk.java.net  Wed Jan 12 11:25:45 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 12 Jan 2022 11:25:45 GMT
Subject: RFR: 7503: Fix serializers.test dependency
In-Reply-To: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
References: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
Message-ID: <gf0hnvbEWepvlpAaeyDMyiqmip1tDreZ-BFqpodgCZE=.0e5b84a7-0d98-4ba5-a28d-eb133c5d27cc@github.com>

On Wed, 12 Jan 2022 10:07:19 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> This simple fix properly declares the `flightrecorder.test` dependency as a `test-jar`. This fixes compilation issues in IntelliJ especially.

Seems related to https://bugs.openjdk.java.net/browse/JMC-7406

-------------

PR: https://git.openjdk.java.net/jmc/pull/351

From duke at openjdk.java.net  Wed Jan 12 11:25:44 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Wed, 12 Jan 2022 11:25:44 GMT
Subject: RFR: 7503: Fix serializers.test dependency
Message-ID: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>

This simple fix properly declares the `flightrecorder.test` dependency as a `test-jar`. This fixes compilation issues in IntelliJ especially.

-------------

Commit messages:
 - Fixes org.openjdk.jmc.flightrecorder.serializers.test dependencies

Changes: https://git.openjdk.java.net/jmc/pull/351/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=351&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7503
  Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/351.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/351/head:pull/351

PR: https://git.openjdk.java.net/jmc/pull/351

From hirt at openjdk.java.net  Wed Jan 12 13:51:53 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 13:51:53 GMT
Subject: RFR: 7504: Fix flightrecorder.writer.test project setup
Message-ID: <5IXqPnEKtS3PHFeFwzQO3GshN-xgV0ip-xnxnhp6P0M=.70d55424-8017-472a-9a89-285dca0a0a64@github.com>

...so that it can be imported into Eclipse.

-------------

Commit messages:
 - Fixing redundant path
 - 7504: Fix flightrecorder.writer.test project setup

Changes: https://git.openjdk.java.net/jmc/pull/352/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=352&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7504
  Stats: 51 lines in 7 files changed: 41 ins; 1 del; 9 mod
  Patch: https://git.openjdk.java.net/jmc/pull/352.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/352/head:pull/352

PR: https://git.openjdk.java.net/jmc/pull/352

From duke at openjdk.java.net  Wed Jan 12 13:59:31 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Wed, 12 Jan 2022 13:59:31 GMT
Subject: Integrated: 7503: Fix serializers.test dependency
In-Reply-To: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
References: <N67WvwKN-ScVksG5Ad-ccP91N005cUSsK4nlB5Fx_Ag=.b465018a-5f73-47c5-9cb4-fe54a0ac165c@github.com>
Message-ID: <eCsDWaYHLQLCIArsKOJb4lUZIjDg9C4Hu6YxONJBK1g=.515831dd-69c8-42ed-a986-ebe06cc5c721@github.com>

On Wed, 12 Jan 2022 10:07:19 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> This simple fix properly declares the `flightrecorder.test` dependency as a `test-jar`. This fixes compilation issues in IntelliJ especially.

This pull request has now been integrated.

Changeset: 367914b6
Author:    Brice Dutheil <brice.dutheil at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/367914b671dca7652e2ed3cb52d57331dfb91a5b
Stats:     6 lines in 1 file changed: 2 ins; 0 del; 4 mod

7503: Fix serializers.test dependency

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/351

From schaturvedi at openjdk.java.net  Wed Jan 12 14:00:30 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 12 Jan 2022 14:00:30 GMT
Subject: Integrated: 7485: JMC Application,
 Plugins and License Copyright year requires update
In-Reply-To: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
References: <R7UGJJGwaFKmm1U6pL9kFBpn28NXhrH03njw_JCmSpc=.3e96a3aa-8c9b-416b-a72d-e625c9d60563@github.com>
Message-ID: <yFvvzuMxZOcA1BToWvmxt4hGg7qEL8Zn3TTM8e7h8m0=.754e0b70-29e8-4bea-abcf-d4dbbd14f861@github.com>

On Tue, 11 Jan 2022 21:29:26 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR addresses the copyright update task for JMC 8.2 release.

This pull request has now been integrated.

Changeset: b6bf40f8
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/b6bf40f821e959a529f007e282e7e8e4077e9457
Stats:     571 lines in 298 files changed: 0 ins; 0 del; 571 mod

7485: JMC Application, Plugins and License Copyright year requires update

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/350

From aptmac at openjdk.java.net  Wed Jan 12 15:33:27 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 12 Jan 2022 15:33:27 GMT
Subject: Integrated: 7473: Unable to view constants in constant pool page.
In-Reply-To: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
References: <0DhRaAeNY4K2yS-M-joSEw6s8rokuzw3JIA3xfCdra4=.4276607c-f0cd-43e0-b1dd-b9421859bb8e@github.com>
Message-ID: <vOQi-Bmy0nSq5MlLd6pzas1RuD-SLY8YK6h4MnOwXYM=.1baf06ac-0172-480a-9732-14a0e0e41bf1@github.com>

On Mon, 10 Jan 2022 15:57:50 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-7473 [[0]](https://bugs.openjdk.java.net/browse/JMC-7473), in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame. 
> 
> Before:
> ![2022-01-10-105031_790x151_scrot](https://user-images.githubusercontent.com/10425301/148796099-b32c4802-7b12-4489-ab09-0aa65a73cea9.png)
> 
> After:
> ![2022-01-10-105044_668x458_scrot](https://user-images.githubusercontent.com/10425301/148796118-d066f332-d0a3-4982-9502-b26efd2ef01b.png)

This pull request has now been integrated.

Changeset: dbb3e76d
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/dbb3e76d6f9e7a993b1eac37b2cbfeb09bef65ef
Stats:     10 lines in 1 file changed: 4 ins; 0 del; 6 mod

7473: Unable to view constants in constant pool page.

Reviewed-by: jpbempel, hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/348

From aptmac at openjdk.java.net  Wed Jan 12 16:07:37 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 12 Jan 2022 16:07:37 GMT
Subject: RFR: 7504: Fix flightrecorder.writer.test project setup
In-Reply-To: <5IXqPnEKtS3PHFeFwzQO3GshN-xgV0ip-xnxnhp6P0M=.70d55424-8017-472a-9a89-285dca0a0a64@github.com>
References: <5IXqPnEKtS3PHFeFwzQO3GshN-xgV0ip-xnxnhp6P0M=.70d55424-8017-472a-9a89-285dca0a0a64@github.com>
Message-ID: <_XakrIhtVIQHd4xZcNVzW9Vn-d3nHA24QnzqlFUACHE=.2e8edaba-c9bd-4020-85a8-d27402dcd2b1@github.com>

On Wed, 12 Jan 2022 13:46:23 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...so that it can be imported into Eclipse.

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/352

From duke at openjdk.java.net  Wed Jan 12 16:17:33 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Wed, 12 Jan 2022 16:17:33 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v11]
In-Reply-To: <efHs0T9btZm3mY8KUyRGmc0Nyd7atdYN0-68rfe7HqM=.d7cd9ff4-69f5-4bb3-9b63-87bbf4f98a56@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <efHs0T9btZm3mY8KUyRGmc0Nyd7atdYN0-68rfe7HqM=.d7cd9ff4-69f5-4bb3-9b63-87bbf4f98a56@github.com>
Message-ID: <v6yDiW5UccLVSZ6Ge9TyxUHWDhzTQPgPvnVqkFMxqiM=.b989015a-dc70-4a34-b3ca-19bce20d186c@github.com>

On Wed, 12 Jan 2022 05:32:07 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-7455: Re-export jolokia JMX adapter for simplicity

It would be good to get a new CI run with the new way of handling OSGi dependencies

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From hirt at openjdk.java.net  Wed Jan 12 16:21:34 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 16:21:34 GMT
Subject: Integrated: 7504: Fix flightrecorder.writer.test project setup
In-Reply-To: <5IXqPnEKtS3PHFeFwzQO3GshN-xgV0ip-xnxnhp6P0M=.70d55424-8017-472a-9a89-285dca0a0a64@github.com>
References: <5IXqPnEKtS3PHFeFwzQO3GshN-xgV0ip-xnxnhp6P0M=.70d55424-8017-472a-9a89-285dca0a0a64@github.com>
Message-ID: <2tC4DqTOraxZfCpTP9oBbiikxASdnEk9xXnXGzcNzIU=.caacc15c-0d43-4235-9acd-11590ab6da7f@github.com>

On Wed, 12 Jan 2022 13:46:23 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...so that it can be imported into Eclipse.

This pull request has now been integrated.

Changeset: be067aba
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/be067aba5dce42086deb7c9ea3f9aeecd58706b4
Stats:     51 lines in 7 files changed: 41 ins; 1 del; 9 mod

7504: Fix flightrecorder.writer.test project setup

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/352

From aptmac at openjdk.java.net  Wed Jan 12 16:23:44 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 12 Jan 2022 16:23:44 GMT
Subject: RFR: 7505: Cannot reset websocket server port to default
Message-ID: <P2IjhbtlMpCdAu2tBZYTjzJKu0U0TZMuC2NOcKGpM6g=.029a7a18-0f1a-47d1-b62f-891ab1908286@github.com>

This quick change addresses JMC-7505 [[0]](https://bugs.openjdk.java.net/browse/JMC-7505), in which the Preferences menu does not reset the value of the websocket server port.

The fix is to add the missing call to `loadWebsocketPortFromPrefStore()` in the `performDefaults()`.

Before:
![websocket-reset-before](https://user-images.githubusercontent.com/10425301/149178788-f2a12ee2-d6f7-4438-85f2-a56e11c743d6.gif)

After:
![websocket-reset-after](https://user-images.githubusercontent.com/10425301/149178778-f2d707d3-6a7f-4eb7-a603-b2de63aee319.gif)

-------------

Commit messages:
 - 7505: Cannot reset websocket server port to default

Changes: https://git.openjdk.java.net/jmc/pull/353/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=353&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7505
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/353.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/353/head:pull/353

PR: https://git.openjdk.java.net/jmc/pull/353

From hirt at openjdk.java.net  Wed Jan 12 16:31:27 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 12 Jan 2022 16:31:27 GMT
Subject: RFR: 7505: Cannot reset websocket server port to default
In-Reply-To: <P2IjhbtlMpCdAu2tBZYTjzJKu0U0TZMuC2NOcKGpM6g=.029a7a18-0f1a-47d1-b62f-891ab1908286@github.com>
References: <P2IjhbtlMpCdAu2tBZYTjzJKu0U0TZMuC2NOcKGpM6g=.029a7a18-0f1a-47d1-b62f-891ab1908286@github.com>
Message-ID: <3ggYa_o18XMF3bnABXIgcuXUCSHptYHZFUT12U18hpk=.444763ae-9356-4abe-ad83-714c97764fd5@github.com>

On Wed, 12 Jan 2022 16:17:53 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This quick change addresses JMC-7505 [[0]](https://bugs.openjdk.java.net/browse/JMC-7505), in which the Preferences menu does not reset the value of the websocket server port.
> 
> The fix is to add the missing call to `loadWebsocketPortFromPrefStore()` in the `performDefaults()`.
> 
> Before:
> ![websocket-reset-before](https://user-images.githubusercontent.com/10425301/149178788-f2a12ee2-d6f7-4438-85f2-a56e11c743d6.gif)
> 
> After:
> ![websocket-reset-after](https://user-images.githubusercontent.com/10425301/149178778-f2d707d3-6a7f-4eb7-a603-b2de63aee319.gif)

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/353

From aptmac at openjdk.java.net  Wed Jan 12 16:53:28 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 12 Jan 2022 16:53:28 GMT
Subject: Integrated: 7505: Cannot reset websocket server port to default
In-Reply-To: <P2IjhbtlMpCdAu2tBZYTjzJKu0U0TZMuC2NOcKGpM6g=.029a7a18-0f1a-47d1-b62f-891ab1908286@github.com>
References: <P2IjhbtlMpCdAu2tBZYTjzJKu0U0TZMuC2NOcKGpM6g=.029a7a18-0f1a-47d1-b62f-891ab1908286@github.com>
Message-ID: <X-JpYD6tJN2mNtAAwmfGbHu5R9zvCrpoOGmZF0lGpvw=.1650e466-68dd-4cef-9fb2-db52aa32b991@github.com>

On Wed, 12 Jan 2022 16:17:53 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This quick change addresses JMC-7505 [[0]](https://bugs.openjdk.java.net/browse/JMC-7505), in which the Preferences menu does not reset the value of the websocket server port.
> 
> The fix is to add the missing call to `loadWebsocketPortFromPrefStore()` in the `performDefaults()`.
> 
> Before:
> ![websocket-reset-before](https://user-images.githubusercontent.com/10425301/149178788-f2a12ee2-d6f7-4438-85f2-a56e11c743d6.gif)
> 
> After:
> ![websocket-reset-after](https://user-images.githubusercontent.com/10425301/149178778-f2d707d3-6a7f-4eb7-a603-b2de63aee319.gif)

This pull request has now been integrated.

Changeset: 70aa834a
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/70aa834a5eca40a4c65adc4f0e6287635f4455e3
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

7505: Cannot reset websocket server port to default

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/353

From duke at openjdk.java.net  Thu Jan 13 05:55:50 2022
From: duke at openjdk.java.net (Bhogesh Patil)
Date: Thu, 13 Jan 2022 05:55:50 GMT
Subject: RFR: 7492: Update org.owasp.encoder to version 1.2.3
Message-ID: <vYtxUKMcSU-K1eTJHz3ArPA0uTjwX4ziHcVxS2yYi1k=.1aadeac5-bd9d-4ab2-ae1f-20777bdf46ca@github.com>

7492: Update org.owasp.encoder to version 1.2.3

-------------

Commit messages:
 - Merge branch '7492_encoder_version_update' of https://github.com/bhopatil/jmc into 7492_encoder_version_update
 - Updated org.owasp.encoder to 1.2.3
 - 7492: Updated org.owasp.encoder to 1.2.3

Changes: https://git.openjdk.java.net/jmc/pull/345/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=345&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7492
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/345.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/345/head:pull/345

PR: https://git.openjdk.java.net/jmc/pull/345

From hirt at openjdk.java.net  Thu Jan 13 12:07:30 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 13 Jan 2022 12:07:30 GMT
Subject: RFR: 7492: Update org.owasp.encoder to version 1.2.3
In-Reply-To: <vYtxUKMcSU-K1eTJHz3ArPA0uTjwX4ziHcVxS2yYi1k=.1aadeac5-bd9d-4ab2-ae1f-20777bdf46ca@github.com>
References: <vYtxUKMcSU-K1eTJHz3ArPA0uTjwX4ziHcVxS2yYi1k=.1aadeac5-bd9d-4ab2-ae1f-20777bdf46ca@github.com>
Message-ID: <tRG68BMueKJxQ3ailJi5H2bMzNjCzDU8FUxvyIgLRnk=.4806f885-5ace-4cb9-812e-d93f798afb73@github.com>

On Mon, 3 Jan 2022 12:13:15 GMT, Bhogesh Patil <duke at openjdk.java.net> wrote:

> 7492: Update org.owasp.encoder to version 1.2.3

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/345

From duke at openjdk.java.net  Thu Jan 13 12:52:34 2022
From: duke at openjdk.java.net (Bhogesh Patil)
Date: Thu, 13 Jan 2022 12:52:34 GMT
Subject: Integrated: 7492: Update org.owasp.encoder to version 1.2.3
In-Reply-To: <vYtxUKMcSU-K1eTJHz3ArPA0uTjwX4ziHcVxS2yYi1k=.1aadeac5-bd9d-4ab2-ae1f-20777bdf46ca@github.com>
References: <vYtxUKMcSU-K1eTJHz3ArPA0uTjwX4ziHcVxS2yYi1k=.1aadeac5-bd9d-4ab2-ae1f-20777bdf46ca@github.com>
Message-ID: <3Lm-NDXQUZ33YNnGSECD-iWsmcGUo7y4Dyaxq-rXz9o=.14cefedf-4c2f-4bf0-815f-b1e6ffb6084c@github.com>

On Mon, 3 Jan 2022 12:13:15 GMT, Bhogesh Patil <duke at openjdk.java.net> wrote:

> 7492: Update org.owasp.encoder to version 1.2.3

This pull request has now been integrated.

Changeset: 132d281b
Author:    Bhogesh Patil <bhogesh.patil at oracle.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/132d281b6f9463675f0b690c2304ea1d5b0322d5
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

7492: Update org.owasp.encoder to version 1.2.3

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/345

From hirt at openjdk.java.net  Thu Jan 13 15:30:51 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 13 Jan 2022 15:30:51 GMT
Subject: RFR: 7507: Fixing project setup
Message-ID: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>

...and some cleanup.

-------------

Commit messages:
 - Fixing copyright years
 - Further project files and fixes
 - 7505: Fixing project setup

Changes: https://git.openjdk.java.net/jmc/pull/355/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=355&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7507
  Stats: 239 lines in 34 files changed: 92 ins; 12 del; 135 mod
  Patch: https://git.openjdk.java.net/jmc/pull/355.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/355/head:pull/355

PR: https://git.openjdk.java.net/jmc/pull/355

From aptmac at openjdk.java.net  Thu Jan 13 21:56:34 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 13 Jan 2022 21:56:34 GMT
Subject: RFR: 7507: Fixing project setup
In-Reply-To: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
Message-ID: <9X1kJgRzJkcEKAEL8Qko3dEj6fpA8i66V3Yab7615fk=.0879f07d-c671-438c-b5d1-607c751c19df@github.com>

On Thu, 13 Jan 2022 12:47:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...and some cleanup.

application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF line 15:

> 13:  org.openjdk.jmc.flightrecorder;visibility:=reexport,
> 14:  org.openjdk.jmc.ui;visibility:=reexport,
> 15:  org.openjdk.jmc.ui.celleditors,

Duplicate entry

application/uitests/pom.xml line 93:

> 91: 		<dependency>
> 92: 			<groupId>org.openjdk.jmc</groupId>
> 93: 			<artifactId>flightrecorder.serializers</artifactId>

Is there anything in the uitests that use serializers and writer?

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From duke at openjdk.java.net  Fri Jan 14 08:32:32 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 14 Jan 2022 08:32:32 GMT
Subject: RFR: 7507: Fixing project setup
In-Reply-To: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
Message-ID: <Sg4ds0jBnfJEhI3WhXEbqXak9RWP4xC9Z3GLTGkZeQM=.1af289dd-d951-4712-a32c-6dd5d09fc152@github.com>

On Thu, 13 Jan 2022 12:47:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...and some cleanup.

On clean git repository (after a the nuclear `git clean -fdx`), I noticed the `org.openjdk.jmc.flightrecorder.writer.test` project has compile errors, unless I do a right click on the project then `Maven | Update Project...`. Which result in this modification.

Other project's `.classpath` file seem to have this `classpathentry` element.


diff --git i/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath w/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
index b5527438..5de0999d 100644
--- i/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
+++ w/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
@@ -37,4 +37,5 @@
                        <attribute name="maven.pomderived" value="true"/>
                </attributes>
        </classpathentry>
+  <classpathentry kind="output" path="target/classes"/>
 </classpath>

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 13:25:49 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:25:49 GMT
Subject: RFR: 7509: Add 2021-09 target platform
Message-ID: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>

...also updating babel.

-------------

Commit messages:
 - 7509: Add 2021-09 target platform
 - Fixing copyright years
 - Further project files and fixes
 - 7505: Fixing project setup

Changes: https://git.openjdk.java.net/jmc/pull/357/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=357&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7509
  Stats: 352 lines in 39 files changed: 199 ins; 12 del; 141 mod
  Patch: https://git.openjdk.java.net/jmc/pull/357.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/357/head:pull/357

PR: https://git.openjdk.java.net/jmc/pull/357

From hirt at openjdk.java.net  Fri Jan 14 13:35:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:35:07 GMT
Subject: RFR: 7507: Fixing project setup [v2]
In-Reply-To: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
Message-ID: <n0_IOG1ic45BUK66oYZj8ExhzYGqVIGgYZ9hIcCE4Ik=.1dd5ba93-99d1-429b-af9b-66136697778b@github.com>

> ...and some cleanup.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Review feedback

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/355/files
  - new: https://git.openjdk.java.net/jmc/pull/355/files/70b3981c..9cca545b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=355&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=355&range=00-01

  Stats: 2 lines in 2 files changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/355.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/355/head:pull/355

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 13:35:11 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:35:11 GMT
Subject: RFR: 7507: Fixing project setup [v2]
In-Reply-To: <9X1kJgRzJkcEKAEL8Qko3dEj6fpA8i66V3Yab7615fk=.0879f07d-c671-438c-b5d1-607c751c19df@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
 <9X1kJgRzJkcEKAEL8Qko3dEj6fpA8i66V3Yab7615fk=.0879f07d-c671-438c-b5d1-607c751c19df@github.com>
Message-ID: <qdKMaYOJRQ5TPvuXB2_vwQlUv52OLBEC-QsgjLd5EeQ=.f094a267-e9e3-438c-95d4-93251df0425f@github.com>

On Thu, 13 Jan 2022 21:49:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> application/uitests/pom.xml line 93:
> 
>> 91: 		<dependency>
>> 92: 			<groupId>org.openjdk.jmc</groupId>
>> 93: 			<artifactId>flightrecorder.serializers</artifactId>
> 
> Is there anything in the uitests that use serializers and writer?

Writer, probably not right now, but doesn't hurt. I think the serializers are used by the Websocket stuff, so added them for good measure. Was trying to figure out why it's not possible to sometimes run the UI-tests after having run the RCP app from within Eclipse. I think the conclusion was that this doesn't matter, but having all of core available shouldn't hurt.

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 13:35:09 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:35:09 GMT
Subject: RFR: 7507: Fixing project setup
In-Reply-To: <Sg4ds0jBnfJEhI3WhXEbqXak9RWP4xC9Z3GLTGkZeQM=.1af289dd-d951-4712-a32c-6dd5d09fc152@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
 <Sg4ds0jBnfJEhI3WhXEbqXak9RWP4xC9Z3GLTGkZeQM=.1af289dd-d951-4712-a32c-6dd5d09fc152@github.com>
Message-ID: <H-Uqx_xyeyDw30gmzxxKPbVYUTxPgXTUd34CnqBs5qY=.db8435d4-e51a-4234-ab1b-e1ae814ca1d5@github.com>

On Fri, 14 Jan 2022 08:29:12 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> +  <classpathentry kind="output" path="target/classes"/>

You'd think it shouldn't be needed given that there is only test classes, but adding.

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 13:40:57 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:40:57 GMT
Subject: RFR: 7509: Add 2021-09 target platform [v2]
In-Reply-To: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
References: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
Message-ID: <rualWJCnPJq3343j2lxkBD-D58l8SYSfivRiCMlrMXk=.8a7606ed-6d77-4739-9340-3b742fbb4b32@github.com>

> ...also updating babel.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixed version

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/357/files
  - new: https://git.openjdk.java.net/jmc/pull/357/files/5189ace9..9102dd49

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=357&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=357&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/357.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/357/head:pull/357

PR: https://git.openjdk.java.net/jmc/pull/357

From duke at openjdk.java.net  Fri Jan 14 13:46:27 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 14 Jan 2022 13:46:27 GMT
Subject: RFR: 7507: Fixing project setup [v2]
In-Reply-To: <n0_IOG1ic45BUK66oYZj8ExhzYGqVIGgYZ9hIcCE4Ik=.1dd5ba93-99d1-429b-af9b-66136697778b@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
 <n0_IOG1ic45BUK66oYZj8ExhzYGqVIGgYZ9hIcCE4Ik=.1dd5ba93-99d1-429b-af9b-66136697778b@github.com>
Message-ID: <M4Qg4fLh7Rj7eqyvKkujGsvi9AkNxNQvVCzES6W1qow=.046a9f5d-8da7-46dc-9593-c3751ac24965@github.com>

On Fri, 14 Jan 2022 13:35:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> ...and some cleanup.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review feedback

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 13:48:45 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 13:48:45 GMT
Subject: RFR: 7510: Remove 2020-06 platform
Message-ID: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>

Last platform for JDK 8.

-------------

Commit messages:
 - 7510: Remove 2020-06 platform

Changes: https://git.openjdk.java.net/jmc/pull/358/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=358&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7510
  Stats: 155 lines in 5 files changed: 0 ins; 155 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/358.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/358/head:pull/358

PR: https://git.openjdk.java.net/jmc/pull/358

From duke at openjdk.java.net  Fri Jan 14 13:50:34 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 14 Jan 2022 13:50:34 GMT
Subject: RFR: 7509: Add 2021-09 target platform [v2]
In-Reply-To: <rualWJCnPJq3343j2lxkBD-D58l8SYSfivRiCMlrMXk=.8a7606ed-6d77-4739-9340-3b742fbb4b32@github.com>
References: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
 <rualWJCnPJq3343j2lxkBD-D58l8SYSfivRiCMlrMXk=.8a7606ed-6d77-4739-9340-3b742fbb4b32@github.com>
Message-ID: <L77MGdTYfjMHCeCK_qCBHczN5wRsfTuzVNzoGBPL76o=.40759672-fa6e-4cc6-8811-abb8993da4d1@github.com>

On Fri, 14 Jan 2022 13:40:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> ...also updating babel.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed version

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/357

From duke at openjdk.java.net  Fri Jan 14 13:55:31 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 14 Jan 2022 13:55:31 GMT
Subject: RFR: 7510: Remove 2020-06 platform
In-Reply-To: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
References: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
Message-ID: <ccRiVutiYnx6UIic-eRUmYL5NRAfnWdejHO1eopXWx4=.e4b45152-7a67-4e91-b2c4-5d682b7f4a86@github.com>

On Fri, 14 Jan 2022 13:44:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Last platform for JDK 8.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

For reference, the platform runtime requirement are here : https://wiki.eclipse.org/Eclipse/Installation

-------------

PR: https://git.openjdk.java.net/jmc/pull/358

From aptmac at openjdk.java.net  Fri Jan 14 14:01:28 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 14 Jan 2022 14:01:28 GMT
Subject: RFR: 7510: Remove 2020-06 platform
In-Reply-To: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
References: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
Message-ID: <qPzouKX0mXjKLAMyKws3-TjYTsdYXtzZv9fdKIJrxTU=.915cfe30-6a1f-46c8-aed1-bb848b8eab3c@github.com>

On Fri, 14 Jan 2022 13:44:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Last platform for JDK 8.

lgtm.

Additionally, after the inclusion of the OSX aarch64 environment [[0]](https://github.com/openjdk/jmc/commit/d218205fd4113daea82de1b813d5ef1ed740983d), builds fail on 2021-03 and earlier because 4.20 is required for the aarch64 environment [[1]](https://bugs.openjdk.java.net/browse/JMC-7477). Not sure if you would want to clean up any more platforms here, but 2021-03, 2020-12, and 2020-09 are broken without manual adjustment to remove OSX aarch64.

[0] https://github.com/openjdk/jmc/commit/d218205fd4113daea82de1b813d5ef1ed740983d
[1] https://bugs.openjdk.java.net/browse/JMC-7477

-------------

Marked as reviewed by aptmac (Committer).

PR: https://git.openjdk.java.net/jmc/pull/358

From aptmac at openjdk.java.net  Fri Jan 14 14:04:33 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 14 Jan 2022 14:04:33 GMT
Subject: RFR: 7507: Fixing project setup [v2]
In-Reply-To: <n0_IOG1ic45BUK66oYZj8ExhzYGqVIGgYZ9hIcCE4Ik=.1dd5ba93-99d1-429b-af9b-66136697778b@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
 <n0_IOG1ic45BUK66oYZj8ExhzYGqVIGgYZ9hIcCE4Ik=.1dd5ba93-99d1-429b-af9b-66136697778b@github.com>
Message-ID: <-9gj-qd5FK3nQLfk02KpoHRrwWSshNLHofeSMsK0Ufs=.d49c3992-50f5-435f-adc4-72085d3865e3@github.com>

On Fri, 14 Jan 2022 13:35:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> ...and some cleanup.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review feedback

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From aptmac at openjdk.java.net  Fri Jan 14 14:06:33 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 14 Jan 2022 14:06:33 GMT
Subject: RFR: 7493: Update versions and copyright on Update site pages
In-Reply-To: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
References: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
Message-ID: <4ltDgTf0iMry42178El8UIc742gTcNMckq3ezigt9ao=.a94ca0e8-86fb-4652-9c32-5284e9b954ca@github.com>

On Wed, 5 Jan 2022 19:15:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR updates the copyright year and Eclipse pre-requisite version.

Neat, looks like the bot didn't close this close this PR after integrating it. It should be closed now I believe.

-------------

PR: https://git.openjdk.java.net/jmc/pull/346

From hirt at openjdk.java.net  Fri Jan 14 15:08:34 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 15:08:34 GMT
Subject: Integrated: 7507: Fixing project setup
In-Reply-To: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
References: <0KgjnCLS22_amU3OF5cWSBUfQVA6URVsem-vjJ_Q2J8=.67bfbe5d-4571-460c-bedc-0527ec3e8e8c@github.com>
Message-ID: <7Lqp7hzAkNGWgXaqyH7UyndgU6_91wRG3N7Q3pbLR4A=.a4ca8be4-7035-4c66-9e51-673ff512f672@github.com>

On Thu, 13 Jan 2022 12:47:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...and some cleanup.

This pull request has now been integrated.

Changeset: 8ade37d8
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8ade37d84fdaca91b8b3c2999d18e61caacd6b8e
Stats:     240 lines in 35 files changed: 93 ins; 13 del; 134 mod

7507: Fixing project setup

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/355

From hirt at openjdk.java.net  Fri Jan 14 15:09:31 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 15:09:31 GMT
Subject: Integrated: 7510: Remove 2020-06 platform
In-Reply-To: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
References: <NHiDZBtLOEUH4uZYm5Ba7JtNbBz60fbLEMJvqFzo4VI=.b6004812-cd11-44d4-a4c5-5965cfdba16e@github.com>
Message-ID: <4mtOJJWTsjBrDhGo1RrVKgQ6dTBWWqlMoKXDXhW2pI8=.f9b35849-3fe1-484d-8e9c-940d77a15b0f@github.com>

On Fri, 14 Jan 2022 13:44:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Last platform for JDK 8.

This pull request has now been integrated.

Changeset: 80fce51c
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/80fce51c6dc3b5c368df70d5afb10a300fbe005d
Stats:     155 lines in 5 files changed: 0 ins; 155 del; 0 mod

7510: Remove 2020-06 platform

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/358

From hirt at openjdk.java.net  Fri Jan 14 17:33:45 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 17:33:45 GMT
Subject: RFR: 7509: Add 2021-09 target platform [v3]
In-Reply-To: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
References: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
Message-ID: <DH1ztDQmkp5hAadq9GGouqk9Meh13HUVr_10TD6Tdf0=.4d6ac716-b7e2-4bc5-9287-abd374331759@github.com>

> ...also updating babel.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:

 - Merge branch 'master' into 7509-2021-09
 - Fixed version
 - 7509: Add 2021-09 target platform
 - Fixing copyright years
 - Further project files and fixes
 - 7505: Fixing project setup

-------------

Changes: https://git.openjdk.java.net/jmc/pull/357/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=357&range=02
  Stats: 115 lines in 6 files changed: 107 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/357.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/357/head:pull/357

PR: https://git.openjdk.java.net/jmc/pull/357

From duke at openjdk.java.net  Fri Jan 14 19:39:53 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Fri, 14 Jan 2022 19:39:53 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v12]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <x5_4VyHMOQUidyrGBu7MOXB54OJrrG3dR2Kp6eGcGA8=.26f02ff0-6e19-4c54-bc14-daa4e21add63@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - JMC-7455: Remaining OSGi cleanup
 - JMC-7455: Re-export jolokia JMX adapter for simplicity
 - JMC-7455: Use third party to pull inn Jolokia modules
 - Review corrections: Javadoc and refactoring attempt to use local operation info
 - Removed -XstartOnFirstThread as it is not valid for some JVMs
 - Used spotbugs to format more code
 - Used spotbugs to format according to convention
 - json.simple is needed by kubernetes plugin downstream
 - Adding test plugin for Jolokia
 - Revert unwanted change unrelated to new plugins
 - ... and 4 more: https://git.openjdk.java.net/jmc/compare/80fce51c...dc047f95

-------------

Changes: https://git.openjdk.java.net/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=332&range=11
  Stats: 3101 lines in 52 files changed: 3101 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/332/head:pull/332

PR: https://git.openjdk.java.net/jmc/pull/332

From duke at openjdk.java.net  Fri Jan 14 19:43:39 2022
From: duke at openjdk.java.net (Martin Skarsaune)
Date: Fri, 14 Jan 2022 19:43:39 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v12]
In-Reply-To: <x5_4VyHMOQUidyrGBu7MOXB54OJrrG3dR2Kp6eGcGA8=.26f02ff0-6e19-4c54-bc14-daa4e21add63@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
 <x5_4VyHMOQUidyrGBu7MOXB54OJrrG3dR2Kp6eGcGA8=.26f02ff0-6e19-4c54-bc14-daa4e21add63@github.com>
Message-ID: <PPnOMnt9erpY_eeuqiqQ7_lKbwXSV0v3l9t2tY3v48o=.2e82377f-c6fa-415c-8a42-a4f3e472118d@github.com>

On Fri, 14 Jan 2022 19:39:53 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Setting back for review. The azure problem requires a fix in Jolokia.
>> 
>> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
> 
>  - JMC-7455: Remaining OSGi cleanup
>  - JMC-7455: Re-export jolokia JMX adapter for simplicity
>  - JMC-7455: Use third party to pull inn Jolokia modules
>  - Review corrections: Javadoc and refactoring attempt to use local operation info
>  - Removed -XstartOnFirstThread as it is not valid for some JVMs
>  - Used spotbugs to format more code
>  - Used spotbugs to format according to convention
>  - json.simple is needed by kubernetes plugin downstream
>  - Adding test plugin for Jolokia
>  - Revert unwanted change unrelated to new plugins
>  - ... and 4 more: https://git.openjdk.java.net/jmc/compare/80fce51c...dc047f95

application/tests/org.openjdk.jmc.jolokia.test/pom.xml line 86:

> 84: 			<plugin>
> 85: 				<groupId>org.apache.maven.plugins</groupId>
> 86: 				<artifactId>maven-dependency-plugin</artifactId>

Wondering whether I should do the same OSGi packaging solution with third party and platform definitions here. But is it ok to include test dependencies there as well, or should they be kept out of it?

-------------

PR: https://git.openjdk.java.net/jmc/pull/332

From aptmac at openjdk.java.net  Fri Jan 14 19:56:26 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 14 Jan 2022 19:56:26 GMT
Subject: RFR: 7509: Add 2021-09 target platform [v3]
In-Reply-To: <DH1ztDQmkp5hAadq9GGouqk9Meh13HUVr_10TD6Tdf0=.4d6ac716-b7e2-4bc5-9287-abd374331759@github.com>
References: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
 <DH1ztDQmkp5hAadq9GGouqk9Meh13HUVr_10TD6Tdf0=.4d6ac716-b7e2-4bc5-9287-abd374331759@github.com>
Message-ID: <XtsVmfy-10V4nBJD-TmDceXE1_Ccl1bTqxdCjCON6T0=.0d0c089b-2ec1-4422-ae05-b750011d0aa2@github.com>

On Fri, 14 Jan 2022 17:33:45 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> ...also updating babel.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into 7509-2021-09
>  - Fixed version
>  - 7509: Add 2021-09 target platform
>  - Fixing copyright years
>  - Further project files and fixes
>  - 7505: Fixing project setup

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/357

From hirt at openjdk.java.net  Fri Jan 14 20:58:28 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 14 Jan 2022 20:58:28 GMT
Subject: Integrated: 7509: Add 2021-09 target platform
In-Reply-To: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
References: <SsSnDHuNe2kUqUYATKc11bOa0Vu1klAQovdi_T4z_00=.0c5a5066-1e07-4fba-9825-fa5e4671a9be@github.com>
Message-ID: <M5tUVx0SYwfjj6hYxutqBdGLkNe1NtwNtT7tjX5WlFs=.b43f3ee9-d967-4129-9874-4dacf78d2e08@github.com>

On Fri, 14 Jan 2022 13:20:12 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...also updating babel.

This pull request has now been integrated.

Changeset: f8105b87
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f8105b87ccc8b77842e100ed35b4d9556e34a6b0
Stats:     115 lines in 6 files changed: 107 ins; 0 del; 8 mod

7509: Add 2021-09 target platform

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/357

From hirt at openjdk.java.net  Sun Jan 16 14:28:48 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 16 Jan 2022 14:28:48 GMT
Subject: RFR: 7511: Add 2021-12 target platform
Message-ID: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>

Not adding as default yet.

-------------

Commit messages:
 - Add project file
 - 7511: Add 2021-12 target platform

Changes: https://git.openjdk.java.net/jmc/pull/360/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=360&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7511
  Stats: 49 lines in 5 files changed: 39 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/360.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/360/head:pull/360

PR: https://git.openjdk.java.net/jmc/pull/360

From hirt at openjdk.java.net  Sun Jan 16 14:40:52 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 16 Jan 2022 14:40:52 GMT
Subject: RFR: 7477: Removing old platforms
Message-ID: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>

This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

-------------

Commit messages:
 - 7477: Removing old platforms

Changes: https://git.openjdk.java.net/jmc/pull/361/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=361&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7477
  Stats: 449 lines in 10 files changed: 0 ins; 448 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/361.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/361/head:pull/361

PR: https://git.openjdk.java.net/jmc/pull/361

From hirt at openjdk.java.net  Sun Jan 16 14:40:52 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 16 Jan 2022 14:40:52 GMT
Subject: RFR: 7477: Removing old platforms
In-Reply-To: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
Message-ID: <iDcLx5PDHEHpWtGvzuxTWAfzjDlESSW6ulWC-Xsr9LM=.927f6ed3-0205-478f-afb9-d605c641c0b3@github.com>

On Sun, 16 Jan 2022 14:35:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

That said, it doesn't build anyways, without manual modifications, so might perhaps take it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From duke at openjdk.java.net  Sun Jan 16 16:33:27 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Sun, 16 Jan 2022 16:33:27 GMT
Subject: RFR: 7511: Add 2021-12 target platform
In-Reply-To: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
References: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
Message-ID: <6_kUJaT9vEPPebkgAjI42Llxi8rFw9tPrS1m5NFjHIw=.21826fe0-e6d3-4936-a5dc-a77c3ec7f745@github.com>

On Sun, 16 Jan 2022 14:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not adding as default yet.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/360

From duke at openjdk.java.net  Mon Jan 17 11:55:54 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 Jan 2022 11:55:54 GMT
Subject: RFR: 7056: Fix dark mode
Message-ID: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com>

This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes.

Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin.
In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file.



**After**
![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png)
![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png)



**Before**
![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png)
There's no theme, as such the combo box doesn't open either.

-------------

Commit messages:
 - Allow dark appearance for the RCP distribution

Changes: https://git.openjdk.java.net/jmc/pull/362/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=362&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7056
  Stats: 14 lines in 2 files changed: 13 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/362.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/362/head:pull/362

PR: https://git.openjdk.java.net/jmc/pull/362

From duke at openjdk.java.net  Mon Jan 17 11:55:55 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Mon, 17 Jan 2022 11:55:55 GMT
Subject: RFR: 7056: Fix dark mode
In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com>
References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com>
Message-ID: <ICtaKapPOR6EXKbhn84oTRVV2sfaG-F57OkG3_YbK_A=.3833ed70-ad62-48e4-bc44-270821b59cfc@github.com>

On Sun, 16 Jan 2022 15:32:33 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes.
> 
> Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin.
> In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file.
> 
> 
> 
> **After**
> ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png)
> ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png)
> 
> 
> 
> **Before**
> ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png)
> There's no theme, as such the combo box doesn't open either.

Note this PR doesn't fix the graph issues mentioned in [JMC-7056](https://bugs.openjdk.java.net/browse/JMC-7056).

For JMC-7056, I'm not quite sure how to fix that yet, but using the following APIs might prove useful:

* `PlatformUI.getWorkbench().getThemeManager().getCurrentTheme()` gets an `ITheme`
* `theme.getColorRegistry().get(String)` gets the `Color` or a symbolic name

It makes sense, let's fix those.

-------------

PR: https://git.openjdk.java.net/jmc/pull/362

From hirt at openjdk.java.net  Mon Jan 17 11:55:56 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 17 Jan 2022 11:55:56 GMT
Subject: RFR: 7056: Fix dark mode
In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com>
References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com>
Message-ID: <nEqdeMmvQkTniO6RZ6L-CUYaGZ9h1cgwkqua3PK4blA=.69d8da12-e845-4d55-8f06-3a230fcdcce8@github.com>

On Sun, 16 Jan 2022 15:32:33 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes.
> 
> Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin.
> In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file.
> 
> 
> 
> **After**
> ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png)
> ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png)
> 
> 
> 
> **Before**
> ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png)
> There's no theme, as such the combo box doesn't open either.

I think we may have skipped having dark mode available due to the problems mentioned in JMC-7056. I think we need to fix JMC-7065 to re-enable.

-------------

PR: https://git.openjdk.java.net/jmc/pull/362

From jpbempel at openjdk.java.net  Mon Jan 17 11:58:26 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 17 Jan 2022 11:58:26 GMT
Subject: RFR: 7511: Add 2021-12 target platform
In-Reply-To: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
References: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
Message-ID: <r1iR4y7Nw-mJmUFBFupqoQZb-HxiQrzmq1rGsjePY0A=.c4b0d722-faaa-445a-8a40-b06e6e1b374a@github.com>

On Sun, 16 Jan 2022 14:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not adding as default yet.

Marked as reviewed by jpbempel (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/360

From marcus at hirt.se  Mon Jan 17 12:03:46 2022
From: marcus at hirt.se (Marcus Hirt)
Date: Mon, 17 Jan 2022 13:03:46 +0100
Subject: Remove platforms not supporting AARCH64?
Message-ID: <032f01d80b9a$47f160a0$d7d421e0$@hirt.se>

Hi all (especially vendors),

 

I'd like to remove the old platforms (not supporting AARCH64). This would
unfortunately mean an exception to our usual support for (at least) the last 4
Eclipse releases. The old platforms, however, are not really properly
supported today anyways, as you'd need to manually remove the AARCH64
environment from the main pom to make them build. The simplest would simply be
to remove the platform definitions for <= 2021-03, meaning we'd support
2021-06, 2021-09 and 2021-12, with 2022-03 being a little bit over a month
away. 

What do you think? Just remove them? Is there any vendor relying on 2021-03
(or earlier) being available?


See: [JMC-7477] JMC8.2 does not build with eclipse 4.19 (21-03) - Java Bug
System <https://bugs.openjdk.java.net/browse/JMC-7477> 



Kind regards,

Marcus


From hirt at openjdk.java.net  Mon Jan 17 14:01:31 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 17 Jan 2022 14:01:31 GMT
Subject: RFR: 7493: Update versions and copyright on Update site pages
In-Reply-To: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
References: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
Message-ID: <LdY5o7-qHnXzigShAlAJv3ABVJsHUBH6jG70vBsrbIU=.9302a93d-2557-4d59-8508-a7f739220589@github.com>

On Wed, 5 Jan 2022 19:15:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR updates the copyright year and Eclipse pre-requisite version.

@edvbld - do you know what might have happened here?

-------------

PR: https://git.openjdk.java.net/jmc/pull/346

From aptmac at openjdk.java.net  Mon Jan 17 16:22:31 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 17 Jan 2022 16:22:31 GMT
Subject: RFR: 7511: Add 2021-12 target platform
In-Reply-To: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
References: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
Message-ID: <L2HNeArfYEG0jHdeftJ8LgW5Rviq-qtvgusezltokfQ=.d2756008-5317-43f1-a00f-644ed35cdd75@github.com>

On Sun, 16 Jan 2022 14:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not adding as default yet.

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/360

From hirt at openjdk.java.net  Mon Jan 17 16:25:34 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 17 Jan 2022 16:25:34 GMT
Subject: Integrated: 7511: Add 2021-12 target platform
In-Reply-To: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
References: <DsZf7-N3VTxYo5vcH8CyoXOahR38kCzMAS8_Ro3Y3UA=.3df13e3b-f3f5-4e23-9ddc-ce3df20871ee@github.com>
Message-ID: <KPSQYdXMEnVa23PFlpCS7Hz7mzbEJOlRVm3vn7AQntw=.0619dd1a-b3e8-48c5-b43b-0ed9edb18c3d@github.com>

On Sun, 16 Jan 2022 14:24:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not adding as default yet.

This pull request has now been integrated.

Changeset: 8152e8d8
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8152e8d804f653f949bfa54abf6ca70b21b86037
Stats:     49 lines in 5 files changed: 39 ins; 0 del; 10 mod

7511: Add 2021-12 target platform

Reviewed-by: jpbempel, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/360

From duke at openjdk.java.net  Mon Jan 17 16:36:53 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 17 Jan 2022 16:36:53 GMT
Subject: RFR: 7526: JMC not buildable with jdk17
Message-ID: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>

Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

-------------

Commit messages:
 - Update READMEs and GitHub actions to include JDK 17
 - Update mockito and p2-maven-plugin to work with Java 17

Changes: https://git.openjdk.java.net/jmc/pull/363/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7526
  Stats: 90 lines in 5 files changed: 80 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Mon Jan 17 17:16:54 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 17 Jan 2022 17:16:54 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Fix maven cache directories in GitHub actions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/be0b8544..1018eae1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Mon Jan 17 17:31:31 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 17 Jan 2022 17:31:31 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
Message-ID: <P4qbNYNbivWqP4r9ATF9WEAnjMHfR5Yurc1ViD_J5PY=.972e70f7-ffa8-49bc-9d25-2ccd0a326c92@github.com>

On Mon, 17 Jan 2022 17:16:54 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix maven cache directories in GitHub actions

There is a problem that I was missing in my builds. I'm working on it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From reinhapa at openjdk.java.net  Mon Jan 17 19:05:34 2022
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Mon, 17 Jan 2022 19:05:34 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
Message-ID: <SN7oEOBD3gdVu5EjzaVONvTSiGbHqdJQK8Q3tGeoXLw=.ac0ff007-76b9-407b-bb07-3a97f09cac6b@github.com>

On Mon, 17 Jan 2022 17:16:54 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix maven cache directories in GitHub actions

Changes requested by reinhapa (Committer).

.github/workflows/validate.yml line 155:

> 153:     - name: Run agent tests
> 154:       run: .\scripts\runagenttests.bat
> 155:       shell: cmd

This could be solved by define an according matrix definition and using `{{ matrix.jdk }}` in the respective places

    strategy:
      matrix:
        jdk: ['11', '17']

 Here the example for the `linux` build step:


jobs:
  linux:
    strategy:
      matrix:
        jdk: ['11', '17']
    runs-on: 'ubuntu-latest'
    steps:
    - uses: actions/checkout at v1
    - uses: actions/setup-java at v1
      with:
        java-version: {{ matrix.jdk }}
        java-package: jdk
    - name: Cache local Maven repository
      uses: actions/cache at v2
      with:
        path: ~/.m2/repository
        key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
        restore-keys: |
          ${{ runner.os }}-maven-
    - name: Check formatting
      run: ./scripts/checkformatting.sh
    - name: Run core tests
      run: ./scripts/runcoretests.sh
    - name: Run application tests
      run: ./scripts/runapptests.sh
    - name: Run agent tests
      run: ./scripts/runagenttests.sh

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 08:32:27 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 18 Jan 2022 08:32:27 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <SN7oEOBD3gdVu5EjzaVONvTSiGbHqdJQK8Q3tGeoXLw=.ac0ff007-76b9-407b-bb07-3a97f09cac6b@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
 <SN7oEOBD3gdVu5EjzaVONvTSiGbHqdJQK8Q3tGeoXLw=.ac0ff007-76b9-407b-bb07-3a97f09cac6b@github.com>
Message-ID: <bhgZPs-vPMsXdkMI6JkegvkHsJwi4I5OKv3v5YaDp_U=.de448e3f-3550-4a6a-ac7f-09e5aeb3eee1@github.com>

On Mon, 17 Jan 2022 19:02:13 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix maven cache directories in GitHub actions
>
> .github/workflows/validate.yml line 155:
> 
>> 153:     - name: Run agent tests
>> 154:       run: .\scripts\runagenttests.bat
>> 155:       shell: cmd
> 
> This could be solved by define an according matrix definition and using `{{ matrix.jdk }}` in the respective places
> 
>     strategy:
>       matrix:
>         jdk: ['11', '17']
> 
>  Here the example for the `linux` build step:
> 
> 
> jobs:
>   linux:
>     strategy:
>       matrix:
>         jdk: ['11', '17']
>     runs-on: 'ubuntu-latest'
>     steps:
>     - uses: actions/checkout at v1
>     - uses: actions/setup-java at v1
>       with:
>         java-version: {{ matrix.jdk }}
>         java-package: jdk
>     - name: Cache local Maven repository
>       uses: actions/cache at v2
>       with:
>         path: ~/.m2/repository
>         key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
>         restore-keys: |
>           ${{ runner.os }}-maven-
>     - name: Check formatting
>       run: ./scripts/checkformatting.sh
>     - name: Run core tests
>       run: ./scripts/runcoretests.sh
>     - name: Run application tests
>       run: ./scripts/runapptests.sh
>     - name: Run agent tests
>       run: ./scripts/runagenttests.sh

Thanks, I thought about the possibility, but forgot that it was that easy

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 08:36:31 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 18 Jan 2022 08:36:31 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
Message-ID: <QjM9qWYdGVvQ2S0KcNRy0xNgP4AexBsLyvgGpfLYPmY=.371db477-618a-42c5-9f51-6dc15a7fa8f4@github.com>

On Mon, 17 Jan 2022 17:16:54 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix maven cache directories in GitHub actions

This PR has currently a few issues (that I'm dealing with in the next few) days:
- [ ] fix reliance on `tools.jar` (work with tycho to open up modules)
- [ ] improve GitHub actions
- [ ] fix spurious bug related to JDP that only happens sometimes
- [ ] fix bug that is probably related to trying to build this on an Mac M1

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From clanger at openjdk.java.net  Tue Jan 18 10:02:24 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Tue, 18 Jan 2022 10:02:24 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <QjM9qWYdGVvQ2S0KcNRy0xNgP4AexBsLyvgGpfLYPmY=.371db477-618a-42c5-9f51-6dc15a7fa8f4@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
 <QjM9qWYdGVvQ2S0KcNRy0xNgP4AexBsLyvgGpfLYPmY=.371db477-618a-42c5-9f51-6dc15a7fa8f4@github.com>
Message-ID: <d01V5WWPlZmSzmFf18xvW0vwPJP_kVU2E00YRf-8-_o=.d0d97f06-7150-4590-a78e-97c17ad66399@github.com>

On Tue, 18 Jan 2022 08:33:37 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> This PR has currently a few issues (that I'm dealing with in the next few) days:
> 
> * [ ]  fix reliance on `tools.jar` (work with tycho to open up modules)
> * [ ]  improve GitHub actions
> * [ ]  fix spurious bug related to JDP that only happens sometimes
> * [ ]  fix bug that is probably related to trying to build this on an Mac M1
> * [ ]  fix `./build.sh --run` to work on non `x86_64` (might be a different bug)

Maybe it's anyway feasible/better to split up the PR into separate items...

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 10:15:49 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 18 Jan 2022 10:15:49 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name override
Message-ID: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>

The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.

Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.

The change is little, and hopefully won't ripple beyond.

-------------

Commit messages:
 - Bump lz4-java, removes the osgi bundle name override

Changes: https://git.openjdk.java.net/jmc/pull/356/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7512
  Stats: 30 lines in 16 files changed: 4 ins; 6 del; 20 mod
  Patch: https://git.openjdk.java.net/jmc/pull/356.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/356/head:pull/356

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Tue Jan 18 10:15:50 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 18 Jan 2022 10:15:50 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <K07V2Y-WBIk9Z4Er_gi9VYrT9Js2wkjbBRImIsPAH48=.ccfa6596-2b35-429e-8804-8364124562af@github.com>

On Thu, 13 Jan 2022 16:37:22 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

Will need to also update the new targets. Let's take this one after #360 and #361.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Tue Jan 18 13:31:06 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 18 Jan 2022 13:31:06 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v3]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <4ftYBlfrr3Iq6X_NXRKVtV_Ae4W1u6hBq7q6YMkCCvI=.9f960285-e697-407d-9351-fcabcd621884@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into parttimenerd_java17
 - Fix maven cache directories in GitHub actions
 - Update READMEs and GitHub actions to include JDK 17
 - Update mockito and p2-maven-plugin to work with Java 17

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/1018eae1..f43d9506

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=01-02

  Stats: 547 lines in 45 files changed: 289 ins; 102 del; 156 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 14:51:40 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 18 Jan 2022 14:51:40 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <d01V5WWPlZmSzmFf18xvW0vwPJP_kVU2E00YRf-8-_o=.d0d97f06-7150-4590-a78e-97c17ad66399@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
 <QjM9qWYdGVvQ2S0KcNRy0xNgP4AexBsLyvgGpfLYPmY=.371db477-618a-42c5-9f51-6dc15a7fa8f4@github.com>
 <d01V5WWPlZmSzmFf18xvW0vwPJP_kVU2E00YRf-8-_o=.d0d97f06-7150-4590-a78e-97c17ad66399@github.com>
Message-ID: <FSt4uGBHh9rmKh5JXgJXlTFAUE5lCgJFM00Bzn0cL7o=.7c02d7d7-142c-43ed-9c19-c5f668c7be81@github.com>

On Tue, 18 Jan 2022 09:59:21 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> fix reliance on `tools.jar` (work with tycho to open up modules)

Since #358, [Eclipse now requires Java 11](https://wiki.eclipse.org/Eclipse/Installation). In #359, I bumped the JDK to Java 11, and dropped the JMC_JDK _library_ (that contains `tools.jar`) as now these APIs live in modules (the needed package exports were already defined in the `pom.xml`), however I'm quite unsure about the Eclipse configuration.

> fix bug that is probably related to trying to build this on an Mac M1

Could it be related to #361 ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 14:58:11 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 18 Jan 2022 14:58:11 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v4]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <hVCA5dDa9qNX-eIffx4LN5eSktZo45F0A4qXQf9sO5c=.a6286fb6-5e80-48e9-baf0-9f262c2c8b0b@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:

 - Improve devguide
 - Update jetty versions

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/f43d9506..639c4575

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=02-03

  Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 18 15:01:37 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 18 Jan 2022 15:01:37 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v2]
In-Reply-To: <FSt4uGBHh9rmKh5JXgJXlTFAUE5lCgJFM00Bzn0cL7o=.7c02d7d7-142c-43ed-9c19-c5f668c7be81@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <3UDWGnpvACgfTHXeODhtKQ0xqavxI3Hmn1hvCBE7cDs=.0595aca5-2d42-4788-bad0-95ba65b7d0f5@github.com>
 <QjM9qWYdGVvQ2S0KcNRy0xNgP4AexBsLyvgGpfLYPmY=.371db477-618a-42c5-9f51-6dc15a7fa8f4@github.com>
 <d01V5WWPlZmSzmFf18xvW0vwPJP_kVU2E00YRf-8-_o=.d0d97f06-7150-4590-a78e-97c17ad66399@github.com>
 <FSt4uGBHh9rmKh5JXgJXlTFAUE5lCgJFM00Bzn0cL7o=.7c02d7d7-142c-43ed-9c19-c5f668c7be81@github.com>
Message-ID: <xMgwxihgjHH6tUTiXVKBO7TC3AJs2Ds9UUM90A-JU_s=.14dd6f95-2899-4d8e-a5f1-4c8c0f6805bd@github.com>

On Tue, 18 Jan 2022 14:49:00 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> Could it be related to #361 ?

Yes. Switching to eclipse 4.22 is necessary to build it on Mac M1.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Tue Jan 18 16:56:33 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 18 Jan 2022 16:56:33 GMT
Subject: RFR: 7493: Update versions and copyright on Update site pages
In-Reply-To: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
References: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
Message-ID: <VHip2sbLV9ZSE0ymDoJwt_oI1jt2_4vPRmi7aGzjMVE=.a87b0cf8-97bd-419e-b980-923e7e348e96@github.com>

On Wed, 5 Jan 2022 19:15:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR updates the copyright year and Eclipse pre-requisite version.

See https://bugs.openjdk.java.net/browse/SKARA-1311.

-------------

PR: https://git.openjdk.java.net/jmc/pull/346

From schaturvedi at openjdk.java.net  Tue Jan 18 17:11:56 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 18 Jan 2022 17:11:56 GMT
Subject: RFR: 7531: Update jetty websocket third party
Message-ID: <IkNq85JC3jShgp4WtwrwfMq2rx2_6uPXze-1Osm29z8=.1f3b4825-0422-4f41-be55-719ee7a4e388@github.com>

This PR upgrades Jetty websocket third party from 10.0.5 to 10.0.7.

-------------

Commit messages:
 - 7531: Update jetty websocket third party

Changes: https://git.openjdk.java.net/jmc/pull/364/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=364&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7531
  Stats: 29 lines in 7 files changed: 0 ins; 0 del; 29 mod
  Patch: https://git.openjdk.java.net/jmc/pull/364.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/364/head:pull/364

PR: https://git.openjdk.java.net/jmc/pull/364

From jpbempel at openjdk.java.net  Wed Jan 19 10:20:33 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 19 Jan 2022 10:20:33 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v4]
In-Reply-To: <hVCA5dDa9qNX-eIffx4LN5eSktZo45F0A4qXQf9sO5c=.a6286fb6-5e80-48e9-baf0-9f262c2c8b0b@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <hVCA5dDa9qNX-eIffx4LN5eSktZo45F0A4qXQf9sO5c=.a6286fb6-5e80-48e9-baf0-9f262c2c8b0b@github.com>
Message-ID: <vbty7JUVPF8_CJm8a-70fmToMZnaqqAb__ig4VI73Jo=.e0cadfff-5021-42ac-949f-56f424baa091@github.com>

On Tue, 18 Jan 2022 14:58:11 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Improve devguide
>  - Update jetty versions

releng/platform-definitions/platform-definition-2021-12/platform-definition-2021-12.target line 5:

> 3:    Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.
> 5:    Copyright (c) 2022, SAP, SE. All rights reserved.

I think you can only add this line only if you introduce a new file in the repository.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Wed Jan 19 10:28:32 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Wed, 19 Jan 2022 10:28:32 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v4]
In-Reply-To: <vbty7JUVPF8_CJm8a-70fmToMZnaqqAb__ig4VI73Jo=.e0cadfff-5021-42ac-949f-56f424baa091@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <hVCA5dDa9qNX-eIffx4LN5eSktZo45F0A4qXQf9sO5c=.a6286fb6-5e80-48e9-baf0-9f262c2c8b0b@github.com>
 <vbty7JUVPF8_CJm8a-70fmToMZnaqqAb__ig4VI73Jo=.e0cadfff-5021-42ac-949f-56f424baa091@github.com>
Message-ID: <3lvC_opqYtbwvMBN88HbRtbbG-EtrN-0RWa-hLIl18k=.46f25e92-941d-4601-889c-5e7243c6b4d4@github.com>

On Wed, 19 Jan 2022 10:16:54 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Improve devguide
>>  - Update jetty versions
>
> releng/platform-definitions/platform-definition-2021-12/platform-definition-2021-12.target line 5:
> 
>> 3:    Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
>> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.
>> 5:    Copyright (c) 2022, SAP, SE. All rights reserved.
> 
> I think you can only add this line only if you introduce a new file in the repository.

thanks for the info, I'm new to the process

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Thu Jan 20 09:35:57 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 09:35:57 GMT
Subject: RFR: 7531: Update jetty websocket third party
In-Reply-To: <IkNq85JC3jShgp4WtwrwfMq2rx2_6uPXze-1Osm29z8=.1f3b4825-0422-4f41-be55-719ee7a4e388@github.com>
References: <IkNq85JC3jShgp4WtwrwfMq2rx2_6uPXze-1Osm29z8=.1f3b4825-0422-4f41-be55-719ee7a4e388@github.com>
Message-ID: <McFhbIp0BPIfE37wLX3LhxMT3gVSSt-TV2mFEfWTgIw=.08f3e4bf-3223-4ca4-bbf9-fb7c5390ddfb@github.com>

On Tue, 18 Jan 2022 17:06:51 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR upgrades Jetty websocket third party from 10.0.5 to 10.0.7.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/364

From schaturvedi at openjdk.java.net  Thu Jan 20 09:39:53 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 20 Jan 2022 09:39:53 GMT
Subject: Integrated: 7531: Update jetty websocket third party
In-Reply-To: <IkNq85JC3jShgp4WtwrwfMq2rx2_6uPXze-1Osm29z8=.1f3b4825-0422-4f41-be55-719ee7a4e388@github.com>
References: <IkNq85JC3jShgp4WtwrwfMq2rx2_6uPXze-1Osm29z8=.1f3b4825-0422-4f41-be55-719ee7a4e388@github.com>
Message-ID: <cl5OGy00f8DM0TmC338HcZYmjv9z29TfbLF44sOkEW0=.b89e6696-514c-42c6-995c-c875ebe3a238@github.com>

On Tue, 18 Jan 2022 17:06:51 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR upgrades Jetty websocket third party from 10.0.5 to 10.0.7.

This pull request has now been integrated.

Changeset: 3f9b42d8
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/3f9b42d88900ba49ce305ac975dfe602f281b815
Stats:     29 lines in 7 files changed: 0 ins; 0 del; 29 mod

7531: Update jetty websocket third party

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/364

From duke at openjdk.java.net  Thu Jan 20 10:45:12 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 10:45:12 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
Message-ID: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>

Tested on Mac M1.

-------------

Commit messages:
 - Add aarch64 support to build.sh

Changes: https://git.openjdk.java.net/jmc/pull/366/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=366&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7537
  Stats: 13 lines in 2 files changed: 7 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/366.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/366/head:pull/366

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Thu Jan 20 16:52:33 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 16:52:33 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Add JDK 17 to CI
 - Fix --add-exports
   
   Multiple --add-exports seem to require a flag like -version
   in between.
   It maybe related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016
 - Update p2-maven-plugin
 - Bump mockito to run --installCore on JDK 17

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/639c4575..019a32d3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=03-04

  Stats: 139 lines in 12 files changed: 10 ins; 84 del; 45 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From jpbempel at openjdk.java.net  Thu Jan 20 16:56:02 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 20 Jan 2022 16:56:02 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
In-Reply-To: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
Message-ID: <skDj26ifI-y-8JxLpWGHI36qChB5AH7vcnmGbMEQ9eE=.81c05bb5-d632-444e-9054-a5069fef9736@github.com>

On Sun, 16 Jan 2022 14:35:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

Marked as reviewed by jpbempel (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From hdafgard at openjdk.java.net  Thu Jan 20 17:06:01 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 20 Jan 2022 17:06:01 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
In-Reply-To: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
Message-ID: <kHjYdCdgUVjhp86u3dpFP3HorqvsiwMs-JKtyhGFmm8=.3744d138-045e-4653-98ff-feac9cbd4340@github.com>

On Sun, 16 Jan 2022 14:35:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From duke at openjdk.java.net  Thu Jan 20 17:27:56 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 17:27:56 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
Message-ID: <SSDrm9uWuL2fAV4TmS_bUgbm870ElxDeOz5XeZcTfQE=.9efd52a9-1b7f-4051-8bd5-d495c87b766f@github.com>

On Thu, 20 Jan 2022 16:52:33 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Add JDK 17 to CI
>  - Fix --add-exports
>    
>    Multiple --add-exports seem to require a flag like -version
>    in between.
>    It maybe related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016
>  - Update p2-maven-plugin
>  - Bump mockito to run --installCore on JDK 17

It now is buildable on JDK 17 and only the apptests fail.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From reinhapa at openjdk.java.net  Thu Jan 20 17:35:52 2022
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 20 Jan 2022 17:35:52 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
In-Reply-To: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
Message-ID: <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>

On Thu, 20 Jan 2022 10:38:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Tested on Mac M1.

Changes requested by reinhapa (Committer).

build.sh line 10:

> 8: if [[ "`uname -m`" =~ "arm64" ]]; then 
> 9:   ARCH="aarch64"
> 10: fi

I think we could use result from `uname -m` in any case:

  ARCH=`uname -m`

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Thu Jan 20 17:35:53 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 17:35:53 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
In-Reply-To: <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
 <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>
Message-ID: <s1Yg5MSLd0wbC6ZPs1K2H2d4_KzXSRzGSDYge4QL5SM=.dd3a6239-06c0-4056-bfb6-5ee75d587a1f@github.com>

On Thu, 20 Jan 2022 17:28:42 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Tested on Mac M1.
>
> build.sh line 10:
> 
>> 8: if [[ "`uname -m`" =~ "arm64" ]]; then 
>> 9:   ARCH="aarch64"
>> 10: fi
> 
> I think we could use result from `uname -m` in any case:
> 
>   ARCH=`uname -m`

No, this would break our current build, as `uname -m` outputs `arm64` instead of `aarch64` which is expected by the rest of the build system. Changing it would require to change the build system.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Thu Jan 20 17:35:53 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 17:35:53 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
In-Reply-To: <s1Yg5MSLd0wbC6ZPs1K2H2d4_KzXSRzGSDYge4QL5SM=.dd3a6239-06c0-4056-bfb6-5ee75d587a1f@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
 <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>
 <s1Yg5MSLd0wbC6ZPs1K2H2d4_KzXSRzGSDYge4QL5SM=.dd3a6239-06c0-4056-bfb6-5ee75d587a1f@github.com>
Message-ID: <d4qWvXeVvKgepwN9-0qeEt8WfJM0GA49I5UpnrnlCvA=.50c1249c-5db6-4037-80c8-728c4a2b2a17@github.com>

On Thu, 20 Jan 2022 17:32:42 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> build.sh line 10:
>> 
>>> 8: if [[ "`uname -m`" =~ "arm64" ]]; then 
>>> 9:   ARCH="aarch64"
>>> 10: fi
>> 
>> I think we could use result from `uname -m` in any case:
>> 
>>   ARCH=`uname -m`
>
> No, this would break our current build, as `uname -m` outputs `arm64` instead of `aarch64` which is expected by the rest of the build system. Changing it would require to change the build system.

It's probably baked into eclipse.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From reinhapa at openjdk.java.net  Thu Jan 20 17:44:56 2022
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 20 Jan 2022 17:44:56 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
In-Reply-To: <d4qWvXeVvKgepwN9-0qeEt8WfJM0GA49I5UpnrnlCvA=.50c1249c-5db6-4037-80c8-728c4a2b2a17@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
 <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>
 <s1Yg5MSLd0wbC6ZPs1K2H2d4_KzXSRzGSDYge4QL5SM=.dd3a6239-06c0-4056-bfb6-5ee75d587a1f@github.com>
 <d4qWvXeVvKgepwN9-0qeEt8WfJM0GA49I5UpnrnlCvA=.50c1249c-5db6-4037-80c8-728c4a2b2a17@github.com>
Message-ID: <aL5cKJBQosU18hRx_LTKGebetb6MyrVCVrJAUoG0Hto=.6aae164f-48d9-4260-b1ad-b98cc8f68a36@github.com>

On Thu, 20 Jan 2022 17:33:17 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> No, this would break our current build, as `uname -m` outputs `arm64` instead of `aarch64` which is expected by the rest of the build system. Changing it would require to change the build system.
>
> It's probably baked into eclipse.

Then it's OK for me.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Thu Jan 20 17:44:56 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 17:44:56 GMT
Subject: RFR: 7537: build script assumes that Darwin always targets x86_64
In-Reply-To: <aL5cKJBQosU18hRx_LTKGebetb6MyrVCVrJAUoG0Hto=.6aae164f-48d9-4260-b1ad-b98cc8f68a36@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
 <YW8OB1znL8BqKMYyZRNbDB3bwa5TOxn7gXk5JH8AnMw=.64653981-76f4-43ea-bbe5-c0dd86193f80@github.com>
 <s1Yg5MSLd0wbC6ZPs1K2H2d4_KzXSRzGSDYge4QL5SM=.dd3a6239-06c0-4056-bfb6-5ee75d587a1f@github.com>
 <d4qWvXeVvKgepwN9-0qeEt8WfJM0GA49I5UpnrnlCvA=.50c1249c-5db6-4037-80c8-728c4a2b2a17@github.com>
 <aL5cKJBQosU18hRx_LTKGebetb6MyrVCVrJAUoG0Hto=.6aae164f-48d9-4260-b1ad-b98cc8f68a36@github.com>
Message-ID: <sETrptk_CJgrQyPzOlDtp0mtrxt_8GpALfwoO3U3uj8=.b1ba5024-b3a9-47d0-aabb-c1f25a699092@github.com>

On Thu, 20 Jan 2022 17:39:05 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> It's probably baked into eclipse.
>
> Then it's OK for me.

According to https://docs.osgi.org/reference/osnames.html we could change it, but I do not know whether we need it at this point. It's still just a small bash script after all.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Thu Jan 20 18:03:56 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Thu, 20 Jan 2022 18:03:56 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
Message-ID: <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>

On Thu, 20 Jan 2022 16:52:33 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Add JDK 17 to CI
>  - Fix --add-exports
>    
>    Multiple --add-exports seem to require a flag like -version
>    in between.
>    It maybe related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016
>  - Update p2-maven-plugin
>  - Bump mockito to run --installCore on JDK 17

application/org.openjdk.jmc.browser.attach/pom.xml line 58:

> 56: 						<args>--add-exports</args>
> 57: 						<args>jdk.attach/sun.tools.attach=ALL-UNNAMED</args>
> 58: 						<args>-version</args><!-- see https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016 -->

This bug is closed, does that means it's again broken.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Thu Jan 20 18:11:54 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 20 Jan 2022 18:11:54 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
Message-ID: <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>

On Thu, 20 Jan 2022 18:01:08 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Add JDK 17 to CI
>>  - Fix --add-exports
>>    
>>    Multiple --add-exports seem to require a flag like -version
>>    in between.
>>    It maybe related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016
>>  - Update p2-maven-plugin
>>  - Bump mockito to run --installCore on JDK 17
>
> application/org.openjdk.jmc.browser.attach/pom.xml line 58:
> 
>> 56: 						<args>--add-exports</args>
>> 57: 						<args>jdk.attach/sun.tools.attach=ALL-UNNAMED</args>
>> 58: 						<args>-version</args><!-- see https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016 -->
> 
> This bug is closed, does that means it's again broken.

Seems so, but I did not have the time to look into this further.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From marcus.hirt at datadoghq.com  Thu Jan 20 18:26:02 2022
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 20 Jan 2022 19:26:02 +0100
Subject: Remove platforms not supporting AARCH64?
In-Reply-To: <032f01d80b9a$47f160a0$d7d421e0$@hirt.se>
References: <032f01d80b9a$47f160a0$d7d421e0$@hirt.se>
Message-ID: <CAOpWGx2S8=URMxkcxjzGvOR0Fz3uOKE57jTrQEovGF_rKHE5ew@mail.gmail.com>

Hi all,

Since no one seems to have a problem with this, I'll go ahead with the PR.
See: https://github.com/openjdk/jmc/pull/361

Kind regards,
Marcus

On Mon, Jan 17, 2022 at 1:04 PM Marcus Hirt <marcus at hirt.se> wrote:
>
> Hi all (especially vendors),
>
>
>
> I'd like to remove the old platforms (not supporting AARCH64). This would
> unfortunately mean an exception to our usual support for (at least) the last 4
> Eclipse releases. The old platforms, however, are not really properly
> supported today anyways, as you'd need to manually remove the AARCH64
> environment from the main pom to make them build. The simplest would simply be
> to remove the platform definitions for <= 2021-03, meaning we'd support
> 2021-06, 2021-09 and 2021-12, with 2022-03 being a little bit over a month
> away.
>
> What do you think? Just remove them? Is there any vendor relying on 2021-03
> (or earlier) being available?
>
>
> See: [JMC-7477] JMC8.2 does not build with eclipse 4.19 (21-03) - Java Bug
> System <https://bugs.openjdk.java.net/browse/JMC-7477>
>
>
>
> Kind regards,
>
> Marcus
>

From hirt at openjdk.java.net  Thu Jan 20 20:41:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 20:41:07 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03) [v2]
In-Reply-To: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
Message-ID: <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>

> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge master
 - 7477: Removing old platforms

-------------

Changes: https://git.openjdk.java.net/jmc/pull/361/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=361&range=01
  Stats: 448 lines in 10 files changed: 0 ins; 448 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/361.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/361/head:pull/361

PR: https://git.openjdk.java.net/jmc/pull/361

From aptmac at openjdk.java.net  Thu Jan 20 20:50:56 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 20 Jan 2022 20:50:56 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03) [v2]
In-Reply-To: <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
 <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
Message-ID: <ISuUJwVLCBFvvBwqCG4_YegTK-FZhhufp5bQe3vjOZ4=.bf65e19e-a580-429c-82cc-e804760ba58f@github.com>

On Thu, 20 Jan 2022 20:41:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge master
>  - 7477: Removing old platforms

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From hirt at openjdk.java.net  Thu Jan 20 21:34:50 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 21:34:50 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03) [v2]
In-Reply-To: <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
 <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
Message-ID: <Fs4SAWQNTI_nAn2UsdWGr7rpHUs4YNGayyJg_3JgRMQ=.e6157918-36fa-4c38-86ed-d86070079083@github.com>

On Thu, 20 Jan 2022 20:41:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge master
>  - 7477: Removing old platforms

Hm. It didn't run all checks. I'll redo the merge and see if it happens again.

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From hirt at openjdk.java.net  Thu Jan 20 22:21:57 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 22:21:57 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03) [v2]
In-Reply-To: <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
 <vJiFPgFfLbxJ5yjkSxQgL33rjDTZYbz583PTVdpck-U=.0179e3af-cc3c-4625-bef6-ed64badeef69@github.com>
Message-ID: <jYi2djmrU72qay9GHAybek8jroLfFlrgEkD1MOPvfDg=.5ab678ab-5cfe-47f7-a538-df3723add9c2@github.com>

On Thu, 20 Jan 2022 20:41:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge master
>  - 7477: Removing old platforms

Something is funny with the workflow. Moving this to #367 instead, and closing this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From hirt at openjdk.java.net  Thu Jan 20 22:21:57 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 22:21:57 GMT
Subject: Withdrawn: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
In-Reply-To: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
References: <lPfT_leN8mUJ07qJn0sySDLgGce5OwcAV6AZfTpop9A=.c6dd5cd0-5a1e-4491-8712-f6e586b5542e@github.com>
Message-ID: <Yc_Fm1Ixubr_1r21R_NYxmC0tlixNl-xYho-iW9wL_k=.4cb0cbf0-e960-47ce-bf29-20067ad00125@github.com>

On Sun, 16 Jan 2022 14:35:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmc/pull/361

From hirt at openjdk.java.net  Thu Jan 20 22:22:09 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 22:22:09 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
Message-ID: <DvTInY_LAlhDOpRiFhmLvV5tiA10WfNGxJxzLbZ7I7I=.ca9daf26-384c-4551-9d4c-06fdf9c2f8a8@github.com>

Something funny is happening with the workflow. Trying in a separate PR to see if it can be reproduced.

-------------

Commit messages:
 - 7477: Remove old platforms

Changes: https://git.openjdk.java.net/jmc/pull/367/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=367&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7477
  Stats: 448 lines in 10 files changed: 0 ins; 448 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/367.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/367/head:pull/367

PR: https://git.openjdk.java.net/jmc/pull/367

From duke at openjdk.java.net  Thu Jan 20 23:33:07 2022
From: duke at openjdk.java.net (mohno007)
Date: Thu, 20 Jan 2022 23:33:07 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule
Message-ID: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>

This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.

`BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

-------------

Commit messages:
 - Fix wrong placeholder in BiasedLockingRevocationRule

Changes: https://git.openjdk.java.net/jmc/pull/309/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=309&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7417
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/309.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/309/head:pull/309

PR: https://git.openjdk.java.net/jmc/pull/309

From aptmac at openjdk.java.net  Thu Jan 20 23:33:09 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 20 Jan 2022 23:33:09 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <Q2jn4oYfIfOL2MmQ4hclwnIVwNIJJhbcm2O6XJBffKw=.7a2ff982-e2d3-40bd-93cf-60d41c3729b4@github.com>

On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From duke at openjdk.java.net  Thu Jan 20 23:33:11 2022
From: duke at openjdk.java.net (mohno007)
Date: Thu, 20 Jan 2022 23:33:11 GMT
Subject: RFR: 7420: Update Japanese translation for rules
Message-ID: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>

This PR updates/improves Japanese translation of rules and its descriptions.

## Update

* Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
	* Support a new placeholder format introduced in `Rule 2.0`.
	* Use Markdown style link.
	* Add translations for newly added texts.
* Update texts for translation correctness and understandability.
	* Fix some wordings for understandability. Especially usage of Japanese particle.
	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.

You can see decoded version of `messages_ja` using this script:


native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

-------------

Commit messages:
 - fix copyright text
 - Update Japanese translation for rules

Changes: https://git.openjdk.java.net/jmc/pull/308/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=308&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7420
  Stats: 290 lines in 1 file changed: 89 ins; 4 del; 197 mod
  Patch: https://git.openjdk.java.net/jmc/pull/308.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/308/head:pull/308

PR: https://git.openjdk.java.net/jmc/pull/308

From hirt at openjdk.java.net  Thu Jan 20 23:33:10 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 23:33:10 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <bxiQXhMco9_1ejx-rqSeK5YmmIXQJwvLzenHtzaVgr0=.03fcd862-9c32-4c9d-8141-6cd53b41cb6c@github.com>

On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

Looks good @mohno007! Please follow the instructions of the bot to get your OCA status set straight.

Hi @mohno007! Just checking on how things are going with the OCA. Can I help?

@mohno007 / @robilad - any news on the OCA?

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From hirt at openjdk.java.net  Thu Jan 20 23:33:13 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 23:33:13 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
Message-ID: <rjy_AOooRoOqS7kP3dxRHxzgPOIJf6mBVOZX21KeEoY=.f4bec987-d484-44a5-8fa8-8ba2d2689210@github.com>

On Mon, 20 Sep 2021 04:55:25 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation of rules and its descriptions.
> 
> ## Update
> 
> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 	* Support a new placeholder format introduced in `Rule 2.0`.
> 	* Use Markdown style link.
> 	* Add translations for newly added texts.
> * Update texts for translation correctness and understandability.
> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

Thanks @mohno007! Let me know if you need any help with verifying the OCA status! Meanwhile, I've asked a friend in Japan to verify the texts.

Hi @davidbuckjp! Any chance you could take a look at this?

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2019, 2020, 2021 Oracle and/or its affiliates. All rights reserved.

Only the first and the last year in the range should be in the copyright header. In this case the text should be:
Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

Note the comma after the end year as well.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From hdafgard at openjdk.java.net  Thu Jan 20 23:33:11 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Thu, 20 Jan 2022 23:33:11 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <RN0Ra9xxqsp3-ByDJR24jVDp_cYrMOZPs8HpJ4Y6xic=.33d3c8f4-aa1b-4009-89d3-67595dab0c87@github.com>

On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

Please edit the title to refer to [JMC-7417](https://bugs.openjdk.java.net/browse/JMC-7417) by adding changing the title to "7417:Fix incorrect identifier in result for biased locking revocation rule". And when the OCA status is fixed I'll be happy to approve this PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From duke at openjdk.java.net  Thu Jan 20 23:33:14 2022
From: duke at openjdk.java.net (mohno007)
Date: Thu, 20 Jan 2022 23:33:14 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <rjy_AOooRoOqS7kP3dxRHxzgPOIJf6mBVOZX21KeEoY=.f4bec987-d484-44a5-8fa8-8ba2d2689210@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <rjy_AOooRoOqS7kP3dxRHxzgPOIJf6mBVOZX21KeEoY=.f4bec987-d484-44a5-8fa8-8ba2d2689210@github.com>
Message-ID: <agVDdqB8AT0A3H_NJWNE_ZZ8rkFS1ay5IBPMK9p49iE=.a06011a0-b0cb-43e6-97ff-759945247613@github.com>

On Tue, 21 Sep 2021 22:59:14 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Let me know if you need any help with verifying the OCA status! 

I run into a problem with OCA.
I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address.
Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.

I have already contacted Oracle Support by email and currently waiting for a response.

>  I've asked a friend in Japan to verify the texts.

Thank you.
I write Java code but I'm not very familiar with Java internals and its translation, so it would be very helpful if someone could check this translation.

> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties line 2:
> 
>> 1: #
>> 2: #  Copyright (c) 2018, 2019, 2020, 2021 Oracle and/or its affiliates. All rights reserved.
> 
> Only the first and the last year in the range should be in the copyright header. In this case the text should be:
> Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> Note the comma after the end year as well.

I fixed it in 48d36d496f8085da84b434a6842da6009b72bfe1

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From hirt at openjdk.java.net  Thu Jan 20 23:33:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 23:33:15 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <agVDdqB8AT0A3H_NJWNE_ZZ8rkFS1ay5IBPMK9p49iE=.a06011a0-b0cb-43e6-97ff-759945247613@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <rjy_AOooRoOqS7kP3dxRHxzgPOIJf6mBVOZX21KeEoY=.f4bec987-d484-44a5-8fa8-8ba2d2689210@github.com>
 <agVDdqB8AT0A3H_NJWNE_ZZ8rkFS1ay5IBPMK9p49iE=.a06011a0-b0cb-43e6-97ff-759945247613@github.com>
Message-ID: <nYDT4yxMjvR21c9cA9ORekvQSZ9okIhmVM2CpTh7s3Q=.6f0cb340-7353-412f-a389-0394af1e75eb@github.com>

On Wed, 22 Sep 2021 17:35:03 GMT, mohno007 <duke at openjdk.java.net> wrote:

> I run into a problem with OCA.
> I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address.
> Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.

@edvbld - can you help? What's the best way to help @mohno007 proceed with his application?

> I run into a problem with OCA. I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address. Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.
> 
> I have already contacted Oracle Support by email and currently waiting for a response.

Have you heard back from Oracle Support yet?

Hi @mohno007! Just checking to see how things are going. Did you see @robilad's message?

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From robilad at openjdk.java.net  Thu Jan 20 23:33:15 2022
From: robilad at openjdk.java.net (Dalibor Topic)
Date: Thu, 20 Jan 2022 23:33:15 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
Message-ID: <CvEhCkCrVauSh-EBcG7-WXTFX-M3V_amAMYcLhCtQfQ=.dfb66e9b-3b46-4757-92b2-1a5ccfc3f1e7@github.com>

On Mon, 20 Sep 2021 04:55:25 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation of rules and its descriptions.
> 
> ## Update
> 
> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 	* Support a new placeholder format introduced in `Rule 2.0`.
> 	* Use Markdown style link.
> 	* Add translations for newly added texts.
> * Update texts for translation correctness and understandability.
> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

Hi, please send me an e-Mail at dalibor.topic at oracle.com and I can try to assist you to find a resolution for the OCA issue.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Thu Jan 20 23:33:17 2022
From: duke at openjdk.java.net (mohno007)
Date: Thu, 20 Jan 2022 23:33:17 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <nYDT4yxMjvR21c9cA9ORekvQSZ9okIhmVM2CpTh7s3Q=.6f0cb340-7353-412f-a389-0394af1e75eb@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <rjy_AOooRoOqS7kP3dxRHxzgPOIJf6mBVOZX21KeEoY=.f4bec987-d484-44a5-8fa8-8ba2d2689210@github.com>
 <agVDdqB8AT0A3H_NJWNE_ZZ8rkFS1ay5IBPMK9p49iE=.a06011a0-b0cb-43e6-97ff-759945247613@github.com>
 <nYDT4yxMjvR21c9cA9ORekvQSZ9okIhmVM2CpTh7s3Q=.6f0cb340-7353-412f-a389-0394af1e75eb@github.com>
Message-ID: <6ebO-oLWnkxTkaYvWRYZjR48Mpol9kCMr9mDkFA1p2A=.802fff76-156e-4259-a30e-f3b5d302056f@github.com>

On Mon, 4 Oct 2021 09:12:28 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>>> Let me know if you need any help with verifying the OCA status! 
>> 
>> I run into a problem with OCA.
>> I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address.
>> Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.
>> 
>> I have already contacted Oracle Support by email and currently waiting for a response.
>> 
>>>  I've asked a friend in Japan to verify the texts.
>> 
>> Thank you.
>> I write Java code but I'm not very familiar with Java internals and its translation, so it would be very helpful if someone could check this translation.
>
> Hi @mohno007! Just checking to see how things are going. Did you see @robilad's message?

@thegreystone

> Hi @mohno007! Just checking to see how things are going. Did you see @robilad's message?

Thank you for the notice and sorry for the late reply, I just realized it and send a email.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From hirt at openjdk.java.net  Thu Jan 20 23:33:18 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 23:33:18 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <CvEhCkCrVauSh-EBcG7-WXTFX-M3V_amAMYcLhCtQfQ=.dfb66e9b-3b46-4757-92b2-1a5ccfc3f1e7@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <CvEhCkCrVauSh-EBcG7-WXTFX-M3V_amAMYcLhCtQfQ=.dfb66e9b-3b46-4757-92b2-1a5ccfc3f1e7@github.com>
Message-ID: <h98ONTwBR03P5NPa3Xl9T2goJnrvA4me55OmykFRTgE=.2ef7a6bf-1161-45ce-81e4-ed5916e51ae5@github.com>

On Fri, 1 Oct 2021 19:36:08 GMT, Dalibor Topic <robilad at openjdk.org> wrote:

>> This PR updates/improves Japanese translation of rules and its descriptions.
>> 
>> ## Update
>> 
>> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 	* Support a new placeholder format introduced in `Rule 2.0`.
>> 	* Use Markdown style link.
>> 	* Add translations for newly added texts.
>> * Update texts for translation correctness and understandability.
>> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
>> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties
>
> Hi, please send me an e-Mail at dalibor.topic at oracle.com and I can try to assist you to find a resolution for the OCA issue.

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Thu Jan 20 23:34:14 2022
From: duke at openjdk.java.net (mohno007)
Date: Thu, 20 Jan 2022 23:34:14 GMT
Subject: RFR: 7421: Update Japanese translation for pages
Message-ID: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>

This PR updates/improves Japanese translation for pages.

Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.

You can see decoded version of `messages_ja` using this script:


native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

-------------

Commit messages:
 - Update Japanese translation for pages

Changes: https://git.openjdk.java.net/jmc/pull/310/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=310&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7421
  Stats: 73 lines in 1 file changed: 61 ins; 2 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/310.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/310/head:pull/310

PR: https://git.openjdk.java.net/jmc/pull/310

From aptmac at openjdk.java.net  Thu Jan 20 23:34:16 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 20 Jan 2022 23:34:16 GMT
Subject: RFR: 7421: Update Japanese translation for pages
In-Reply-To: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
Message-ID: <CxDlhDIuf8V2tDhjVRxPC4vM1hN9rrNgS7fFRwa2HQQ=.6272e404-b39e-4338-8e91-ac27df373d39@github.com>

On Mon, 20 Sep 2021 12:56:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation for pages.
> 
> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

Marked as reviewed by aptmac (Reviewer).

application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties line 514:

> 512: ThreadsPage_EDIT_LANES=\u30B9\u30EC\u30C3\u30C9\u30FB\u30EC\u30FC\u30F3\u306E\u7DE8\u96C6
> 513: ThreadsPage_FOLD_CHART_TOOLTIP=\u30C1\u30E3\u30FC\u30C8\u3092\u6298\u308A\u305F\u305F\u3080
> 514: ThreadsPage_FOLD_TABLE_TOOLTIP=\u30C6\u30FC\u30D6\u30EB\u3092\u6298\u308A\u305F\u305F\u3080

Out of curiosity, how come this string uses "????" for table instead of "?" ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From hirt at openjdk.java.net  Thu Jan 20 23:34:17 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 20 Jan 2022 23:34:17 GMT
Subject: RFR: 7421: Update Japanese translation for pages
In-Reply-To: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
Message-ID: <5Xuq57P5Lxv9KlEEYwZ_OB2em03K3_i6_rcmkwFshCM=.268aae9c-9e83-41e8-8e25-0567159c9e59@github.com>

On Mon, 20 Sep 2021 12:56:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation for pages.
> 
> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

Hi @davidbuckjp! Any chance you could take a look at this?

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

Hi @davidbuckjp, any chance you can take a look at this whilst the OCA problems are being looked at?

Hi @robilad, @davidbuckjp & @edvbld! Is there anything that can be done to help @mohno007 get his OCA through? We're entering RDP2 for JMC 8.2.0, and I'd really like to take these PRs.

Hi @robilad! Any chance the OCA will be processed soon?

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From clanger at openjdk.java.net  Fri Jan 21 07:49:50 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 07:49:50 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
Message-ID: <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>

On Thu, 20 Jan 2022 18:08:08 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> application/org.openjdk.jmc.browser.attach/pom.xml line 58:
>> 
>>> 56: 						<args>--add-exports</args>
>>> 57: 						<args>jdk.attach/sun.tools.attach=ALL-UNNAMED</args>
>>> 58: 						<args>-version</args><!-- see https://bugs.eclipse.org/bugs/show_bug.cgi?id=544016 -->
>> 
>> This bug is closed, does that means it's again broken.
>
> Seems so, but I did not have the time to look into this further.

This is really weird. I'm struggling with the add-eports setting in my build attempts as well. I'm using JDK11. I also find that there's a difference in behavior between maven versions. E.g. maven 3.8.1 behaves slightly better than 3.8.4. But I have to do this kind of changes in several pom files until I get the build to go through.
What's your maven versions?

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Fri Jan 21 08:01:52 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 08:01:52 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
Message-ID: <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>

On Fri, 21 Jan 2022 07:46:34 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Seems so, but I did not have the time to look into this further.
>
> This is really weird. I'm struggling with the add-eports setting in my build attempts as well. I'm using JDK11. I also find that there's a difference in behavior between maven versions. E.g. maven 3.8.1 behaves slightly better than 3.8.4. But I have to do this kind of changes in several pom files until I get the build to go through.
> What's your maven versions?

My version is 3.8.4 which is the current version of maven. But it works for me with JDK 11. So the culprit (in my opinion) is the p2-maven-plugin, which is the only other thing I changed besides the JDK version, or of course, the JDK itself, but this seems to be unlikely.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Fri Jan 21 08:01:52 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 08:01:52 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
Message-ID: <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>

On Fri, 21 Jan 2022 07:56:24 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> This is really weird. I'm struggling with the add-eports setting in my build attempts as well. I'm using JDK11. I also find that there's a difference in behavior between maven versions. E.g. maven 3.8.1 behaves slightly better than 3.8.4. But I have to do this kind of changes in several pom files until I get the build to go through.
>> What's your maven versions?
>
> My version is 3.8.4 which is the current version of maven. But it works for me with JDK 11. So the culprit (in my opinion) is the p2-maven-plugin, which is the only other thing I changed besides the JDK version, or of course, the JDK itself, but this seems to be unlikely.

I have to test the new p2-maven-plugin version with JDK 11.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From reinhapa at openjdk.java.net  Fri Jan 21 08:16:55 2022
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 21 Jan 2022 08:16:55 GMT
Subject: RFR: 7537: Build script assumes that Darwin always targets x86_64
In-Reply-To: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
Message-ID: <QM_OX0Xyyage0xsd6iM5h6HWa4B-wXsVc1IrmqzUdzs=.6a6b1e5c-619d-4e3f-aafd-a8874567b24b@github.com>

On Thu, 20 Jan 2022 10:38:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Tested on Mac M1.

@thegreystone should we also open an issue for the Windows build script?

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Fri Jan 21 08:23:48 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 08:23:48 GMT
Subject: RFR: 7537: Build script assumes that Darwin always targets x86_64
In-Reply-To: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
Message-ID: <Rro3VHQPgUaef3Ar1aZWixIOxg429autOZmkw9iNSS4=.21cba881-359f-4693-a173-53f90cc90565@github.com>

On Thu, 20 Jan 2022 10:38:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Tested on Mac M1.

my take on it: it is highly unlikely that someone is running a windows on this architecture, as it only seems to be possible inside a VM.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From duke at openjdk.java.net  Fri Jan 21 11:18:55 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 21 Jan 2022 11:18:55 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v5]
In-Reply-To: <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
 <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
Message-ID: <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>

On Fri, 21 Jan 2022 07:58:54 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> My version is 3.8.4 which is the current version of maven. But it works for me with JDK 11. So the culprit (in my opinion) is the p2-maven-plugin, which is the only other thing I changed besides the JDK version, or of course, the JDK itself, but this seems to be unlikely.
>
> It's weird: the problem does not occur on JDK 11 with the newer p2-maven-plugin. So it might the JDK itself?

Could it be a tycho issue, again. Tycho overrides many lifecycle of Maven:

https://github.com/eclipse/tycho/blob/5c83ecd968eae37aa328020d228c8f03b2a3168c/tycho-maven-plugin/src/main/resources/META-INF/plexus/components.xml#L27-L29


<compile>
  org.eclipse.tycho:tycho-compiler-plugin:${project.version}:compile
</compile>


_By the way tycho 2.6.0 seems to be [around the corner](https://github.com/eclipse/tycho/releases/tag/tycho-2.6.0), I haven't checked the changelog though._

It can't be `p2-maven-plugin` anyway as it is only used to generate a p2 repository (that is used in the `.target` files), and it is only used in `releng/third-party`.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Fri Jan 21 11:59:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 11:59:07 GMT
Subject: RFR: 7538: Check in launcher for JVMKeepAlive
Message-ID: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>

Helpful for new developers.

-------------

Commit messages:
 - 7538: Check in launcher for JVMKeepAlive

Changes: https://git.openjdk.java.net/jmc/pull/368/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=368&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7538
  Stats: 19 lines in 1 file changed: 19 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/368.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/368/head:pull/368

PR: https://git.openjdk.java.net/jmc/pull/368

From duke at openjdk.java.net  Fri Jan 21 12:03:19 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 12:03:19 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v6]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <FmP1Q78TgZ_m_HZMzvPbNDE6cYEivojjcEaeBvlZXME=.ce8e5b08-76b3-4fc0-991d-4550356ab489@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Add another -version

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/019a32d3..7a77eef1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=04-05

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Fri Jan 21 12:06:25 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 12:06:25 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
Message-ID: <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>

> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Bump javadoc version

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/363/files
  - new: https://git.openjdk.java.net/jmc/pull/363/files/7a77eef1..db52a27b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=363&range=05-06

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/363.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/363/head:pull/363

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Fri Jan 21 12:13:48 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 12:13:48 GMT
Subject: RFR: 7421: Update Japanese translation for pages
In-Reply-To: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
Message-ID: <Ny2lpatPk5Ztc3uJJx6TWwIbB3udQEhApBCrD1T2Bfk=.14c17ab4-6728-4a91-b4d3-1dad1f984338@github.com>

On Mon, 20 Sep 2021 12:56:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation for pages.
> 
> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

Changes requested by hirt (Lead).

application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

Should update copyright year.

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From hirt at openjdk.java.net  Fri Jan 21 12:14:55 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 12:14:55 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <i5nOAN4XVZx4Eu5TaBnvCGh1uPvDR2i19D7DkchPUr4=.09306eb7-c473-4194-8da1-4b192f75d800@github.com>

On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java line 116:

> 114: 			MAX_NUMBER_OF_CLASSES_TO_REPORT, FILTERED_CLASSES);
> 115: 
> 116: 	public static final TypedCollectionResult<IMCType> REVOKED_CLASSES = new TypedCollectionResult<>("revokedClasses", //$NON-NLS-1$

Need to update copyright year.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 77:

> 75: BiasedLockingRevocationRule_TEXT_OK=No classes were disabled from participating in biased locking
> 76: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND=Fully revoked classes found.
> 77: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG=The following classes were disabled from using biased locking: {revokedClasses}

Need to update copyright year.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From duke at openjdk.java.net  Fri Jan 21 12:26:55 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 12:26:55 GMT
Subject: RFR: 7538: Check in launcher for JVMKeepAlive
In-Reply-To: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
References: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
Message-ID: <_nGuGqJQDqfO8ShFP8cgB-3tw1Fd8JKsRRgTkYJHLv8=.c3036df6-d866-415c-a228-fa806a5d67c8@github.com>

On Fri, 21 Jan 2022 11:54:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Helpful for new developers.

Please add a remark to the devguide on when and how to use it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/368

From clanger at openjdk.java.net  Fri Jan 21 14:21:38 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 14:21:38 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
Message-ID: <v_de4jQ_Fva_2hJVL5mnFJlCDZEV5QrWQ5aGFpAcstM=.d593b8fb-ab68-44af-abcc-c0d869b842b2@github.com>

On Fri, 21 Jan 2022 12:06:25 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bump javadoc version

The version bumps seem good. I think the GHA workflow has some issues still. I'll continue my investigations regarding the tycho compiler...

.github/workflows/validate.yml line 15:

> 13:     - uses: actions/setup-java at v1
> 14:       with:
> 15:         java-version: {{ matrix.jdk }}

Did you see that the workflow seems to have some issues still? (https://github.com/parttimenerd/jmc/actions/runs/1728551346)

-------------

Changes requested by clanger (Author).

PR: https://git.openjdk.java.net/jmc/pull/363

From clanger at openjdk.java.net  Fri Jan 21 14:21:44 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 14:21:44 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
 <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
 <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>
Message-ID: <Y-Pp7fWsAdnKNlYhsnh93l1p5r2wT-kM-P_RW5nnwPU=.b59f8003-12a8-4941-8cbb-45c819a58989@github.com>

On Fri, 21 Jan 2022 11:13:36 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> It's weird: the problem does not occur on JDK 11 with the newer p2-maven-plugin. So it might the JDK itself?
>
> Could it be a tycho issue, again. Tycho overrides many lifecycle of Maven:
> 
> https://github.com/eclipse/tycho/blob/5c83ecd968eae37aa328020d228c8f03b2a3168c/tycho-maven-plugin/src/main/resources/META-INF/plexus/components.xml#L27-L29
> 
> 
> <compile>
>   org.eclipse.tycho:tycho-compiler-plugin:${project.version}:compile
> </compile>
> 
> 
> _By the way tycho 2.6.0 seems to be [around the corner](https://github.com/eclipse/tycho/releases/tag/tycho-2.6.0), I haven't checked the changelog though._
> 
> It can't be `p2-maven-plugin` anyway as it is only used to generate a p2 repository (that is used in the `.target` files), and it is only used in `releng/third-party`.

I played around with it further. tycho uses JDT under the covers. And it seems to be an issue between Tycho JDT and JDK17. mvn -X shows nice parameters were passed to JDT but I didn't look into it. I will try to see what happens when switching the tycho compiler to javac. Don't know whether that's possible/a good idea...

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From schaturvedi at openjdk.java.net  Fri Jan 21 14:49:32 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 21 Jan 2022 14:49:32 GMT
Subject: Integrated: 7493: Update versions and copyright on Update site pages
In-Reply-To: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
References: <oYxfCh-E6ld7VzPYbeqpXZAnnMLTONUhYKTQG-qgDWY=.1388f5ec-a416-4456-aaac-ba5c6bdde2ae@github.com>
Message-ID: <56-yAuv76aBaKRCyar57ruk7dgEdARdPwJNBtts3zks=.ce88f819-68fe-48b5-b014-9db2c439bb7e@github.com>

On Wed, 5 Jan 2022 19:15:52 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR updates the copyright year and Eclipse pre-requisite version.

This pull request has now been integrated.

Changeset: f077a406
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f077a406946ccab1ca1f3a09e36ace76cda3243c
Stats:     9 lines in 4 files changed: 1 ins; 0 del; 8 mod

7493: Update versions and copyright on Update site pages

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/346

From duke at openjdk.java.net  Fri Jan 21 14:53:06 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 14:53:06 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
Message-ID: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>

Only run broadcasting related tests when supported.
Tested on Mac M1 with and without VPN.

-------------

Commit messages:
 - Formatting, again
 - Update copyright years
 - Use try-with-resources
 - Reformat changes
 - Only run broadcasting related tests when supported

Changes: https://git.openjdk.java.net/jmc/pull/369/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7539
  Stats: 48 lines in 3 files changed: 45 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From clanger at openjdk.java.net  Fri Jan 21 14:53:10 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 14:53:10 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <BEne4kyAAaUTPHu-Z3hq9VrQpc0olU3FEtT5ZvD15m0=.ca35980d-6248-4852-b21f-e3f6d73582f8@github.com>

On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

You also need to update the copyright years.

I'll test this later with my VPN.

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 72:

> 70: 		}
> 71: 		TEST_MULTICAST_ADDRESS = tmp;
> 72: 		BROADCASTING_SUPPORTED = isBroadcastingSupported();

Hm, I'm wondering whether this broadcasting check should be done in the static initialization of the class... maybe not. Rather do it lazily when calling isBroadcastingSupported()? There are a few tests which don't need this...

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 165:

> 163:             int multiCastPort = 7711;
> 164:             Thread thread = new Thread(() -> {
> 165:                 try {

you can use a try-with resources here: `try (MulticastSocket ssocket = new MulticastSocket(multiCastPort)) {` That way, the socket will also be closed in the end.

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 178:

> 176:             });
> 177:             thread.start();
> 178:             try {

Same here, try-with resources. The thread.interrupt() can then be done in the `finally` clause.

-------------

Changes requested by clanger (Author).

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Fri Jan 21 14:53:11 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 14:53:11 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <BEne4kyAAaUTPHu-Z3hq9VrQpc0olU3FEtT5ZvD15m0=.ca35980d-6248-4852-b21f-e3f6d73582f8@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <BEne4kyAAaUTPHu-Z3hq9VrQpc0olU3FEtT5ZvD15m0=.ca35980d-6248-4852-b21f-e3f6d73582f8@github.com>
Message-ID: <WZ0nCxZAMFJWxOoqU5BpW6P12d95NGNBGIeDhpoAka4=.3e68840a-c4d6-415f-bae2-5d2673fb57b4@github.com>

On Fri, 21 Jan 2022 14:33:15 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 165:
> 
>> 163:             int multiCastPort = 7711;
>> 164:             Thread thread = new Thread(() -> {
>> 165:                 try {
> 
> you can use a try-with resources here: `try (MulticastSocket ssocket = new MulticastSocket(multiCastPort)) {` That way, the socket will also be closed in the end.

you're right, I forgot it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Fri Jan 21 14:57:51 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 14:57:51 GMT
Subject: RFR: 7420: Update Japanese translation for rules
In-Reply-To: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
Message-ID: <bpZITL63wBCXZ-D1j8as9PQpjsK2dLzKnhWyBloUvWQ=.6fdb9b16-00e9-4057-9600-08bfe7118497@github.com>

On Mon, 20 Sep 2021 04:55:25 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation of rules and its descriptions.
> 
> ## Update
> 
> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 	* Support a new placeholder format introduced in `Rule 2.0`.
> 	* Use Markdown style link.
> 	* Add translations for newly added texts.
> * Update texts for translation correctness and understandability.
> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

Needs an updated copyright year.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.

Copyright needs to be updated.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Fri Jan 21 15:01:47 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 15:01:47 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <BEne4kyAAaUTPHu-Z3hq9VrQpc0olU3FEtT5ZvD15m0=.ca35980d-6248-4852-b21f-e3f6d73582f8@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <BEne4kyAAaUTPHu-Z3hq9VrQpc0olU3FEtT5ZvD15m0=.ca35980d-6248-4852-b21f-e3f6d73582f8@github.com>
Message-ID: <UmKwIHJNeWYOqDtHu9Q_-ILzPCDNBH7aTDS7365U2R8=.f685a4d0-bcf0-44fc-a3ef-e1e274321847@github.com>

On Fri, 21 Jan 2022 14:49:51 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 72:
> 
>> 70: 		}
>> 71: 		TEST_MULTICAST_ADDRESS = tmp;
>> 72: 		BROADCASTING_SUPPORTED = isBroadcastingSupported();
> 
> Hm, I'm wondering whether this broadcasting check should be done in the static initialization of the class... maybe not. Rather do it lazily when calling isBroadcastingSupported()? There are a few tests which don't need this...

The class is only used in this package and half of the test classes in this package need to functionality for their test.
There are 4 test classes overall.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Fri Jan 21 15:04:15 2022
From: duke at openjdk.java.net (mohno007)
Date: Fri, 21 Jan 2022 15:04:15 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule [v2]
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <UYSRb5YgYMHGEMhnpk0Va8rRNKI-JAoom6uHu6138hU=.26955770-5b26-4ca3-9a8f-0e4c462ce346@github.com>

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

mohno007 has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Update copyright year
 - Fix wrong placeholder in BiasedLockingRevocationRule

-------------

Changes: https://git.openjdk.java.net/jmc/pull/309/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=309&range=01
  Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/309.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/309/head:pull/309

PR: https://git.openjdk.java.net/jmc/pull/309

From duke at openjdk.java.net  Fri Jan 21 15:04:18 2022
From: duke at openjdk.java.net (mohno007)
Date: Fri, 21 Jan 2022 15:04:18 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule [v2]
In-Reply-To: <i5nOAN4XVZx4Eu5TaBnvCGh1uPvDR2i19D7DkchPUr4=.09306eb7-c473-4194-8da1-4b192f75d800@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
 <i5nOAN4XVZx4Eu5TaBnvCGh1uPvDR2i19D7DkchPUr4=.09306eb7-c473-4194-8da1-4b192f75d800@github.com>
Message-ID: <eVPVhhnsDdmtkl4jOTeO2tUkM_aBF3ubxbcis_hU5Xo=.958a63f6-36ad-4a87-bd53-e337de5dbafa@github.com>

On Fri, 21 Jan 2022 12:11:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> mohno007 has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Update copyright year
>>  - Fix wrong placeholder in BiasedLockingRevocationRule
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java line 115:
> 
>> 113: 	private static final List<TypedPreference<?>> CONFIG_ATTRIBUTES = Arrays.<TypedPreference<?>> asList(WARNING_LIMIT,
>> 114: 			MAX_NUMBER_OF_CLASSES_TO_REPORT, FILTERED_CLASSES);
>> 115: 
> 
> Need to update copyright year.

Thank you for your advice. I fixed it in ecb74c7.

> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 77:
> 
>> 75: BiasedLockingRevocationRule_TEXT_OK=No classes were disabled from participating in biased locking
>> 76: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND=Fully revoked classes found.
>> 77: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG=The following classes were disabled from using biased locking: {revokedClasses}
> 
> Need to update copyright year.

Thank you for your advice. I fixed it in ecb74c7.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From aptmac at openjdk.java.net  Fri Jan 21 15:12:50 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 21 Jan 2022 15:12:50 GMT
Subject: RFR: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
In-Reply-To: <DvTInY_LAlhDOpRiFhmLvV5tiA10WfNGxJxzLbZ7I7I=.ca9daf26-384c-4551-9d4c-06fdf9c2f8a8@github.com>
References: <DvTInY_LAlhDOpRiFhmLvV5tiA10WfNGxJxzLbZ7I7I=.ca9daf26-384c-4551-9d4c-06fdf9c2f8a8@github.com>
Message-ID: <vwb_UbsAT2SSe9iCGkqgq3XwAop3OnUwkwjJeYPP_Jg=.d2a3c1ea-49b4-4c0b-9ba3-634e68a3cd7e@github.com>

On Thu, 20 Jan 2022 22:16:09 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Something funny is happening with the workflow. Trying in a separate PR to see if it can be reproduced.

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/367

From hirt at openjdk.java.net  Fri Jan 21 15:14:49 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 15:14:49 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <MpOLsQcIJ28Ls-2iJw7aKBSCGTiEAGtZVw3H85VVfzs=.df1cad7a-91e6-4974-9f0c-df5d3a34242e@github.com>

On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

I think it would be better to have the test provide information about how to properly configure the machine to properly run the tests than to automatically skip the tests. Perhaps we could also add a system property check or something to make it easy to skip the test from the command line, if someone truly can't get it to work. But then it should be a conscious choice, not something happening automatically to avoid having to fix the setup.

Here is for example one possible scenario if we go with automated skipping:
1. Images used for our automated testing change their configuration, no longer providing a route for local multicast.
2. Tests are automatically skipped.
3. JDP changes and breaks.
4. We are never the wiser (until some JDP using person complains post release).

We shouldn't automatically skip tests without a very strong reason. It's better to inform the runner of the test how to fix their config.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Fri Jan 21 15:20:51 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 15:20:51 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <zI2cWfEgcpwP2Zzq2VFmc5rsE2QM3Gk6AY7IDJrhJ4A=.beb35429-5568-4552-9cd3-96ec86369647@github.com>

On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

An option could be to log a warning if we skip a test.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From clanger at openjdk.java.net  Fri Jan 21 15:24:50 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 15:24:50 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <MpOLsQcIJ28Ls-2iJw7aKBSCGTiEAGtZVw3H85VVfzs=.df1cad7a-91e6-4974-9f0c-df5d3a34242e@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <MpOLsQcIJ28Ls-2iJw7aKBSCGTiEAGtZVw3H85VVfzs=.df1cad7a-91e6-4974-9f0c-df5d3a34242e@github.com>
Message-ID: <nSt4r4WKOS_Rq95TKdmjZvodcRY1b6rFfKwDwfUMu0c=.a885afe4-7bd6-4b66-8126-80039999afbd@github.com>

On Fri, 21 Jan 2022 15:12:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> I think it would be better to have the test provide information about how to properly configure the machine to properly run the tests than to automatically skip the tests. Perhaps we could also add a system property check or something to make it easy to skip the test from the command line, if someone truly can't get it to work. But then it should be a conscious choice, not something happening automatically to avoid having to fix the setup.
> 
> Here is for example one possible scenario if we go with automated skipping:
> 
> 1. Images used for our automated testing change their configuration, no longer providing a route for local multicast.
> 2. Tests are automatically skipped.
> 3. JDP changes and breaks.
> 4. We are never the wiser (until some JDP using person complains post release).
> 
> We shouldn't automatically skip tests without a very strong reason. It's better to inform the runner of the test how to fix their config.

I agree - we should catch the failure and then log something like:
This test failed. Please check if your multicast is working or you are running in a VPN configuration. If this can't be fixed, build with `mvn -DskipJDPMulticastTests=true ...`.

And then check for this property when deciding whether to run the test.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Fri Jan 21 15:31:49 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 15:31:49 GMT
Subject: RFR: 7537: Build script assumes that Darwin always targets x86_64
In-Reply-To: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
Message-ID: <TH1VFW4-4lAThdEhZZzYdhpMb9muV32xPtzsMa1SFCw=.582273ea-4a4f-4361-aa7e-d0e2451bdb72@github.com>

On Thu, 20 Jan 2022 10:38:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Tested on Mac M1.

Marked as reviewed by hirt (Lead).

Olga helped verify this!

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From hirt at openjdk.java.net  Fri Jan 21 15:35:47 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 15:35:47 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <JKRbx9OQa-xoPLx_IkOv_y9ThVZwT8TPOd-dYF7JRHQ=.f863e39d-91d4-4366-97cb-4b94d1c9acd4@github.com>

On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Yup. We can even provide information about the proper command to use on Mac for adding the route.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Fri Jan 21 15:40:50 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 15:40:50 GMT
Subject: Integrated: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
In-Reply-To: <DvTInY_LAlhDOpRiFhmLvV5tiA10WfNGxJxzLbZ7I7I=.ca9daf26-384c-4551-9d4c-06fdf9c2f8a8@github.com>
References: <DvTInY_LAlhDOpRiFhmLvV5tiA10WfNGxJxzLbZ7I7I=.ca9daf26-384c-4551-9d4c-06fdf9c2f8a8@github.com>
Message-ID: <dcyDfP-_QHNIULLdK1AKoFun4KpXLGigIuGwkcEZ8GI=.f43a3171-2b04-4918-96c3-c72aa6488d8b@github.com>

On Thu, 20 Jan 2022 22:16:09 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Something funny is happening with the workflow. Trying in a separate PR to see if it can be reproduced.

This pull request has now been integrated.

Changeset: c646b146
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/c646b1463c5317e279729440bd6b85ff0764a953
Stats:     448 lines in 10 files changed: 0 ins; 448 del; 0 mod

7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/367

From clanger at openjdk.java.net  Fri Jan 21 16:04:16 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 16:04:16 GMT
Subject: RFR: 7540: IItemCollectionJsonSerializerTest.java might fail on
 Windows due to line endings
Message-ID: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>

Fix test IItemCollectionJsonSerializerTest.java

The line endings should be normalized, to avoid errors on Windows due to incompatible line ending formats.

-------------

Commit messages:
 - JMC-7540

Changes: https://git.openjdk.java.net/jmc/pull/370/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=370&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7540
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/370.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/370/head:pull/370

PR: https://git.openjdk.java.net/jmc/pull/370

From duke at openjdk.java.net  Fri Jan 21 16:42:51 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 21 Jan 2022 16:42:51 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <Y-Pp7fWsAdnKNlYhsnh93l1p5r2wT-kM-P_RW5nnwPU=.b59f8003-12a8-4941-8cbb-45c819a58989@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
 <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
 <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>
 <Y-Pp7fWsAdnKNlYhsnh93l1p5r2wT-kM-P_RW5nnwPU=.b59f8003-12a8-4941-8cbb-45c819a58989@github.com>
Message-ID: <KWDlkx1pRbmf3MB0r0wKXVhbQoBRAx5UBak-Nc7SajQ=.cd0ab07f-04f4-49ed-83d1-5ddc488b1482@github.com>

On Fri, 21 Jan 2022 14:09:39 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Could it be a tycho issue, again. Tycho overrides many lifecycle of Maven:
>> 
>> https://github.com/eclipse/tycho/blob/5c83ecd968eae37aa328020d228c8f03b2a3168c/tycho-maven-plugin/src/main/resources/META-INF/plexus/components.xml#L27-L29
>> 
>> 
>> <compile>
>>   org.eclipse.tycho:tycho-compiler-plugin:${project.version}:compile
>> </compile>
>> 
>> 
>> _By the way tycho 2.6.0 seems to be [around the corner](https://github.com/eclipse/tycho/releases/tag/tycho-2.6.0), I haven't checked the changelog though._
>> 
>> It can't be `p2-maven-plugin` anyway as it is only used to generate a p2 repository (that is used in the `.target` files), and it is only used in `releng/third-party`.
>
> I played around with it further. tycho uses JDT under the covers. And it seems to be an issue between Tycho JDT and JDK17. mvn -X shows nice parameters were passed to JDT but I didn't look into it. I will try to see what happens when switching the tycho compiler to javac. Don't know whether that's possible/a good idea...

I don't think that's possible, tycho overrides many aspects of maven, typicaly for the compiler the tycho _overlay_ will get depdencies from other tycho plugin, not from maven APIs.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From clanger at openjdk.java.net  Fri Jan 21 16:52:49 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Fri, 21 Jan 2022 16:52:49 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <KWDlkx1pRbmf3MB0r0wKXVhbQoBRAx5UBak-Nc7SajQ=.cd0ab07f-04f4-49ed-83d1-5ddc488b1482@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <PIqGicQrNln-OCKZmfUQaM0TqdYfpXxZGHGNCCKGUbA=.5bc9cdc3-aebd-4196-ac4e-cd3f371582f2@github.com>
 <wdxYjAMJCgw3nL2ZGEKtHuzu4Dk6hKNQiYOiI_Z5hMw=.6c7e8fec-cec1-4f3c-9dfe-a6bf2363d18b@github.com>
 <EhxvkglRaaYBBX2CCoWZO9enN_qg8zmKWsf59P41Q9M=.b2a759fc-150c-468c-899d-fa04d006e026@github.com>
 <onoqlPTsfyqhrzDJbCzwfHf1Vfs0DRpnUB6hFVetQdY=.a0b622d1-ebf3-468a-9dde-b374ed848d00@github.com>
 <IjrIeH20Fs1pD8IO0wmB5K1jV7YNQ5BCAS_xC4dGbo0=.ac1b9c16-7b29-45e8-9d58-99bb59c71c0d@github.com>
 <XH20E9JIu3Bjq1Rdr-83m4wlUolodJot8WtOBpjLocM=.36c0b8a4-b854-430d-b3b8-ad716520db56@github.com>
 <VEdaMf0wg7BHSBi8D74tPsmbshC2ziLB_js9Z3oSzDg=.dc3dec42-4bab-4d8f-bc24-b83794cde4b5@github.com>
 <Y-Pp7fWsAdnKNlYhsnh93l1p5r2wT-kM-P_RW5nnwPU=.b59f8003-12a8-4941-8cbb-45c819a58989@github.com>
 <KWDlkx1pRbmf3MB0r0wKXVhbQoBRAx5UBak-Nc7SajQ=.cd0ab07f-04f4-49ed-83d1-5ddc488b1482@github.com>
Message-ID: <JOXv8C_qzcXJGrbBlZgQw-uH76xwfEP6LsJjHUICcHw=.a0143362-a7fd-450b-81a4-3c1b049939a9@github.com>

On Fri, 21 Jan 2022 16:39:33 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> I played around with it further. tycho uses JDT under the covers. And it seems to be an issue between Tycho JDT and JDK17. mvn -X shows nice parameters were passed to JDT but I didn't look into it. I will try to see what happens when switching the tycho compiler to javac. Don't know whether that's possible/a good idea...
>
> I don't think that's possible, tycho overrides many aspects of maven, typicaly for the compiler the tycho _overlay_ will get depdencies from other tycho plugin, not from maven APIs.

Yup, you're right. I figured that out. I guess we have to live with the workaround. We can try once again with tycho 2.6.0 which should be out really soon. But if that doesn't change a thing we can only open an issue with tycho.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Fri Jan 21 17:15:22 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 17:15:22 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v2]
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <OuPIJmm1wSCmBSe689vbPKNN7zchKlKJMdJFBoO-Ac8=.5e9f3a79-1992-4d38-a79b-c673a95f28f4@github.com>

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:

 - Add skip functionality to build.sh script
 - Introduce -DskipJDPMulticastTests

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/369/files
  - new: https://git.openjdk.java.net/jmc/pull/369/files/774c2093..a50e543f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=00-01

  Stats: 80 lines in 4 files changed: 41 ins; 16 del; 23 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Fri Jan 21 17:25:18 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 17:25:18 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v3]
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/369/files
  - new: https://git.openjdk.java.net/jmc/pull/369/files/a50e543f..f902747c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Fri Jan 21 18:23:47 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Fri, 21 Jan 2022 18:23:47 GMT
Subject: Integrated: 7537: Build script assumes that Darwin always targets
 x86_64
In-Reply-To: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
References: <2P2V8rPVYzaQKk43iAkOX4GRdpkHiLMX9RBoS7-_3LY=.e6267ea2-f1bb-44cb-849e-dafe0c345ad7@github.com>
Message-ID: <3f6G_WCZFccV7m8zZfMWH3GVaPc93pvJL7NuEdnrvrQ=.56691ba5-55b9-40d3-8b45-1cdcdfbee70f@github.com>

On Thu, 20 Jan 2022 10:38:35 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Tested on Mac M1.

This pull request has now been integrated.

Changeset: baa6c777
Author:    Johannes Bechberger <johannes.bechberger at sap.com>
Committer: Patrick Reinhart <reinhapa at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/baa6c777e461982b9c8d729fcac799abe2c004b0
Stats:     13 lines in 2 files changed: 7 ins; 0 del; 6 mod

7537: Build script assumes that Darwin always targets x86_64

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/366

From hirt at openjdk.java.net  Fri Jan 21 23:36:13 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 23:36:13 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v3]
In-Reply-To: <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
Message-ID: <QwMir_tOtQXBdTfCDVVYWO8FQZWLbyIP513vlb6a_Uw=.5914dfda-8f87-43dc-a139-a761cf90cd1f@github.com>

On Fri, 21 Jan 2022 17:25:18 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Fri Jan 21 23:37:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 23:37:15 GMT
Subject: RFR: 7540: IItemCollectionJsonSerializerTest.java might fail on
 Windows due to line endings
In-Reply-To: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
References: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
Message-ID: <gObdLJKnN-ma5XIkt3gwEhV9NwWdt16EMTaXAvxo04I=.fb90451e-af56-401e-81a6-4ccd6b951f5f@github.com>

On Fri, 21 Jan 2022 15:57:41 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Fix test IItemCollectionJsonSerializerTest.java
> 
> The line endings should be normalized, to avoid errors on Windows due to incompatible line ending formats.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/370

From hirt at openjdk.java.net  Fri Jan 21 23:46:37 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 21 Jan 2022 23:46:37 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
Message-ID: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>

This is the platform that Oracle will use when releasing, so might as well make it the default.

-------------

Commit messages:
 - 7541: Switch to using 2021-09 by default

Changes: https://git.openjdk.java.net/jmc/pull/371/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=371&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7541
  Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/371.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/371/head:pull/371

PR: https://git.openjdk.java.net/jmc/pull/371

From duke at openjdk.java.net  Sat Jan 22 01:07:52 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:07:52 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
Message-ID: <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>

> This PR updates/improves Japanese translation of rules and its descriptions.
> 
> ## Update
> 
> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 	* Support a new placeholder format introduced in `Rule 2.0`.
> 	* Use Markdown style link.
> 	* Add translations for newly added texts.
> * Update texts for translation correctness and understandability.
> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

mohno007 has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/308/files
  - new: https://git.openjdk.java.net/jmc/pull/308/files/48d36d49..ac631bd3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=308&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=308&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/308.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/308/head:pull/308

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Sat Jan 22 01:16:10 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:16:10 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
Message-ID: <3ifh0-pAlumb7yhlLu69TFfHtugMssKOKaK45-kVYnM=.2dc2c912-5556-4827-971c-3fcd4575db01@github.com>

On Sat, 22 Jan 2022 01:07:52 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation of rules and its descriptions.
>> 
>> ## Update
>> 
>> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 	* Support a new placeholder format introduced in `Rule 2.0`.
>> 	* Use Markdown style link.
>> 	* Add translations for newly added texts.
>> * Update texts for translation correctness and understandability.
>> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
>> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

As you may know, I can sign the OCA.
Thank you to the developers for your patience.
Thank you to Dalibor-san and OCA support for resolving the issue.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Sat Jan 22 01:16:11 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:16:11 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <bpZITL63wBCXZ-D1j8as9PQpjsK2dLzKnhWyBloUvWQ=.6fdb9b16-00e9-4057-9600-08bfe7118497@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <bpZITL63wBCXZ-D1j8as9PQpjsK2dLzKnhWyBloUvWQ=.6fdb9b16-00e9-4057-9600-08bfe7118497@github.com>
Message-ID: <tdZu4Zuv0DmXPgeyhIZo98gH5_ZbWd798YmL-h-63c8=.574b9b8d-6467-463d-a46d-3dfdc6f83ba0@github.com>

On Fri, 21 Jan 2022 12:09:54 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties line 2:
> 
>> 1: #
>> 2: #  Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> Copyright needs to be updated.

I fixed it in ac631bd.

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Sat Jan 22 01:38:50 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:38:50 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
Message-ID: <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>

> This PR updates/improves Japanese translation for pages.
> 
> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

mohno007 has updated the pull request incrementally with three additional commits since the last revision:

 - Use "???" for "span"
 - Use "?" instead of "????"
 - Update copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/310/files
  - new: https://git.openjdk.java.net/jmc/pull/310/files/11b2825f..3fdce404

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=310&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=310&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/310.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/310/head:pull/310

PR: https://git.openjdk.java.net/jmc/pull/310

From duke at openjdk.java.net  Sat Jan 22 01:41:12 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:41:12 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <Ny2lpatPk5Ztc3uJJx6TWwIbB3udQEhApBCrD1T2Bfk=.14c17ab4-6728-4a91-b4d3-1dad1f984338@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
 <Ny2lpatPk5Ztc3uJJx6TWwIbB3udQEhApBCrD1T2Bfk=.14c17ab4-6728-4a91-b4d3-1dad1f984338@github.com>
Message-ID: <T56FIzQAjKMcknWwx-dKMosjDlqdry-AdQdWiWCX_ZQ=.a9b5c6c6-d70d-482e-80da-ca27900d76c2@github.com>

On Fri, 21 Jan 2022 12:10:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> mohno007 has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Use "???" for "span"
>>  - Use "?" instead of "????"
>>  - Update copyright year
>
> application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties line 2:
> 
>> 1: #
>> 2: #  Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> Should update copyright year.

I fixed it in 935be84b.

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From duke at openjdk.java.net  Sat Jan 22 01:41:13 2022
From: duke at openjdk.java.net (mohno007)
Date: Sat, 22 Jan 2022 01:41:13 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <CxDlhDIuf8V2tDhjVRxPC4vM1hN9rrNgS7fFRwa2HQQ=.6272e404-b39e-4338-8e91-ac27df373d39@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
 <CxDlhDIuf8V2tDhjVRxPC4vM1hN9rrNgS7fFRwa2HQQ=.6272e404-b39e-4338-8e91-ac27df373d39@github.com>
Message-ID: <PhLiEJ-AnOYXRUViseU1yLOcF0gmzGdUCj32s7ChvcY=.7f14edcb-d40f-4b96-8033-f5fa62e8a51f@github.com>

On Mon, 15 Nov 2021 22:15:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> mohno007 has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Use "???" for "span"
>>  - Use "?" instead of "????"
>>  - Update copyright year
>
> application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties line 514:
> 
>> 512: ThreadsPage_EDIT_LANES=\u30B9\u30EC\u30C3\u30C9\u30FB\u30EC\u30FC\u30F3\u306E\u7DE8\u96C6
>> 513: ThreadsPage_FOLD_CHART_TOOLTIP=\u30C1\u30E3\u30FC\u30C8\u3092\u6298\u308A\u305F\u305F\u3080
>> 514: ThreadsPage_FOLD_TABLE_TOOLTIP=\u30C6\u30FC\u30D6\u30EB\u3092\u6298\u308A\u305F\u305F\u3080
> 
> Out of curiosity, how come this string uses "????" for table instead of "?" ?

Thank you for pointing this out.

I overlooked the correspondence between `ThreadsPage_FOLD_TABLE_TOOLTIP` and `ThreadsPage_SHOW_TABLE_TOOLTIP`.
I think "?" is appropriate for here.

I fixed it in ef89b0dc.

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From clanger at openjdk.java.net  Sat Jan 22 06:38:33 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Sat, 22 Jan 2022 06:38:33 GMT
Subject: RFR: 7540: IItemCollectionJsonSerializerTest.java might fail on
 Windows due to line endings [v2]
In-Reply-To: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
References: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
Message-ID: <vRGuo34S-eRZrYhMfmwVsUrALBfR1rLbbVyjnjB1sXM=.7795aaf0-22b5-4188-8c49-e633f84dbf0c@github.com>

> Fix test IItemCollectionJsonSerializerTest.java
> 
> The line endings should be normalized, to avoid errors on Windows due to incompatible line ending formats.

Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  JMC-7540
  Fix test IItemCollectionJsonSerializerTest.java

-------------

Changes: https://git.openjdk.java.net/jmc/pull/370/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=370&range=01
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/370.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/370/head:pull/370

PR: https://git.openjdk.java.net/jmc/pull/370

From duke at openjdk.java.net  Sat Jan 22 07:43:12 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Sat, 22 Jan 2022 07:43:12 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v3]
In-Reply-To: <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
Message-ID: <GrSqyayMhUCK4pXVNLpQ1IHnD4K0NBTjJdpC3D5S8_w=.23c267cd-18ba-4560-b995-93e10de681d6@github.com>

On Fri, 21 Jan 2022 17:25:18 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

My current change still misses the integration in the Windows build script (but this might not be a problem as the VPN stuff primarily seems to affect Mac users) and a short remark in the README. Any thoughts about windows?

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From clanger at openjdk.java.net  Sat Jan 22 10:24:11 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Sat, 22 Jan 2022 10:24:11 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <8cJGFqZ3aXBnsdsNdYDZRA8MPDr_xjygohaXxQGNj2s=.0be2d2db-ea55-4472-9c8d-0e442d79c88d@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

Marked as reviewed by clanger (Author).

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From clanger at openjdk.java.net  Sat Jan 22 13:40:15 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Sat, 22 Jan 2022 13:40:15 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v3]
In-Reply-To: <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
Message-ID: <Syg5M98L6EpeJlA8eH8osHaazcd3xyPZHJcSZzICn4U=.473aed2f-2bb7-401e-baa4-59b334c38f05@github.com>

On Fri, 21 Jan 2022 17:25:18 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Looks good, I only have a few minor suggestions. For me it's ok to leave out the windows build script for now. I can add this later on, I want to play with that script anyway, have just built with maven so far.

build.sh line 297:

> 295:                 ;;
> 296:             --skipJDPMulticastTests)
> 297:                 JVM_ARGUMENTS="${JVM_ARGUMENTS} -DskipJDPMulticastTests=true "

nit: you could remove the space after -DskipJDPMulticastTests=true

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 55:

> 53: 	private static final String TEST_MULTICAST_ADDRESS_STRING = "224.0.23.177";
> 54: 	public static final InetAddress TEST_MULTICAST_ADDRESS;
> 55: 

nit: Leave that line.

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 158:

> 156: 	 */
> 157: 	public static boolean areBroadcastingTestsEnabled() {
> 158: 		if (System.getProperty("skipJDPMulticastTests", "false").equals("true")) {

you could do: `if (Boolean.getBoolean("skipJDPMulticastTests")) {` here

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 171:

> 169: 				helpMessage += String.format("'sudo ip route add %s dev eth0'", address);
> 170: 			} else {
> 171: 				helpMessage = "";

On windows you can recommend to `route add ... <gateway>` in a shell with administrator permissions. I did that and this made the test work. Obviously the user has to look up the gateway.

Something like
`helpMessage += String.format("'route add %s <gateway>' in a shell with administrator permissions", address);`

core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 174:

> 172: 			}
> 173: 			JDPClientTest.LOGGER.log(Level.WARNING, "Broadcasting does not seem to be possible.\n"
> 174: 					+ "This is usually related to VPN. There are four possible ways to remedy this:\n"

Actually, you enumerate only 3 possibilities, although the last one consists of two distinct options, depending on your build scenario

-------------

Changes requested by clanger (Author).

PR: https://git.openjdk.java.net/jmc/pull/369

From jpbempel at openjdk.java.net  Sat Jan 22 14:13:07 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 22 Jan 2022 14:13:07 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <PRhaxqHI7htWgqvvlVheUuc2Qz1DPXXqaGtP-osQAXo=.96b053cb-1910-42e8-aaa8-4b255900f03e@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

Marked as reviewed by jpbempel (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From clanger at openjdk.java.net  Sat Jan 22 14:29:10 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Sat, 22 Jan 2022 14:29:10 GMT
Subject: Integrated: 7540: IItemCollectionJsonSerializerTest.java might fail on
 Windows due to line endings
In-Reply-To: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
References: <4QDJZCaqrjOa0hzKkNkpk25V40v0kap0Y3t5ByPmcoY=.a9c80de6-b329-4928-a7cd-387163576685@github.com>
Message-ID: <Ag-HHV38HQSriRQBykdn93GDI7q7tpc8Wnst_61clW4=.16003c04-0cf2-41aa-bd09-f89b43e9a273@github.com>

On Fri, 21 Jan 2022 15:57:41 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Fix test IItemCollectionJsonSerializerTest.java
> 
> The line endings should be normalized, to avoid errors on Windows due to incompatible line ending formats.

This pull request has now been integrated.

Changeset: 3d036435
Author:    Christoph Langer <clanger at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/3d0364353bee86b742a351c5617032b1d1b8aa0c
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/370

From hirt at openjdk.java.net  Sat Jan 22 14:31:12 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 22 Jan 2022 14:31:12 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments
In-Reply-To: <nSt4r4WKOS_Rq95TKdmjZvodcRY1b6rFfKwDwfUMu0c=.a885afe4-7bd6-4b66-8126-80039999afbd@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <MpOLsQcIJ28Ls-2iJw7aKBSCGTiEAGtZVw3H85VVfzs=.df1cad7a-91e6-4974-9f0c-df5d3a34242e@github.com>
 <nSt4r4WKOS_Rq95TKdmjZvodcRY1b6rFfKwDwfUMu0c=.a885afe4-7bd6-4b66-8126-80039999afbd@github.com>
Message-ID: <oladn_B1J2pwaZlV6pWkniq8DnscBWQknConaQAdAgU=.465d1550-2179-4187-bf64-a0bed96f4ca0@github.com>

On Fri, 21 Jan 2022 15:22:04 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I think it would be better to have the test provide information about how to properly configure the machine to properly run the tests than to automatically skip the tests. Perhaps we could also add a system property check or something to make it easy to skip the test from the command line, if someone truly can't get it to work. But then it should be a conscious choice, not something happening automatically to avoid having to fix the setup.
>> 
>> Here is for example one possible scenario if we go with automated skipping:
>> 1. Images used for our automated testing change their configuration, no longer providing a route for local multicast.
>> 2. Tests are automatically skipped.
>> 3. JDP changes and breaks.
>> 4. We are never the wiser (until some JDP using person complains post release).
>> 
>> We shouldn't automatically skip tests without a very strong reason. It's better to inform the runner of the test how to fix their config.
>
>> I think it would be better to have the test provide information about how to properly configure the machine to properly run the tests than to automatically skip the tests. Perhaps we could also add a system property check or something to make it easy to skip the test from the command line, if someone truly can't get it to work. But then it should be a conscious choice, not something happening automatically to avoid having to fix the setup.
>> 
>> Here is for example one possible scenario if we go with automated skipping:
>> 
>> 1. Images used for our automated testing change their configuration, no longer providing a route for local multicast.
>> 2. Tests are automatically skipped.
>> 3. JDP changes and breaks.
>> 4. We are never the wiser (until some JDP using person complains post release).
>> 
>> We shouldn't automatically skip tests without a very strong reason. It's better to inform the runner of the test how to fix their config.
> 
> I agree - we should catch the failure and then log something like:
> This test failed. Please check if your multicast is working or you are running in a VPN configuration. If this can't be fixed, build with `mvn -DskipJDPMulticastTests=true ...`.
> 
> And then check for this property when deciding whether to run the test.

@RealCLanger has provided good insights! Let's act on his feedback before pushing this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Sat Jan 22 14:33:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 22 Jan 2022 14:33:07 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <TnA6VHwGThbqDyxMJ7aK9oqWCA2IGh0tP7Pe3Mf1X8A=.e9ebea07-bc58-4d8d-89b3-81e5c062f473@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

Need another committer (or a reviewer) to review this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From hirt at openjdk.java.net  Sat Jan 22 14:35:12 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 22 Jan 2022 14:35:12 GMT
Subject: RFR: 7538: Check in launcher for JVMKeepAlive
In-Reply-To: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
References: <yDJh1IreuieGCRRtOSF4mrgurEc2cw3IYBw4FqdJ1bM=.11376e1c-d7f4-4984-a7de-0902ebb21cc1@github.com>
Message-ID: <qgmP1T_HjANj6ArH5ukJ-6iPl7S5f2dMHMHH6zeVLf0=.cb5be85c-ff83-4756-b8a2-18a83cb3a37f@github.com>

On Fri, 21 Jan 2022 11:54:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Helpful for new developers.

Good point. Will add some detail to the devguide.

-------------

PR: https://git.openjdk.java.net/jmc/pull/368

From hirt at openjdk.java.net  Sat Jan 22 14:37:03 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 22 Jan 2022 14:37:03 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year [v3]
In-Reply-To: <QSPAx7l74ZNGYG35CA55z9GBo4Fvs-qXigZoLe-UXl4=.4ede5341-4d70-4f17-829f-aa933b39cbe9@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
 <QSPAx7l74ZNGYG35CA55z9GBo4Fvs-qXigZoLe-UXl4=.4ede5341-4d70-4f17-829f-aa933b39cbe9@github.com>
Message-ID: <1VqMp-Qm-6ISgdIOjAIb5ZLDxR2DlA-RZnXN1tCvTTc=.4057dc69-c09a-4488-a024-2f5d474a5cc6@github.com>

On Sat, 11 Dec 2021 20:20:44 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ?? 
>> 
>> The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).
>> 
>> It works as follows:
>> 
>> * diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
>> * for every changed file (except deletions), validate the copyright header
>>   - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
>>   - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
>> * we compare file contents from objects in the git repo, not the files themselves
>> * currently we don't validate we're in the correct directory or the commits
>> 
>> The output looks like this:
>> 
>> 
>> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                     
>> Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
>> ?? scripts/copyrightchecker.main.kts
>> ? Validation succeeded
>> 
>> 
>> 
>> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                       
>> Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
>> ?? .gitignore
>> ?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
>> ?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
>> Expected:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>> 	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>> 	Copyright (c) 2021, Datadog, Inc. All rights reserved.
>> 
>> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> Actual:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>>    Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>>    Copyright (c) 2021, Datadog, Inc. All rights reserved.
>> 
>>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
>> (check whitespace if strings seem to match)
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
>> ?? application/pom.xml
>> Expected:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>> 	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>> 
>> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> Actual:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>>    Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>> 
>>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
>> (check whitespace if strings seem to match)
>> 
>> ? Validation failed
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Run copyright checker during validate workflow on linux

Let's stick with Java in the OpenJDK JMC project though...

-------------

PR: https://git.openjdk.java.net/jmc/pull/342

From duke at openjdk.java.net  Sun Jan 23 09:48:14 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Sun, 23 Jan 2022 09:48:14 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v3]
In-Reply-To: <Syg5M98L6EpeJlA8eH8osHaazcd3xyPZHJcSZzICn4U=.473aed2f-2bb7-401e-baa4-59b334c38f05@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <Rz74AKjbA9bPMFcd8xTXatK077oJy2nsL0LUBKNNk3s=.1655b62a-59bd-40f9-a365-7fcdb61748c8@github.com>
 <Syg5M98L6EpeJlA8eH8osHaazcd3xyPZHJcSZzICn4U=.473aed2f-2bb7-401e-baa4-59b334c38f05@github.com>
Message-ID: <jylVN67kFYxHYasXck3MLpLDukSd_lJr6TKxcaZYce4=.44f82688-06cb-40e1-aef2-637344829369@github.com>

On Sat, 22 Jan 2022 13:22:24 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 174:
> 
>> 172: 			}
>> 173: 			JDPClientTest.LOGGER.log(Level.WARNING, "Broadcasting does not seem to be possible.\n"
>> 174: 					+ "This is usually related to VPN. There are four possible ways to remedy this:\n"
> 
> Actually, you enumerate only 3 possibilities, although the last one consists of two distinct options, depending on your build scenario

Oh, I thought I changed it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hdafgard at openjdk.java.net  Sun Jan 23 17:33:08 2022
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Sun, 23 Jan 2022 17:33:08 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <mAzbPTjTpdKJ-N78fp6xISV_1JuO829jhTiwDj3ivVQ=.e42dbc63-be7c-4c56-b5e1-9b7d07418dee@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From duke at openjdk.java.net  Mon Jan 24 09:48:13 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Mon, 24 Jan 2022 09:48:13 GMT
Subject: RFR: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <Mi_cTdN09HzemdmuZ2Spdxh05FW089rCi0svSaW0sbc=.2f62e777-25b1-4565-9cc0-16c1eb9b1671@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From duke at openjdk.java.net  Mon Jan 24 09:56:43 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 24 Jan 2022 09:56:43 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v4]
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <oSvVjQJ8e7sMd3Iz7HRyugmXfDtLboxJPqTvTF_rlB8=.9dc3ca14-bbd3-4a71-88c7-249088d08298@github.com>

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:

  Small fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/369/files
  - new: https://git.openjdk.java.net/jmc/pull/369/files/f902747c..dff7bc85

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=02-03

  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Mon Jan 24 09:57:13 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 09:57:13 GMT
Subject: Integrated: 7541: Switch to using 2021-09 by default
In-Reply-To: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
References: <Wmt62VPSl-G-50fqO6PY24j-xz83T5dxcTMNORu0nRE=.901f8f16-eae8-441e-9806-d46da9053d71@github.com>
Message-ID: <iQqRbgqVXvJsKozYj_LUBrUjEfiTioT7MbA-1Ourm9E=.40cc744e-e5ad-4d58-b41c-8c3c834ab8ec@github.com>

On Fri, 21 Jan 2022 23:41:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is the platform that Oracle will use when releasing, so might as well make it the default.

This pull request has now been integrated.

Changeset: 7037e747
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/7037e747c158bc4fedafebb5c817ad2307217c6a
Stats:     6 lines in 1 file changed: 3 ins; 3 del; 0 mod

7541: Switch to using 2021-09 by default

Reviewed-by: clanger, jpbempel, hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/371

From duke at openjdk.java.net  Mon Jan 24 10:00:45 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 24 Jan 2022 10:00:45 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v5]
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <GRKJzHvY-LJIjmSu970Z4H3bdvJ-ujk6nCMFoB74V9s=.86574996-4a8a-4e81-85c8-575aa88f8ff7@github.com>

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Small fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/369/files
  - new: https://git.openjdk.java.net/jmc/pull/369/files/dff7bc85..67473e8c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From duke at openjdk.java.net  Mon Jan 24 10:05:43 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 24 Jan 2022 10:05:43 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v6]
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <hR7N7Ghk75p8lfyxuSkEAk6Ks3f9Ky2PU-glhlVZKc0=.5cd6bec7-7aab-4fed-b6db-0857efd7a8c4@github.com>

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Small fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/369/files
  - new: https://git.openjdk.java.net/jmc/pull/369/files/67473e8c..e3d853db

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=369&range=04-05

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/369/head:pull/369

PR: https://git.openjdk.java.net/jmc/pull/369

From clanger at openjdk.java.net  Mon Jan 24 10:09:11 2022
From: clanger at openjdk.java.net (Christoph Langer)
Date: Mon, 24 Jan 2022 10:09:11 GMT
Subject: RFR: 7539: JDP Tests failing in VPN environments [v6]
In-Reply-To: <hR7N7Ghk75p8lfyxuSkEAk6Ks3f9Ky2PU-glhlVZKc0=.5cd6bec7-7aab-4fed-b6db-0857efd7a8c4@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
 <hR7N7Ghk75p8lfyxuSkEAk6Ks3f9Ky2PU-glhlVZKc0=.5cd6bec7-7aab-4fed-b6db-0857efd7a8c4@github.com>
Message-ID: <ZlDqw-VyFIkw09oTzaKG5sY5HVyzQJAl48BX-ze3L4o=.86d2ee3f-d728-46cd-ab0f-a679acf8cd54@github.com>

On Mon, 24 Jan 2022 10:05:43 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Only run broadcasting related tests when supported.
>> Tested on Mac M1 with and without VPN.
>
> Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Small fixes

LGTM

-------------

Marked as reviewed by clanger (Author).

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Mon Jan 24 12:26:13 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 12:26:13 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <VVDgbeGveT16vJY2cJIYJy48PNBRj9LBI4pN4bBwm74=.e4439c9d-4e8a-4a8b-ba3b-880b3f214a79@github.com>

On Thu, 13 Jan 2022 16:37:22 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

Hi @bric3 - got to resolve the conflicts (just accepting that the files have been deleted).

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Mon Jan 24 12:35:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 12:35:15 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
Message-ID: <mDGxGGOarHMpZ68td-BlROR3QHDzjTRFzczunfeY4Iw=.50651949-cfdd-4c81-8aac-e75ebe43eff4@github.com>

On Sat, 22 Jan 2022 01:07:52 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation of rules and its descriptions.
>> 
>> ## Update
>> 
>> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 	* Support a new placeholder format introduced in `Rule 2.0`.
>> 	* Use Markdown style link.
>> 	* Add translations for newly added texts.
>> * Update texts for translation correctness and understandability.
>> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
>> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From duke at openjdk.java.net  Mon Jan 24 16:09:10 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 24 Jan 2022 16:09:10 GMT
Subject: Integrated: 7539: JDP Tests failing in VPN environments
In-Reply-To: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
References: <dF7THRAJUwLEKOB0ms9Uc5NQsygOiFl6TnO17ZJE1B0=.79953587-f0b9-4eb9-aad6-4db940bc538b@github.com>
Message-ID: <4sgRJ1AJCeaRYcoeB2IgGDIt_pqaYivVDJJmRAZNE-A=.a65bd339-b675-41b5-b81f-2c758d2e1fc6@github.com>

On Fri, 21 Jan 2022 14:25:16 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Only run broadcasting related tests when supported.
> Tested on Mac M1 with and without VPN.

This pull request has now been integrated.

Changeset: f3ca1b12
Author:    Johannes Bechberger <johannes.bechberger at sap.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f3ca1b120449ecb2d77cfc7f5116da79d6a4cefe
Stats:     81 lines in 4 files changed: 74 ins; 0 del; 7 mod

7539: JDP Tests failing in VPN environments

Reviewed-by: clanger, hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/369

From hirt at openjdk.java.net  Mon Jan 24 17:01:20 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 17:01:20 GMT
Subject: RFR: 7420: Update Japanese translation for rules [v2]
In-Reply-To: <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
References: <_3eRPXBrbMr6uVo3lMVwefLwCSLj9Y_hnR21yY0T_vI=.a76a0f72-cb79-4fa9-921b-63d12432b8f4@github.com>
 <ZvXz35qApiWWfPY0R8ctJu_H8gn5m8E8OofXijVjlxA=.bb757a5d-c017-4882-a19a-755f0738fa08@github.com>
Message-ID: <kNWlWlx1mr84F6UBqfTfk_N4SGp9vsDeXkCT7-0xT_g=.a6abeb6a-f668-45bd-a3d4-da95f6fd166d@github.com>

On Sat, 22 Jan 2022 01:07:52 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation of rules and its descriptions.
>> 
>> ## Update
>> 
>> * Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 	* Support a new placeholder format introduced in `Rule 2.0`.
>> 	* Use Markdown style link.
>> 	* Add translations for newly added texts.
>> * Update texts for translation correctness and understandability.
>> 	* Fix some wordings for understandability. Especially usage of Japanese particle.
>> 	* Add [Japanese counter word (???)](https://en.wikipedia.org/wiki/Japanese_counter_word) for numeric value.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/308

From hirt at openjdk.java.net  Mon Jan 24 17:02:14 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 17:02:14 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
 <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
Message-ID: <JrggfwerVIM6Ki5cWidA1LRrWSKpO3-wO8J0vZI6wMU=.a744f6c1-1e8d-43c6-a566-7e5d407c9a18@github.com>

On Sat, 22 Jan 2022 01:38:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation for pages.
>> 
>> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Use "???" for "span"
>  - Use "?" instead of "????"
>  - Update copyright year

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From hirt at openjdk.java.net  Mon Jan 24 17:03:10 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 17:03:10 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule [v2]
In-Reply-To: <UYSRb5YgYMHGEMhnpk0Va8rRNKI-JAoom6uHu6138hU=.26955770-5b26-4ca3-9a8f-0e4c462ce346@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
 <UYSRb5YgYMHGEMhnpk0Va8rRNKI-JAoom6uHu6138hU=.26955770-5b26-4ca3-9a8f-0e4c462ce346@github.com>
Message-ID: <cgnNG7QfVtY9O2P2EXBWkG9KUg6FugdUZOz6Cuwn_3o=.2cfe6a4b-d64b-439e-a54c-2c2e63f47648@github.com>

On Fri, 21 Jan 2022 15:04:15 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
>> 
>> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.
>
> mohno007 has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Update copyright year
>  - Fix wrong placeholder in BiasedLockingRevocationRule

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From hirt at openjdk.java.net  Mon Jan 24 20:16:22 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 20:16:22 GMT
Subject: RFR: 7417: Fix incorrect identifier in result for biased locking
 revocation rule [v2]
In-Reply-To: <UYSRb5YgYMHGEMhnpk0Va8rRNKI-JAoom6uHu6138hU=.26955770-5b26-4ca3-9a8f-0e4c462ce346@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
 <UYSRb5YgYMHGEMhnpk0Va8rRNKI-JAoom6uHu6138hU=.26955770-5b26-4ca3-9a8f-0e4c462ce346@github.com>
Message-ID: <HKzHePxRzzujA_T7W0vCU863VTWvREvhD4e88PC4ixY=.7305cf7a-3a34-4452-beb7-b0c95c6ebad3@github.com>

On Fri, 21 Jan 2022 15:04:15 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
>> 
>> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.
>
> mohno007 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Update copyright year
>  - Fix wrong placeholder in BiasedLockingRevocationRule

@mohno007 - please integrate your changes by writing /integrate in a comment.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From hirt at openjdk.java.net  Mon Jan 24 20:17:16 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 24 Jan 2022 20:17:16 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
 <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
Message-ID: <hSMu51vs1fwgibTYIuzB5Woyfil3lRwQZ2ofaODJlps=.7af0163b-459b-4268-b0e1-32f719f5a789@github.com>

On Sat, 22 Jan 2022 01:38:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation for pages.
>> 
>> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Use "???" for "span"
>  - Use "?" instead of "????"
>  - Update copyright year

@mohno007 - please integrate your changes by writing /integrate in a comment.

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From hirt at openjdk.java.net  Tue Jan 25 05:35:42 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 25 Jan 2022 05:35:42 GMT
Subject: RFR: 7421: Update Japanese translation for pages [v2]
In-Reply-To: <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
 <d7oih2FLpFCYCxvn9PRR4EAMmvMTi8M-gDQwKs8GQy8=.da798518-e6af-4b52-8b54-b751b7df352d@github.com>
Message-ID: <6oCcEiCQXSkgeTrfDpdlBQZ9KZMgx6Ve-lmSGaWsxFQ=.0b09dba0-6b8e-4d91-8521-fcf0085fad56@github.com>

On Sat, 22 Jan 2022 01:38:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

>> This PR updates/improves Japanese translation for pages.
>> 
>> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
>> 
>> You can see decoded version of `messages_ja` using this script:
>> 
>> 
>> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties
>
> mohno007 has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Use "???" for "span"
>  - Use "?" instead of "????"
>  - Update copyright year

Thank you @mohno007! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From duke at openjdk.java.net  Tue Jan 25 05:35:42 2022
From: duke at openjdk.java.net (mohno007)
Date: Tue, 25 Jan 2022 05:35:42 GMT
Subject: Integrated: 7417: Fix incorrect identifier in result for biased
 locking revocation rule
In-Reply-To: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
References: <F5WR-cNMclMiMRFsvRs0oPXZZ5-LHFJQAJXZ41kkEAo=.84e83ab0-c095-4482-972a-df700e02307d@github.com>
Message-ID: <0cX3xlHDqLYzNTU7kvIEm4z3EDui0NiD87m91uTg19E=.e61e5cd0-fefd-40c6-83e5-7da10389a06a@github.com>

On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

This pull request has now been integrated.

Changeset: 87be29c5
Author:    Motohiro Ohno <m-ohno at atware.co.jp>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/87be29c5945628285bc3fc687adcd9b42faf0eac
Stats:     6 lines in 2 files changed: 0 ins; 0 del; 6 mod

7417: Fix incorrect identifier in result for biased locking revocation rule

Reviewed-by: aptmac, hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/309

From duke at openjdk.java.net  Tue Jan 25 05:35:43 2022
From: duke at openjdk.java.net (mohno007)
Date: Tue, 25 Jan 2022 05:35:43 GMT
Subject: Integrated: 7421: Update Japanese translation for pages
In-Reply-To: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
References: <3BJ0s8EF4PjKGMfzZKjf3LygHTGqkSDJ4J6mzmS_srE=.b49ef1ef-a54b-4ed5-9971-919726bd645a@github.com>
Message-ID: <G680AXpqb1cXx1-CeqcBmOA3-ihf_2KSBPTSu72_0RE=.5b2fe871-72ea-4410-b54d-4238eb6fa647@github.com>

On Mon, 20 Sep 2021 12:56:50 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR updates/improves Japanese translation for pages.
> 
> Update texts based on new commits to `messages.properties` made after the last update date of the `messages_ja.properties`.
> 
> You can see decoded version of `messages_ja` using this script:
> 
> 
> native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

This pull request has now been integrated.

Changeset: 2f791567
Author:    Motohiro Ohno <m-ohno at atware.co.jp>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/2f7915676d077987292b76aa462aa0d71f8ef372
Stats:     72 lines in 1 file changed: 61 ins; 2 del; 9 mod

7421: Update Japanese translation for pages

Reviewed-by: aptmac, hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/310

From duke at openjdk.java.net  Tue Jan 25 10:47:49 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Tue, 25 Jan 2022 10:47:49 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <v_de4jQ_Fva_2hJVL5mnFJlCDZEV5QrWQ5aGFpAcstM=.d593b8fb-ab68-44af-abcc-c0d869b842b2@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
 <v_de4jQ_Fva_2hJVL5mnFJlCDZEV5QrWQ5aGFpAcstM=.d593b8fb-ab68-44af-abcc-c0d869b842b2@github.com>
Message-ID: <ry9GBCJE0BsLj4nABh0-YuA2YyA-HXTzv8AsN4_Igho=.a54509f9-efc7-487f-a1ff-3b6776b5f6c4@github.com>

On Fri, 21 Jan 2022 14:01:47 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bump javadoc version
>
> .github/workflows/validate.yml line 15:
> 
>> 13:     - uses: actions/setup-java at v1
>> 14:       with:
>> 15:         java-version: {{ matrix.jdk }}
> 
> Did you see that the workflow seems to have some issues still? (https://github.com/parttimenerd/jmc/actions/runs/1728551346)

I did not. But I consider working on this when I'm able to run successfully run all tests.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From duke at openjdk.java.net  Tue Jan 25 14:17:57 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 25 Jan 2022 14:17:57 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v2]
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <Fttdi0aDUSKU2MgBLBo5VbsQmxeimsXgjBxJIAHwNhU=.9380942d-02a9-4786-bf80-6cc550885e4b@github.com>

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Bump lz4-java, removes the osgi bundle name override

-------------

Changes: https://git.openjdk.java.net/jmc/pull/356/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=01
  Stats: 21 lines in 13 files changed: 4 ins; 6 del; 11 mod
  Patch: https://git.openjdk.java.net/jmc/pull/356.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/356/head:pull/356

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Tue Jan 25 14:17:59 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 25 Jan 2022 14:17:59 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override
In-Reply-To: <VVDgbeGveT16vJY2cJIYJy48PNBRj9LBI4pN4bBwm74=.e4439c9d-4e8a-4a8b-ba3b-880b3f214a79@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <VVDgbeGveT16vJY2cJIYJy48PNBRj9LBI4pN4bBwm74=.e4439c9d-4e8a-4a8b-ba3b-880b3f214a79@github.com>
Message-ID: <WA6J5MiHdlf6Dw3Hw_hZ_CtIFevu4QnH3UP1xaIKi-4=.4290dbea-b2ee-45f5-8313-d9118e832706@github.com>

On Mon, 24 Jan 2022 12:22:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Hi @bric3 - got to resolve the conflicts (just accepting that the files have been deleted).

@thegreystone Done

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Tue Jan 25 21:42:40 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 25 Jan 2022 21:42:40 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v2]
In-Reply-To: <Fttdi0aDUSKU2MgBLBo5VbsQmxeimsXgjBxJIAHwNhU=.9380942d-02a9-4786-bf80-6cc550885e4b@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <Fttdi0aDUSKU2MgBLBo5VbsQmxeimsXgjBxJIAHwNhU=.9380942d-02a9-4786-bf80-6cc550885e4b@github.com>
Message-ID: <CryVjSifBXeeMquoEc1EdmZraj7rdvcoQFR0xinqRCg=.357b1888-6d66-46a6-969f-702e5c838286@github.com>

On Tue, 25 Jan 2022 14:17:57 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Bump lz4-java, removes the osgi bundle name override

Changes requested by hirt (Lead).

application/org.openjdk.jmc.feature.core/feature.xml line 4:

> 2: <!--   
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

We don't add copyright lines to already existing files. Only when creating new files.

application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

Same here. Only add a Datadog (in this case) specific copyright line if it is a new file.

releng/platform-definitions/pom.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

Here as well. Don't add copyright line.

releng/third-party/pom.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

And here as well.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Tue Jan 25 23:59:08 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 25 Jan 2022 23:59:08 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v3]
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Bump lz4-java, removes the osgi bundle name override

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/356/files
  - new: https://git.openjdk.java.net/jmc/pull/356/files/f813fefe..661c8750

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=01-02

  Stats: 4 lines in 4 files changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/356.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/356/head:pull/356

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Wed Jan 26 05:27:36 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 26 Jan 2022 05:27:36 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v3]
In-Reply-To: <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
Message-ID: <OY18qc7ewcxPTBOGMfHkGaNElB6ey-D_rbzF2GVGNWg=.3b2ced9a-ad90-413e-97d6-1ce23261f8ad@github.com>

On Tue, 25 Jan 2022 23:59:08 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Bump lz4-java, removes the osgi bundle name override

There is no need to force push changes. The tooling will take care of the squashing and merging automatically. It's actually easier to do the review if changes aren't force pushed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Wed Jan 26 10:37:39 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Wed, 26 Jan 2022 10:37:39 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v3]
In-Reply-To: <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
Message-ID: <8TD0UiHBiOZ6ZL7Xa7JDIDAL58Cz-H_sK9qGOtI9Q9o=.6d5f94c8-4741-4999-a337-827c17625336@github.com>

On Tue, 25 Jan 2022 23:59:08 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Bump lz4-java, removes the osgi bundle name override

Noted

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Wed Jan 26 13:56:42 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 26 Jan 2022 13:56:42 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v3]
In-Reply-To: <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
Message-ID: <_1MXIKpe3q2yTR3CZ3-xBRq1i1QCTUZT8KqlBv-kvUA=.8b7c62fa-9a98-4dda-88eb-8f8ff08b6531@github.com>

On Tue, 25 Jan 2022 23:59:08 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Bump lz4-java, removes the osgi bundle name override

core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF line 28:

> 26:  org.openjdk.jmc.flightrecorder.rules.util,
> 27:  org.openjdk.jmc.flightrecorder.stacktrace,
> 28:  org.owasp.encoder

Why was the Owasp encoder removed in this change?

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Thu Jan 27 16:10:25 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Thu, 27 Jan 2022 16:10:25 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v4]
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <1F4DgF3bAsbm9i4iS4aSVnuZ8CaW98hGmDbbuw7H5U8=.b4ff95fe-dedf-41b8-925f-a05ddad5ef5d@github.com>

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:

  Revert accidental owasp import removal in MANIFEST.MF

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/356/files
  - new: https://git.openjdk.java.net/jmc/pull/356/files/661c8750..e72ce0a9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=356&range=02-03

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/356.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/356/head:pull/356

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Thu Jan 27 18:15:39 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 27 Jan 2022 18:15:39 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v4]
In-Reply-To: <1F4DgF3bAsbm9i4iS4aSVnuZ8CaW98hGmDbbuw7H5U8=.b4ff95fe-dedf-41b8-925f-a05ddad5ef5d@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <1F4DgF3bAsbm9i4iS4aSVnuZ8CaW98hGmDbbuw7H5U8=.b4ff95fe-dedf-41b8-925f-a05ddad5ef5d@github.com>
Message-ID: <s2qHfk8PrlTDYSOR2wOyGbOXfdJ8oIx-wiZQ3W_r1E8=.ad54d59d-bce3-448f-9c83-c46fe148dba4@github.com>

On Thu, 27 Jan 2022 16:10:25 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert accidental owasp import removal in MANIFEST.MF

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Fri Jan 28 12:14:17 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 28 Jan 2022 12:14:17 GMT
Subject: RFR: 7512: Update lz4-java and remove the osgi bundle name
 override [v3]
In-Reply-To: <8TD0UiHBiOZ6ZL7Xa7JDIDAL58Cz-H_sK9qGOtI9Q9o=.6d5f94c8-4741-4999-a337-827c17625336@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
 <iEA3Lm1kyLuc73UnTE3rS9lC9JI1epVM1HCj3Ra-LH8=.a5c86125-3344-410c-af64-527cba354928@github.com>
 <8TD0UiHBiOZ6ZL7Xa7JDIDAL58Cz-H_sK9qGOtI9Q9o=.6d5f94c8-4741-4999-a337-827c17625336@github.com>
Message-ID: <S9S_mMgy6HmLQdcNlIC-O9iZaD26gvi2urO1BBnJM2o=.12241217-9237-4f4a-9cab-6accb5e0eee9@github.com>

On Wed, 26 Jan 2022 10:34:19 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Bump lz4-java, removes the osgi bundle name override
>
> Noted

Hi @bric3! Please type /integrate in a comment to integrate this PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From duke at openjdk.java.net  Fri Jan 28 19:02:16 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Fri, 28 Jan 2022 19:02:16 GMT
Subject: Integrated: 7512: Update lz4-java and remove the osgi bundle name
 override
In-Reply-To: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
References: <WYOvO2ZQLcXlua3ITzsQziybEPEHN90hsUQTjLeT6jg=.575b0162-c0c2-4673-b7ad-7bbf1c4f7f31@github.com>
Message-ID: <ayEMMl2ulkRPVijJHWDON_Azbfr_VUTKiKZI69V7tUE=.4f73c15d-12f7-46fa-bb2d-373e2c0b8303@github.com>

On Thu, 13 Jan 2022 16:37:22 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
> 
> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
> 
> The change is little, and hopefully won't ripple beyond.

This pull request has now been integrated.

Changeset: 9ec05b30
Author:    Brice Dutheil <brice.dutheil at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/9ec05b30c4181c2fba827cfef04da5f9aa96c5d5
Stats:     15 lines in 11 files changed: 0 ins; 5 del; 10 mod

7512: Update lz4-java and remove the osgi bundle name override

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/356

From hirt at openjdk.java.net  Mon Jan 31 13:38:38 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 31 Jan 2022 13:38:38 GMT
Subject: RFR: 7467: Only use one version of d3
Message-ID: <jKjQuTHdTe_Fk5eCo5Rjx7Mjf1ZWHDfo9s3l-mMtc50=.458a67e7-e369-4e80-baab-45cab71e2b36@github.com>

Updating v5 to v6.

-------------

Commit messages:
 - 7467: Only use one version of d3

Changes: https://git.openjdk.java.net/jmc/pull/372/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=372&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7467
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/372.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/372/head:pull/372

PR: https://git.openjdk.java.net/jmc/pull/372

From duke at openjdk.java.net  Mon Jan 31 16:48:25 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Mon, 31 Jan 2022 16:48:25 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v7]
In-Reply-To: <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <DQNDWqkJ0SzVhrJNOtI-_7gQ3TjWy6XZxwlT2XV8kYg=.1b187e55-55db-4d6a-8277-0bca86726524@github.com>
Message-ID: <2DN9apQrzdSyYie9zkNcD_eIm1PfdswWS2Ruj6DZIxU=.07c0f978-ab48-47e1-ae0c-fad4c7e13ef1@github.com>

On Fri, 21 Jan 2022 12:06:25 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bump javadoc version

I currently unable to get the tests running in eclipse (the devguide does not help), therefore no progress here.

The tests that fail, running with maven, seem to be UI related.

-------------

PR: https://git.openjdk.java.net/jmc/pull/363