RFR: 7455: Add support for jolokia JMX service connection [v7]
Martin Skarsaune
duke at openjdk.java.net
Sun Jan 2 21:00:19 UTC 2022
On Thu, 11 Nov 2021 09:11:21 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:
>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review corrections: Javadoc and refactoring attempt to use local operation info
>
> application/org.openjdk.jmc.jolokia/pom.xml line 64:
>
>> 62: </plugin>
>> 63: <plugin>
>> 64: <groupId>org.apache.maven.plugins</groupId>
>
> Sooo .... I am not sure about the preferred way to pull in external dependencies. I can add that both jolokia libraries come as shaded jars with some OSGi packaging, but I do not know enough about that to say whether that would be a workable or better solution. These are quite new components, so we can probably modify the OSGI packaging in Jolokia going forwards if needed.
> POM: https://github.com/rhuss/jolokia/blob/556b58e63a125fb79d516d7f7833e22270f591b0/client/jmx-adapter/pom.xml#L129
> Artifact: https://repo1.maven.org/maven2/org/jolokia/jolokia-jmx-adapter/1.7.0/jolokia-jmx-adapter-1.7.0-standalone.jar
I'm working in a separate branch to expose the dependencies via releng/thirdparty, but have not been able to make it work yet.
-------------
PR: https://git.openjdk.java.net/jmc/pull/332
More information about the jmc-dev
mailing list